Aperture::fromFocalLength() - Code Metrics - Inspection of "Merge pull request #24 from Miljar/develop" - PHPExif/php-exif-common - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e263f3...74da5c )

by Tom Van

created 2016-11-10 09:22 UTC

Aperture::fromFocalLength() A

↳ Parent: Aperture

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	20
rs	9.2
cc	4
eloc	11
nc	4
nop	1

<?php
/**
 * PHP Exif Aperture ValueObject
 *
 * @link        http://github.com/PHPExif/php-exif-common for the canonical source repository
 * @copyright   Copyright (c) 2016 Tom Van Herreweghe <[email protected]>
 * @license     http://github.com/PHPExif/php-exif-common/blob/master/LICENSE MIT License
 * @category    PHPExif
 * @package     Common
 * @codeCoverageIgnore
 */

namespace PHPExif\Common\Data\ValueObject;

use \InvalidArgumentException;
use \JsonSerializable;
use \RuntimeException;

/**
 * Aperture class
 *
 * A value object to describe the Aperture f-number
 *
 * @category    PHPExif
 * @package     Common
 */
class Aperture implements JsonSerializable
{
    /**
     * The f-number
     *
     * @see https://en.wikipedia.org/wiki/F-number
     *
     * @var float
     */
    private $fNumber;

    /**
     * @param float $fNumber
     *
     * @throws InvalidArgumentException If given f-number is not a float
     */
    public function __construct($fNumber)
    {
        if (!is_float($fNumber) && !is_int($fNumber)) {
            throw new InvalidArgumentException('fNumber must be an integer or float');
        }

        $this->setFNumber($fNumber);
    }

    /**
     * Sets the fNumber
     *
     * @param float|int $fNumber
     *
     * @return void
     */
    private function setFNumber($fNumber)
    {
        $this->fNumber = $fNumber;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * Getter for fNumber
     *
     * @return float|int
     */
    public function getFNumber()
    {
        return $this->fNumber;
    }

    /**
     * Creates new instance from given Focal Length format
     *
     * Format:
     *          f/<f-number>
     *
     * @param string $focalLength
     *
     * @throws \InvalidArgumentException If focalLength is not a string
     *
     * @return Aperture
     */
    public static function fromFocalLength($focalLength)
    {
        if (!is_string($focalLength)) {
            throw new InvalidArgumentException('focalLength must be a string');
        }

        if (!preg_match('#^f/([0-9]*\.[0-9]+|[0-9]*)$#', $focalLength, $matches)) {
            throw new RuntimeException('Given focalLength is not in a valid format. Need: "f/<number>"');
        }

        $fNumber = $matches[1];

        if (($filtered = filter_var($fNumber, FILTER_VALIDATE_INT)) !== false) {
            $fNumber = $filtered;
        } else {
            $fNumber = (float) $fNumber;
        }

        return new self($fNumber);
    }

    /**
     * Creates a new instance from given Aperture object
     *
     * @param Aperture $aperture
     *
     * @return Aperture
     */
    public static function fromAperture(Aperture $aperture)
    {
        return new self(
            $aperture->getFNumber()
        );
    }

    /**
     * @inheritDoc
     *
     * @return string
     */
    public function jsonSerialize()
    {
        return (string) $this;
    }

    /**
     * Returns string representation
     *
     * @return string
     */
    public function __toString()
    {
        return sprintf(
            'f/%1$s',
            $this->getFNumber()
        );
    }
}


1			<?php
2			/**
3			* PHP Exif Aperture ValueObject
4			*
5			* @link http://github.com/PHPExif/php-exif-common for the canonical source repository
6			* @copyright Copyright (c) 2016 Tom Van Herreweghe <[email protected]>
7			* @license http://github.com/PHPExif/php-exif-common/blob/master/LICENSE MIT License
8			* @category PHPExif
9			* @package Common
10			* @codeCoverageIgnore
11			*/
12
13			namespace PHPExif\Common\Data\ValueObject;
14
15			use \InvalidArgumentException;
16			use \JsonSerializable;
17			use \RuntimeException;
18
19			/**
20			* Aperture class
21			*
22			* A value object to describe the Aperture f-number
23			*
24			* @category PHPExif
25			* @package Common
26			*/
27			class Aperture implements JsonSerializable
28			{
29			/**
30			* The f-number
31			*
32			* @see https://en.wikipedia.org/wiki/F-number
33			*
34			* @var float
35			*/
36			private $fNumber;
37
38			/**
39			* @param float $fNumber
40			*
41			* @throws InvalidArgumentException If given f-number is not a float
42			*/
43			public function __construct($fNumber)
44			{
45			if (!is_float($fNumber) && !is_int($fNumber)) {
46			throw new InvalidArgumentException('fNumber must be an integer or float');
47			}
48
49			$this->setFNumber($fNumber);
50			}
51
52			/**
53			* Sets the fNumber
54			*
55			* @param float\|int $fNumber
56			*
57			* @return void
58			*/
59			private function setFNumber($fNumber)
60			{
61			$this->fNumber = $fNumber;
			0 ignored issues – show Documentation Bug introduced 2016-10-25 18:28 UTC by Report Bug Copy Issue Report It seems like `$fNumber` can also be of type `integer`. However, the property `$fNumber` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
62			}
63
64			/**
65			* Getter for fNumber
66			*
67			* @return float\|int
68			*/
69			public function getFNumber()
70			{
71			return $this->fNumber;
72			}
73
74			/**
75			* Creates new instance from given Focal Length format
76			*
77			* Format:
78			* f/<f-number>
79			*
80			* @param string $focalLength
81			*
82			* @throws \InvalidArgumentException If focalLength is not a string
83			*
84			* @return Aperture
85			*/
86			public static function fromFocalLength($focalLength)
87			{
88			if (!is_string($focalLength)) {
89			throw new InvalidArgumentException('focalLength must be a string');
90			}
91
92			if (!preg_match('#^f/([0-9]\.[0-9]+\|[0-9])$#', $focalLength, $matches)) {
93			throw new RuntimeException('Given focalLength is not in a valid format. Need: "f/<number>"');
94			}
95
96			$fNumber = $matches[1];
97
98			if (($filtered = filter_var($fNumber, FILTER_VALIDATE_INT)) !== false) {
99			$fNumber = $filtered;
100			} else {
101			$fNumber = (float) $fNumber;
102			}
103
104			return new self($fNumber);
105			}
106
107			/**
108			* Creates a new instance from given Aperture object
109			*
110			* @param Aperture $aperture
111			*
112			* @return Aperture
113			*/
114			public static function fromAperture(Aperture $aperture)
115			{
116			return new self(
117			$aperture->getFNumber()
118			);
119			}
120
121			/**
122			* @inheritDoc
123			*
124			* @return string
125			*/
126			public function jsonSerialize()
127			{
128			return (string) $this;
129			}
130
131			/**
132			* Returns string representation
133			*
134			* @return string
135			*/
136			public function __toString()
137			{
138			return sprintf(
139			'f/%1$s',
140			$this->getFNumber()
141			);
142			}
143			}
144

PHPExif / php-exif-common

GitHub Access Token became invalid

Push — develop ( e263f3...74da5c )

Aperture::fromFocalLength() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like