Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
23 | View Code Duplication | class Height extends MeasuredObject |
|
|
|||
24 | { |
||
25 | /** |
||
26 | * Creates a new instance from given Height object |
||
27 | * |
||
28 | * @param Height $height |
||
29 | * |
||
30 | * @return Height |
||
31 | */ |
||
32 | public static function fromHeight(Height $height) |
||
39 | |||
40 | /** |
||
41 | * Creates new instance from given value and |
||
42 | * adds a "px" Unit |
||
43 | * |
||
44 | * @param mixed $value |
||
45 | * |
||
46 | * @return Height |
||
47 | */ |
||
48 | public static function pixels($value) |
||
55 | } |
||
56 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.