Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
34 | class Iptc implements IptcInterface, JsonSerializable |
||
35 | { |
||
36 | /** |
||
37 | * @var Caption |
||
38 | */ |
||
39 | protected $caption; |
||
40 | |||
41 | /** |
||
42 | * @var Copyright |
||
43 | */ |
||
44 | protected $copyright; |
||
45 | |||
46 | /** |
||
47 | * @var Credit |
||
48 | */ |
||
49 | protected $credit; |
||
50 | |||
51 | /** |
||
52 | * @var Headline |
||
53 | */ |
||
54 | protected $headline; |
||
55 | |||
56 | /** |
||
57 | * @var Jobtitle |
||
58 | */ |
||
59 | protected $jobtitle; |
||
60 | |||
61 | /** |
||
62 | * @var Source |
||
63 | */ |
||
64 | protected $source; |
||
65 | |||
66 | /** |
||
67 | * @var Title |
||
68 | */ |
||
69 | protected $title; |
||
70 | |||
71 | /** |
||
72 | * @var Collection |
||
73 | */ |
||
74 | protected $keywords; |
||
75 | |||
76 | /** |
||
77 | * {@inheritDoc} |
||
78 | */ |
||
79 | public function getHeadline() |
||
83 | |||
84 | /** |
||
85 | * {@inheritDoc} |
||
86 | */ |
||
87 | public function withHeadline(Headline $headline) |
||
94 | |||
95 | /** |
||
96 | * {@inheritDoc} |
||
97 | */ |
||
98 | public function getCredit() |
||
102 | |||
103 | /** |
||
104 | * {@inheritDoc} |
||
105 | */ |
||
106 | public function withCredit(Credit $credit) |
||
113 | |||
114 | /** |
||
115 | * {@inheritDoc} |
||
116 | */ |
||
117 | public function getCopyright() |
||
121 | |||
122 | /** |
||
123 | * {@inheritDoc} |
||
124 | */ |
||
125 | public function withCopyright(Copyright $copyright) |
||
132 | |||
133 | /** |
||
134 | * {@inheritDoc} |
||
135 | */ |
||
136 | public function getCaption() |
||
140 | |||
141 | /** |
||
142 | * {@inheritDoc} |
||
143 | */ |
||
144 | public function withCaption(Caption $caption) |
||
151 | |||
152 | /** |
||
153 | * {@inheritDoc} |
||
154 | */ |
||
155 | public function getTitle() |
||
159 | |||
160 | /** |
||
161 | * {@inheritDoc} |
||
162 | */ |
||
163 | public function withTitle(Title $title) |
||
170 | |||
171 | /** |
||
172 | * {@inheritDoc} |
||
173 | */ |
||
174 | public function getKeywords() |
||
178 | |||
179 | /** |
||
180 | * {@inheritDoc} |
||
181 | */ |
||
182 | public function withKeywords(Collection $keywords) |
||
189 | |||
190 | /** |
||
191 | * {@inheritDoc} |
||
192 | */ |
||
193 | public function getJobtitle() |
||
197 | |||
198 | /** |
||
199 | * {@inheritDoc} |
||
200 | */ |
||
201 | public function withJobtitle(Jobtitle $jobtitle) |
||
208 | |||
209 | /** |
||
210 | * {@inheritDoc} |
||
211 | */ |
||
212 | public function getSource() |
||
216 | |||
217 | /** |
||
218 | * {@inheritDoc} |
||
219 | */ |
||
220 | public function withSource(Source $source) |
||
227 | |||
228 | /** |
||
229 | * @inheritDoc |
||
230 | * |
||
231 | * @return array |
||
232 | */ |
||
233 | View Code Duplication | public function jsonSerialize() |
|
247 | } |
||
248 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.