PHPAlgorithms\GraphTools\Line1D

Complexity

Total Complexity

4

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkPoint()	0	6	2
A	countLength()	0	4	1
A	__construct()	0	7	1

<?php

/**
 * @author ventaquil <ventaquil@outlook.com>
 * @licence MIT
 */

namespace PHPAlgorithms\GraphTools;

use PHPAlgorithms\GraphTools\Interfaces\LineInterface;
use PHPAlgorithms\GraphTools\Exceptions\LineException;

/**
 * Class Line1D
 * @package PHPAlgorithms\GraphTools
 * @property-read float $length
 * @property-read float $width
 */
class Line1D extends AbstractLine implements LineInterface {
    /**
     * @var float $length Line length property.
     * @var float $width Line width property.
     */
    protected $length,

It is generally advisable to only define one property per statement.

              $width;

    /**
     * Method checks sent variable and throws LineException if it is not an Point1D instance.
     *
     * @param mixed $point Variable to check.
     * @throws LineException If sent argument is not an Point1D instance.
     */
    protected function checkPoint($point)
    {
        if (!($point instanceof Point1D)) {
            throw new LineException('This is not a point');
        }
    }

    /**
     * Method counts length.
     *
     * return float Line length.
     */
    protected function countLength()
    {
        return abs($this->from->x - $this->to->x);

The property x does not seem to exist in PHPAlgorithms\GraphTools\Point.

    }

    /**
     * Line1D constructor.
     *
     * @param mixed $from First end of the line.
     * @param mixed $to Second end of the line.
     */
    public function __construct($from, $to)
    {
        parent::__construct($from, $to);

        $this->width = $this->length

It seems like $this->length = $this->countLength() can also be of type integer. However, the property $width is declared as type double. Maybe add an additional type check?

                     = $this->countLength();

It seems like $this->countLength() can also be of type integer. However, the property $length is declared as type double. Maybe add an additional type check?

    }
}