PHPAlgorithms\GraphTools\Line

Complexity

Total Complexity

14

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	checkPoint()	0	6	2
A	getDimensionNumber()	0	13	3
A	getLowestPointsDimension()	0	12	3
B	create()	0	22	6

<?php

namespace PHPAlgorithms\GraphTools;

use PHPAlgorithms\GraphTools\Exceptions\LineException;

abstract class Line {
    private static function checkPoint($point)
    {
        if (!($point instanceof AbstractPoint)) {
            throw new LineException('This is not a point');
        }
    }

    private static function getDimensionNumber($point)
    {
        $pointDimensions = array(AbstractPoint::class, Point1D::class, Point2D::class, Point3D::class, Point4D::class);

        foreach ($pointDimensions as $dimension => $pointDimension)
        {
            if (!($point instanceof $pointDimension)) {
                return --$dimension;
            }
        }

        return $dimension;

The variable $dimension seems to be defined by a foreach iteration on line 19. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    private static function getLowestPointsDimension($from, $to)
    {
        $fromDimension = self::getDimensionNumber($from);
        $toDimension = self::getDimensionNumber($to);

        switch (true) {
            case $fromDimension <= $toDimension:
                return $fromDimension;
            case $fromDimension > $toDimension:
                return $toDimension;
        }
    }

    public static function create($from, $to)
    {
        self::checkPoint($from);
        self::checkPoint($to);

        $lowestDimension = self::getLowestPointsDimension($from, $to);

        switch ($lowestDimension) {
            case 0:

It seems like you are loosely comparing $lowestDimension of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

                return new AbstractLine($from, $to);
            case 1:
                return new Line1D($from, $to);
            case 2:
                return new Line2D($from, $to);
            case 3:
                return new Line3D($from, $to);
            case 4:
                return new Line4D($from, $to);
            default:
                throw new LineException('Unknown dimension');
        }
    }
}