Pgs\HashIdBundle\DependencyInjection\Configuration

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

95.24%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfigTreeBuilder()	0	10	1
A	addHashidsNode()	0	18	2

<?php

namespace Pgs\HashIdBundle\DependencyInjection;

use Hashids\Hashids;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

class Configuration implements ConfigurationInterface
{
    const ROOT_NAME = 'pgs_hash_id';

    const NODE_CONVERTER = 'converter';
    const NODE_CONVERTER_HASHIDS = 'hashids';
    const NODE_CONVERTER_HASHIDS_SALT = 'salt';
    const NODE_CONVERTER_HASHIDS_MIN_HASH_LENGTH = 'min_hash_length';
    const NODE_CONVERTER_HASHIDS_ALPHABET = 'alphabet';

    public function getConfigTreeBuilder(): TreeBuilder
    {
        $treeBuilder = new TreeBuilder(self::ROOT_NAME);
        $rootNode = $treeBuilder->getRootNode();
        $converterNode = (new ArrayNodeDefinition(self::NODE_CONVERTER))->addDefaultsIfNotSet();
        $rootNode->append($converterNode);

The method append() does not exist on Symfony\Component\Config\Definition\Builder\NodeDefinition. It seems like you code against a sub-type of Symfony\Component\Config\Definition\Builder\NodeDefinition such as Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition.

        $this->addHashidsNode($converterNode);

        return $treeBuilder;
    }

    private function addHashidsNode(ArrayNodeDefinition $node): void
    {
        if (!class_exists(Hashids::class)) {
            return;
        }

        $node
            ->children()
                ->arrayNode(self::NODE_CONVERTER_HASHIDS)->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode(self::NODE_CONVERTER_HASHIDS_SALT)->defaultNull()->end()
                        ->scalarNode(self::NODE_CONVERTER_HASHIDS_MIN_HASH_LENGTH)->defaultValue(10)->end()

The method scalarNode() does not exist on Symfony\Component\Config\Definition\Builder\NodeParentInterface. It seems like you code against a sub-type of Symfony\Component\Config\Definition\Builder\NodeParentInterface such as Symfony\Component\Config\Definition\Builder\NodeBuilder.

                        ->scalarNode(self::NODE_CONVERTER_HASHIDS_ALPHABET)
                            ->defaultValue('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890')
                        ->end()
                    ->end()
                ->end()
            ->end();
    }
}