Pgs\HashIdBundle\DependencyInjection\Configuration

Complexity

Total Complexity

4

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

93.1%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfigTreeBuilder()	0	19	2
A	addHashidsConverterNode()	0	20	2

<?php

namespace Pgs\HashIdBundle\DependencyInjection;

use Hashids\Hashids;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

class Configuration implements ConfigurationInterface
{
    const ROOT_NAME = 'pgs_hash_id';

    const NODE_CONVERTER = 'converter';
    const NODE_CONVERTER_HASHIDS = 'hashids';
    const NODE_CONVERTER_HASHIDS_SALT = 'salt';
    const NODE_CONVERTER_HASHIDS_MIN_HASH_LENGTH = 'min_hash_length';
    const NODE_CONVERTER_HASHIDS_ALPHABET = 'alphabet';

    public function getConfigTreeBuilder(): TreeBuilder
    {
        $treeBuilder = new TreeBuilder(self::ROOT_NAME);
        if (method_exists($treeBuilder, 'getRootNode')) {
            $rootNode = $treeBuilder->getRootNode();
        } else {
            // BC layer for symfony/config 4.1 and older
            $rootNode = $treeBuilder->root(self::ROOT_NAME);

The function Symfony\Component\Config\Definition\Builder\TreeBuilder::root() has been deprecated: since Symfony 4.3, pass the root name to the constructor instead

        }
        $rootNode
            ->children()
                ->arrayNode(self::NODE_CONVERTER)->addDefaultsIfNotSet()
                    ->children()
                        ->append($this->addHashidsConverterNode())
                    ->end()
                ->end()
            ->end();

        return $treeBuilder;
    }

    private function addHashidsConverterNode(): ArrayNodeDefinition
    {
        $node = new ArrayNodeDefinition(self::NODE_CONVERTER_HASHIDS);

        if (!class_exists(Hashids::class)) {
            return $node;
        }

        return $node->addDefaultsIfNotSet()
                ->children()
                    ->scalarNode(self::NODE_CONVERTER_HASHIDS_SALT)
                        ->defaultNull()
                    ->end()
                    ->scalarNode(self::NODE_CONVERTER_HASHIDS_MIN_HASH_LENGTH)

The method scalarNode() does not exist on Symfony\Component\Config\Definition\Builder\NodeParentInterface. It seems like you code against a sub-type of Symfony\Component\Config\Definition\Builder\NodeParentInterface such as Symfony\Component\Config\Definition\Builder\NodeBuilder.

                        ->defaultValue(10)
                    ->end()
                    ->scalarNode(self::NODE_CONVERTER_HASHIDS_ALPHABET)
                        ->defaultValue('abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890')
                    ->end()
                ->end();
    }
}