Issues in UrlHelpersTrait.php (master) - Issues in master - PCextreme/cloudstack-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Util/UrlHelpersTrait.php (14 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace PCextreme\Cloudstack\Util;

use InvalidArgumentException;
use PCextreme\Cloudstack\Exception\ClientException;

trait UrlHelpersTrait
{
    /**
     * Generate Client URL for specified username.
     *
     * @param  string $username
     * @param  string $domainId
     * @return string
     * @throws InvalidArgumentException
     */
    public function clientUrl(string $username, string $domainId) : string
    {
        if (is_null($this->urlClient)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            throw new InvalidArgumentException(
                'Required options not defined: urlClient'
            );
        }

        // Prepare session.
        // Using the SSO (Single Sign On) key we can generate a sessionkey used for the console url.
        $command = 'login';
        $params = [
            'command'   => $command,
            'username'  => $username,
            'domainid'  => $domainId,
            'timestamp' => round(microtime(true) * 1000),
            'response'  => 'json',
        ];

        $method  = $this->getCommandMethod($command);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $query   = $this->enableSso()->getCommandQuery($params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->urlClient.'?loginUrl='.urlencode($query);
    }

    /**
     * Generate Console URL for specified username owning the virtual machine.
     *
     * @param  string $username
     * @param  string $domainId
     * @param  string $virtualMachineId
     * @return string
     * @throws InvalidArgumentException
     */
    public function consoleUrl(string $username, string $domainId, string $virtualMachineId) : string
    {
        if (is_null($this->urlConsole)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            throw new InvalidArgumentException(
                'Required options not defined: urlConsole'
            );
        }

        // Prepare session.
        // Using the SSO (Single Sign On) key we can generate a sessionkey used for the console url.
        $command = 'login';
        $params = [
            'command'   => $command,
            'username'  => $username,
            'domainid'  => $domainId,
            'timestamp' => round(microtime(true) * 1000),
            'response'  => 'json',
        ];

        $base    = $this->urlApi;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $method  = $this->getCommandMethod($command);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $query   = $this->enableSso()->getCommandQuery($params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $url     = $this->appendQuery($base, $query);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $request = $this->getRequest($method, $url);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $login = $this->getResponse($request);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // Prepare a signed request for the Console url.
        // Effectively this will be the console url, it won't be requested at the Cloudstack API.
        $params = [
            'cmd'        => 'access',
            'vm'         => $virtualMachineId,
            'userid'     => $login['loginresponse']['userid'],
            'sessionkey' => $login['loginresponse']['sessionkey'],
            'timestamp'  => round(microtime(true) * 1000),
            'apikey'     => $this->apiKey,
class MyClass { }

$x = new MyClass();
$x->foo = true;
        ];

        $base = $this->urlConsole;
        $query = $this->getCommandQuery($params);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this->appendQuery($base, $query);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace PCextreme\Cloudstack\Util;
6
7			use InvalidArgumentException;
8			use PCextreme\Cloudstack\Exception\ClientException;
9
10			trait UrlHelpersTrait
11			{
12			/**
13			* Generate Client URL for specified username.
14			*
15			* @param string $username
16			* @param string $domainId
17			* @return string
18			* @throws InvalidArgumentException
19			*/
20			public function clientUrl(string $username, string $domainId) : string
21			{
22			if (is_null($this->urlClient)) {
			0 ignored issues – show Bug introduced 2017-02-06 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `urlClient` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			throw new InvalidArgumentException(
24			'Required options not defined: urlClient'
25			);
26			}
27
28			// Prepare session.
29			// Using the SSO (Single Sign On) key we can generate a sessionkey used for the console url.
30			$command = 'login';
31			$params = [
32			'command' => $command,
33			'username' => $username,
34			'domainid' => $domainId,
35			'timestamp' => round(microtime(true) * 1000),
36			'response' => 'json',
37			];
38
39			$method = $this->getCommandMethod($command);
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getCommandMethod()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Unused Code introduced 2017-02-06 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$method` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
40			$query = $this->enableSso()->getCommandQuery($params);
			0 ignored issues – show Bug introduced 2017-02-06 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `enableSso()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41
42			return $this->urlClient.'?loginUrl='.urlencode($query);
43			}
44
45			/**
46			* Generate Console URL for specified username owning the virtual machine.
47			*
48			* @param string $username
49			* @param string $domainId
50			* @param string $virtualMachineId
51			* @return string
52			* @throws InvalidArgumentException
53			*/
54			public function consoleUrl(string $username, string $domainId, string $virtualMachineId) : string
55			{
56			if (is_null($this->urlConsole)) {
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `urlConsole` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
57			throw new InvalidArgumentException(
58			'Required options not defined: urlConsole'
59			);
60			}
61
62			// Prepare session.
63			// Using the SSO (Single Sign On) key we can generate a sessionkey used for the console url.
64			$command = 'login';
65			$params = [
66			'command' => $command,
67			'username' => $username,
68			'domainid' => $domainId,
69			'timestamp' => round(microtime(true) * 1000),
70			'response' => 'json',
71			];
72
73			$base = $this->urlApi;
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `urlApi` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
74			$method = $this->getCommandMethod($command);
			0 ignored issues – show Bug introduced 2017-02-06 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getCommandMethod()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
75			$query = $this->enableSso()->getCommandQuery($params);
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `enableSso()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
76			$url = $this->appendQuery($base, $query);
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `appendQuery()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
77			$request = $this->getRequest($method, $url);
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
78
79			$login = $this->getResponse($request);
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getResponse()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
80
81			// Prepare a signed request for the Console url.
82			// Effectively this will be the console url, it won't be requested at the Cloudstack API.
83			$params = [
84			'cmd' => 'access',
85			'vm' => $virtualMachineId,
86			'userid' => $login['loginresponse']['userid'],
87			'sessionkey' => $login['loginresponse']['sessionkey'],
88			'timestamp' => round(microtime(true) * 1000),
89			'apikey' => $this->apiKey,
			0 ignored issues – show Bug introduced 2017-01-23 15:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `apiKey` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
90			];
91
92			$base = $this->urlConsole;
93			$query = $this->getCommandQuery($params);
			0 ignored issues – show Bug introduced 2017-02-06 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `getCommandQuery()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
94
95			return $this->appendQuery($base, $query);
			0 ignored issues – show Bug introduced 2017-02-06 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `appendQuery()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
96			}
97			}
98

PCextreme / cloudstack-php

Issues (21)

Security Analysis no request data

src/Util/UrlHelpersTrait.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like