SongArtist - Code Metrics - Inspection of "Feature/musicbrainz" - PBXg33k/php-music-info - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — develop (#22)

by Oguzhan

created 2017-04-20 22:58 UTC

SongArtist A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	10
c	1
b	0
f	0
lcom	0
cbo	1
dl	119
loc	119
rs	10

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getSong()	4	4	1
A	setSong()	5	5	1
A	getArtist()	4	4	1
A	setArtist()	5	5	1
A	getRole()	4	4	1
A	setRole()	5	5	1
A	getJoinphrase()	4	4	1
A	setJoinphrase()	5	5	1
A	getOrder()	4	4	1
A	setOrder()	5	5	1

How to fix Duplicated Code

<?php
/**
 * Created by PhpStorm.
 * User: PBX_g33k
 * Date: 10/21/2016
 * Time: 6:39 PM
 */

namespace Pbxg33k\MusicInfo\Model;


/**
 * Class SongArtist
 * @package Pbxg33k\MusicInfo\Model
 */
class SongArtist extends BaseModel

{
    /**
     * @var Song
     */
    protected $song;

    /**
     * @var Artist
     */
    protected $artist;

    /**
     * @var string
     */
    protected $role;

    /**
     * @var string
     */
    protected $joinphrase;

    /**
     * @var integer
     */
    protected $order;

    /**
     * @return Song
     */
    public function getSong()
    {
        return $this->song;
    }

    /**
     * @param Song $song
     * @return SongArtist
     */
    public function setSong($song)
    {
        $this->song = $song;
        return $this;
    }

    /**
     * @return Artist
     */
    public function getArtist()
    {
        return $this->artist;
    }

    /**
     * @param Artist $artist
     * @return SongArtist
     */
    public function setArtist($artist)
    {
        $this->artist = $artist;
        return $this;
    }

    /**
     * @return string
     */
    public function getRole()
    {
        return $this->role;
    }

    /**
     * @param string $role
     * @return SongArtist
     */
    public function setRole($role)
    {
        $this->role = $role;
        return $this;
    }

    /**
     * @return string
     */
    public function getJoinphrase()
    {
        return $this->joinphrase;
    }

    /**
     * @param string $joinphrase
     * @return SongArtist
     */
    public function setJoinphrase($joinphrase)
    {
        $this->joinphrase = $joinphrase;
        return $this;
    }

    /**
     * @return int
     */
    public function getOrder()
    {
        return $this->order;
    }

    /**
     * @param int $order
     * @return SongArtist
     */
    public function setOrder($order)
    {
        $this->order = $order;
        return $this;
    }


}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: PBX_g33k
5		* Date: 10/21/2016
6		* Time: 6:39 PM
7		*/
8
9		namespace Pbxg33k\MusicInfo\Model;
10
11
12		/**
13		* Class SongArtist
14		* @package Pbxg33k\MusicInfo\Model
15		*/
16	View Code Duplication	class SongArtist extends BaseModel
		0 ignored issues – show Duplication introduced 2017-02-06 14:28 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		/**
19		* @var Song
20		*/
21		protected $song;
22
23		/**
24		* @var Artist
25		*/
26		protected $artist;
27
28		/**
29		* @var string
30		*/
31		protected $role;
32
33		/**
34		* @var string
35		*/
36		protected $joinphrase;
37
38		/**
39		* @var integer
40		*/
41		protected $order;
42
43		/**
44		* @return Song
45		*/
46		public function getSong()
47		{
48		return $this->song;
49		}
50
51		/**
52		* @param Song $song
53		* @return SongArtist
54		*/
55		public function setSong($song)
56		{
57		$this->song = $song;
58		return $this;
59		}
60
61		/**
62		* @return Artist
63		*/
64		public function getArtist()
65		{
66		return $this->artist;
67		}
68
69		/**
70		* @param Artist $artist
71		* @return SongArtist
72		*/
73		public function setArtist($artist)
74		{
75		$this->artist = $artist;
76		return $this;
77		}
78
79		/**
80		* @return string
81		*/
82		public function getRole()
83		{
84		return $this->role;
85		}
86
87		/**
88		* @param string $role
89		* @return SongArtist
90		*/
91		public function setRole($role)
92		{
93		$this->role = $role;
94		return $this;
95		}
96
97		/**
98		* @return string
99		*/
100		public function getJoinphrase()
101		{
102		return $this->joinphrase;
103		}
104
105		/**
106		* @param string $joinphrase
107		* @return SongArtist
108		*/
109		public function setJoinphrase($joinphrase)
110		{
111		$this->joinphrase = $joinphrase;
112		return $this;
113		}
114
115		/**
116		* @return int
117		*/
118		public function getOrder()
119		{
120		return $this->order;
121		}
122
123		/**
124		* @param int $order
125		* @return SongArtist
126		*/
127		public function setOrder($order)
128		{
129		$this->order = $order;
130		return $this;
131		}
132
133
134		}

PBXg33k / php-music-info

Pull Request — develop (#22)

SongArtist A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like