SearchSpotifyArtistCommand::setSpotifyService() - Code Metrics - Inspection of "WIP" - PBXg33k/php-music-info - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/test-commands ( b61593...109eae )

by Oguzhan

created 2017-03-16 18:42 UTC

SearchSpotifyArtistCommand::setSpotifyService() A

↳ Parent: SearchSpotifyArtistCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	4
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/*******************************************************************************
 * This file is part of the Pbxg33k\MusicInfo package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * (c) 2017 Oguzhan uysal. All rights reserved
 ******************************************************************************/
namespace Pbxg33k\MusicInfo\Command;

use Pbxg33k\MusicInfo\Model\Artist;
use Pbxg33k\MusicInfo\Service\Spotify\Service;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class SearchSpotifyArtistCommand extends Command

{
    /**
     * @var Service
     */
    protected $spotifyService;

    protected function configure()
    {
        $this
            ->setName('music-info:search:spotify:artist')
            ->setDescription('Search an artist on Spotify')
            ->setHelp("This command will search and return an artist using the Spotify API")
            ->addOption('save', 'p', InputOption::VALUE_OPTIONAL, false)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->addArgument('query', InputArgument::REQUIRED, 'Artist name')
            ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $artist = $input->getArgument('query');
        if(!$artist) {
            throw new \InvalidArgumentException('Artist missing');
        }

        $result = $this->spotifyService->artist()->getByName($artist);

        $table = new Table($output);
        $table
            ->setHeaders(['ID','Artist']);

        if(!$result) {
            $output->writeln('No results');
        } else {
            /** @var Artist $artist */
            foreach($result as $artist) {
                $table
                    ->addRow([
                        $artist->getId(),
                        $artist->getName()
                    ]);
            }

            $table->render();
        }
    }

    public function setSpotifyService(Service $service)
    {
        $this->spotifyService = $service;
    }
}

1		<?php
2
3		/*******************************************************************************
4		* This file is part of the Pbxg33k\MusicInfo package.
5		*
6		* For the full copyright and license information, please view the LICENSE
7		* file that was distributed with this source code.
8		*
9		* (c) 2017 Oguzhan uysal. All rights reserved
10		******************************************************************************/
11		namespace Pbxg33k\MusicInfo\Command;
12
13		use Pbxg33k\MusicInfo\Model\Artist;
14		use Pbxg33k\MusicInfo\Service\Spotify\Service;
15		use Symfony\Component\Console\Command\Command;
16		use Symfony\Component\Console\Helper\Table;
17		use Symfony\Component\Console\Input\InputArgument;
18		use Symfony\Component\Console\Input\InputInterface;
19		use Symfony\Component\Console\Input\InputOption;
20		use Symfony\Component\Console\Output\OutputInterface;
21
22	View Code Duplication	class SearchSpotifyArtistCommand extends Command
		0 ignored issues – show Duplication introduced 2017-03-16 18:46 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		/**
25		* @var Service
26		*/
27		protected $spotifyService;
28
29		protected function configure()
30		{
31		$this
32		->setName('music-info:search:spotify:artist')
33		->setDescription('Search an artist on Spotify')
34		->setHelp("This command will search and return an artist using the Spotify API")
35		->addOption('save', 'p', InputOption::VALUE_OPTIONAL, false)
		0 ignored issues – show Documentation introduced 2017-03-16 18:46 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36		->addArgument('query', InputArgument::REQUIRED, 'Artist name')
37		;
38		}
39
40		protected function execute(InputInterface $input, OutputInterface $output)
41		{
42		$artist = $input->getArgument('query');
43		if(!$artist) {
44		throw new \InvalidArgumentException('Artist missing');
45		}
46
47		$result = $this->spotifyService->artist()->getByName($artist);
48
49		$table = new Table($output);
50		$table
51		->setHeaders(['ID','Artist']);
52
53		if(!$result) {
54		$output->writeln('No results');
55		} else {
56		/** @var Artist $artist */
57		foreach($result as $artist) {
58		$table
59		->addRow([
60		$artist->getId(),
61		$artist->getName()
62		]);
63		}
64
65		$table->render();
66		}
67		}
68
69		public function setSpotifyService(Service $service)
70		{
71		$this->spotifyService = $service;
72		}
73		}

PBXg33k / php-music-info

Push — feature/test-commands ( b61593...109eae )

SearchSpotifyArtistCommand::setSpotifyService() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like