Service::track() - Code Metrics - Inspection of "Refactored tests" - PBXg33k/php-music-info - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/spotify ( 0214f9...7a052d )

by Oguzhan

created 2017-02-04 00:20 UTC

Service::track() A

↳ Parent: Service

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php
/**
 * Created by PhpStorm.
 * User: PBX_g33k
 * Date: 30-May-16
 * Time: 13:01
 */

namespace Pbxg33k\MusicInfo\Service\Spotify;

use Pbxg33k\MusicInfo\Service\BaseService;
use Pbxg33k\MusicInfo\Service\Spotify\Endpoint\Artist;
use Pbxg33k\MusicInfo\Service\Spotify\Endpoint\Track;
use SpotifyWebAPI\Session;
use SpotifyWebAPI\SpotifyWebAPI;
use Symfony\Component\HttpFoundation\Request;

class Service extends BaseService
{
    /**
     * Is the client authorized via OAuth2.0
     *
     * @var bool
     */
    protected $authorized = false;

    /**
     * @var Session
     */
    protected $spotifySession;

    /**
     * @var Artist
     */
    protected $artist;

    /**
     * @var Track
     */
    protected $track;

    /**
     * {@inheritdoc}
     */
    public function init($config = [])
    {
        if (empty($config)) {
            $config = $this->getConfig();
        }

        $this->spotifySession = new Session($config['client_id'], $config['client_secret'], $config['redirect_uri']);
        $this->setApiClient(new SpotifyWebAPI());

        $this->requestCredentialsToken($config['scopes']);
        $this->setInitialized(true);

        $this->artist = new Artist($this);
        $this->track = new Track($this);

        return $this;
    }

    /**
     * @param $scopes
     *
     * @return mixed
     */
    public function requestCredentialsToken($scopes)
    {
        $this->spotifySession->requestCredentialsToken($scopes);

        return $this->setAccessTokenFromSession();
    }

    /**
     * @param Request $request
     *
     * @return string
     */
    public function requestAccessToken(Request $request)
    {
        $this->spotifySession->requestAccessToken($request->query->get('code'));
        $this->setAccessTokenFromSession();

        return $this->getApiClient()->getAccessToken();
    }

    /**
     * @return bool
     */
    public function refreshTokens()
    {
        return $this->spotifySession->refreshAccessToken($this->spotifySession->getRefreshToken());
    }

    /**
     * @return mixed
     */
    protected function setAccessTokenFromSession()
    {
        return $this->getApiClient()->setAccessToken($this->spotifySession->getAccessToken());
    }

    /**
     * @return Artist
     */
    public function getArtist()
    {
        return $this->artist;
    }

    /**
     * @return Track
     */
    public function getTrack()
    {
        return $this->track;
    }

    public function testArtistSearchWithServiceAsString()
    {
        $result = $this->musicInfo->doSearch(self::TEST_SEARCH_NAME, 'artist', self::SERVICE_KEY);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->assertInstanceOf(ArrayCollection::class, $result);

        $this->assertInstanceOf(ArrayCollection::class, $result->get( self::SERVICE_KEY ));

        $this->assertInstanceOf(\Pbxg33k\MusicInfo\Model\Artist::class, $result->get( self::SERVICE_KEY )->first());

    }

    /**
     * @return Session
     */
    public function getSpotifySession()
    {
        return $this->spotifySession;
    }

    /**
     * @return boolean
     */
    public function isAuthorized()
    {
        return $this->authorized;
    }

    public function artist()
    {
        return $this->artist;
    }

    public function track()
    {
        return $this->track;
    }

}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: PBX_g33k
5		* Date: 30-May-16
6		* Time: 13:01
7		*/
8
9		namespace Pbxg33k\MusicInfo\Service\Spotify;
10
11		use Pbxg33k\MusicInfo\Service\BaseService;
12		use Pbxg33k\MusicInfo\Service\Spotify\Endpoint\Artist;
13		use Pbxg33k\MusicInfo\Service\Spotify\Endpoint\Track;
14		use SpotifyWebAPI\Session;
15		use SpotifyWebAPI\SpotifyWebAPI;
16		use Symfony\Component\HttpFoundation\Request;
17
18		class Service extends BaseService
19		{
20		/**
21		* Is the client authorized via OAuth2.0
22		*
23		* @var bool
24		*/
25		protected $authorized = false;
26
27		/**
28		* @var Session
29		*/
30		protected $spotifySession;
31
32		/**
33		* @var Artist
34		*/
35		protected $artist;
36
37		/**
38		* @var Track
39		*/
40		protected $track;
41
42		/**
43		* {@inheritdoc}
44		*/
45	11	public function init($config = [])
46		{
47	11	if (empty($config)) {
48	11	$config = $this->getConfig();
49	11	}
50
51	11	$this->spotifySession = new Session($config['client_id'], $config['client_secret'], $config['redirect_uri']);
52	11	$this->setApiClient(new SpotifyWebAPI());
53
54	11	$this->requestCredentialsToken($config['scopes']);
55	11	$this->setInitialized(true);
56
57	11	$this->artist = new Artist($this);
58	11	$this->track = new Track($this);
59
60	11	return $this;
61		}
62
63		/**
64		* @param $scopes
65		*
66		* @return mixed
67		*/
68	11	public function requestCredentialsToken($scopes)
69		{
70	11	$this->spotifySession->requestCredentialsToken($scopes);
71
72	11	return $this->setAccessTokenFromSession();
73		}
74
75		/**
76		* @param Request $request
77		*
78		* @return string
79		*/
80		public function requestAccessToken(Request $request)
81		{
82		$this->spotifySession->requestAccessToken($request->query->get('code'));
83		$this->setAccessTokenFromSession();
84
85		return $this->getApiClient()->getAccessToken();
86		}
87
88		/**
89		* @return bool
90		*/
91		public function refreshTokens()
92		{
93		return $this->spotifySession->refreshAccessToken($this->spotifySession->getRefreshToken());
94		}
95
96		/**
97		* @return mixed
98		*/
99	11	protected function setAccessTokenFromSession()
100		{
101	11	return $this->getApiClient()->setAccessToken($this->spotifySession->getAccessToken());
102		}
103
104		/**
105		* @return Artist
106		*/
107	1	public function getArtist()
108		{
109	1	return $this->artist;
110		}
111
112		/**
113		* @return Track
114		*/
115	1	public function getTrack()
116		{
117	1	return $this->track;
118		}
119
120		public function testArtistSearchWithServiceAsString()
121		{
122		$result = $this->musicInfo->doSearch(self::TEST_SEARCH_NAME, 'artist', self::SERVICE_KEY);
		0 ignored issues – show Bug introduced 2017-02-04 00:23 UTC by Report Bug Copy Issue Report The property `musicInfo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
123
124		$this->assertInstanceOf(ArrayCollection::class, $result);
		0 ignored issues – show Bug introduced 2017-02-04 00:23 UTC by Report Bug Copy Issue Report The method `assertInstanceOf()` does not seem to exist on `object<Pbxg33k\MusicInfo\Service\Spotify\Service>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
125		$this->assertInstanceOf(ArrayCollection::class, $result->get( self::SERVICE_KEY ));
		0 ignored issues – show Bug introduced 2017-02-04 00:23 UTC by Report Bug Copy Issue Report The method `assertInstanceOf()` does not seem to exist on `object<Pbxg33k\MusicInfo\Service\Spotify\Service>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
126		$this->assertInstanceOf(\Pbxg33k\MusicInfo\Model\Artist::class, $result->get( self::SERVICE_KEY )->first());
		0 ignored issues – show Bug introduced 2017-02-04 00:23 UTC by Report Bug Copy Issue Report The method `assertInstanceOf()` does not seem to exist on `object<Pbxg33k\MusicInfo\Service\Spotify\Service>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
127		}
128	5
129		/**
130	5	* @return Session
131		*/
132		public function getSpotifySession()
133	2	{
134		return $this->spotifySession;
135	2	}
136
137		/**
138		* @return boolean
139		*/
140		public function isAuthorized()
141		{
142		return $this->authorized;
143		}
144
145		public function artist()
146		{
147		return $this->artist;
148		}
149
150		public function track()
151		{
152		return $this->track;
153		}
154
155		}

PBXg33k / php-music-info

Push — feature/spotify ( 0214f9...7a052d )

Service::track() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like