Issues (1092)

Model/Plugins/CustomerManagementPlugin.php (4 issues)

1
<?php
2
3
/**
4
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5
 * it under the terms of the GNU Lesser General Public License as published by
6
 * the Free Software Foundation, either version 3 of the License, or
7
 * (at your option) any later version.
8
 *
9
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
 * GNU Lesser General Public License for more details.
13
 *
14
 * You should have received a copy of the GNU Lesser General Public License
15
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16
 *
17
 * PHP version 5
18
 *
19
 * @category  Payone
20
 * @package   Payone_Magento2_Plugin
21
 * @author    FATCHIP GmbH <[email protected]>
22
 * @copyright 2003 - 2025 Payone GmbH
23
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
24
 * @link      http://www.payone.de
25
 */
26
27
declare(strict_types=1);
28
29
namespace Payone\Core\Model\Plugins;
30
31
use Magento\Quote\Model\CustomerManagement;
0 ignored issues
show
The type Magento\Quote\Model\CustomerManagement was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
32
use Magento\Quote\Model\Quote as QuoteEntity;
0 ignored issues
show
The type Magento\Quote\Model\Quote was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
33
use Payone\Core\Model\Methods\PayoneMethod;
34
use Payone\Core\Model\PayoneConfig;
35
36
class CustomerManagementPlugin
37
{
38
    protected $aPaymentMethodWhitelist = [
39
        PayoneConfig::METHOD_PAYPAL,
40
        PayoneConfig::METHOD_PAYPALV2,
41
        PayoneConfig::METHOD_AMAZONPAYV2,
42
    ];
43
44
    /**
45
     * Around plugin for the validateAddresses method
46
     * Skip address validation for guest customers when using Payone Express payment methods
47
     *
48
     * @param CustomerManagement $subject
49
     * @param \Closure $proceed
50
     * @param QuoteEntity $quote
51
     * @return void
52
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
53
     */
54
    public function aroundValidateAddresses(CustomerManagement $subject, \Closure $proceed, QuoteEntity $quote): void
0 ignored issues
show
The parameter $subject is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

54
    public function aroundValidateAddresses(/** @scrutinizer ignore-unused */ CustomerManagement $subject, \Closure $proceed, QuoteEntity $quote): void

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
55
    {
56
        if ($quote->getCustomerIsGuest() && in_array($quote->getPayment()->getMethod(), $this->aPaymentMethodWhitelist)) {
57
            $methodInstance = $quote->getPayment()->getMethodInstance();
58
            if ($methodInstance instanceof PayoneMethod && $methodInstance->isExpressPayment() === true) {
0 ignored issues
show
The condition $methodInstance->isExpressPayment() === true is always false.
Loading history...
59
                return;
60
            }
61
        }
62
        $proceed($quote);
63
    }
64
}
65