Issues (1092)

Model/Plugins/BillingAddressManagement.php (3 issues)

1
<?php
2
3
/**
4
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5
 * it under the terms of the GNU Lesser General Public License as published by
6
 * the Free Software Foundation, either version 3 of the License, or
7
 * (at your option) any later version.
8
 *
9
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
 * GNU Lesser General Public License for more details.
13
 *
14
 * You should have received a copy of the GNU Lesser General Public License
15
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16
 *
17
 * PHP version 5
18
 *
19
 * @category  Payone
20
 * @package   Payone_Magento2_Plugin
21
 * @author    FATCHIP GmbH <[email protected]>
22
 * @copyright 2003 - 2016 Payone GmbH
23
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
24
 * @link      http://www.payone.de
25
 */
26
27
namespace Payone\Core\Model\Plugins;
28
29
use Magento\Quote\Api\Data\AddressInterface;
0 ignored issues
show
The type Magento\Quote\Api\Data\AddressInterface was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
30
use Magento\Quote\Model\BillingAddressManagement as BillingAddressManagementOrig;
0 ignored issues
show
The type Magento\Quote\Model\BillingAddressManagement was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
31
32
/**
33
 * Plugin for Magentos BillingAddressManagement class
34
 */
35
class BillingAddressManagement
36
{
37
    /**
38
     * PAYONE addresscheck request model
39
     *
40
     * @var \Payone\Core\Model\Risk\Addresscheck
41
     */
42
    protected $addresscheck;
43
44
    /**
45
     * PAYONE Addresscheck helper
46
     *
47
     * @var \Payone\Core\Helper\Addresscheck
48
     */
49
    protected $addresscheckHelper;
50
51
    /**
52
     * Constructor
53
     *
54
     * @param \Payone\Core\Model\Risk\Addresscheck       $addresscheck
55
     * @param \Payone\Core\Helper\Addresscheck           $addresscheckHelper
56
     */
57
    public function __construct(
58
        \Payone\Core\Model\Risk\Addresscheck $addresscheck,
59
        \Payone\Core\Helper\Addresscheck $addresscheckHelper
60
    ) {
61
        $this->addresscheck = $addresscheck;
62
        $this->addresscheckHelper = $addresscheckHelper;
63
    }
64
65
    /**
66
     * This writes the addresscheck score to the quote address
67
     *
68
     * @param  BillingAddressManagementOrig $oSource
69
     * @param  int                          $sCartId
70
     * @param  AddressInterface             $oAddress
71
     * @param  bool                         $useForShipping
72
     * @return array
73
     */
74
    public function beforeAssign(BillingAddressManagementOrig $oSource, $sCartId, AddressInterface $oAddress, $useForShipping = false)
0 ignored issues
show
The parameter $oSource is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

74
    public function beforeAssign(/** @scrutinizer ignore-unused */ BillingAddressManagementOrig $oSource, $sCartId, AddressInterface $oAddress, $useForShipping = false)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
75
    {
76
        if ($this->addresscheckHelper->isCheckEnabled(true)) {
77
            $oAddress = $this->addresscheck->handleAddressManagement($oAddress, $sCartId);
78
        }
79
        return [$sCartId, $oAddress, $useForShipping];
80
    }
81
}
82