PAYONE-GmbH / magento-2

Test/Unit/Service/V1/AddresscheckTest.php

Unused Use Statements -2 removed lines

@@ -27,13 +27,11 @@
 namespace Payone\Core\Test\Unit\Service\V1\Data;
 
 use Payone\Core\Service\V1\Addresscheck as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Model\Risk\Addresscheck;
 use Magento\Quote\Api\Data\AddressInterface;
 use Payone\Core\Service\V1\Data\AddresscheckResponse;
 use Payone\Core\Service\V1\Data\AddresscheckResponseFactory;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class AddresscheckTest extends BaseTestCase
 {

Observer/Transactionstatus/Appointed.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
         }
 
         // preauthorization-orders and advance payment should not create an invoice
-        if ($oOrder->getPayoneAuthmode() != 'authorization' || $oOrder->getPayment()->getMethodInstance()->getCode() == PayoneConfig::METHOD_ADVANCE_PAYMENT){
+        if ($oOrder->getPayoneAuthmode() != 'authorization' || $oOrder->getPayment()->getMethodInstance()->getCode() == PayoneConfig::METHOD_ADVANCE_PAYMENT) {
             return;
         }
 

Helper/Base.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
     /**
      * Checks if the given value is json encoded
      *
-     * @param  $sValue
+     * @param  string $sValue
      * @return bool
      */
     protected function isJson($sValue)

Model/Plugins/MethodList.php

Doc Comments +1 added lines, -1 removed lines

@@ -180,7 +180,7 @@
     /**
      * Remove banned paymenttypes
      *
-     * @param  array $aPaymentMethods
+     * @param  MethodInterface[] $aPaymentMethods
      * @param  Quote $oQuote
      * @return array
      */

Spacing +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
     protected function removeBannedPaymentMethods($aPaymentMethods, Quote $oQuote)
     {
         $aBannedMethos = $this->getBannedPaymentMethods($oQuote);
-        for($i = 0; $i < count($aPaymentMethods); $i++) {
+        for ($i = 0; $i < count($aPaymentMethods); $i++) {
             $sCode = $aPaymentMethods[$i]->getCode();
             if (array_key_exists($sCode, $aBannedMethos) !== false) {
                 $iBannedUntil = strtotime($aBannedMethos[$sCode]);