PAYONE-GmbH / magento-2

Helper/Toolkit.php

Doc Comments +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
      *
      * @param  string   $sText
      * @param  string   $aSubstitutionArray
-     * @param  int|bool $iMaxLength
+     * @param  integer $iMaxLength
      * @return string
      */
     public function handleSubstituteReplacement($sText, $aSubstitutionArray, $iMaxLength = false)

Controller/Adminhtml/Config/Export/Index.php

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
                 $sXml = $this->configExport->generateConfigExportXml();
                 if ($sXml !== false) {
                     $oResultRaw->setHeader("Content-Type", "text/xml; charset=\"utf8\"", true);
-                    $oResultRaw->setHeader("Content-Disposition", "attachment; filename=\"payone_config_export" . date('Y-m-d H-i-s') . "_" . md5($sXml) . ".xml\"", true);
+                    $oResultRaw->setHeader("Content-Disposition", "attachment; filename=\"payone_config_export".date('Y-m-d H-i-s')."_".md5($sXml).".xml\"", true);
                     $oResultRaw->setContents($sXml);
                 }
             } catch (\Exception $e) {

Model/Api/Invoice.php

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
     {
         if (fmod(floatval($dItemAmount), 1.0) > 0) { // input does not represent an integer
             $sErrorMessage = "Unable to use floating point values for item amounts! Parameter was: ";
-            throw new \InvalidArgumentException($sErrorMessage . strval($dItemAmount), 1);
+            throw new \InvalidArgumentException($sErrorMessage.strval($dItemAmount), 1);
         } else { // return the integer value
             return intval($dItemAmount);
         }

Model/Api/Payolution/PrivacyDeclaration.php

Doc Comments +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
      * Get fallback template
      *
      * @param  string $sCompany
-     * @return mixed
+     * @return string
      */
     protected function getFallbackText($sCompany)
     {

Model/Methods/Payolution/PayolutionBase.php

Doc Comments -1 removed lines

@@ -170,7 +170,6 @@
      * Method to trigger the Payone genericpayment request pre-check
      *
      * @param  float       $dAmount
-     * @param  string|bool $sBirthday
      * @return array
      * @throws LocalizedException
      */

Service/V1/InstallmentPlan.php

Spacing +8 added lines, -8 removed lines

@@ -135,9 +135,9 @@ 
     {
         $sErrorMessage = false;
         if (isset($aResponsePreCheck['status']) && $aResponsePreCheck['status'] == 'ERROR') {
-            $sErrorMessage = __($aResponsePreCheck['errorcode'] . ' - ' . $aResponsePreCheck['customermessage']);
+            $sErrorMessage = __($aResponsePreCheck['errorcode'].' - '.$aResponsePreCheck['customermessage']);
         } elseif (isset($aResponseCalculation['status']) && $aResponseCalculation['status'] == 'ERROR') {
-            $sErrorMessage = __($aResponseCalculation['errorcode'] . ' - ' . $aResponseCalculation['customermessage']);
+            $sErrorMessage = __($aResponseCalculation['errorcode'].' - '.$aResponseCalculation['customermessage']);
         } elseif (!$aResponsePreCheck || (isset($aResponsePreCheck['status']) && $aResponsePreCheck['status'] == 'OK' && !$aResponseCalculation)) {
             $sErrorMessage = __('An unknown error occurred');
         }
@@ -189,7 +189,7 @@ 
     public function getPayDataArray($aResponse)
     {
         $aPayData = array();
-        foreach($aResponse as $sKey => $sValue) {
+        foreach ($aResponse as $sKey => $sValue) {
             $sCorrectedKey = str_ireplace('add_paydata[', '', $sKey);
             $sCorrectedKey = rtrim($sCorrectedKey, ']');
             $sCorrectedKey = strtolower($sCorrectedKey);
@@ -214,18 +214,18 @@ 
         $aPayData = $this->getPayDataArray($aResponse);
         foreach ($aPayData as $sKey => $sValue) {
             $aSplit = explode('_', $sKey);
-            for($i = count($aSplit); $i > 0; $i--) {
-                if($i == count($aSplit)) {
-                    $aTmp = array($aSplit[$i-1] => $sValue);
+            for ($i = count($aSplit); $i > 0; $i--) {
+                if ($i == count($aSplit)) {
+                    $aTmp = array($aSplit[$i - 1] => $sValue);
                 } else {
-                    $aTmp = array($aSplit[$i-1] => $aTmp);
+                    $aTmp = array($aSplit[$i - 1] => $aTmp);
                 }
             }
 
             $aInstallmentData = array_replace_recursive($aInstallmentData, $aTmp);
         }
 
-        if(isset($aInstallmentData['paymentdetails']) && count($aInstallmentData['paymentdetails']) > 0) {
+        if (isset($aInstallmentData['paymentdetails']) && count($aInstallmentData['paymentdetails']) > 0) {
             return $aInstallmentData['paymentdetails'];
         }
 

Observer/Transactionstatus/Paid.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 
         // order is not guaranteed to exist if using transaction status forwarding
         // advance payment should not create an invoice
-        if (null === $oOrder || $oOrder->getPayment()->getMethodInstance()->getCode() == PayoneConfig::METHOD_ADVANCE_PAYMENT){
+        if (null === $oOrder || $oOrder->getPayment()->getMethodInstance()->getCode() == PayoneConfig::METHOD_ADVANCE_PAYMENT) {
             return;
         }
 

Model/Test/PayoneObjectManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * Class constructor
      *
-     * @param \PHPUnit_Framework_TestCase $testObject
+     * @param \Payone\Core\Test\Unit\BaseTestCase $testObject
      */
     public function __construct($testObject)
     {