PAYONE-GmbH / magento-2

Test/Unit/Model/Methods/BaseMethodTest.php

Unused Use Statements +1 added lines, -2 removed lines

@@ -28,11 +28,10 @@
 
 use Magento\Payment\Model\Method\AbstractMethod;
 use Magento\Sales\Model\Order;
-use Payone\Core\Model\Methods\Paydirekt as ClassToTest;
+use Payone\Core\Model\Methods\Paydirekt;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Shop;
 use Magento\Framework\App\Config\ScopeConfigInterface;
-use Payone\Core\Model\Methods\Paydirekt;
 use Payone\Core\Model\PayoneConfig;
 use Magento\Payment\Model\Info;
 use Payone\Core\Model\Api\Request\Authorization;

Model/Api/Payolution/PrivacyDeclaration.php

Doc Comments +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
      * Get fallback template
      *
      * @param  string $sCompany
-     * @return mixed
+     * @return string
      */
     protected function getFallbackText($sCompany)
     {

Unused Use Statements -2 removed lines

@@ -26,8 +26,6 @@
 
 namespace Payone\Core\Model\Api\Payolution;
 
-use Locale;
-
 /**
  * Class for requesting the privacy declaration from payolution
  */

Model/Methods/Payolution/PayolutionBase.php

Doc Comments -1 removed lines

@@ -170,7 +170,6 @@
      * Method to trigger the Payone genericpayment request pre-check
      *
      * @param  float       $dAmount
-     * @param  string|bool $sBirthday
      * @return array
      * @throws LocalizedException
      */

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 
 use Payone\Core\Model\PayoneConfig;
 use Magento\Sales\Model\Order;
-use Magento\Payment\Model\InfoInterface;
 use Magento\Framework\Exception\LocalizedException;
 use Payone\Core\Model\Methods\PayoneMethod;
 use Magento\Framework\DataObject;

Service/V1/InstallmentPlan.php

Spacing +8 added lines, -8 removed lines

@@ -135,9 +135,9 @@ 
     {
         $sErrorMessage = false;
         if (isset($aResponsePreCheck['status']) && $aResponsePreCheck['status'] == 'ERROR') {
-            $sErrorMessage = __($aResponsePreCheck['errorcode'] . ' - ' . $aResponsePreCheck['customermessage']);
+            $sErrorMessage = __($aResponsePreCheck['errorcode'].' - '.$aResponsePreCheck['customermessage']);
         } elseif (isset($aResponseCalculation['status']) && $aResponseCalculation['status'] == 'ERROR') {
-            $sErrorMessage = __($aResponseCalculation['errorcode'] . ' - ' . $aResponseCalculation['customermessage']);
+            $sErrorMessage = __($aResponseCalculation['errorcode'].' - '.$aResponseCalculation['customermessage']);
         } elseif (!$aResponsePreCheck || (isset($aResponsePreCheck['status']) && $aResponsePreCheck['status'] == 'OK' && !$aResponseCalculation)) {
             $sErrorMessage = __('An unknown error occurred');
         }
@@ -189,7 +189,7 @@ 
     public function getPayDataArray($aResponse)
     {
         $aPayData = array();
-        foreach($aResponse as $sKey => $sValue) {
+        foreach ($aResponse as $sKey => $sValue) {
             $sCorrectedKey = str_ireplace('add_paydata[', '', $sKey);
             $sCorrectedKey = rtrim($sCorrectedKey, ']');
             $sCorrectedKey = strtolower($sCorrectedKey);
@@ -214,18 +214,18 @@ 
         $aPayData = $this->getPayDataArray($aResponse);
         foreach ($aPayData as $sKey => $sValue) {
             $aSplit = explode('_', $sKey);
-            for($i = count($aSplit); $i > 0; $i--) {
-                if($i == count($aSplit)) {
-                    $aTmp = array($aSplit[$i-1] => $sValue);
+            for ($i = count($aSplit); $i > 0; $i--) {
+                if ($i == count($aSplit)) {
+                    $aTmp = array($aSplit[$i - 1] => $sValue);
                 } else {
-                    $aTmp = array($aSplit[$i-1] => $aTmp);
+                    $aTmp = array($aSplit[$i - 1] => $aTmp);
                 }
             }
 
             $aInstallmentData = array_replace_recursive($aInstallmentData, $aTmp);
         }
 
-        if(isset($aInstallmentData['paymentdetails']) && count($aInstallmentData['paymentdetails']) > 0) {
+        if (isset($aInstallmentData['paymentdetails']) && count($aInstallmentData['paymentdetails']) > 0) {
             return $aInstallmentData['paymentdetails'];
         }
 

Model/Api/Request/Base.php

Indentation -1 removed lines

@@ -268,7 +268,6 @@
 
     /**
      * Send the previously prepared request, log request and response into the database and return the response
-
      * @param  PayoneMethod $oPayment
      * @return array
      */

Observer/Transactionstatus/Paid.php

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
 
         // order is not guaranteed to exist if using transaction status forwarding
         // advance payment should not create an invoice
-        if (null === $oOrder || $oOrder->getPayment()->getMethodInstance()->getCode() == PayoneConfig::METHOD_ADVANCE_PAYMENT){
+        if (null === $oOrder || $oOrder->getPayment()->getMethodInstance()->getCode() == PayoneConfig::METHOD_ADVANCE_PAYMENT) {
             return;
         }
 

Model/Test/PayoneObjectManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * Class constructor
      *
-     * @param \PHPUnit_Framework_TestCase $testObject
+     * @param \Payone\Core\Test\Unit\BaseTestCase $testObject
      */
     public function __construct($testObject)
     {

Test/Unit/Helper/RequestTest.php

Unused Use Statements -1 removed lines

@@ -36,7 +36,6 @@
 use Payone\Core\Helper\Environment;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\PayoneConfig;
-use Locale;
 use Payone\Core\Test\Unit\BaseTestCase;
 use Payone\Core\Model\Test\PayoneObjectManager;
 

Test/Unit/Model/Api/InvoiceTest.php

Unused Use Statements -2 removed lines

@@ -27,13 +27,11 @@
 namespace Payone\Core\Test\Unit\Model\Api;
 
 use Payone\Core\Model\Api\Invoice as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Toolkit;
 use Payone\Core\Model\Api\Request\Authorization;
 use Magento\Sales\Model\Order;
 use Magento\Sales\Model\Order\Item;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Model\Test\PayoneObjectManager;
 
 class InvoiceTest extends BaseTestCase
 {