Creditcard - Code Metrics - Inspection of "Merge pull request #78 'robert/MAG2-19-Addresschec..." - PAYONE-GmbH/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0dbe68...17d58d )

by Florian

created 2017-06-15 07:42 UTC

Creditcard A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	10.87 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	5
c	1
b	0
f	0
lcom	0
cbo	2
dl	5
loc	46
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCreditcardType()	0	8	2
A	_prepareSpecificInformation()	5	22	3

How to fix Duplicated Code

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <[email protected]>
 * @copyright 2003 - 2017 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Block\Info;

use Payone\Core\Model\Source\CreditcardTypes;

class Creditcard extends Base
{
    /**
     * Get long version of given creditcard type
     *
     * @param  string $sShortType
     * @return string
     */
    protected function getCreditcardType($sShortType)
    {
        $aTypes = CreditcardTypes::getCreditcardTypes();
        if (array_key_exists($sShortType, $aTypes) !== false) {
            return $aTypes[$sShortType];
        }
        return '';
    }

    /**
     * Prepare credit card related payment info
     *
     * @param \Magento\Framework\DataObject|array $transport
     * @return \Magento\Framework\DataObject
     */
    protected function _prepareSpecificInformation($transport = null)
    {
        if (null !== $this->_paymentSpecificInformation) {
            return $this->_paymentSpecificInformation;
        }
        $transport = parent::_prepareSpecificInformation($transport);
        $data = [];

        $oStatus = $this->getAppointedStatus();

        $data[(string)__('Credit Card Type:')] = $this->getCreditcardType($oStatus->getCardtype());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $data[(string)__('Credit Card Number:')] = $oStatus->getCardpan();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $data[(string)__('Expiration Date:')] = $oStatus->getCardexpiredate();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $sTransId = $this->getInfo()->getLastTransId();
        if ($sTransId == '') {

            $data[(string)__('Payment has not been processed yet.')] = '';
        } else {
            $data[(string)__('Payment reference:')] = $sTransId;
        }
        return $transport->setData(array_merge($data, $transport->getData()));
    }
}


1		<?php
2
3		/**
4		* PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5		* it under the terms of the GNU Lesser General Public License as published by
6		* the Free Software Foundation, either version 3 of the License, or
7		* (at your option) any later version.
8		*
9		* PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10		* but WITHOUT ANY WARRANTY; without even the implied warranty of
11		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12		* GNU Lesser General Public License for more details.
13		*
14		* You should have received a copy of the GNU Lesser General Public License
15		* along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16		*
17		* PHP version 5
18		*
19		* @category Payone
20		* @package Payone_Magento2_Plugin
21		* @author FATCHIP GmbH <[email protected]>
22		* @copyright 2003 - 2017 Payone GmbH
23		* @license <http://www.gnu.org/licenses/> GNU Lesser General Public License
24		* @link http://www.payone.de
25		*/
26
27		namespace Payone\Core\Block\Info;
28
29		use Payone\Core\Model\Source\CreditcardTypes;
30
31		class Creditcard extends Base
32		{
33		/**
34		* Get long version of given creditcard type
35		*
36		* @param string $sShortType
37		* @return string
38		*/
39		protected function getCreditcardType($sShortType)
40		{
41		$aTypes = CreditcardTypes::getCreditcardTypes();
42		if (array_key_exists($sShortType, $aTypes) !== false) {
43		return $aTypes[$sShortType];
44		}
45		return '';
46		}
47
48		/**
49		* Prepare credit card related payment info
50		*
51		* @param \Magento\Framework\DataObject\|array $transport
52		* @return \Magento\Framework\DataObject
53		*/
54		protected function _prepareSpecificInformation($transport = null)
55		{
56		if (null !== $this->_paymentSpecificInformation) {
57		return $this->_paymentSpecificInformation;
58		}
59		$transport = parent::_prepareSpecificInformation($transport);
60		$data = [];
61
62		$oStatus = $this->getAppointedStatus();
63
64		$data[(string)__('Credit Card Type:')] = $this->getCreditcardType($oStatus->getCardtype());
		0 ignored issues – show Documentation Bug introduced 2017-06-02 10:53 UTC by Report Bug Copy Issue Report The method `getCardtype` does not exist on `object<Payone\Core\Model...ties\TransactionStatus>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
65		$data[(string)__('Credit Card Number:')] = $oStatus->getCardpan();
		0 ignored issues – show Documentation Bug introduced 2017-06-02 10:53 UTC by Report Bug Copy Issue Report The method `getCardpan` does not exist on `object<Payone\Core\Model...ties\TransactionStatus>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
66		$data[(string)__('Expiration Date:')] = $oStatus->getCardexpiredate();
		0 ignored issues – show Documentation Bug introduced 2017-06-02 10:53 UTC by Report Bug Copy Issue Report The method `getCardexpiredate` does not exist on `object<Payone\Core\Model...ties\TransactionStatus>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
67
68		$sTransId = $this->getInfo()->getLastTransId();
69	View Code Duplication	if ($sTransId == '') {
		0 ignored issues – show Duplication introduced 2017-06-02 10:53 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		$data[(string)__('Payment has not been processed yet.')] = '';
71		} else {
72		$data[(string)__('Payment reference:')] = $sTransId;
73		}
74		return $transport->setData(array_merge($data, $transport->getData()));
75		}
76		}
77

PAYONE-GmbH / magento-2

Push — master ( 0dbe68...17d58d )

Creditcard A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like