Inspection of "Merge pull request #145 from FatchipRobert/MAG2-59..." - PAYONE-GmbH/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3ab156...6d4a89 )

by Florian

created 2018-02-19 14:26 UTC

Status

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -28,12 +28,10 @@
 block discarded – undo
 
 use Magento\Quote\Model\Quote\Address;
 use Payone\Core\Model\Api\Request\Addresscheck as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Api;
 use Payone\Core\Model\ResourceModel\CheckedAddresses;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class AddresscheckTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/AuthorizationTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,6 @@  discard block
 block discarded – undo
 use Magento\Sales\Model\Order;
 use Payone\Core\Helper\Database;
 use Payone\Core\Model\Api\Request\Authorization as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Model\Methods\PayoneMethod;
 use Payone\Core\Helper\Api;
 use Payone\Core\Helper\Toolkit;
@@ -41,7 +40,6 @@  discard block
 block discarded – undo
 use Magento\Customer\Api\Data\CustomerInterface;
 use Payone\Core\Helper\Environment;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class AuthorizationTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/CaptureTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -30,13 +30,11 @@
 block discarded – undo
 use Payone\Core\Helper\Database;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\Api\Request\Capture as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Model\Methods\PayoneMethod;
 use Magento\Payment\Model\Info;
 use Payone\Core\Helper\Api;
 use Magento\Sales\Model\Order\Item;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class CaptureTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/ConsumerscoreTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -30,14 +30,12 @@
 block discarded – undo
 use Magento\Quote\Model\Quote\Address;
 use Payone\Core\Helper\Database;
 use Payone\Core\Model\Api\Request\Consumerscore as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Api;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\ResourceModel\CheckedAddresses;
 use Payone\Core\Model\Source\AddressCheckType;
 use Payone\Core\Model\Source\CreditratingCheckType;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class ConsumerscoreTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/DebitTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -30,7 +30,6 @@  discard block
 block discarded – undo
 use Magento\Sales\Model\Order;
 use Payone\Core\Helper\Database;
 use Payone\Core\Model\Api\Request\Debit as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Model\Methods\PayoneMethod;
 use Magento\Payment\Model\Info;
 use Payone\Core\Helper\Api;
@@ -40,7 +39,6 @@  discard block
 block discarded – undo
 use Payone\Core\Helper\Shop;
 use Magento\Sales\Model\Order\Item;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class DebitTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/Genericpayment/CalculationTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -28,13 +28,11 @@
 block discarded – undo
 
 use Magento\Quote\Model\Quote;
 use Payone\Core\Model\Api\Request\Genericpayment\Calculation as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Api;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\Methods\Paypal;
 use Magento\Quote\Model\Quote\Address;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class CalculationTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/Genericpayment/PayPalExpressTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -28,12 +28,10 @@
 block discarded – undo
 
 use Magento\Quote\Model\Quote;
 use Payone\Core\Model\Api\Request\Genericpayment\PayPalExpress as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Api;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\Methods\Paypal;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class CaptureTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/Genericpayment/PreCheckTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -28,7 +28,6 @@  discard block
 block discarded – undo
 
 use Magento\Quote\Model\Quote;
 use Payone\Core\Model\Api\Request\Genericpayment\PreCheck as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Helper\Api;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\Methods\Paypal;
@@ -36,7 +35,6 @@  discard block
 block discarded – undo
 use Magento\Payment\Model\Info;
 use Payone\Core\Helper\Environment;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class PreCheckTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

Test/Unit/Model/Api/Request/ManagemandateTest.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -30,14 +30,12 @@
 block discarded – undo
 use Payone\Core\Helper\Database;
 use Payone\Core\Helper\Shop;
 use Payone\Core\Model\Api\Request\Managemandate as ClassToTest;
-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Payone\Core\Model\Methods\PayoneMethod;
 use Magento\Payment\Model\Info;
 use Payone\Core\Helper\Api;
 use Magento\Customer\Api\Data\CustomerInterface;
 use Magento\Quote\Model\Quote\Address;
 use Payone\Core\Test\Unit\BaseTestCase;
-use Payone\Core\Test\Unit\PayoneObjectManager;
 
 class ManagemandateTest extends BaseTestCase
 {

Please login to merge, or discard this patch.

		@@ -28,12 +28,10 @@
		block discarded – undo
28	28
29	29	use Magento\Quote\Model\Quote\Address;
30	30	use Payone\Core\Model\Api\Request\Addresscheck as ClassToTest;
31		-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
32	31	use Payone\Core\Helper\Api;
33	32	use Payone\Core\Model\ResourceModel\CheckedAddresses;
34	33	use Payone\Core\Helper\Shop;
35	34	use Payone\Core\Test\Unit\BaseTestCase;
36		-use Payone\Core\Test\Unit\PayoneObjectManager;
37	35
38	36	class AddresscheckTest extends BaseTestCase
39	37	{

		@@ -30,7 +30,6 @@ discard block
		block discarded – undo
30	30	use Magento\Sales\Model\Order;
31	31	use Payone\Core\Helper\Database;
32	32	use Payone\Core\Model\Api\Request\Authorization as ClassToTest;
33		-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
34	33	use Payone\Core\Model\Methods\PayoneMethod;
35	34	use Payone\Core\Helper\Api;
36	35	use Payone\Core\Helper\Toolkit;
		@@ -41,7 +40,6 @@ discard block
		block discarded – undo
41	40	use Magento\Customer\Api\Data\CustomerInterface;
42	41	use Payone\Core\Helper\Environment;
43	42	use Payone\Core\Test\Unit\BaseTestCase;
44		-use Payone\Core\Test\Unit\PayoneObjectManager;
45	43
46	44	class AuthorizationTest extends BaseTestCase
47	45	{

		@@ -30,13 +30,11 @@
		block discarded – undo
30	30	use Payone\Core\Helper\Database;
31	31	use Payone\Core\Helper\Shop;
32	32	use Payone\Core\Model\Api\Request\Capture as ClassToTest;
33		-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
34	33	use Payone\Core\Model\Methods\PayoneMethod;
35	34	use Magento\Payment\Model\Info;
36	35	use Payone\Core\Helper\Api;
37	36	use Magento\Sales\Model\Order\Item;
38	37	use Payone\Core\Test\Unit\BaseTestCase;
39		-use Payone\Core\Test\Unit\PayoneObjectManager;
40	38
41	39	class CaptureTest extends BaseTestCase
42	40	{

		@@ -30,14 +30,12 @@
		block discarded – undo
30	30	use Magento\Quote\Model\Quote\Address;
31	31	use Payone\Core\Helper\Database;
32	32	use Payone\Core\Model\Api\Request\Consumerscore as ClassToTest;
33		-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
34	33	use Payone\Core\Helper\Api;
35	34	use Payone\Core\Helper\Shop;
36	35	use Payone\Core\Model\ResourceModel\CheckedAddresses;
37	36	use Payone\Core\Model\Source\AddressCheckType;
38	37	use Payone\Core\Model\Source\CreditratingCheckType;
39	38	use Payone\Core\Test\Unit\BaseTestCase;
40		-use Payone\Core\Test\Unit\PayoneObjectManager;
41	39
42	40	class ConsumerscoreTest extends BaseTestCase
43	41	{

		@@ -28,13 +28,11 @@
		block discarded – undo
28	28
29	29	use Magento\Quote\Model\Quote;
30	30	use Payone\Core\Model\Api\Request\Genericpayment\Calculation as ClassToTest;
31		-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
32	31	use Payone\Core\Helper\Api;
33	32	use Payone\Core\Helper\Shop;
34	33	use Payone\Core\Model\Methods\Paypal;
35	34	use Magento\Quote\Model\Quote\Address;
36	35	use Payone\Core\Test\Unit\BaseTestCase;
37		-use Payone\Core\Test\Unit\PayoneObjectManager;
38	36
39	37	class CalculationTest extends BaseTestCase
40	38	{

		@@ -28,7 +28,6 @@ discard block
		block discarded – undo
28	28
29	29	use Magento\Quote\Model\Quote;
30	30	use Payone\Core\Model\Api\Request\Genericpayment\PreCheck as ClassToTest;
31		-use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
32	31	use Payone\Core\Helper\Api;
33	32	use Payone\Core\Helper\Shop;
34	33	use Payone\Core\Model\Methods\Paypal;
		@@ -36,7 +35,6 @@ discard block
		block discarded – undo
36	35	use Magento\Payment\Model\Info;
37	36	use Payone\Core\Helper\Environment;
38	37	use Payone\Core\Test\Unit\BaseTestCase;
39		-use Payone\Core\Test\Unit\PayoneObjectManager;
40	38
41	39	class PreCheckTest extends BaseTestCase
42	40	{

PAYONE-GmbH / magento-2

Push — master ( 3ab156...6d4a89 )

Status

Category

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch