RemoteAddressTest::setUp() - Code Metrics - Inspection of "Merge pull request #145 from FatchipRobert/MAG2-59..." - PAYONE-GmbH/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3ab156...6d4a89 )

by Florian

created 2018-02-19 14:26 UTC

RemoteAddressTest::setUp() A

↳ Parent: RemoteAddressTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <[email protected]>
 * @copyright 2003 - 2017 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Test\Unit\Model\Methods;

use Payone\Core\Model\Environment\RemoteAddress as ClassToTest;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
use Payone\Core\Test\Unit\BaseTestCase;
use Payone\Core\Test\Unit\PayoneObjectManager;

class RemoteAddressTest extends BaseTestCase
{
    /**
     * @var ClassToTest
     */
    private $classToTest;

    /**
     * @var ObjectManager|PayoneObjectManager
     */
    private $objectManager;

    protected function setUp()
    {
        $this->objectManager = $this->getObjectManager();

        $this->classToTest = $this->objectManager->getObject(ClassToTest::class);
    }

    public function testUseHttpXForwardedTest()
    {
        $result = $this->classToTest->useHttpXForwarded();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $this->assertNull($result);
    }
}


1			<?php
2
3			/**
4			* PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5			* it under the terms of the GNU Lesser General Public License as published by
6			* the Free Software Foundation, either version 3 of the License, or
7			* (at your option) any later version.
8			*
9			* PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			* GNU Lesser General Public License for more details.
13			*
14			* You should have received a copy of the GNU Lesser General Public License
15			* along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16			*
17			* PHP version 5
18			*
19			* @category Payone
20			* @package Payone_Magento2_Plugin
21			* @author FATCHIP GmbH <[email protected]>
22			* @copyright 2003 - 2017 Payone GmbH
23			* @license <http://www.gnu.org/licenses/> GNU Lesser General Public License
24			* @link http://www.payone.de
25			*/
26
27			namespace Payone\Core\Test\Unit\Model\Methods;
28
29			use Payone\Core\Model\Environment\RemoteAddress as ClassToTest;
30			use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
31			use Payone\Core\Test\Unit\BaseTestCase;
32			use Payone\Core\Test\Unit\PayoneObjectManager;
33
34			class RemoteAddressTest extends BaseTestCase
35			{
36			/**
37			* @var ClassToTest
38			*/
39			private $classToTest;
40
41			/**
42			* @var ObjectManager\|PayoneObjectManager
43			*/
44			private $objectManager;
45
46			protected function setUp()
47			{
48			$this->objectManager = $this->getObjectManager();
49
50			$this->classToTest = $this->objectManager->getObject(ClassToTest::class);
51			}
52
53			public function testUseHttpXForwardedTest()
54			{
55			$result = $this->classToTest->useHttpXForwarded();
			0 ignored issues – show Bug introduced 2018-01-17 11:05 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$result` is correct as `$this->classToTest->useHttpXForwarded()` (which targets `Payone\Core\Model\Enviro...ss::useHttpXForwarded()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56			$this->assertNull($result);
57			}
58			}
59

PAYONE-GmbH / magento-2

Push — master ( 3ab156...6d4a89 )

RemoteAddressTest::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like