PAYONE-GmbH /
magento-2
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 104 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | /** |
||
| 33 | ], function ($, addresscheck, editAddress, quote, selectShippingAddressAction, checkoutData) { |
||
| 34 | 'use strict'; |
||
| 35 | |||
| 36 | var mixin = { |
||
| 37 | payoneCheckAddress: function () { |
||
| 38 | if (window.checkoutConfig.payment.payone.addresscheckEnabled && window.checkoutConfig.payment.payone.addresscheckShippingEnabled) { |
||
| 39 | return true; |
||
| 40 | } |
||
| 41 | return false; |
||
| 42 | }, |
||
| 43 | saveNewAddress: function () { |
||
| 44 | if (!this.payoneCheckAddress()) { |
||
| 45 | return this._super(); |
||
| 46 | } |
||
| 47 | |||
| 48 | if (!this.source.get('payone_address_checked')) { |
||
| 49 | addresscheck(this.source.get('shippingAddress'), false, this, 'saveNewAddress'); |
||
|
Best Practice
introduced
by
|
|||
| 50 | } else { |
||
| 51 | this.source.set('payone_address_checked', false); |
||
| 52 | return this._super(); |
||
| 53 | } |
||
| 54 | }, |
||
| 55 | payoneReplaceInSelectedShippingAddress: function (sReplace, sReplaceWith) { |
||
| 56 | var oElem = $('.shipping-address-item.selected-item'); |
||
| 57 | if (oElem.length > 0) { |
||
| 58 | oElem.html(oElem.html().replace(sReplace, sReplaceWith)); |
||
| 59 | } |
||
| 60 | }, |
||
| 61 | payoneUpdateField: function(oSourceAddress, oResponseAddress, sField) { |
||
| 62 | if (sField === "street") { |
||
| 63 | if (oSourceAddress[sField][0] !== oResponseAddress[sField][0]) { |
||
| 64 | this.payoneReplaceInSelectedShippingAddress(oSourceAddress[sField][0], oResponseAddress[sField][0]); |
||
| 65 | oSourceAddress[sField][0] = oResponseAddress[sField][0]; |
||
| 66 | } |
||
| 67 | } else { |
||
| 68 | if (oSourceAddress[sField] !== oResponseAddress[sField]) { |
||
| 69 | this.payoneReplaceInSelectedShippingAddress(oSourceAddress[sField], oResponseAddress[sField]); |
||
| 70 | oSourceAddress[sField] = oResponseAddress[sField]; |
||
| 71 | } |
||
| 72 | } |
||
| 73 | return oSourceAddress; |
||
| 74 | }, |
||
| 75 | payoneUpdateAddress: function (addressData) { |
||
| 76 | if (this.isFormInline) { |
||
| 77 | this.payoneUpdateAddressSource(addressData); |
||
| 78 | } else { |
||
| 79 | this.payoneUpdateAddressRegistered(addressData); |
||
| 80 | } |
||
| 81 | }, |
||
| 82 | payoneUpdateAddressSource: function (addressData) { |
||
| 83 | this.source.set('shippingAddress.postcode', addressData.postcode); |
||
| 84 | this.source.set('shippingAddress.firstname', addressData.firstname); |
||
| 85 | this.source.set('shippingAddress.lastname', addressData.lastname); |
||
| 86 | this.source.set('shippingAddress.street.0', addressData.street[0]); |
||
| 87 | this.source.set('shippingAddress.city', addressData.city); |
||
| 88 | this.source.set('shippingAddress.country_id', addressData.country_id); |
||
| 89 | }, |
||
| 90 | payoneUpdateAddressRegistered: function (addressData) { |
||
| 91 | var newShippingAddress = quote.shippingAddress(); |
||
| 92 | var aUpdateFields = ["postcode", "firstname", "lastname", "street", "city"]; |
||
| 93 | for (var i = 0; i < aUpdateFields.length; i++) { |
||
| 94 | newShippingAddress = this.payoneUpdateField(newShippingAddress, addressData, aUpdateFields[i]); |
||
| 95 | } |
||
| 96 | |||
| 97 | this.payoneUpdateAddressSource(addressData); |
||
| 98 | |||
| 99 | editAddress(addressData); |
||
| 100 | |||
| 101 | selectShippingAddressAction(newShippingAddress); |
||
| 102 | checkoutData.setSelectedShippingAddress(newShippingAddress.getKey()); |
||
| 103 | }, |
||
| 104 | payoneContinue: function (sType) { |
||
| 105 | if (sType == 'saveNewAddress') { |
||
| 106 | this.source.set('payone_address_checked', true); |
||
| 107 | this.saveNewAddress(); |
||
| 108 | } else if (sType == 'setShippingInformation') { |
||
| 109 | this.source.set('payone_guest_address_checked', true); |
||
| 110 | this.setShippingInformation(); |
||
| 111 | } |
||
| 112 | }, |
||
| 113 | setShippingInformation: function () { |
||
| 114 | if (!this.payoneCheckAddress()) { |
||
| 115 | return this._super(); |
||
| 116 | } |
||
| 117 | |||
| 118 | if (!this.source.get('payone_guest_address_checked')) { |
||
| 119 | if (this.validateShippingInformation()) { |
||
| 120 | if (!this.isFormInline) { |
||
| 121 | addresscheck(quote.shippingAddress(), false, this, 'setShippingInformation'); |
||
| 122 | } else { |
||
| 123 | addresscheck(this.source.get('shippingAddress'), false, this, 'setShippingInformation'); |
||
| 124 | } |
||
| 125 | } |
||
| 126 | } else { |
||
| 127 | this.source.set('payone_guest_address_checked', false); |
||
| 128 | return this._super(); |
||
| 129 | } |
||
| 130 | } |
||
| 131 | } |
||
| 132 | |||
| 133 | return function (shipping) { |
||
| 134 | return shipping.extend(mixin); |
||
| 135 | }; |
||
| 136 | }); |
||
| 137 |
Loading history...
