PAYONE-GmbH / magento-2

Service/V1/InstallmentPlan.php

Spacing +8 added lines, -8 removed lines

@@ -135,9 +135,9 @@ 
     {
         $sErrorMessage = false;
         if (isset($aResponsePreCheck['status']) && $aResponsePreCheck['status'] == 'ERROR') {
-            $sErrorMessage = __($aResponsePreCheck['errorcode'] . ' - ' . $aResponsePreCheck['customermessage']);
+            $sErrorMessage = __($aResponsePreCheck['errorcode'].' - '.$aResponsePreCheck['customermessage']);
         } elseif (isset($aResponseCalculation['status']) && $aResponseCalculation['status'] == 'ERROR') {
-            $sErrorMessage = __($aResponseCalculation['errorcode'] . ' - ' . $aResponseCalculation['customermessage']);
+            $sErrorMessage = __($aResponseCalculation['errorcode'].' - '.$aResponseCalculation['customermessage']);
         } elseif (!$aResponsePreCheck || (isset($aResponsePreCheck['status']) && $aResponsePreCheck['status'] == 'OK' && !$aResponseCalculation)) {
             $sErrorMessage = __('An unknown error occurred');
         }
@@ -189,7 +189,7 @@ 
     public function getPayDataArray($aResponse)
     {
         $aPayData = array();
-        foreach($aResponse as $sKey => $sValue) {
+        foreach ($aResponse as $sKey => $sValue) {
             $sCorrectedKey = str_ireplace('add_paydata[', '', $sKey);
             $sCorrectedKey = rtrim($sCorrectedKey, ']');
             $sCorrectedKey = strtolower($sCorrectedKey);
@@ -214,18 +214,18 @@ 
         $aPayData = $this->getPayDataArray($aResponse);
         foreach ($aPayData as $sKey => $sValue) {
             $aSplit = explode('_', $sKey);
-            for($i = count($aSplit); $i > 0; $i--) {
-                if($i == count($aSplit)) {
-                    $aTmp = array($aSplit[$i-1] => $sValue);
+            for ($i = count($aSplit); $i > 0; $i--) {
+                if ($i == count($aSplit)) {
+                    $aTmp = array($aSplit[$i - 1] => $sValue);
                 } else {
-                    $aTmp = array($aSplit[$i-1] => $aTmp);
+                    $aTmp = array($aSplit[$i - 1] => $aTmp);
                 }
             }
 
             $aInstallmentData = array_replace_recursive($aInstallmentData, $aTmp);
         }
 
-        if(isset($aInstallmentData['paymentdetails']) && count($aInstallmentData['paymentdetails']) > 0) {
+        if (isset($aInstallmentData['paymentdetails']) && count($aInstallmentData['paymentdetails']) > 0) {
             return $aInstallmentData['paymentdetails'];
         }
 

Model/Api/Request/Base.php

Indentation -1 removed lines

@@ -268,7 +268,6 @@
 
     /**
      * Send the previously prepared request, log request and response into the database and return the response
-
      * @param  PayoneMethod $oPayment
      * @return array
      */

Spacing +2 added lines, -2 removed lines

@@ -150,7 +150,7 @@ 
         $this->aParameters = [];
         $this->addParameter('mid', $this->shopHelper->getConfigParam('mid', 'global', 'payone_general', $this->storeCode)); // PayOne Merchant ID
         $this->addParameter('portalid', $this->shopHelper->getConfigParam('portalid', 'global', 'payone_general', $this->storeCode)); // PayOne Portal ID
-        $this->addParameter('key', hash("md5",$this->shopHelper->getConfigParam('key', 'global', 'payone_general', $this->storeCode))); // PayOne Portal Key
+        $this->addParameter('key', hash("md5", $this->shopHelper->getConfigParam('key', 'global', 'payone_general', $this->storeCode))); // PayOne Portal Key
         $this->addParameter('encoding', $this->environmentHelper->getEncoding()); // Encoding
         $this->addParameter('integrator_name', 'Magento2'); // Shop-system
         $this->addParameter('integrator_version', $this->shopHelper->getMagentoVersion()); // Shop version
@@ -258,7 +258,7 @@ 
             $sCustomConfig = $oPayment->getCustomConfigParam($sConfigName); // get custom config param
             if (!empty($sCustomConfig)) { // only add if the param is configured
                 if ($sConfigName == 'key') {
-                    $this->addParameter($sParamName, hash("md5",$sCustomConfig)); // key isn't hashed in db
+                    $this->addParameter($sParamName, hash("md5", $sCustomConfig)); // key isn't hashed in db
                 } else {
                     $this->addParameter($sParamName, $sCustomConfig); // add custom param to request
                 }

Model/Api/Request/Authorization.php

Indentation +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
      *
      * @var \Payone\Core\Helper\Toolkit
      */
-     protected $toolkitHelper;
+        protected $toolkitHelper;
 
     /**
      * Constructor

Model/Plugins/CreditmemoService.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     ) {
         try {
             $return = $proceed($creditmemo, $offlineRequested);
-        } catch(\Exception $ex) {
+        } catch (\Exception $ex) {
             $aRequest = $this->checkoutSession->getPayoneDebitRequest();
             if (is_array($aRequest) && !empty($aRequest)) {
                 $aResponse = $this->checkoutSession->getPayoneDebitResponse();

Model/TransactionStatus/Forwarding.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
         try {
             $this->curl->post($sUrl, $aPostArray);
             $this->log($sUrl.' Response: '.$this->curl->getBody(), $aPostArray);
-        } catch(\Exception $exc) {
+        } catch (\Exception $exc) {
             $this->log($sUrl.' Exception: '.$exc->getMessage(), $aPostArray);
         }
     }

Indentation +2 added lines, -2 removed lines

@@ -123,8 +123,8 @@
      */
     public function forwardAsyncRequest($aPostArray, $sUrl)
     {
-	// Increased timeout to 5500ms
-	// See payone-gmbh/magento-2 issue #316
+    // Increased timeout to 5500ms
+    // See payone-gmbh/magento-2 issue #316
         $this->curl->setOption(CURLOPT_TIMEOUT_MS, 5500);
         $this->curl->setOption(CURLOPT_SSL_VERIFYPEER, false);
         $this->curl->setOption(CURLOPT_SSL_VERIFYHOST, false);

Controller/ExternalAction.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         parent::__construct($context);
 
         // Fix for Magento 2.3 CsrfValidator and backwards-compatibility to prior Magento 2 versions
-        if(interface_exists("\Magento\Framework\App\CsrfAwareActionInterface")) {
+        if (interface_exists("\Magento\Framework\App\CsrfAwareActionInterface")) {
             $request = $this->getRequest();
             if ($request instanceof Http && $request->isPost()) {
                 $request->setParam('ajax', true);

Model/Methods/Paydirekt.php

Spacing +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
             $aParams['add_paydata[terminal_address_country]'] = $this->shopHelper->getConfigParam('country_id', 'store_information', 'general'); // CHECKEN!
             $aParams['add_paydata[terminal_address_name]'] = $this->shopHelper->getConfigParam('name', 'store_information', 'general');
             $aParams['add_paydata[terminal_address_streetname]'] = $this->shopHelper->getConfigParam('street_line1', 'store_information', 'general');
-            $aParams['add_paydata[terminal_address_streetnumber]'] = '';// IS THIS NECESSARY?
+            $aParams['add_paydata[terminal_address_streetnumber]'] = ''; // IS THIS NECESSARY?
             $aParams['add_paydata[terminal_address_zip]'] = $this->shopHelper->getConfigParam('postcode', 'store_information', 'general');
             $aParams['add_paydata[terminal_id]'] = $this->shopHelper->getConfigParam('name', 'store_information', 'general');
 

Helper/HostedIframe.php

Spacing +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
 
         if ($autoCcDetection) {
             // Get a flat CC type array like (e.g. ["V", "M", "J", "U", "P"]).
-            $availableCcTypes = array_map(function ($type) { return $type['id']; }, $this->paymentHelper->getAvailableCreditcardTypes());
+            $availableCcTypes = array_map(function($type) { return $type['id']; }, $this->paymentHelper->getAvailableCreditcardTypes());
 
             // Return the auto cardtype detection config with enabled CC types.
             return [

Helper/Database.php

Spacing +1 added lines, -1 removed lines

@@ -278,7 +278,7 @@
     public function getOldAddressStatus(AddressInterface $oAddress, $blIsCreditrating = true)
     {
         $sStatus = $this->getStatusFromPreviousQuoteAddress($oAddress, $blIsCreditrating);
-        if(empty($sStatus) && $blIsCreditrating === true && $this->getConfigParam('integration_event', 'creditrating', 'payone_protect') == 'after_payment') {
+        if (empty($sStatus) && $blIsCreditrating === true && $this->getConfigParam('integration_event', 'creditrating', 'payone_protect') == 'after_payment') {
             $sStatus = $this->getScoreFromCheckedAddresses($oAddress);
         }
         return $sStatus;