HostedIframeTest::testGetHostedFieldConfig() - Code Metrics - Inspection of "MAG2-42 - Added compatibility to Magento 2.2" - PAYONE-GmbH/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Florian

created 2017-10-20 06:35 UTC

HostedIframeTest::testGetHostedFieldConfig() B

↳ Parent: HostedIframeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	95
Code Lines	78

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	95
rs	8.4117
cc	1
eloc	78
nc	1
nop	0

How to fix Long Method

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <[email protected]>
 * @copyright 2003 - 2017 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Test\Unit\Helper;

use Payone\Core\Helper\HostedIframe;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
use Magento\Store\Model\StoreManagerInterface;
use Magento\Store\Api\Data\StoreInterface;
use Magento\Framework\App\Helper\Context;
use Magento\Store\Model\ScopeInterface;
use Magento\Framework\App\Config\ScopeConfigInterface;
use Payone\Core\Helper\Payment;
use Payone\Core\Helper\Shop;
use Payone\Core\Helper\Toolkit;
use Payone\Core\Model\Test\BaseTestCase;
use Payone\Core\Model\Test\PayoneObjectManager;

class HostedIframeTest extends BaseTestCase
{
    /**
     * @var ObjectManager|PayoneObjectManager
     */
    private $objectManager;

    /**
     * @var HostedIframe
     */
    private $hostedIframe;

    /**
     * @var ScopeConfigInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $scopeConfig;

    /**
     * @var Toolkit
     */
    private $toolkitHelper;

    protected function setUp()
    {
        $this->objectManager = $this->getObjectManager();

        $this->scopeConfig = $this->getMockBuilder(ScopeConfigInterface::class)->disableOriginalConstructor()->getMock();
        $context = $this->objectManager->getObject(Context::class, ['scopeConfig' => $this->scopeConfig]);

        $store = $this->getMockBuilder(StoreInterface::class)->disableOriginalConstructor()->getMock();
        $store->method('getCode')->willReturn(null);

        $storeManager = $this->getMockBuilder(StoreManagerInterface::class)->disableOriginalConstructor()->getMock();
        $storeManager->method('getStore')->willReturn($store);

        $paymentHelper = $this->getMockBuilder(Payment::class)->disableOriginalConstructor()->getMock();
        $paymentHelper->method('isCheckCvcActive')->willReturn(true);

        $this->toolkitHelper = $this->objectManager->getObject(Toolkit::class, [
            'shopHelper' => $this->objectManager->getObject(Shop::class)
        ]);

        $this->hostedIframe = $this->objectManager->getObject(HostedIframe::class, [
            'context' => $context,
            'storeManager' => $storeManager,
            'paymentHelper' => $paymentHelper,
            'toolkitHelper' => $this->toolkitHelper
        ]);
    }

    public function testGetHostedFieldConfigEmpty()
    {
        $this->scopeConfig->expects($this->any())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getValue')
            ->willReturnMap(
                [
                    ['payone_general/creditcard/cc_template', ScopeInterface::SCOPE_STORE, null, $this->toolkitHelper->serialize('string')]
                ]
            );
        $result = $this->hostedIframe->getHostedFieldConfig();
        $expected = [];
        $this->assertEquals($expected, $result);
    }

    public function testGetHostedFieldConfig()
    {
        $aHostedConfig = [
            "Number_type" => "tel",
            "Number_count" => "30",
            "Number_max" => "16",
            "Number_iframe" => "standard",
            "Number_style" => "custom",
            "Number_css" => "",
            "CVC_type" => "tel",
            "CVC_count" => "30",
            "CVC_max" => "4",
            "CVC_iframe" => "standard",
            "CVC_style" => "custom",
            "CVC_css" => "",
            "Month_type" => "select",
            "Month_count" => "3",
            "Month_max" => "2",
            "Month_iframe" => "custom",
            "Month_width" => "120px",
            "Month_height" => "20px",
            "Month_style" => "standard",
            "Year_type" => "select",
            "Year_count" => "5",
            "Year_max" => "4",
            "Year_iframe" => "custom",
            "Year_width" => "120px",
            "Year_height" => "20px",
            "Year_style" => "standard",
            "Standard_input" => "",
            "Standard_selection" => "width:100px;",
            "Iframe_width" => "365px",
            "Iframe_height" => "30px",
            "Errors_active" => "true",
            "Errors_lang" => "de"
        ];

        $this->scopeConfig->expects($this->any())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getValue')
            ->willReturnMap(
                [
                    ['payone_general/creditcard/cc_template', ScopeInterface::SCOPE_STORE, null, $this->toolkitHelper->serialize($aHostedConfig)]
                ]
            );
        $result = $this->hostedIframe->getHostedFieldConfig();
        $expected = [
            'fields' => [
                'cardpan' => [
                    'selector' => 'cardpan',
                    'type' => 'tel',
                    'size' => '30',
                    'maxlength' => '16',
                    'style' => ''
                ],
                'cardcvc2' => [
                    'selector' => 'cardcvc2',
                    'type' => 'tel',
                    'size' => '30',
                    'maxlength' => '4',
                    'style' => ''
                ],
                'cardexpiremonth' => [
                    'selector' => 'cardexpiremonth',
                    'type' => 'select',
                    'size' => '3',
                    'maxlength' => '2',
                    'iframe' => [
                        'width' => '120px',
                        'height' => '20px'
                    ]
                ],
                'cardexpireyear' => [
                    'selector' => 'cardexpireyear',
                    'type' => 'select',
                    'size' => '5',
                    'maxlength' => '4',
                    'iframe' => [
                        'width' => '120px',
                        'height' => '20px'
                    ]
                ]
            ],
            'defaultStyle' => [
                'input' => '',
                'select' => 'width:100px;',
                'iframe' => [
                    'width' => '365px',
                    'height' => '30px'
                ]
            ],
            'error' => 'errorOutput',
            'language' => 'de'
        ];
        $this->assertEquals($expected, $result);
    }
}


Pull Request — master (#114)

HostedIframeTest::testGetHostedFieldConfig() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5			* it under the terms of the GNU Lesser General Public License as published by
6			* the Free Software Foundation, either version 3 of the License, or
7			* (at your option) any later version.
8			*
9			* PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			* GNU Lesser General Public License for more details.
13			*
14			* You should have received a copy of the GNU Lesser General Public License
15			* along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16			*
17			* PHP version 5
18			*
19			* @category Payone
20			* @package Payone_Magento2_Plugin
21			* @author FATCHIP GmbH <[email protected]>
22			* @copyright 2003 - 2017 Payone GmbH
23			* @license <http://www.gnu.org/licenses/> GNU Lesser General Public License
24			* @link http://www.payone.de
25			*/
26
27			namespace Payone\Core\Test\Unit\Helper;
28
29			use Payone\Core\Helper\HostedIframe;
30			use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
31			use Magento\Store\Model\StoreManagerInterface;
32			use Magento\Store\Api\Data\StoreInterface;
33			use Magento\Framework\App\Helper\Context;
34			use Magento\Store\Model\ScopeInterface;
35			use Magento\Framework\App\Config\ScopeConfigInterface;
36			use Payone\Core\Helper\Payment;
37			use Payone\Core\Helper\Shop;
38			use Payone\Core\Helper\Toolkit;
39			use Payone\Core\Model\Test\BaseTestCase;
40			use Payone\Core\Model\Test\PayoneObjectManager;
41
42			class HostedIframeTest extends BaseTestCase
43			{
44			/**
45			* @var ObjectManager\|PayoneObjectManager
46			*/
47			private $objectManager;
48
49			/**
50			* @var HostedIframe
51			*/
52			private $hostedIframe;
53
54			/**
55			* @var ScopeConfigInterface\|\PHPUnit_Framework_MockObject_MockObject
56			*/
57			private $scopeConfig;
58
59			/**
60			* @var Toolkit
61			*/
62			private $toolkitHelper;
63
64			protected function setUp()
65			{
66			$this->objectManager = $this->getObjectManager();
67
68			$this->scopeConfig = $this->getMockBuilder(ScopeConfigInterface::class)->disableOriginalConstructor()->getMock();
69			$context = $this->objectManager->getObject(Context::class, ['scopeConfig' => $this->scopeConfig]);
70
71			$store = $this->getMockBuilder(StoreInterface::class)->disableOriginalConstructor()->getMock();
72			$store->method('getCode')->willReturn(null);
73
74			$storeManager = $this->getMockBuilder(StoreManagerInterface::class)->disableOriginalConstructor()->getMock();
75			$storeManager->method('getStore')->willReturn($store);
76
77			$paymentHelper = $this->getMockBuilder(Payment::class)->disableOriginalConstructor()->getMock();
78			$paymentHelper->method('isCheckCvcActive')->willReturn(true);
79
80			$this->toolkitHelper = $this->objectManager->getObject(Toolkit::class, [
81			'shopHelper' => $this->objectManager->getObject(Shop::class)
82			]);
83
84			$this->hostedIframe = $this->objectManager->getObject(HostedIframe::class, [
85			'context' => $context,
86			'storeManager' => $storeManager,
87			'paymentHelper' => $paymentHelper,
88			'toolkitHelper' => $this->toolkitHelper
89			]);
90			}
91
92			public function testGetHostedFieldConfigEmpty()
93			{
94			$this->scopeConfig->expects($this->any())
			0 ignored issues – show Bug introduced 2017-05-22 12:39 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Magento\Framework\App\Config\ScopeConfigInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
95			->method('getValue')
96			->willReturnMap(
97			[
98			['payone_general/creditcard/cc_template', ScopeInterface::SCOPE_STORE, null, $this->toolkitHelper->serialize('string')]
99			]
100			);
101			$result = $this->hostedIframe->getHostedFieldConfig();
102			$expected = [];
103			$this->assertEquals($expected, $result);
104			}
105
106			public function testGetHostedFieldConfig()
107			{
108			$aHostedConfig = [
109			"Number_type" => "tel",
110			"Number_count" => "30",
111			"Number_max" => "16",
112			"Number_iframe" => "standard",
113			"Number_style" => "custom",
114			"Number_css" => "",
115			"CVC_type" => "tel",
116			"CVC_count" => "30",
117			"CVC_max" => "4",
118			"CVC_iframe" => "standard",
119			"CVC_style" => "custom",
120			"CVC_css" => "",
121			"Month_type" => "select",
122			"Month_count" => "3",
123			"Month_max" => "2",
124			"Month_iframe" => "custom",
125			"Month_width" => "120px",
126			"Month_height" => "20px",
127			"Month_style" => "standard",
128			"Year_type" => "select",
129			"Year_count" => "5",
130			"Year_max" => "4",
131			"Year_iframe" => "custom",
132			"Year_width" => "120px",
133			"Year_height" => "20px",
134			"Year_style" => "standard",
135			"Standard_input" => "",
136			"Standard_selection" => "width:100px;",
137			"Iframe_width" => "365px",
138			"Iframe_height" => "30px",
139			"Errors_active" => "true",
140			"Errors_lang" => "de"
141			];
142
143			$this->scopeConfig->expects($this->any())
			0 ignored issues – show Bug introduced 2017-05-22 12:39 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Magento\Framework\App\Config\ScopeConfigInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
144			->method('getValue')
145			->willReturnMap(
146			[
147			['payone_general/creditcard/cc_template', ScopeInterface::SCOPE_STORE, null, $this->toolkitHelper->serialize($aHostedConfig)]
148			]
149			);
150			$result = $this->hostedIframe->getHostedFieldConfig();
151			$expected = [
152			'fields' => [
153			'cardpan' => [
154			'selector' => 'cardpan',
155			'type' => 'tel',
156			'size' => '30',
157			'maxlength' => '16',
158			'style' => ''
159			],
160			'cardcvc2' => [
161			'selector' => 'cardcvc2',
162			'type' => 'tel',
163			'size' => '30',
164			'maxlength' => '4',
165			'style' => ''
166			],
167			'cardexpiremonth' => [
168			'selector' => 'cardexpiremonth',
169			'type' => 'select',
170			'size' => '3',
171			'maxlength' => '2',
172			'iframe' => [
173			'width' => '120px',
174			'height' => '20px'
175			]
176			],
177			'cardexpireyear' => [
178			'selector' => 'cardexpireyear',
179			'type' => 'select',
180			'size' => '5',
181			'maxlength' => '4',
182			'iframe' => [
183			'width' => '120px',
184			'height' => '20px'
185			]
186			]
187			],
188			'defaultStyle' => [
189			'input' => '',
190			'select' => 'width:100px;',
191			'iframe' => [
192			'width' => '365px',
193			'height' => '30px'
194			]
195			],
196			'error' => 'errorOutput',
197			'language' => 'de'
198			];
199			$this->assertEquals($expected, $result);
200			}
201			}
202

PAYONE-GmbH / magento-2

Pull Request — master (#114)

HostedIframeTest::testGetHostedFieldConfig() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like