Index::__construct() - Code Metrics - Inspection of "MAG2-362 - Fixed race condition in TransactionStat..." - PAYONE-GmbH/magento-2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#600)

unknown

created 2025-07-29 09:21 UTC

Index::__construct() A

↳ Parent: Index

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	9
c	1
b	0
f	0
nc	1
nop	10
dl	0
loc	21
rs	9.9666

How to fix Many Parameters

<?php

/**
 * PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
 *
 * PHP version 5
 *
 * @category  Payone
 * @package   Payone_Magento2_Plugin
 * @author    FATCHIP GmbH <[email protected]>
 * @copyright 2003 - 2016 Payone GmbH
 * @license   <http://www.gnu.org/licenses/> GNU Lesser General Public License
 * @link      http://www.payone.de
 */

namespace Payone\Core\Controller\Transactionstatus;

use Magento\Sales\Model\Order;
filter:
    dependency_paths: ["lib/*"]

/**
 * TransactionStatus receiver
 */
class Index extends \Payone\Core\Controller\ExternalAction
{
    /**
     * @var array
     */
    protected $aFirstContactWhitelist = [
        'appointed',
        'failed',
    ];

    /**
     * TransactionStatus model
     *
     * @var \Payone\Core\Model\ResourceModel\TransactionStatus
     */
    protected $transactionStatus;

    /**
     * PAYONE toolkit helper
     *
     * @var \Payone\Core\Helper\Toolkit
     */
    protected $toolkitHelper;

    /**
     * PAYONE environment helper
     *
     * @var \Payone\Core\Helper\Environment
     */
    protected $environmentHelper;

    /**
     * PAYONE order helper
     *
     * @var \Payone\Core\Helper\Order
     */
    protected $orderHelper;

    /**
     * TransactionStatus handler
     *
     * @var \Payone\Core\Model\Handler\TransactionStatus
     */
    protected $transactionStatusHandler;

    /**
     * Result factory for file-download
     *
     * @var \Magento\Framework\Controller\Result\RawFactory
filter:
    dependency_paths: ["lib/*"]
     */
    protected $resultRawFactory;

    /**
     * PAYONE substitute order handler
     *
     * @var \Payone\Core\Model\Handler\SubstituteOrder
     */
    protected $substituteOrder;

    /**
     * CacheInterface object
     *
     * @var \Magento\Framework\App\CacheInterface
filter:
    dependency_paths: ["lib/*"]
     */
    protected $cache;

    /**
     * Constructor
     *
     * @param \Magento\Framework\App\Action\Context              $context
     * @param \Magento\Framework\Data\Form\FormKey               $formKey
     * @param \Payone\Core\Model\ResourceModel\TransactionStatus $transactionStatus
     * @param \Payone\Core\Helper\Toolkit                        $toolkitHelper
     * @param \Payone\Core\Helper\Environment                    $environmentHelper
     * @param \Payone\Core\Helper\Order                          $orderHelper
     * @param \Payone\Core\Model\Handler\TransactionStatus       $transactionStatusHandler,
     * @param \Magento\Framework\Controller\Result\RawFactory    $resultRawFactory
     * @param \Payone\Core\Model\Handler\SubstituteOrder         $substituteOrder
     * @param \Magento\Framework\App\CacheInterface              $cache
     */
    public function __construct(
        \Magento\Framework\App\Action\Context $context,
filter:
    dependency_paths: ["lib/*"]
        \Magento\Framework\Data\Form\FormKey $formKey,
filter:
    dependency_paths: ["lib/*"]
        \Payone\Core\Model\ResourceModel\TransactionStatus $transactionStatus,
        \Payone\Core\Helper\Toolkit $toolkitHelper,
        \Payone\Core\Helper\Environment $environmentHelper,
        \Payone\Core\Helper\Order $orderHelper,
        \Payone\Core\Model\Handler\TransactionStatus $transactionStatusHandler,
        \Magento\Framework\Controller\Result\RawFactory $resultRawFactory,
        \Payone\Core\Model\Handler\SubstituteOrder $substituteOrder,
        \Magento\Framework\App\CacheInterface $cache
    ) {
        parent::__construct($context, $formKey);
        $this->transactionStatus = $transactionStatus;
        $this->toolkitHelper = $toolkitHelper;
        $this->environmentHelper = $environmentHelper;
        $this->orderHelper = $orderHelper;
        $this->transactionStatusHandler = $transactionStatusHandler;
        $this->resultRawFactory = $resultRawFactory;
        $this->substituteOrder = $substituteOrder;
        $this->cache = $cache;
    }

    /**
     * Return request parameter value
     *
     * @param  string $sKey
     * @return string
     */
    protected function getParam($sKey)
    {
        return $this->getRequest()->getParam($sKey, '');
    }

    /**
     * Return Post array
     *
     * @return array
     */
    protected function getPostArray()
    {
        return $this->getRequest()->getPostValue();
    }

    /**
     * Write the TransactionStatus to the database
     *
     * @param  Order $oOrder
     * @param  array $aRequest
     * @param  bool  $blWillBeHandled
     * @return void
     */
    protected function logTransactionStatus(Order $oOrder, $aRequest, $blWillBeHandled)
    {
        $this->transactionStatus->addTransactionLogEntry($aRequest, $oOrder, $blWillBeHandled);
    }

    /**
     * Main method for executing all needed actions for the incoming TransactionStatus
     *
     * @return string
     */
    protected function handleTransactionStatus()
    {
        if (!$this->environmentHelper->isRemoteIpValid()) {
            return 'Access denied';
        } elseif (!$this->toolkitHelper->isKeyValid($this->getParam('key'))) {
            return 'Key wrong or missing!';
        }

        $oOrder = $this->orderHelper->getOrderByTxid($this->getParam('txid'));
        if (!$oOrder) {
            return 'Order not found';
        }

        if (in_array($this->getParam('txaction'), $this->aFirstContactWhitelist) === false && empty($this->transactionStatus->getAppointedIdByTxid($this->getParam('txid')))) {
            return 'Appointed status has to be handled first!';
        }

        $lockKey = 'payone_order_status_lock_' . $oOrder->getId();
        if ($this->cache->load($lockKey)) {
            return 'Another status is being handled at the moment.';
        }

        // Lock transaction status handling for this order for 50 seconds to not handle multiple statuses at the same time
        $this->cache->save('1', $lockKey, [], 50);

        try {
            if ($this->getParam('txaction') == 'appointed' && $oOrder->getStatus() == 'canceled') {
                // order was canceled in checkout, probably due to browser-back-button usage -> create a new order for incoming payment
                $oOrder = $this->substituteOrder->createSubstituteOrder($oOrder, false);
            }

            $this->logTransactionStatus($oOrder, $this->getPostArray(), true);

            $this->transactionStatusHandler->handle($oOrder, $this->getPostArray());
        } catch (\Exception $e) {
            $this->cache->remove($lockKey);
            throw $e;
        }

        return 'TSOK';
    }

    /**
     * Executing TransactionStatus handling
     *
     * @return \Magento\Framework\Controller\Result\Raw
filter:
    dependency_paths: ["lib/*"]
     */
    public function execute()
    {
        $sOutput = $this->handleTransactionStatus();

        $oResultRaw = $this->resultRawFactory->create();
        $oResultRaw->setContents($sOutput);
        
        return $oResultRaw;
    }
}


1			<?php
2
3			/**
4			* PAYONE Magento 2 Connector is free software: you can redistribute it and/or modify
5			* it under the terms of the GNU Lesser General Public License as published by
6			* the Free Software Foundation, either version 3 of the License, or
7			* (at your option) any later version.
8			*
9			* PAYONE Magento 2 Connector is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12			* GNU Lesser General Public License for more details.
13			*
14			* You should have received a copy of the GNU Lesser General Public License
15			* along with PAYONE Magento 2 Connector. If not, see <http://www.gnu.org/licenses/>.
16			*
17			* PHP version 5
18			*
19			* @category Payone
20			* @package Payone_Magento2_Plugin
21			* @author FATCHIP GmbH <[email protected]>
22			* @copyright 2003 - 2016 Payone GmbH
23			* @license <http://www.gnu.org/licenses/> GNU Lesser General Public License
24			* @link http://www.payone.de
25			*/
26
27			namespace Payone\Core\Controller\Transactionstatus;
28
29			use Magento\Sales\Model\Order;
			0 ignored issues – show Bug introduced 2018-03-28 06:55 UTC by Report Bug Copy Issue Report The type `Magento\Sales\Model\Order` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
30
31			/**
32			* TransactionStatus receiver
33			*/
34			class Index extends \Payone\Core\Controller\ExternalAction
35			{
36			/**
37			* @var array
38			*/
39			protected $aFirstContactWhitelist = [
40			'appointed',
41			'failed',
42			];
43
44			/**
45			* TransactionStatus model
46			*
47			* @var \Payone\Core\Model\ResourceModel\TransactionStatus
48			*/
49			protected $transactionStatus;
50
51			/**
52			* PAYONE toolkit helper
53			*
54			* @var \Payone\Core\Helper\Toolkit
55			*/
56			protected $toolkitHelper;
57
58			/**
59			* PAYONE environment helper
60			*
61			* @var \Payone\Core\Helper\Environment
62			*/
63			protected $environmentHelper;
64
65			/**
66			* PAYONE order helper
67			*
68			* @var \Payone\Core\Helper\Order
69			*/
70			protected $orderHelper;
71
72			/**
73			* TransactionStatus handler
74			*
75			* @var \Payone\Core\Model\Handler\TransactionStatus
76			*/
77			protected $transactionStatusHandler;
78
79			/**
80			* Result factory for file-download
81			*
82			* @var \Magento\Framework\Controller\Result\RawFactory
			0 ignored issues – show Bug introduced 2018-03-28 06:55 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Controller\Result\RawFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
83			*/
84			protected $resultRawFactory;
85
86			/**
87			* PAYONE substitute order handler
88			*
89			* @var \Payone\Core\Model\Handler\SubstituteOrder
90			*/
91			protected $substituteOrder;
92
93			/**
94			* CacheInterface object
95			*
96			* @var \Magento\Framework\App\CacheInterface
			0 ignored issues – show Bug introduced 2025-07-28 13:20 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\CacheInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
97			*/
98			protected $cache;
99
100			/**
101			* Constructor
102			*
103			* @param \Magento\Framework\App\Action\Context $context
104			* @param \Magento\Framework\Data\Form\FormKey $formKey
105			* @param \Payone\Core\Model\ResourceModel\TransactionStatus $transactionStatus
106			* @param \Payone\Core\Helper\Toolkit $toolkitHelper
107			* @param \Payone\Core\Helper\Environment $environmentHelper
108			* @param \Payone\Core\Helper\Order $orderHelper
109			* @param \Payone\Core\Model\Handler\TransactionStatus $transactionStatusHandler,
110			* @param \Magento\Framework\Controller\Result\RawFactory $resultRawFactory
111			* @param \Payone\Core\Model\Handler\SubstituteOrder $substituteOrder
112			* @param \Magento\Framework\App\CacheInterface $cache
113			*/
114			public function __construct(
115			\Magento\Framework\App\Action\Context $context,
			0 ignored issues – show Bug introduced 2019-07-04 13:50 UTC by Report Bug Copy Issue Report The type `Magento\Framework\App\Action\Context` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
116			\Magento\Framework\Data\Form\FormKey $formKey,
			0 ignored issues – show Bug introduced 2019-07-04 13:50 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Data\Form\FormKey` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
117			\Payone\Core\Model\ResourceModel\TransactionStatus $transactionStatus,
118			\Payone\Core\Helper\Toolkit $toolkitHelper,
119			\Payone\Core\Helper\Environment $environmentHelper,
120			\Payone\Core\Helper\Order $orderHelper,
121			\Payone\Core\Model\Handler\TransactionStatus $transactionStatusHandler,
122			\Magento\Framework\Controller\Result\RawFactory $resultRawFactory,
123			\Payone\Core\Model\Handler\SubstituteOrder $substituteOrder,
124			\Magento\Framework\App\CacheInterface $cache
125			) {
126			parent::__construct($context, $formKey);
127			$this->transactionStatus = $transactionStatus;
128			$this->toolkitHelper = $toolkitHelper;
129			$this->environmentHelper = $environmentHelper;
130			$this->orderHelper = $orderHelper;
131			$this->transactionStatusHandler = $transactionStatusHandler;
132			$this->resultRawFactory = $resultRawFactory;
133			$this->substituteOrder = $substituteOrder;
134			$this->cache = $cache;
135			}
136
137			/**
138			* Return request parameter value
139			*
140			* @param string $sKey
141			* @return string
142			*/
143			protected function getParam($sKey)
144			{
145			return $this->getRequest()->getParam($sKey, '');
146			}
147
148			/**
149			* Return Post array
150			*
151			* @return array
152			*/
153			protected function getPostArray()
154			{
155			return $this->getRequest()->getPostValue();
156			}
157
158			/**
159			* Write the TransactionStatus to the database
160			*
161			* @param Order $oOrder
162			* @param array $aRequest
163			* @param bool $blWillBeHandled
164			* @return void
165			*/
166			protected function logTransactionStatus(Order $oOrder, $aRequest, $blWillBeHandled)
167			{
168			$this->transactionStatus->addTransactionLogEntry($aRequest, $oOrder, $blWillBeHandled);
169			}
170
171			/**
172			* Main method for executing all needed actions for the incoming TransactionStatus
173			*
174			* @return string
175			*/
176			protected function handleTransactionStatus()
177			{
178			if (!$this->environmentHelper->isRemoteIpValid()) {
179			return 'Access denied';
180			} elseif (!$this->toolkitHelper->isKeyValid($this->getParam('key'))) {
181			return 'Key wrong or missing!';
182			}
183
184			$oOrder = $this->orderHelper->getOrderByTxid($this->getParam('txid'));
185			if (!$oOrder) {
186			return 'Order not found';
187			}
188
189			if (in_array($this->getParam('txaction'), $this->aFirstContactWhitelist) === false && empty($this->transactionStatus->getAppointedIdByTxid($this->getParam('txid')))) {
190			return 'Appointed status has to be handled first!';
191			}
192
193			$lockKey = 'payone_order_status_lock_' . $oOrder->getId();
194			if ($this->cache->load($lockKey)) {
195			return 'Another status is being handled at the moment.';
196			}
197
198			// Lock transaction status handling for this order for 50 seconds to not handle multiple statuses at the same time
199			$this->cache->save('1', $lockKey, [], 50);
200
201			try {
202			if ($this->getParam('txaction') == 'appointed' && $oOrder->getStatus() == 'canceled') {
203			// order was canceled in checkout, probably due to browser-back-button usage -> create a new order for incoming payment
204			$oOrder = $this->substituteOrder->createSubstituteOrder($oOrder, false);
205			}
206
207			$this->logTransactionStatus($oOrder, $this->getPostArray(), true);
208
209			$this->transactionStatusHandler->handle($oOrder, $this->getPostArray());
210			} catch (\Exception $e) {
211			$this->cache->remove($lockKey);
212			throw $e;
213			}
214
215			return 'TSOK';
216			}
217
218			/**
219			* Executing TransactionStatus handling
220			*
221			* @return \Magento\Framework\Controller\Result\Raw
			0 ignored issues – show Bug introduced 2019-02-27 13:33 UTC by Report Bug Copy Issue Report The type `Magento\Framework\Controller\Result\Raw` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
222			*/
223			public function execute()
224			{
225			$sOutput = $this->handleTransactionStatus();
226
227			$oResultRaw = $this->resultRawFactory->create();
228			$oResultRaw->setContents($sOutput);
229
230			return $oResultRaw;
231			}
232			}
233

PAYONE-GmbH / magento-2

Pull Request — master (#600)

Index::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like