PAYONE-GmbH /
magento-2
| Conditions | 10 |
| Paths | 36 |
| Total Lines | 38 |
| Code Lines | 27 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 37 | protected function _prepareSpecificInformation($transport = null) |
||
| 38 | { |
||
| 39 | if (null !== $this->_paymentSpecificInformation) { |
||
| 40 | return $this->_paymentSpecificInformation; |
||
| 41 | } |
||
| 42 | $transport = parent::_prepareSpecificInformation($transport); |
||
| 43 | $data = []; |
||
| 44 | |||
| 45 | $sTransId = $this->getInfo()->getLastTransId(); |
||
| 46 | if ($sTransId == '') { |
||
| 47 | $data[(string)__('Payment has not been processed yet.')] = ''; |
||
| 48 | } else { |
||
| 49 | $oOrder = $this->getInfo()->getOrder(); |
||
| 50 | if ($oOrder && $oOrder->getPayoneClearingBankiban()) { |
||
| 51 | $data[(string)__('Please transfer the order amount to this bank account')] = ''; |
||
| 52 | $data[(string)__('Accountholder')] = $oOrder->getPayoneClearingBankaccountholder(); |
||
| 53 | $data[(string)__('IBAN')] = $oOrder->getPayoneClearingBankiban(); |
||
| 54 | $data[(string)__('BIC')] = $oOrder->getPayoneClearingBankbic(); |
||
| 55 | if (!empty($oOrder->getPayoneClearingBankname())) { |
||
| 56 | $data[(string)__('Bank')] = $oOrder->getPayoneClearingBankname(); |
||
| 57 | } |
||
| 58 | if (!empty($oOrder->getPayoneClearingBankcountry())) { |
||
| 59 | $data[(string)__('Bank country')] = $oOrder->getPayoneClearingBankcountry(); |
||
| 60 | } |
||
| 61 | if (!empty($oOrder->getPayoneClearingBankcity())) { |
||
| 62 | $data[(string)__('Bank city')] = $oOrder->getPayoneClearingBankcity(); |
||
| 63 | } |
||
| 64 | if (!empty($oOrder->getPayoneClearingDuedate())) { |
||
| 65 | $data[(string)__('Due date')] = date((string)__('Y-m-d'), strtotime($oOrder->getPayoneClearingDuedate())); |
||
| 66 | } |
||
| 67 | } |
||
| 68 | $sPaymentReference = $oOrder->getPayoneTxid(); |
||
| 69 | if (!empty($oOrder->getPayoneClearingReference())) { |
||
| 70 | $sPaymentReference = $oOrder->getPayoneClearingReference(); |
||
| 71 | } |
||
| 72 | $data[(string)__('Payment reference')] = $sPaymentReference; |
||
| 73 | } |
||
| 74 | return $transport->setData(array_merge($data, $transport->getData())); |
||
| 75 | } |
||
| 77 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths