PAYONE-GmbH / magento-1

lib/Payone/Settings/Service/XmlGenerate.php

Doc Comments +8 added lines, -4 removed lines

@@ -49,7 +49,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string @see SimpleXMLElement::asXml()
      */
     public function generate(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -74,7 +74,7 @@ 
      * @api
      *
      * @param Payone_Settings_Data_ConfigFile_Root $config
-     * @return mixed @see SimpleXMLElement::asXml()
+     * @return string|false @see SimpleXMLElement::asXml()
      */
     public function execute(Payone_Settings_Data_ConfigFile_Root $config)
     {
@@ -124,7 +124,7 @@ 
     /**
      * @param Payone_Settings_Data_ConfigFile_Shop $shopConfig
      * @param DOMElement $configXml
-     * @return string
+     * @return DOMElement
      */
     protected function mapShop(Payone_Settings_Data_ConfigFile_Shop $shopConfig, DOMElement $configXml)
     {
@@ -365,6 +365,10 @@ 
         $this->addGlobal($cleatringTypeNode, $valueClearingType);
     }
 
+    /**
+     * @param DOMElement $parent
+     * @param Payone_Settings_Data_ConfigFile_PaymentMethod_Abstract $type
+     */
     public function addGlobal($parent, $type)
     {
 
@@ -400,7 +404,7 @@ 
     /**
      * @param DOMElement $parent
      * @param $object
-     * @param $property
+     * @param string $property
      * @param bool $withCdata
      * @return DOMElement
      */

Spacing +3 added lines, -3 removed lines

@@ -453,9 +453,9 @@ 
      * @param bool $asCdata
      * @return DOMElement
      */
-    protected function appendElement( $parent, $key, $value = null, $asCdata = false)
+    protected function appendElement($parent, $key, $value = null, $asCdata = false)
     {
-        if($asCdata === true)
+        if ($asCdata === true)
         {
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
@@ -464,7 +464,7 @@ 
         else
         {
             $child = $this->dom->createElement($key);
-            if($value !== null)
+            if ($value !== null)
             {
                 $domValue = $this->dom->createTextNode($value);
                 $child->appendChild($domValue);

Braces +5 added lines, -10 removed lines

@@ -108,12 +108,10 @@ 
                     foreach ($value['attribute'] as $attributKey => $attributData) {
                         $node->addAttribute($attributKey, $attributData);
                     }
-                }
-                else {
+                } else {
                     $this->simpleXmlFromNestedArray($key, $value, $parent);
                 }
-            }
-            else {
+            } else {
                 $parent->addChild($key, $value);
             }
         }
@@ -414,8 +412,7 @@ 
             foreach ($data as $key => $value) {
                 $child = $this->appendElement($parentNode, $key, $value, $withCdata);
             }
-        }
-        else {
+        } else {
             if (isset($data)) {
                 $child = $this->appendElement($parent, $property, $data, $withCdata);
             }
@@ -436,8 +433,7 @@ 
             foreach ($value as $key => $data) {
                 $mapNode->setAttribute($key, $data);
             }
-        }
-        else {
+        } else {
             if (!empty($data)) {
                 $mapNode->setAttribute($name, $value);
             }
@@ -460,8 +456,7 @@ 
             $cdata = $this->dom->createCDATASection($value);
             $child = $this->dom->createElement($key);
             $child->appendChild($cdata);
-        }
-        else
+        } else
         {
             $child = $this->dom->createElement($key);
             if($value !== null)

lib/Payone/TransactionStatus/Factory.php

Doc Comments +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
     }
 
     /**
-     * @param $key
+     * @param string $key
      * @return Payone_TransactionStatus_Service_HandleRequest
      * @throws Exception
      */

lib/Payone/Config/Abstract.php

Braces +5 added lines, -10 removed lines

@@ -77,8 +77,7 @@ 
     {
         if (empty($data)) {
             $this->config = $this->getDefaultConfigData();
-        }
-        else {
+        } else {
             $this->config = $data;
         }
     }
@@ -127,8 +126,7 @@ 
 
             // Start recursion:
             return $this->set($newKey, $value, $tree[$currentKey]);
-        }
-        else {
+        } else {
             // Set value (can overwrite an existing value)
             $tree[$key] = $value;
             // Exit recursion, Success!
@@ -166,15 +164,12 @@ 
                 // Reassemble key, start recursion:
                 $newKey = implode(self::KEY_SEPARATOR, $explodedKey);
                 return $this->get($newKey, $newTree);
-            }
-            else {
+            } else {
                 return NULL; // Exit recursion, unsuccessful
             }
-        }
-        elseif (is_array($tree) and array_key_exists($key, $tree)) {
+        } elseif (is_array($tree) and array_key_exists($key, $tree)) {
             return $tree[$key]; // Exit recursion, Success!
-        }
-        else {
+        } else {
             return NULL; // Exit recursion, unsuccessful
         }
     }

lib/Payone/Config.php

Spacing +6 added lines, -6 removed lines

@@ -91,17 +91,17 @@ 
     public function __construct(array $data = array())
     {
         if (empty($data)) {
-            if($this->getApiConfig() === null)
+            if ($this->getApiConfig() === null)
             {
                 $this->apiConfig = new Payone_Api_Config();
             }
 
-            if($this->getTransactionStatusConfig() === null)
+            if ($this->getTransactionStatusConfig() === null)
             {
                 $this->transactionStatusConfig = new Payone_TransactionStatus_Config();
             }
 
-            if($this->getSessionStatusConfig() === null)
+            if ($this->getSessionStatusConfig() === null)
             {
                 $this->sessionStatusConfig = new Payone_SessionStatus_Config();
             }
@@ -109,11 +109,11 @@ 
             $this->config = $this->getDefaultConfigData();
         }
         else {
-            if(array_key_exists('api', $data))
+            if (array_key_exists('api', $data))
                 $this->setApiConfig($data['api']);
-            if(array_key_exists('transaction_status', $data))
+            if (array_key_exists('transaction_status', $data))
                 $this->setTransactionStatusConfig($data['transaction_status']);
-            if(array_key_exists('session_status', $data))
+            if (array_key_exists('session_status', $data))
                 $this->setSessionStatusConfig($data['session_status']);
             $this->config = $data;
         }

Braces +13 added lines, -14 removed lines

@@ -107,14 +107,16 @@ 
             }
 
             $this->config = $this->getDefaultConfigData();
-        }
-        else {
-            if(array_key_exists('api', $data))
-                $this->setApiConfig($data['api']);
-            if(array_key_exists('transaction_status', $data))
-                $this->setTransactionStatusConfig($data['transaction_status']);
-            if(array_key_exists('session_status', $data))
-                $this->setSessionStatusConfig($data['session_status']);
+        } else {
+            if(array_key_exists('api', $data)) {
+                            $this->setApiConfig($data['api']);
+            }
+            if(array_key_exists('transaction_status', $data)) {
+                            $this->setTransactionStatusConfig($data['transaction_status']);
+            }
+            if(array_key_exists('session_status', $data)) {
+                            $this->setSessionStatusConfig($data['session_status']);
+            }
             $this->config = $data;
         }
     }
@@ -173,8 +175,7 @@ 
             $object = $tree[$currentKey];
             $object->setValue($newKey, $value);
             return TRUE;
-        }
-        else {
+        } else {
             // Set value (can overwrite an existing value)
             $tree[$key] = $value;
             // Exit recursion, Success!
@@ -208,11 +209,9 @@ 
             /** @var $object Payone_Config_Abstract */
             $object = $tree[$currentKey];
             return $object->getValue($newKey);
-        }
-        elseif (is_array($tree) and array_key_exists($key, $tree)) {
+        } elseif (is_array($tree) and array_key_exists($key, $tree)) {
             return $tree[$key]; // Exit recursion, Success!
-        }
-        else {
+        } else {
             return NULL; // Exit recursion, unsuccessful
         }
     }

lib/Payone/Settings/Data/ConfigFile/Abstract.php

Braces +3 added lines, -6 removed lines

@@ -51,21 +51,18 @@
             if ($data instanceof Payone_Settings_Data_ConfigFile_Interface) {
                 /** @var Payone_Api_Request_Parameter_Interface $data */
                 $array[$key] = $data->toArray();
-            }
-            elseif (is_array($data))
+            } elseif (is_array($data))
             {
                 foreach ($data as $innerKey => $innerValue)
                 {
                     if ($innerValue instanceof Payone_Settings_Data_ConfigFile_Interface) {
                         /** @var Payone_Api_Request_Parameter_Interface $innerValue */
                         $array[$key][$innerValue->getKey()] = $innerValue->toArray();
-                    }
-                    else {
+                    } else {
                         $array[$key][$innerKey] = $innerValue;
                     }
                 }
-            }
-            else {
+            } else {
                 $array[$key] = $data;
             }
         }

lib/Payone/Settings/Data/ConfigFile/Shop/ClearingTypes.php

Braces +1 added lines, -2 removed lines

@@ -58,8 +58,7 @@
             if ($value instanceof Payone_Settings_Data_ConfigFile_Interface) {
                 /** @var Payone_Api_Request_Parameter_Interface $value */
                 $array[$value->getKey()] = $value->toArray();
-            }
-            else {
+            } else {
                 $array[$key] = $value;
             }
         }

lib/Payone/Settings/Data/ConfigFile/Shop/Global.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     protected $parameter_invoice = array();
 
     /** @var Payone_Settings_Data_ConfigFile_Global_StatusMapping */
-    protected $status_mapping = null ;
+    protected $status_mapping = null;
 
     /** @var array */
     protected $payment_creditcard = array();

lib/Payone/Settings/Data/ConfigFile/Root.php

Spacing +1 added lines, -1 removed lines

@@ -67,6 +67,6 @@
 
     public function addShop($shop)
     {
-        return $this->shop[]=$shop;
+        return $this->shop[] = $shop;
     }
 }

lib/Payone/Settings/Data/ConfigFile/PaymentMethod/Abstract.php

Spacing +3 added lines, -3 removed lines

@@ -41,11 +41,11 @@ 
     protected $title = '';
 
     protected $mid = null;
-    protected $aid =null;
+    protected $aid = null;
     protected $portalid = null;
     protected $fee_config = array();
     protected $min_order_total = null;
-    protected $max_order_total =null;
+    protected $max_order_total = null;
     /** @var string */
     protected $types = null;
     /** @var string */
@@ -113,7 +113,7 @@ 
 
     public function addFeeConfig($value)
     {
-        return $this->fee_config[]=$value;
+        return $this->fee_config[] = $value;
     }
 
     public function setMaxOrderTotal($max_order_total)