Conditions | 13 |
Paths | 78 |
Total Lines | 41 |
Code Lines | 25 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
75 | protected function validateKeys() |
||
76 | { |
||
77 | $fieldNames = array_map(function ($field) { |
||
78 | return $field->name; |
||
79 | }, $this->descriptor->fields); |
||
80 | if (isset($this->descriptor->primaryKey)) { |
||
81 | $primaryKey = is_array($this->descriptor->primaryKey) ? $this->descriptor->primaryKey : [$this->descriptor->primaryKey]; |
||
82 | foreach ($primaryKey as $primaryKeyField) { |
||
83 | if (!in_array($primaryKeyField, $fieldNames)) { |
||
84 | $this->addError( |
||
85 | SchemaValidationError::SCHEMA_VIOLATION, |
||
86 | "primary key must refer to a field name ({$primaryKeyField})" |
||
87 | ); |
||
88 | } |
||
89 | } |
||
90 | } |
||
91 | if (isset($this->descriptor->foreignKeys)) { |
||
92 | foreach ($this->descriptor->foreignKeys as $foreignKey) { |
||
93 | $fields = is_array($foreignKey->fields) ? $foreignKey->fields : [$foreignKey->fields]; |
||
94 | foreach ($fields as $field) { |
||
95 | if (!in_array($field, $fieldNames)) { |
||
96 | $this->addError( |
||
97 | SchemaValidationError::SCHEMA_VIOLATION, |
||
98 | "foreign key fields must refer to a field name ({$field})" |
||
99 | ); |
||
100 | } |
||
101 | } |
||
102 | if ($foreignKey->reference->resource == '') { |
||
103 | // empty resource = reference to self |
||
104 | foreach ($foreignKey->reference->fields as $field) { |
||
105 | if (!in_array($field, $fieldNames)) { |
||
106 | $this->addError( |
||
107 | SchemaValidationError::SCHEMA_VIOLATION, |
||
108 | "foreign key reference to self must refer to a field name ({$field})" |
||
109 | ); |
||
110 | } |
||
111 | } |
||
112 | } |
||
113 | } |
||
114 | } |
||
115 | } |
||
116 | |||
134 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: