SchemaValidator::__construct() - Code Metrics - Inspection of "#18 added functionality and refactoring of Schema..." - OriHoch/tableschema-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 29cde4...77c4c6 )

by Ori

created 2017-05-04 13:39 UTC

SchemaValidator::__construct() A

↳ Parent: SchemaValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php
namespace frictionlessdata\tableschema;

/**
 * validates a table schema descriptor object
 * returns a list of validation errors
 */
class SchemaValidator
{
    /**
     * @param object $descriptor
     * @return SchemaValidationError[]
     */
    public static function validate($descriptor)
    {
        $validator = new self($descriptor);
        return $validator->getValidationErrors();
    }

    /**
     * @param object $descriptor
     */
    public function __construct($descriptor)
    {
        $this->descriptor = $descriptor;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->errors = [];
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @return SchemaValidationError[]
     */
    public function getValidationErrors()
    {
        $this->errors = [];
        $this->validateSchema();
        return $this->errors;
    }

    /**
     * @param integer $code
     * @param mixed $extraDetails
     */
    protected function addError($code, $extraDetails=null)
    {
        $this->errors[] = new SchemaValidationError($code, $extraDetails);
    }

    protected function validateSchema()
    {
        // Validate
        $validator = new \JsonSchema\Validator();
        $descriptor = json_decode(json_encode($this->descriptor));
        $this->applyForeignKeysResourceHack($descriptor);
        $validator->validate(
            $descriptor,
            (object)['$ref' => 'file://' . realpath(dirname(__FILE__)).'/schemas/table-schema.json']
        );
        if (!$validator->isValid()) {
            foreach ($validator->getErrors() as $error) {
                $this->addError(
                    SchemaValidationError::SCHEMA_VIOLATION,
                    sprintf("[%s] %s", $error['property'], $error['message'])
                );
            }
        }
    }

    protected function applyForeignKeysResourceHack($descriptor)
    {
        if (isset($descriptor->foreignKeys) && is_array($descriptor->foreignKeys)) {
            foreach ($descriptor->foreignKeys as $foreignKey) {
                if (
                    is_object($foreignKey)
                    && isset($foreignKey->reference) && is_object($foreignKey->reference)
                    && isset($foreignKey->reference->resource) && empty($foreignKey->reference->resource)
                ) {
                    $foreignKey->reference->resource = "self";
                }
            }
        }
    }
}


1			<?php
2			namespace frictionlessdata\tableschema;
3
4			/**
5			* validates a table schema descriptor object
6			* returns a list of validation errors
7			*/
8			class SchemaValidator
9			{
10			/**
11			* @param object $descriptor
12			* @return SchemaValidationError[]
13			*/
14			public static function validate($descriptor)
15			{
16			$validator = new self($descriptor);
17			return $validator->getValidationErrors();
18			}
19
20			/**
21			* @param object $descriptor
22			*/
23			public function __construct($descriptor)
24			{
25			$this->descriptor = $descriptor;
			0 ignored issues – show Bug introduced 2017-04-18 05:57 UTC by Report Bug Copy Issue Report The property `descriptor` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			$this->errors = [];
			0 ignored issues – show Bug introduced 2017-04-27 14:43 UTC by Report Bug Copy Issue Report The property `errors` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27			}
28
29			/**
30			* @return SchemaValidationError[]
31			*/
32			public function getValidationErrors()
33			{
34			$this->errors = [];
35			$this->validateSchema();
36			return $this->errors;
37			}
38
39			/**
40			* @param integer $code
41			* @param mixed $extraDetails
42			*/
43			protected function addError($code, $extraDetails=null)
44			{
45			$this->errors[] = new SchemaValidationError($code, $extraDetails);
46			}
47
48			protected function validateSchema()
49			{
50			// Validate
51			$validator = new \JsonSchema\Validator();
52			$descriptor = json_decode(json_encode($this->descriptor));
53			$this->applyForeignKeysResourceHack($descriptor);
54			$validator->validate(
55			$descriptor,
56			(object)['$ref' => 'file://' . realpath(dirname(__FILE__)).'/schemas/table-schema.json']
57			);
58			if (!$validator->isValid()) {
59			foreach ($validator->getErrors() as $error) {
60			$this->addError(
61			SchemaValidationError::SCHEMA_VIOLATION,
62			sprintf("[%s] %s", $error['property'], $error['message'])
63			);
64			}
65			}
66			}
67
68			protected function applyForeignKeysResourceHack($descriptor)
69			{
70			if (isset($descriptor->foreignKeys) && is_array($descriptor->foreignKeys)) {
71			foreach ($descriptor->foreignKeys as $foreignKey) {
72			if (
73			is_object($foreignKey)
74			&& isset($foreignKey->reference) && is_object($foreignKey->reference)
75			&& isset($foreignKey->reference->resource) && empty($foreignKey->reference->resource)
76			) {
77			$foreignKey->reference->resource = "self";
78			}
79			}
80			}
81			}
82			}
83

OriHoch / tableschema-php

Push — master ( 29cde4...77c4c6 )

SchemaValidator::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like