OpenTribes\Core\Silex\Request\IndexRequest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getUsername()	0	5	1
A	getPassword()	0	4	1

<?php

namespace OpenTribes\Core\Silex\Request;


use OpenTribes\Core\Request\LoginRequest;
use Symfony\Component\HttpFoundation\Request;

class IndexRequest implements LoginRequest{
    private $request;

    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }

    public function getUsername()
    {

      return  $this->request->get('username','');
    }

    public function getPassword()
    {
        return $this->request->get('password','');
    }

}