OpenTribes\Core\Silex\Request\CityRequest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	14
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getDirection()	0	4	1

<?php

namespace OpenTribes\Core\Silex\Request;


use OpenTribes\Core\Request\ListDirectionsRequest;
use Symfony\Component\HttpFoundation\Request;

class CityRequest implements ListDirectionsRequest {
    private $request;

    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }

    public function getDirection()
    {
       return $this->request->get('direction');
    }

}