UserProvider::refreshUser() - Code Metrics - Inspection of "[WIP] OCC-71: Implement parallel application" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#795)

by Nick

created 2020-10-10 21:07 UTC

UserProvider::refreshUser() A

↳ Parent: UserProvider

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Oc\Security;

use Oc\Repository\Exception\RecordNotFoundException;
use Oc\User\UserEntity;
use Oc\User\UserRepository;
use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
use Symfony\Component\Security\Core\User\UserInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;

class UserProvider implements UserProviderInterface
{
    /**
     * @var UserRepository
     */
    private $userRepository;

    public function __construct(UserRepository $userRepository)
    {
        $this->userRepository = $userRepository;
    }

    public function loadUserByUsername($username): UserInterface
    {
        try {
            return $this->userRepository->fetchOneByUsername($username);

        } catch (RecordNotFoundException $e) {
            throw new UsernameNotFoundException('User by username "' . $username . '" not found!', 0, $e);
        }
    }

    public function refreshUser(UserInterface $user): UserInterface
    {
        if (!$user instanceof UserEntity) {
            throw new UnsupportedUserException(sprintf('Invalid user class "%s".', get_class($user)));
        }

        return $this->userRepository->fetchOneByUsername($user->getUsername());

    }

    public function supportsClass($class): bool
    {
        return UserEntity::class === $class || is_subclass_of($class, UserEntity::class);

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Oc\Security;
6
7			use Oc\Repository\Exception\RecordNotFoundException;
8			use Oc\User\UserEntity;
9			use Oc\User\UserRepository;
10			use Symfony\Component\Security\Core\Exception\UnsupportedUserException;
11			use Symfony\Component\Security\Core\Exception\UsernameNotFoundException;
12			use Symfony\Component\Security\Core\User\UserInterface;
13			use Symfony\Component\Security\Core\User\UserProviderInterface;
14
15			class UserProvider implements UserProviderInterface
16			{
17			/**
18			* @var UserRepository
19			*/
20			private $userRepository;
21
22			public function __construct(UserRepository $userRepository)
23			{
24			$this->userRepository = $userRepository;
25			}
26
27			public function loadUserByUsername($username): UserInterface
28			{
29			try {
30			return $this->userRepository->fetchOneByUsername($username);
			0 ignored issues – show Bug introduced 2020-10-10 21:11 UTC by Report Bug Copy Issue Report The method `fetchOneByUsername()` does not seem to exist on `object<Oc\User\UserRepository>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
31			} catch (RecordNotFoundException $e) {
32			throw new UsernameNotFoundException('User by username "' . $username . '" not found!', 0, $e);
33			}
34			}
35
36			public function refreshUser(UserInterface $user): UserInterface
37			{
38			if (!$user instanceof UserEntity) {
39			throw new UnsupportedUserException(sprintf('Invalid user class "%s".', get_class($user)));
40			}
41
42			return $this->userRepository->fetchOneByUsername($user->getUsername());
			0 ignored issues – show Bug introduced 2020-10-10 21:11 UTC by Report Bug Copy Issue Report The method `fetchOneByUsername()` does not seem to exist on `object<Oc\User\UserRepository>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
43			}
44
45			public function supportsClass($class): bool
46			{
47			return UserEntity::class === $class \|\| is_subclass_of($class, UserEntity::class);
			0 ignored issues – show Bug introduced 2020-10-10 21:11 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\Oc\User\UserEntity::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
48			}
49			}
50

OpencachingDeutschland / oc-server3

Pull Request — development (#795)

UserProvider::refreshUser() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like