WaypointValidator::validate() - Code Metrics - Inspection of "Refactor field notes" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — development (#682)

by Thomas

created 2017-10-26 21:44 UTC

WaypointValidator::validate() A

↳ Parent: WaypointValidator

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	11
nc	2
nop	2
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0

<?php

namespace Oc\Validator\Constraints;

use Oc\GeoCache\Enum\WaypointType;
use Oc\GeoCache\Exception\UnknownWaypointTypeException;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

class WaypointValidator extends ConstraintValidator
{
    /**
     * Checks if the passed value is valid.
     *
     * @param mixed $waypoint The value that should be validated

     * @param Constraint $constraint The constraint for the validation

     *
     * @return bool
     */
    public function validate($waypoint, Constraint $constraint)
    {
        $valid = true;

        try {
            WaypointType::guess($waypoint);
        } catch (UnknownWaypointTypeException $e) {
            $this->context->buildViolation($constraint->messageInvalid)
                ->setParameter('%waypoint%', $waypoint)
                ->setInvalidValue($waypoint)
                ->addViolation();
            $valid = false;
        }

        return $valid;
    }

    /**
     * Check if the given waypoint is an oc waypoint.
     *
     * @param string $waypoint
     *
     * @return bool True if it is an oc waypoint
     */
    protected function isOCWaypoint($waypoint)
    {
        return stripos($waypoint, 'oc') === 0;
    }

    /**
     * Check if the given waypoint is an gc waypoint.
     *
     * @param string $waypoint
     *
     * @return bool True if it is an gc waypoint
     */
    protected function isGCWaypoint($waypoint)
    {
        return stripos($waypoint, 'gc') === 0;
    }
}


1			<?php
2
3			namespace Oc\Validator\Constraints;
4
5			use Oc\GeoCache\Enum\WaypointType;
6			use Oc\GeoCache\Exception\UnknownWaypointTypeException;
7			use Symfony\Component\Validator\Constraint;
8			use Symfony\Component\Validator\ConstraintValidator;
9
10			class WaypointValidator extends ConstraintValidator
11			{
12			/**
13			* Checks if the passed value is valid.
14			*
15			* @param mixed $waypoint The value that should be validated
			0 ignored issues – show Coding Style introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Expected 3 spaces after parameter name; 1 found Loading history... Coding Style Documentation introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Parameter comment must end with a full stop Loading history...
16			* @param Constraint $constraint The constraint for the validation
			0 ignored issues – show Coding Style Documentation introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Parameter comment must end with a full stop Loading history... introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Constraint => \Symfony\Component\Validator\Constraint Loading history...
17			*
18			* @return bool
19			*/
20			public function validate($waypoint, Constraint $constraint)
21			{
22			$valid = true;
23
24			try {
25			WaypointType::guess($waypoint);
26			} catch (UnknownWaypointTypeException $e) {
27			$this->context->buildViolation($constraint->messageInvalid)
28			->setParameter('%waypoint%', $waypoint)
29			->setInvalidValue($waypoint)
30			->addViolation();
31			$valid = false;
32			}
33
34			return $valid;
35			}
36
37			/**
38			* Check if the given waypoint is an oc waypoint.
39			*
40			* @param string $waypoint
41			*
42			* @return bool True if it is an oc waypoint
43			*/
44			protected function isOCWaypoint($waypoint)
45			{
46			return stripos($waypoint, 'oc') === 0;
47			}
48
49			/**
50			* Check if the given waypoint is an gc waypoint.
51			*
52			* @param string $waypoint
53			*
54			* @return bool True if it is an gc waypoint
55			*/
56			protected function isGCWaypoint($waypoint)
57			{
58			return stripos($waypoint, 'gc') === 0;
59			}
60			}
61

OpencachingDeutschland / oc-server3

Pull Request — development (#682)

WaypointValidator::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like