OpencachingDeutschland / oc-server3

htdocs/lib2/logic/statpic.class.php

Spacing +2 added lines, -2 removed lines

@@ -71,8 +71,8 @@
         global $opt;
 
         // if data changed - delete statpic of user, if exists - will be recreated on next request
-        if (file_exists($opt['rootpath'] . 'images/statpics/statpic' . $this->nUserId . '.jpg')) {
-            unlink($opt['rootpath'] . 'images/statpics/statpic' . $this->nUserId . '.jpg');
+        if (file_exists($opt['rootpath'].'images/statpics/statpic'.$this->nUserId.'.jpg')) {
+            unlink($opt['rootpath'].'images/statpics/statpic'.$this->nUserId.'.jpg');
         }
     }
 }

htdocs/lib2/logic/logpics.class.php

Spacing +5 added lines, -5 removed lines

@@ -17,12 +17,12 @@ 
     const FOR_STARTPAGE_GALLERY = 1;
     const FOR_NEWPICS_GALLERY = 2;
     const FOR_USER_STAT = 3;
-    const FOR_USER_GALLERY = 4;   // params: userid
+    const FOR_USER_GALLERY = 4; // params: userid
     const FOR_MYHOME_GALLERY = 5;
-    const FOR_CACHE_STAT = 6;     // params: cacheid
-    const FOR_CACHE_GALLERY = 7;  // params: cacheid
+    const FOR_CACHE_STAT = 6; // params: cacheid
+    const FOR_CACHE_GALLERY = 7; // params: cacheid
 
-    const MAX_PICTURES_PER_GALLERY_PAGE = 48;   // must be multiple of 6
+    const MAX_PICTURES_PER_GALLERY_PAGE = 48; // must be multiple of 6
 
 
     public static function get($purpose, $userid = 0, $cacheid = 0)
@@ -232,7 +232,7 @@ 
         $pictures = self::get($purpose, $userid, $cacheid);
         $tpl->assign('pictures', array_slice($pictures, $startat, self::MAX_PICTURES_PER_GALLERY_PAGE));
 
-        $pager = new pager($url . "&startat={offset}");
+        $pager = new pager($url."&startat={offset}");
         $pager->make_from_offset($startat, count($pictures), self::MAX_PICTURES_PER_GALLERY_PAGE);
     }
 

htdocs/lib2/logic/user.class.php

Spacing +21 added lines, -21 removed lines

@@ -8,8 +8,8 @@ 
  *   add/remove etc. is executed instantly
  ***************************************************************************/
 
-require_once __DIR__ . '/cracklib.inc.php';
-require_once __DIR__ . '/../translate.class.php';
+require_once __DIR__.'/cracklib.inc.php';
+require_once __DIR__.'/../translate.class.php';
 
 class user
 {
@@ -760,8 +760,8 @@ 
         $mail->to = $this->getEMail();
         $mail->subject = $translate->t('Registration confirmation', '', basename(__FILE__), __LINE__);
         $mail->assign('domain', $opt['page']['domain']);
-        $mail->assign('activation_page', $opt['page']['absolute_url'] . 'activation.php');
-        $mail->assign('short_activation_page', $opt['page']['absolute_url'] . 'a.php');
+        $mail->assign('activation_page', $opt['page']['absolute_url'].'activation.php');
+        $mail->assign('short_activation_page', $opt['page']['absolute_url'].'a.php');
         $mail->assign('username', $this->getUsername());
         $mail->assign('userid', $this->getUserId());
         $mail->assign('last_name', $this->getLastName());
@@ -834,7 +834,7 @@ 
             $mail->returnPath = $fromUser->getEMail();
         }
 
-        $mail->subject = $translate->t('E-Mail from', '', basename(__FILE__), __LINE__, '', 1, $language) . ' ' . $fromUser->getUsername() . ': ' . $sSubject;
+        $mail->subject = $translate->t('E-Mail from', '', basename(__FILE__), __LINE__, '', 1, $language).' '.$fromUser->getUsername().': '.$sSubject;
         $mail->assign('usersubject', $sSubject);
         $mail->assign('text', $sText);
         $mail->assign('username', $this->getUsername());
@@ -906,7 +906,7 @@ 
             $login->userid,
             $this->nUserId,
             0,
-            'User ' . sql_escape($this->getUsername()) . ' disabled',
+            'User '.sql_escape($this->getUsername()).' disabled',
             serialize($backup)
         );
 
@@ -1026,9 +1026,9 @@ 
         if ($num_caches > 0) {
             $cache_descs = array();
             $rs = sql(
-                "SELECT `id`, `language`, `desc`, `hint` " .
-                "FROM `cache_desc`,`caches` " .
-                "WHERE `caches`.`cache_id`=`cache_desc`.`cache_id` " .
+                "SELECT `id`, `language`, `desc`, `hint` ".
+                "FROM `cache_desc`,`caches` ".
+                "WHERE `caches`.`cache_id`=`cache_desc`.`cache_id` ".
                 "AND `caches`.`user_id`='&1'",
                 $this->getUserId()
             );
@@ -1073,10 +1073,10 @@ 
                 }
 
                 sql(
-                    "UPDATE `cache_desc` " .
-                    "SET `desc`='&1',`hint`='&2' " .
+                    "UPDATE `cache_desc` ".
+                    "SET `desc`='&1',`hint`='&2' ".
                     "WHERE `id`='&3'",
-                    "<em>" . $descmsg . "</em>",
+                    "<em>".$descmsg."</em>",
                     '',
                     $desc['id']
                 );
@@ -1175,7 +1175,7 @@ 
         global $opt;
 
         // load bmp-support
-        require_once $opt['rootpath'] . 'lib2/imagebmp.inc.php';
+        require_once $opt['rootpath'].'lib2/imagebmp.inc.php';
 
         // paths cleared by trailing '/'
         if (substr($opt['logic']['pictures']['dir'], - 1) != '/') {
@@ -1221,18 +1221,18 @@ 
          */
         if ($object_type == OBJECT_CACHE) {// get filenames of the pictures of $this' caches
             $rs = sql(
-                "SELECT `pictures`.`url` " .
-                "FROM `pictures`,`caches` " .
-                "WHERE `caches`.`cache_id`=`pictures`.`object_id`" .
+                "SELECT `pictures`.`url` ".
+                "FROM `pictures`,`caches` ".
+                "WHERE `caches`.`cache_id`=`pictures`.`object_id`".
                 " AND `pictures`.`object_type`='&1' AND `caches`.`user_id`='&2'",
                 OBJECT_CACHE,
                 $this->getUserId()
             );
         } elseif ($object_type == OBJECT_CACHELOG) {// get filenames of the pictures of $this' logs
             $rs = sql(
-                "SELECT `pictures`.`url` " .
-                "FROM `pictures`,`cache_logs` " .
-                "WHERE `cache_logs`.`id`=`pictures`.`object_id`" .
+                "SELECT `pictures`.`url` ".
+                "FROM `pictures`,`cache_logs` ".
+                "WHERE `cache_logs`.`id`=`pictures`.`object_id`".
                 " AND `pictures`.`object_type`='&1' AND `cache_logs`.`user_id`='&2'",
                 OBJECT_CACHELOG,
                 $this->getUserId()
@@ -1284,7 +1284,7 @@ 
 
                 // check for replacement-image
                 if ($pdummy && isset($opt['logic']['pictures']['dummy']['replacepic'])
-                    && $opt['logic']['pictures']['dummy']['replacepic'] != $opt['rootpath'] . 'images/'
+                    && $opt['logic']['pictures']['dummy']['replacepic'] != $opt['rootpath'].'images/'
                     && file_exists($opt['logic']['pictures']['dummy']['replacepic'])
                 ) {
 
@@ -1460,7 +1460,7 @@ 
             $login->userid,
             $this->nUserId,
             0,
-            'User ' . sql_escape($this->getUsername()) . ' deleted',
+            'User '.sql_escape($this->getUsername()).' deleted',
             serialize($backup)
         );
 

htdocs/lib2/logic/geodb.class.php

Spacing +7 added lines, -7 removed lines

@@ -32,7 +32,7 @@ 
 
     private static function setCacheLocation($cache_id)
     {
-        echo $cache_id . "\n";
+        echo $cache_id."\n";
         $rs = sqll(
             "SELECT `latitude`, `longitude`, `last_modified`
              FROM `caches`
@@ -95,16 +95,16 @@ 
         $rs = sqll(
             "SELECT
                 `geodb_coordinates`.`loc_id` `loc_id`,
-                (( " . $lon . " - `geodb_coordinates`.`lon` ) * ( " . $lon . " - `geodb_coordinates`.`lon` ) +
-                 ( " . $lat . " - `geodb_coordinates`.`lat` ) * ( " . $lat . " - `geodb_coordinates`.`lat` )) `dist`
+                (( " . $lon." - `geodb_coordinates`.`lon` ) * ( ".$lon." - `geodb_coordinates`.`lon` ) +
+                 ( " . $lat." - `geodb_coordinates`.`lat` ) * ( ".$lat." - `geodb_coordinates`.`lat` )) `dist`
              FROM `geodb_coordinates`
              INNER JOIN `geodb_locations` ON `geodb_coordinates`.`loc_id`=`geodb_locations`.`loc_id`
              WHERE
                 `geodb_locations`.`loc_type`=100700000
-                AND `geodb_coordinates`.`lon` > " . ($lon - 0.15) . "
-                AND `geodb_coordinates`.`lon` < " . ($lon + 0.15) . "
-                AND `geodb_coordinates`.`lat` > " . ($lat - 0.15) . "
-                AND `geodb_coordinates`.`lat` < " . ($lat + 0.15) . "
+                AND `geodb_coordinates`.`lon` > " . ($lon - 0.15)."
+                AND `geodb_coordinates`.`lon` < " . ($lon + 0.15)."
+                AND `geodb_coordinates`.`lat` > " . ($lat - 0.15)."
+                AND `geodb_coordinates`.`lat` < " . ($lat + 0.15)."
              ORDER BY `dist` ASC
              LIMIT 1"
         );

htdocs/lib2/logic/npas.inc.php

Spacing +2 added lines, -2 removed lines

@@ -34,10 +34,10 @@
 
     $npas = get_npas($cache_id);
     if ($npas) {
-        $desc = "<p>" . str_replace('%1', helppagelink('npa'), _('This geocache is probably placed within the following protected areas (%1Info</a>):')) . "</p>\n" .
+        $desc = "<p>".str_replace('%1', helppagelink('npa'), _('This geocache is probably placed within the following protected areas (%1Info</a>):'))."</p>\n".
             "<ul>\n";
         foreach ($npas as $npa) {
-            $desc .= "<li>" . $npa['npaTypeName'] . ": <a href='http://www.google.de/search?q=" . urlencode($npa['npaTypeName'] . ' ' . $npa['npaName']) . "' target='_blank'>" . $npa['npaName'] . "</a></li>\n";
+            $desc .= "<li>".$npa['npaTypeName'].": <a href='http://www.google.de/search?q=".urlencode($npa['npaTypeName'].' '.$npa['npaName'])."' target='_blank'>".$npa['npaName']."</a></li>\n";
         }
         $desc .= "</ul>\n";
     } else {

htdocs/lib2/logic/attribute.class.php

Spacing +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
                     LEFT JOIN `sys_trans_text` AS `tt2`
                         ON `t2`.`id`=`tt2`.`trans_id`
                         AND `tt2`.`lang`='&1'
-                    WHERE `cache_attrib`.`group_id`='&2'" . $sAddWhereSql . "
+                    WHERE `cache_attrib`.`group_id`='&2'" . $sAddWhereSql."
                     AND NOT IFNULL(`cache_attrib`.`hidden`, 0)=1
                     ORDER BY `cache_attrib`.`group_id` ASC",
                     $opt['template']['locale'],
@@ -116,7 +116,7 @@ 
             }
             while ($rAttr = sql_fetch_assoc($rsAttr)) {
                 if ($firstLetterUppercase) {
-                    $rAttr['name'] = mb_strtoupper(mb_substr($rAttr['name'], 0, 1)) . mb_substr($rAttr['name'], 1);
+                    $rAttr['name'] = mb_strtoupper(mb_substr($rAttr['name'], 0, 1)).mb_substr($rAttr['name'], 1);
                 }
                 $attr[] = $rAttr;
                 if ($rAttr['search_default']) {

htdocs/lib2/logic/mailcheck.class.php

Spacing +9 added lines, -9 removed lines

@@ -22,7 +22,7 @@ 
     public $sFrom = 'postmaster@somehost.org';
 
     public $nConnectTimeout = 15; // (sec)
-    public $nReadTimeout = 25;   // (sec)
+    public $nReadTimeout = 25; // (sec)
 
     /* check if the mailserver of $sAddress
      * explicit says that the user does not exist
@@ -50,7 +50,7 @@ 
 
         // sort MX records
         $mxs = [];
-        for ($i = 0; $i < count($mx_records); $i ++) {
+        for ($i = 0; $i < count($mx_records); $i++) {
             $mxs[$i] = [
                 'mx' => $mx_records[$i],
                 'prio' => $mx_weight[$i]
@@ -60,7 +60,7 @@ 
         reset($mxs);
 
         // check address with each MX until one mailserver can be connected
-        for ($i = 0; $i < count($mxs); $i ++) {
+        for ($i = 0; $i < count($mxs); $i++) {
             $retval = $this->pCheckAddress($sAddress, $mxs[$i]['mx']);
             if ($retval != CA_ERROR_CONNECT) {
                 return $retval;
@@ -92,7 +92,7 @@ 
             return CA_ERROR_CONNECT;
         }
 
-        $sResp = $this->send_command($fp, "HELO " . $this->sHostname);
+        $sResp = $this->send_command($fp, "HELO ".$this->sHostname);
         $sCode = $this->extract_return_code($sResp);
         if ($sCode != '220') {
             $this->close($fp);
@@ -100,7 +100,7 @@ 
             return CA_ERROR_UNKOWN;
         }
 
-        $sResp = $this->send_command($fp, "MAIL FROM: <" . $this->sFrom . ">");
+        $sResp = $this->send_command($fp, "MAIL FROM: <".$this->sFrom.">");
         $sCode = $this->extract_return_code($sResp);
         if ($sCode != '250') {
             $this->close($fp);
@@ -108,7 +108,7 @@ 
             return CA_ERROR_UNKOWN;
         }
 
-        $sResp = $this->send_command($fp, "RCPT TO: <" . $sAddress . ">");
+        $sResp = $this->send_command($fp, "RCPT TO: <".$sAddress.">");
         $sCode = $this->extract_return_code($sResp);
         if (strlen($sCode) == 3 && substr($sCode, 0, 1) == '4') {
             $this->close($fp);
@@ -159,7 +159,7 @@ 
 
     public function send_command($fp, $out)
     {
-        fwrite($fp, $out . "\r\n");
+        fwrite($fp, $out."\r\n");
 
         return $this->get_data($fp);
     }
@@ -169,7 +169,7 @@ 
         $s = "";
         stream_set_timeout($fp, $this->nReadTimeout);
 
-        for ($i = 0; $i < 2; $i ++) {
+        for ($i = 0; $i < 2; $i++) {
             $s .= fgets($fp, 1024);
         }
 
@@ -183,5 +183,5 @@ 
         return 0;
     }
 
-    return (($a['prio'] + 0) < ($b['prio'] + 0)) ? - 1 : 1;
+    return (($a['prio'] + 0) < ($b['prio'] + 0)) ? -1 : 1;
 }

htdocs/lib2/logic/cache.class.php

Spacing +11 added lines, -11 removed lines

@@ -8,8 +8,8 @@ 
  *   add/remove etc. is executed instantly
  ***************************************************************************/
 
-require_once __DIR__ . '/logtypes.inc.php';
-require_once __DIR__ . '/../../lib/cache.inc.php';
+require_once __DIR__.'/logtypes.inc.php';
+require_once __DIR__.'/../../lib/cache.inc.php';
 
 class cache
 {
@@ -283,7 +283,7 @@ 
         );
         if ($r = sql_fetch_assoc($rs)) {
             if ($r['listing_outdated'] == 2) {
-                $url = 'viewlogs.php?cacheid=' . $this->getCacheId() . '#log' . $r['id'];
+                $url = 'viewlogs.php?cacheid='.$this->getCacheId().'#log'.$r['id'];
             }
         }
         sql_free_result($rs);
@@ -473,7 +473,7 @@ 
                     `cache_logs`.`text` AS `text`,
                     `cache_logs`.`text_html` AS `texthtml`,
                     `cache_logs`.`picture`,
-                    ' . $delfields . ",
+                    ' . $delfields.",
                     `user`.`username` AS `username`,
                     IF(ISNULL(`cache_rating`.`cache_id`), 0, `cache_logs`.`type` IN (1,7)) AS `recommended`
              FROM $table AS `cache_logs`
@@ -483,7 +483,7 @@ 
                  ON `cache_logs`.`cache_id`=`cache_rating`.`cache_id`
                  AND `cache_logs`.`user_id`=`cache_rating`.`user_id`
                  AND `cache_logs`.`date`=`cache_rating`.`rating_date`
-             " . $addjoin . "
+             ".$addjoin."
              WHERE `cache_logs`.`cache_id`='&1'
              ORDER BY `cache_logs`.`order_date` DESC, `cache_logs`.`date_created` DESC, `id` DESC
              LIMIT &2, &3",
@@ -508,7 +508,7 @@ 
             );
             while ($rPicture = sql_fetch_assoc($rsPictures)) {
                 if (trim($rPicture['title']) == '') {
-                    $rPicture['title'] = $translate->t('Picture', '', '', 0) . ' ' . (count($pictures) + 1);
+                    $rPicture['title'] = $translate->t('Picture', '', '', 0).' '.(count($pictures) + 1);
                 }
                 $pictures[] = $rPicture;
             }
@@ -521,7 +521,7 @@ 
                 if (!$newcoord) {
                     $newcoord = $coords[$coordpos];
                 }
-                ++ $coordpos;
+                ++$coordpos;
             }
             if ($newcoord) {
                 $distance = geomath::calcDistance(
@@ -554,7 +554,7 @@ 
             $original = count($coords) - 1;
             $lastlogdate = $logs[count($logs) - 1]['order_date'];
             while ($original > 0 && $coords[$original - 1]['date'] < $lastlogdate) {
-                -- $original;
+                --$original;
             }
             $coord = new coordinate($coords[$original]['latitude'], $coords[$original]['longitude']);
             $logs[] = [
@@ -676,9 +676,9 @@ 
             $login->userid,
             $this->nCacheId,
             0,
-            'Cache ' . sql_escape($this->nCacheId) . ' has changed the owner from userid ' . sql_escape(
+            'Cache '.sql_escape($this->nCacheId).' has changed the owner from userid '.sql_escape(
                 $this->getUserId()
-            ) . ' to ' . sql_escape($userId) . ' by ' . sql_escape($login->userid)
+            ).' to '.sql_escape($userId).' by '.sql_escape($login->userid)
         );
         // Adoptions now are recorded by trigger in cache_adoptions table.
         // Recording adoptions in 'logentries' may be discarded after ensuring that the
@@ -955,7 +955,7 @@ 
             $logTypes[$i]['selected'] = ($logtype == $defaultLogType) ? true : false;
             $logTypes[$i]['name'] = $logtypeNames[$logtype];
             $logTypes[$i]['id'] = $logtype;
-            $i ++;
+            $i++;
         }
 
         // return

htdocs/lib2/logic/useroptions.class.php

Spacing +2 added lines, -2 removed lines

@@ -8,7 +8,7 @@ 
  *
  ***************************************************************************/
 
-require_once __DIR__ . '/const.inc.php';
+require_once __DIR__.'/const.inc.php';
 
 class useroptions
 {
@@ -150,7 +150,7 @@ 
             $this->nOptions[$pId]['option_value'] = $pValue;
 
             return true;
-        } elseif (preg_match("/" . $this->nOptions[$pId]['check_regex'] . "/", $pValue) || strlen($pValue) == 0) {
+        } elseif (preg_match("/".$this->nOptions[$pId]['check_regex']."/", $pValue) || strlen($pValue) == 0) {
             $this->nOptions[$pId]['option_value'] = $pValue;
 
             return true;