OpencachingDeutschland / oc-server3

htdocs/lib2/logic/cachelist.class.php

Spacing +4 added lines, -4 removed lines

@@ -435,8 +435,8 @@ 
             . ($namelike ? " AND `name` LIKE '%" . sql_escape($namelike) . "%'" : '')
             . ($userlike ? " AND `username` LIKE '%" . sql_escape($userlike) . "%'" : ''),
             0,
-            (int) $startat,
-            (int) $maxitems,
+            (int)$startat,
+            (int)$maxitems,
             true
         );
     }
@@ -526,8 +526,8 @@ 
              ORDER BY `prio`, $nameField
              LIMIT &2,&3",
             $login->userid,
-            (int) $startat,
-            (int) $maxitems
+            (int)$startat,
+            (int)$maxitems
         );
 
         $lists = sql_fetch_assoc_table($rs);

Doc Comments +16 added lines

@@ -18,6 +18,9 @@ 
     public $nCachelistId = 0;
     public $reCachelist;
 
+    /**
+     * @param integer $nNewCacheListId
+     */
     public function __construct($nNewCacheListId = ID_NEW, $nUserId = 0)
     {
         $this->reCachelist = new rowEditor('cache_lists');
@@ -145,6 +148,9 @@ 
         return $this->reCachelist->setValue('description', $desc);
     }
 
+    /**
+     * @param string $pw
+     */
     public function setPassword($pw): void
     {
         $this->reCachelist->setValue('password', $pw);
@@ -225,6 +231,9 @@ 
         return sql_fetch_assoc_table($rs);
     }
 
+    /**
+     * @param string $wp
+     */
     public function addCacheByWP($wp)
     {
         $cache = cache::fromWP($wp);
@@ -273,6 +282,9 @@ 
         return $this->addCache(new cache($cache_id));
     }
 
+    /**
+     * @param cache $cache
+     */
     public function addCache($cache)
     {
         if (!$cache->exist() || !$cache->allowView()) {
@@ -508,6 +520,10 @@ 
         return false;
     }
 
+    /**
+     * @param string $condition
+     * @param integer $maxitems
+     */
     private static function getLists(
         $condition,
         $prio = 0,

htdocs/newcaches.php

Spacing +2 added lines, -2 removed lines

@@ -72,8 +72,8 @@
             ]
         )
         ->orderBy('caches.' . $dateField, $sortOrder)
-        ->setFirstResult((int) $startAt)
-        ->setMaxResults((int) $perpage);
+        ->setFirstResult((int)$startAt)
+        ->setMaxResults((int)$perpage);
 
     if ($country) {
         $newCachesQuery->andWhere('`caches`.`country`= :country');

htdocs/lib/clicompatbase.inc.php

Doc Comments +2 added lines, -2 removed lines

@@ -399,7 +399,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $value
- * @return false|string
+ * @return string
  */
 function sql_escape($value)
 {
@@ -413,7 +413,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $value
- * @return false|mixed|string
+ * @return string
  */
 function sql_escape_backtick($value)
 {

htdocs/lib2/db.inc.php

Doc Comments +7 added lines, -7 removed lines

@@ -84,7 +84,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $sql
- * @return resource
+ * @return mysqli_result
  */
 function sql($sql)
 {
@@ -114,7 +114,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $sql
- * @return resource
+ * @return mysqli_result
  */
 function sql_slave($sql)
 {
@@ -144,7 +144,7 @@ 
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param $dblink
  * @param $sql
- * @return resource
+ * @return mysqli_result
  */
 function sql_internal($dblink, $sql)
 {
@@ -342,7 +342,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param string $sql
- * @return resource
+ * @return mysqli_result
  */
 function sqlf($sql)
 {
@@ -360,7 +360,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param string $sql
- * @return resource
+ * @return mysqli_result
  */
 function sqlf_slave($sql)
 {
@@ -378,7 +378,7 @@ 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
  * @param string $sql
- * @return resource
+ * @return mysqli_result
  */
 function sqll($sql)
 {
@@ -1228,7 +1228,7 @@ 
 
 /**
  * @deprecated use DBAL Conenction instead. See adminreports.php for an example implementation
- * @param $f
+ * @param resource $f
  * @param resource $rs
  * @param $table
  * @param bool $truncate

local/stat/coordstat.php

Spacing +3 added lines, -3 removed lines

@@ -24,7 +24,7 @@ 
     $year = substr($cache['date_created'], 0, 4);
     if ($year >= 2005 && $year <= date('Y') && ($lat != 0 || $long != 0)) {
         $years[$year] = true;
-        $liste[$lat][$long]['caches'][$year] ++;
+        $liste[$lat][$long]['caches'][$year]++;
     }
 }
 mysqli_free_result($rs);
@@ -48,7 +48,7 @@ 
         $year = substr($cache['date'], 0, 4);
         if ($year >= 2005 && $year <= date('Y') && ($lat != 0 || $long != 0)) {
             $years[$year] = true;
-            $liste[$lat][$long]['logs'][$year] ++;
+            $liste[$lat][$long]['logs'][$year]++;
         }
     }
     mysqli_free_result($rs);
@@ -65,7 +65,7 @@ 
 while ($cache = sql_fetch_assoc($rs)) {
     $lat = floor($cache['latitude'] / $grid);
     $long = floor($cache['longitude'] / $grid);
-    $liste[$lat][$long]['caches']['all'] ++;
+    $liste[$lat][$long]['caches']['all']++;
     $liste[$lat][$long]['logs']['all'] += $cache['logs'];
 }
 mysqli_free_result($rs);

htdocs/lang/de/ocstyle/varset.inc.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
 // REQUEST-Variablen durchlaufen und an target anhaengen
 $allowed = ['cacheid', 'userid', 'logid', 'desclang', 'descid'];
 
-foreach($_REQUEST as $varname => $varvalue) {
+foreach ($_REQUEST as $varname => $varvalue) {
     if (in_array($varname, $allowed)) {
         $target .= $varname . '=' . $varvalue . '&';
     }

htdocs/lang/de/ocstyle/main.tpl.php

Spacing +3 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
 <?php
 foreach ($opt['template']['locales'] as $k => $lang) {
     if ($lang['status'] == OC_LOCALE_ACTIVE) {
-        echo '<a style="text-decoration: none;" href="'.$langUrl . $k . '"><img src="' . $lang['flag'] .
+        echo '<a style="text-decoration: none;" href="' . $langUrl . $k . '"><img src="' . $lang['flag'] .
             '" alt="' . $lang['name'] . '" title="' . $lang['name'] . '" width="24px" height="18px" /></a> ';
     }
 }
@@ -185,7 +185,7 @@ 
                                         }
                                         $nLastGroup = $tpl_usercountries[$i]['group'];
 
-                                        echo '<option value="' . htmlspecialchars($tpl_usercountries[$i]['country'], ENT_COMPAT, 'UTF-8') . '"' . (($sUserCountry==$tpl_usercountries[$i]['country']) ? ' selected="selected"' : '') . '>' . htmlspecialchars($tpl_usercountries[$i]['name'], ENT_COMPAT, 'UTF-8') . '</option>';
+                                        echo '<option value="' . htmlspecialchars($tpl_usercountries[$i]['country'], ENT_COMPAT, 'UTF-8') . '"' . (($sUserCountry == $tpl_usercountries[$i]['country']) ? ' selected="selected"' : '') . '>' . htmlspecialchars($tpl_usercountries[$i]['name'], ENT_COMPAT, 'UTF-8') . '</option>';
                                     }
 ?>
                                 </select>
@@ -390,7 +390,7 @@ 
             </div> <!-- page-container-1 -->
 
         </div> <!-- overall -->
-        <?php if($opt['tracking']['googleAnalytics']) { ?>
+        <?php if ($opt['tracking']['googleAnalytics']) { ?>
             <script type="text/javascript">
                 // Set to the same value as the web property used on the site
                 var gaProperty = '<?= $opt['tracking']['googleAnalytics']; ?>';

htdocs/lib2/logic/cachelog.class.php

Spacing +3 added lines, -3 removed lines

@@ -357,7 +357,7 @@ 
         //     return array();
         // Logic Error - log types are still valid when no NEW logs are allowed for the cache.
         // (Would e.g. block admin logs and log-type restoring for locked caches.)
-        return get_cache_log_types($this->getCacheId(), $this->getType());  // depends on userid
+        return get_cache_log_types($this->getCacheId(), $this->getType()); // depends on userid
     }
 
     public static function isDuplicate($cacheId, $userId, $logType, $logDate, $logText)
@@ -443,8 +443,8 @@ 
             if ($dateOk && $submit) {
                 $dateOk = (
                     mktime(
-                        (int) $hour,
-                        (int) $minute,
+                        (int)$hour,
+                        (int)$minute,
                         0,
                         $month,
                         $day,

htdocs/lib2/logic/getNew.class.php

Doc Comments +5 added lines, -5 removed lines

@@ -17,7 +17,7 @@ 
     }
 
     /**
-     * @param $userCountry
+     * @param string $userCountry
      */
     public function set_userCountry($userCountry): void
     {
@@ -41,7 +41,7 @@ 
      *
      * @param string $type type of the "new"-information, i.e. cache, event, rating, etc
      * @param array $args numeric array containing the parameter for "sql_slave"
-     * @return object mysql result used by smarty assign_rs
+     * @return mysqli_result|null mysql result used by smarty assign_rs
      */
     public function rsForSmarty($type, $args = null)
     {
@@ -89,7 +89,7 @@ 
      * cacheRs executes the database statements for type "cache"
      *
      * @param array $args numeric array containing the parameter for "sql_slave"
-     * @return object mysql result used by smarty assign_rs
+     * @return mysqli_result mysql result used by smarty assign_rs
      */
     private function cacheRs($args = null)
     {
@@ -143,7 +143,7 @@ 
      * eventRs executes the database statements for type "event"
      *
      * @param array $args numeric array containing the parameter for "sql_slave"
-     * @return object mysql result used by smarty assign_rs
+     * @return mysqli_result mysql result used by smarty assign_rs
      */
     private function eventRs($args = null)
     {
@@ -215,7 +215,7 @@ 
      * ratingRs executes the database statements for type "rating"
      *
      * @param array $args numeric array containing the parameter for "sql_slave"
-     * @return object mysql result used by smarty assign_rs
+     * @return mysqli_result mysql result used by smarty assign_rs
      */
     private function ratingRs($args = null)
     {