Issues in common.inc.php - All Issues - Inspection of "Merge pull request #705 from nlubisch/feature/move..." - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — development ( f93eb8...ffa1a0 )

by Thomas
created 2017-11-26 19:47 UTC
htdocs/lib/common.inc.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
<?php
/****************************************************************************
 * For license information see LICENSE.md
 *
 * sets up all necessary variables and handle template and database-things
 * also useful functions
 *
 * parameter: lang       get/post/cookie   used language
 * style      get/post/cookie   used style
 ****************************************************************************/

use Oc\Util\CBench;

if (isset($opt['rootpath'])) {
    $rootpath = $opt['rootpath'];
} else {
    if (isset($rootpath)) {
        $opt['rootpath'] = $rootpath;
    } else {
        $rootpath = './';
        $opt['rootpath'] = $rootpath;
    }
}

// we are in HTML-mode ... maybe plain (for CLI scripts)
global $interface_output, $bScriptExecution;
$interface_output = 'html';

// set default CSS
tpl_set_var('css', 'main.css');

//detecting errors
$error = false;

if (!isset($rootpath)) {
    $rootpath = './';
}
require_once __DIR__ . '/clicompatbase.inc.php';

// enforce http or https?
if (isset($opt['gui']) && $opt['gui'] == GUI_HTML) {
    if ($opt['page']['https']['mode'] == HTTPS_DISABLED) {
        if ($opt['page']['https']['active']) {
            header('Location: http://' . $_SERVER['SERVER_NAME'] . $_SERVER['REQUEST_URI']);
        }
        $opt['page']['force_https_login'] = false;
    } else {
        if ($opt['page']['https']['mode'] == HTTPS_ENFORCED) {
            if (!$opt['page']['https']['active']) {
                header('Location: https://' . $_SERVER['SERVER_NAME'] . $_SERVER['REQUEST_URI']);
            }
            $opt['page']['force_https_login'] = true;
        }
    }
}

// load domain specific settings
load_domain_settings();

// load HTML specific includes
$cookie = new \Oc\Session\SessionDataCookie();

//by default, use start template
if (!isset($tplname)) {
    $tplname = 'start';
}

//restore cookievars[]
load_cookie_settings();

//language changed?
if (isset($_POST['lang'])) {
    $lang = $_POST['lang'];
}
if (isset($_GET['lang'])) {
    $lang = $_GET['lang'];
}

//are there files for this language?
if (!file_exists(__DIR__ . '/../lang/' . $lang . '/')) {
    die('Critical Error: The specified language does not exist!');
}

//style changed?
if (isset($_POST['style'])) {
    $style = $_POST['style'];
}
if (isset($_GET['style'])) {
    $style = $_GET['style'];
}

//does the style exist?
if (!file_exists(__DIR__ . '/../lang/' . $lang . '/' . $style . '/')) {
    $style = 'ocstyle';
}

if (!file_exists(__DIR__ . '/../lang/' . $lang . '/' . $style . '/')) {
    die('Critical Error: The specified style does not exist!');
}

//set up the language path
if (!isset($langpath)) {
    $langpath = __DIR__ . '/../lang/' . $lang;
}

//set up the style path
if (!isset($stylepath)) {
    $stylepath = $langpath . '/' . $style;
}

//load gettext translation
load_gettext();

//open a databse connection
db_connect();

require_once __DIR__ . '/auth.inc.php';
require_once __DIR__ . '/../lib2/translate.class.php';

//load language specific strings
require_once $langpath . '/expressions.inc.php';

//set up the defaults for the main template
require_once $stylepath . '/varset.inc.php';

if ($dblink === false) {
    //error while connecting to the database
    $error = true;

    //set up error report
    tpl_set_var('error_msg', htmlspecialchars(mysql_error(), ENT_COMPAT, 'UTF-8'));
    tpl_set_var('tplname', $tplname);
    $tplname = 'error';
} else {
    //user authenification from cookie
    auth_user();
    if ($usr == false) {
        //no user logged in
        if (isset($_POST['target'])) {
            $target = $_POST['target'];
        } elseif (isset($_REQUEST['target'])) {
            $target = $_REQUEST['target'];
        } elseif (isset($_GET['target'])) {
            $target = $_GET['target'];
        } else {
            $target = '{target}';
        }
        $sLoggedOut = mb_ereg_replace('{target}', $target, $sLoggedOut);
        tpl_set_var('loginbox', $sLoggedOut);
        tpl_set_var(
            'login_url',
            ($opt['page']['https']['force_login'] ? $opt['page']['absolute_https_url'] : '') . 'login.php'
        );
    } else {
        //user logged in
        $sTmpString = mb_ereg_replace('{username}', $usr['username'], $sLoggedIn);
        tpl_set_var('loginbox', $sTmpString);
        unset($sTmpString);
    }
}

// are we Ocprop?
$ocpropping = isset($_SERVER['HTTP_USER_AGENT']) && strpos($_SERVER['HTTP_USER_AGENT'], 'Ocprop/') !== false;

// zeitmessung
$bScriptExecution = new CBench;
$bScriptExecution->start();

function load_domain_settings()
{
    global $opt, $style;

    $domain = $opt['page']['domain'];

    if (isset($opt['domain'][$domain]['style'])) {
        $style = $opt['domain'][$domain]['style'];
    }
    if (isset($opt['domain'][$domain]['cookiedomain'])) {
        $opt['cookie']['domain'] = $opt['domain'][$domain]['cookiedomain'];
    }

    set_common_domain_config($opt);
}

// get the language from a given shortage
// on success return the name, otherwise false
function db_LanguageFromShort($langCode)
{
    global $dblink, $locale;

    //no databse connection?
    if ($dblink === false) {
        return false;
    }

    //select the right record
    $rs = sql(
        "SELECT IFNULL(`sys_trans_text`.`text`, `languages`.`name`) AS `text`
        FROM `languages`
        LEFT JOIN `sys_trans`
          ON `languages`.`trans_id`=`sys_trans`.`id`
        LEFT JOIN `sys_trans_text`
          ON `sys_trans`.`id`=`sys_trans_text`.`trans_id`
          AND `sys_trans_text`.`lang`='&1'
        WHERE `languages`.`short`='&2'",
        $locale,
        $langCode
    );
    if (mysql_num_rows($rs) > 0) {
        $record = sql_fetch_array($rs);

        //return the language
        return $record['text'];
    }
    //language not found
    return false;
}

//get the stored settings and authentification data from the cookie
function load_cookie_settings()
{
    global $cookie, $lang, $style;

    //speach
    if ($cookie->is_set('lang')) {
        $lang = $cookie->get('lang');
    }

    //style
    if ($cookie->is_set('style')) {
        $style = $cookie->get('style');
    }
}

//store the cookie vars
function write_cookie_settings()
{
    global $cookie, $lang, $style;

    //language
    $cookie->set('lang', $lang);

    //style
    $cookie->set('style', $style);

    //send cookie
    $cookie->header();
}

//returns the cookie value, otherwise false
function get_cookie_setting($name)
{
    global $cookie;

    if ($cookie->is_set($name)) {
        return $cookie->get($name);
    }

    return false;
}

//sets the cookie value
function set_cookie_setting($name, $value)
{
    global $cookie;
    $cookie->set($name, $value);
}

//set a template replacement
//set no_eval true to prevent this contents from php-parsing.
//Important when replacing something that the user has posted
//in HTML code and could contain \<\? php-Code \?\>
/**
 * @param string $name
 * @param mixed $value
 * @param mixed $no_eval
 */
function tpl_set_var($name, $value, $no_eval = true)
{
    global $vars, $no_eval_vars;
    $vars[$name] = $value;
    $no_eval_vars[$name] = $no_eval;
}

//get a template replacement, otherwise false
function tpl_get_var($name)
{
    global $vars;

    if (isset($vars[$name])) {
        return $vars[$name];
    }

    return false;
}

//clear all template vars
function tpl_clear_vars()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    unset($GLOBALS['vars']);
    unset($GLOBALS['no_eval_vars']);
}

/**
 * page function replaces {functionsbox} in main template
 *
 * @param $id
 * @param $html_code
 */
function tpl_set_page_function($id, $html_code)
{
    global $page_functions;

    $page_functions[$id] = $html_code;
}

function tpl_unset_page_function($id)
{
    global $page_functions;

    unset($page_functions[$id]);
}

function tpl_clear_page_functions()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    unset($GLOBALS['page_functions']);
}

/**
 * see OcSmarty::acceptsAndPurifiesHtmlInput
 */
function tpl_acceptsAndPurifiesHtmlInput()
{
    header('X-XSS-Protection: 0');
}

/**
 * read the templates and echo it to the user
 *
 * @param bool $dbDisconnect
 */
function tpl_BuildTemplate($dbDisconnect = true)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $sql_debug, $sqldbg_cmdNo;

    if (isset($sql_debug) && $sql_debug) {
        if (!isset($sqldbg_cmdNo) || $sqldbg_cmdNo == 0) {
            echo 'No SQL commands on this page.';
        }
        die();

    }

    //template handling vars
    global $style, $stylepath, $tplname, $vars, $langpath, $locale, $opt, $oc_nodeid, $translate, $usr;
    //language specific expression
    global $error_pagenotexist;
    //only for debbuging
    global $b, $bScriptExecution;
    // country dropdown
    global $tpl_usercountries;

    tpl_set_var('screen_css_time', filemtime(__DIR__ . '/../resource2/' . $style . '/css/style_screen.css'));
    tpl_set_var(
        'screen_msie_css_time',
        filemtime(__DIR__ . '/../resource2/' . $style . '/css/style_screen_msie.css')
    );
    tpl_set_var('print_css_time', filemtime(__DIR__ . '/../resource2/' . $style . '/css/style_print.css'));

    if (isset($bScriptExecution)) {
        $bScriptExecution->stop();
        tpl_set_var('scripttime', sprintf('%1.3f', $bScriptExecution->diff()));
    } else {
        tpl_set_var('scripttime', sprintf('%1.3f', 0));
    }

    tpl_set_var('sponsorbottom', $opt['page']['sponsor']['bottom']);

    if (isset($opt['locale'][$locale]['page']['subtitle1'])) {
        $opt['page']['subtitle1'] = $opt['locale'][$locale]['page']['subtitle1'];
    }
    if (isset($opt['locale'][$locale]['page']['subtitle2'])) {
        $opt['page']['subtitle2'] = $opt['locale'][$locale]['page']['subtitle2'];
    }
    tpl_set_var('opt_page_subtitle1', $opt['page']['subtitle1']);
    tpl_set_var('opt_page_subtitle2', $opt['page']['subtitle2']);
    tpl_set_var('opt_page_title', $opt['page']['title']);

    if ($opt['logic']['license']['disclaimer']) {
        if (isset($opt['locale'][$locale]['page']['license_url'])) {
            $lurl = $opt['locale'][$locale]['page']['license_url'];
        } else {
            $lurl = $opt['locale']['EN']['page']['license_url'];
        }

        if (isset($opt['locale'][$locale]['page']['license'])) {
            $ltext = $opt['locale'][$locale]['page']['license'];
        } else {
            $ltext = $opt['locale']['EN']['page']['license'];
        }

        $ltext = mb_ereg_replace('%1', $lurl, $ltext);
        $ltext = mb_ereg_replace('{site}', $opt['page']['sitename'], $ltext);

        $ld = '<p class="sidebar-maintitle">' . $translate->t('Datalicense', '', '', 0) . '</p>' .
            '<div style="margin:20px 0 16px 0; width:100%; text-align:center;">' . $ltext . '</div>';
        tpl_set_var('license_disclaimer', $ld);
    } else {
        tpl_set_var('license_disclaimer', '');
    }

    $bTemplateBuild = new CBench;
    $bTemplateBuild->start();

    //set {functionsbox}
    global $page_functions, $functionsbox_start_tag, $functionsbox_middle_tag, $functionsbox_end_tag;

    if (isset($page_functions)) {
        $functionsbox = $functionsbox_start_tag;
        foreach ($page_functions as $func) {
            if ($functionsbox != $functionsbox_start_tag) {
                $functionsbox .= $functionsbox_middle_tag;
            }
            $functionsbox .= $func;
        }
        $functionsbox .= $functionsbox_end_tag;

        tpl_set_var('functionsbox', $functionsbox);
    }

    /* prepare user country selection
     */
    $tpl_usercountries = [];
    $rsUserCountries = sql(
        "SELECT `countries_options`.`country`,
                        IF(`countries_options`.`nodeId`='&1', 1, IF(`countries_options`.`nodeId`!=0, 2, 3)) AS `group`,
                        IFNULL(`sys_trans_text`.`text`, `countries`.`name`) AS `name`
                   FROM `countries_options`
             INNER JOIN `countries` ON `countries_options`.`country`=`countries`.`short`
              LEFT JOIN `sys_trans` ON `countries`.`trans_id`=`sys_trans`.`id`
              LEFT JOIN `sys_trans_text` ON `sys_trans`.`id`=`sys_trans_text`.`trans_id` AND `sys_trans_text`.`lang`='&2'
                  WHERE `countries_options`.`display`=1
               ORDER BY `group` ASC,
                        IFNULL(`sys_trans_text`.`text`, `countries`.`name`) ASC",
        $oc_nodeid,
        $locale
    );
    while ($rUserCountries = sql_fetch_assoc($rsUserCountries)) {
        $tpl_usercountries[] = $rUserCountries;
    }
    sql_free_result($rsUserCountries);

    //include language specific expressions, so that they are available in the template code
    include $langpath . '/expressions.inc.php';

    //load main template
    tpl_set_var('backgroundimage', '<div id="bg1">&nbsp;</div><div id="bg2">&nbsp;</div>');
    tpl_set_var('bodystyle', '');

    if (isset($_REQUEST['print']) && $_REQUEST['print'] == 'y') {
        $sCode = read_file($stylepath . '/main_print.tpl.php');
    } else {
        if (isset($_REQUEST['popup']) && $_REQUEST['popup'] == 'y') {
            $sCode = read_file($stylepath . '/popup.tpl.php');
        } else {
            $sCode = read_file($stylepath . '/main.tpl.php');
        }
    }
    $sCode = '?>' . $sCode;

    //does template exist?
    if (!file_exists($stylepath . '/' . $tplname . '.tpl.php')) {
        //set up the error template
        $error = true;
        tpl_set_var('error_msg', htmlspecialchars($error_pagenotexist, ENT_COMPAT, 'UTF-8'));
        tpl_set_var('tplname', $tplname);
        $tplname = 'error';
    }

    //read the template
    $sTemplate = read_file($stylepath . '/' . $tplname . '.tpl.php');
    $sCode = mb_ereg_replace('{template}', $sTemplate, $sCode);

    //process translations
    $sCode = tpl_do_translation($sCode);

    //process the template replacements
    $sCode = tpl_do_replace($sCode);

    // fixing path issue
    $sCode = str_replace('lib2/smarty/ocplugins/', 'src/OcLegacy/SmartyPlugins/', $sCode);

    //store the cookie
    write_cookie_settings();

    //send http-no-caching-header
    http_write_no_cache();

    // write UTF8-Header
    header('Content-type: text/html; charset=utf-8');

    //run the template code
    eval($sCode);


    //disconnect the database
    if ($dbDisconnect) {
        db_disconnect();
    }
}

function http_write_no_cache()
{
    // HTTP/1.1
    header('Cache-Control: no-store, no-cache, must-revalidate');
    header('Cache-Control: post-check=0, pre-check=0', false);
    // HTTP/1.0
    header('Pragma: no-cache');
    // Date in the past
    header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
    // always modified
    header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
}

//redirect to another site to display, i.e. to view a cache after logging
/**
 * @param string $page
 */
function tpl_redirect($page)
{
    global $absolute_server_URI;

    write_cookie_settings();
    http_write_no_cache();

    if (!preg_match('/^https?:/i', $page)) {
        header('Location: ' . $absolute_server_URI . $page);
    } else {
        header('Location: ' . $page);
    }

    exit;

}

//process the template replacements
//no_eval_replace - if true, variables will be replaced that are
//                  marked as "no_eval"
/**
 * @param string $str
 * @return string
 */
function tpl_do_replace($str)
{
    global $vars, $no_eval_vars;

    if (is_array($vars)) {
        foreach ($vars as $varname => $varvalue) {
            if ($no_eval_vars[$varname] == false) {
                $str = mb_ereg_replace('{' . $varname . '}', $varvalue, $str);
            } else {
                $replave_var_name = 'tpl_replace_var_' . $varname;

                global $$replave_var_name;
                $$replave_var_name = $varvalue;

                //replace using php-echo
                $str = mb_ereg_replace(
                    '{' . $varname . '}',
                    '<?php global $' . $replave_var_name . '; echo $tpl_replace_var_' . $varname . '; ?>',
                    $str
                );
            }
        }
    }

    return $str;
}

/**
 * @param string $tplnameError
 * @param string $msg
 */
function tpl_errorMsg($tplnameError, $msg)
{
    global $tplname;

    $tplname = 'error';
    tpl_set_var('error_msg', $msg);
    tpl_set_var('tplname', $tplnameError);

    tpl_BuildTemplate();
    exit;

}


function load_gettext()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $cookie, $opt, $locale;

    $locale = isset($_REQUEST['locale']) ? $_REQUEST['locale'] : $cookie->get('locale');
    if (!isset($opt['locale'][$locale])) {
        $locale = $opt['template']['default']['locale'];
    }
    $opt['template']['locale'] = $locale;

    $cookie->set('locale', $opt['template']['locale'], $opt['template']['default']['locale']);

    bindtextdomain('messages', __DIR__ . '/../var/cache2/translate');
    set_php_locale();
    textdomain('messages');
}

/**
 * @param string $sCode
 * @return string
 */
function tpl_do_translation($sCode)
{
    global $opt, $style, $tplname;

    $sResultCode = '';
    $nCurrentPos = 0;
    while ($nCurrentPos < mb_strlen($sCode)) {
        $nStartOfHTML = mb_strpos($sCode, '?>', $nCurrentPos);
        if ($nStartOfHTML === false) {
            $sResultCode .= mb_substr($sCode, $nCurrentPos, mb_strlen($sCode) - $nCurrentPos);
            $nCurrentPos = mb_strlen($sCode);
        } else {
            $nEndOfHTML = mb_strpos($sCode, '<?', $nStartOfHTML);
            if ($nEndOfHTML === false) {
                $nEndOfHTML = mb_strlen($sCode);
            }

            $sResultCode .= mb_substr($sCode, $nCurrentPos, $nStartOfHTML - $nCurrentPos);
            $sHTMLCode = mb_substr($sCode, $nStartOfHTML, $nEndOfHTML - $nStartOfHTML);
            $sResultCode .= gettext_do_html($sHTMLCode);

            $nCurrentPos = $nEndOfHTML;
        }
    }

    return $sResultCode;
}

/**
 * @param string $sCode
 * @return string
 */
function gettext_do_html($sCode)
{
    $sResultCode = '';
    $nCurrentPos = 0;
    while ($nCurrentPos < mb_strlen($sCode)) {
        $nStartOf = mb_strpos($sCode, '{' . 't}', $nCurrentPos);
        if ($nStartOf === false) {
            $sResultCode .= mb_substr($sCode, $nCurrentPos, mb_strlen($sCode) - $nCurrentPos);
            $nCurrentPos = mb_strlen($sCode);
        } else {
            $nEndOf = mb_strpos($sCode, '{/t}', $nStartOf);
            if ($nEndOf === false) {
                $nEndOf = mb_strlen($sCode);
            } else {
                $nEndOf += 4;
            }

            $sResultCode .= mb_substr($sCode, $nCurrentPos, $nStartOf - $nCurrentPos);
            $sTransString = mb_substr($sCode, $nStartOf + 3, $nEndOf - $nStartOf - 3 - 4);

            $sResultCode .= t($sTransString);

            $nCurrentPos = $nEndOf;
        }
    }

    return $sResultCode;
}

/**
 * @param $str
 * @return string
 */
function t($str)
{
    global $translate;

    $str = $translate->t($str, '', basename(__FILE__), __LINE__);
    $args = func_get_args();
    for ($nIndex = count($args) - 1; $nIndex > 0; $nIndex--) {
        $str = str_replace('%' . $nIndex, $args[$nIndex], $str);
    }

    return $str;
}

/**
 * @param $text
 * @return string
 */
function t_prepare_text($text)
{
    $text = mb_ereg_replace("\t", ' ', $text);
    $text = mb_ereg_replace("\r", ' ', $text);
    $text = mb_ereg_replace("\n", ' ', $text);
    while (mb_strpos($text, '  ') !== false) {
        $text = mb_ereg_replace('  ', ' ', $text);
    }

    return $text;
}

/**
 * @return mixed|null|string
 */
function getUserCountry()
{
    global $opt, $cookie, $usr;

    // language specified in cookie?
    if ($cookie->is_set('usercountry')) {
        $sCountry = $cookie->get('usercountry', null);
        if ($sCountry != null) {
            return $sCountry;
        }
    }

    // user specified a country?
    if (isset($usr) && ($usr !== false)) {
        $sCountry = sqlValue("SELECT `country` FROM `user` WHERE `user_id`='" . ($usr['userid'] + 0) . "'", null);
        if ($sCountry != null) {
            return $sCountry;
        }
    }

    // default country of this language
    //
    // disabled: produces unexpected results on multi-domains without translation,
    // and will confusingly switch country when switching language  -- following 3.9.2015
    //
    // if (isset($opt['template']['locale']) && isset($opt['locale'][$opt['template']['locale']]['country']))
    //    return $opt['locale'][$opt['template']['locale']]['country'];

    // default country of installation (or domain)
    if (isset($opt['template']['default']['country'])) {
        return $opt['template']['default']['country'];
    }

    // country could not be determined by the above checks -> return "GB"
    return 'GB';
}

/**
 * external help embedding
 * pay attention to use only ' quotes in $text (escape other ')
 *
 * see corresponding function in lib2/common.inc.php
 * @param $ocPage
 * @return string
 */
function helppagelink($ocPage)
{
    global $opt, $locale, $translate;

    $help_locale = $locale;
    $rs = sql(
        "SELECT `helppage` FROM `helppages` WHERE `ocpage`='&1' AND `language`='&2'",
        $ocPage,
        $help_locale
    );
    if (mysql_num_rows($rs) == 0) {
        mysql_free_result($rs);
        $rs = sql(
            "SELECT `helppage` FROM `helppages` WHERE `ocpage`='&1' AND `language`='*'",
            $ocPage
        );
    }
    if (mysql_num_rows($rs) == 0) {
        mysql_free_result($rs);
        $rs = sql(
            "SELECT `helppage` FROM `helppages` WHERE `ocpage`='&1' AND `language`='&2'",
            $ocPage,
            $opt['template']['default']['fallback_locale']
        );
        if (mysql_num_rows($rs) > 0) {
            $help_locale = $opt['template']['default']['fallback_locale'];
        }
    }

    if (mysql_num_rows($rs) > 0) {
        $record = sql_fetch_array($rs);
        $helpPage = $record['helppage'];
    } else {
        $helpPage = '';
    }
    mysql_free_result($rs);

    $imgTitle = $translate->t('Instructions', '', basename(__FILE__), __LINE__);
    $imgTitle = "alt='" . $imgTitle . "' title='" . $imgTitle . "'";

    if (substr($helpPage, 0, 1) == '!') {
        return "<a class='nooutline' href='" . substr($helpPage, 1) . "' " . $imgTitle . " target='_blank'>";
    }
    if ($helpPage != '' && isset($opt['locale'][$help_locale]['helpwiki'])) {
        return "<a class='nooutline' href='" . $opt['locale'][$help_locale]['helpwiki'] .
            str_replace(' ', '_', $helpPage) . "' " . $imgTitle . " target='_blank'>";
    }
    

    return '';
}

function get_logtype_name($logtype, $language)
{
    return sqlValue(
        "SELECT IFNULL(`stt`.`text`, `log_types`.`en`)
         FROM `log_types`
         LEFT JOIN `sys_trans_text` `stt` ON `stt`.`trans_id`=`log_types`.`trans_id` AND `stt`.`lang`='" . sql_escape($language) . "'
         WHERE `log_types`.`id`='" . sql_escape($logtype) . "'",
        ''
    );
}

OpencachingDeutschland / oc-server3

Push — development ( f93eb8...ffa1a0 )

htdocs/lib/common.inc.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like
