OpencachingDeutschland / oc-server3

htdocs/config2/settings-dist.inc.php

Spacing +21 added lines, -21 removed lines

@@ -8,8 +8,8 @@ 
  *  Do not modify this file - use settings.inc.php!
  ***************************************************************************/
 
-require_once __DIR__. '/locale.inc.php';
-require_once __DIR__. '/settings-dist-common.inc.php';
+require_once __DIR__ . '/locale.inc.php';
+require_once __DIR__ . '/settings-dist-common.inc.php';
 
 /* PHP settings
  *
@@ -108,7 +108,7 @@ 
 // database placeholder
 
 // productive database with opencaching-tables
-$opt['db']['placeholder']['db'] = '';    // selected by default
+$opt['db']['placeholder']['db'] = ''; // selected by default
 
 // empty database for temporary table creation
 $opt['db']['placeholder']['tmpdb'] = '';
@@ -122,14 +122,14 @@ 
 $opt['system']['maillog']['syslog_db_user'] = '';
 $opt['system']['maillog']['syslog_db_password'] = '';
 $opt['system']['maillog']['syslog_db_table'] = '';
-$opt['system']['maillog']['syslog_oc_host'] = '';  // 'host_name' column in syslog DB
-$opt['system']['maillog']['syslog_mta'] = 'postfix/smtp%';  // 'program' column in syslog DB
-$opt['system']['maillog']['column']['id'] = 'id';               // 'ID'
-$opt['system']['maillog']['column']['created'] = 'created';     // 'ReceivedAt'
+$opt['system']['maillog']['syslog_oc_host'] = ''; // 'host_name' column in syslog DB
+$opt['system']['maillog']['syslog_mta'] = 'postfix/smtp%'; // 'program' column in syslog DB
+$opt['system']['maillog']['column']['id'] = 'id'; // 'ID'
+$opt['system']['maillog']['column']['created'] = 'created'; // 'ReceivedAt'
 $opt['system']['maillog']['column']['host_name'] = 'host_name'; // 'FromHost'
-$opt['system']['maillog']['column']['message'] = 'message';     // 'Message'
-$opt['system']['maillog']['column']['program'] = 'program';     // 'SysLogTag'
-$opt['system']['maillog']['inactivity_warning'] = 30;   // warn after N days without new entries
+$opt['system']['maillog']['column']['message'] = 'message'; // 'Message'
+$opt['system']['maillog']['column']['program'] = 'program'; // 'SysLogTag'
+$opt['system']['maillog']['inactivity_warning'] = 30; // warn after N days without new entries
 
 /* cookie or session
  *
@@ -151,15 +151,15 @@ 
  * 
  * other parameters may be customized
  */
-$opt['session']['mode'] = SAVE_COOKIE;     // don't change - other option "SAVE_SESSION" is not implemented properly
+$opt['session']['mode'] = SAVE_COOKIE; // don't change - other option "SAVE_SESSION" is not implemented properly
 $opt['session']['cookiename'] = 'oc_devel'; // only with SAVE_COOKIE
 $opt['session']['path'] = '/';
-$opt['session']['domain'] = '';    // may be overwritten by $opt['domain'][...]['cookiedomain']
+$opt['session']['domain'] = ''; // may be overwritten by $opt['domain'][...]['cookiedomain']
 
 /* maximum session lifetime
  */
 $opt['session']['expire']['cookie'] = 31536000; // when cookies used (default 1 year)
-$opt['session']['expire']['url'] = 1800;        // when no cookies used (default 30 min since last call), attention to session.js
+$opt['session']['expire']['url'] = 1800; // when no cookies used (default 30 min since last call), attention to session.js
 
 /* If the Referer was sent by the client and the substring was not found,
  * the embedded session id will be marked as invalid.
@@ -185,7 +185,7 @@ 
 /* other template options
  *
  */
-$opt['page']['origin_url'] = 'http://www.opencaching.de/';  // production installation for this OC site
+$opt['page']['origin_url'] = 'http://www.opencaching.de/'; // production installation for this OC site
 $opt['page']['develsystem'] = false;
 $opt['page']['teampic_url'] = 'http://www.opencaching.de/images/team/';
 $opt['page']['teammember_url'] = 'http://www.opencaching.de/';
@@ -219,7 +219,7 @@ 
     'newcaches' => [
         'show' => true,
         'url' => 'http://www.opencaching.de',
-        'urlname' => '',  // optional: show other name than the url-domain
+        'urlname' => '', // optional: show other name than the url-domain
     ],
 ];
 
@@ -378,7 +378,7 @@ 
 
 /* license-related functions
  */
-$opt['logic']['license']['newusers'] = 2;  // see license constants in lib2/logic/const.inc.php
+$opt['logic']['license']['newusers'] = 2; // see license constants in lib2/logic/const.inc.php
 $opt['logic']['license']['admin'] = true;
 $opt['logic']['license']['disclaimer'] = false;
 $opt['logic']['license']['terms'] = 'articles.php?page=impressum#datalicense';
@@ -386,18 +386,18 @@ 
 
 /* optional APIs
  */
-$opt['logic']['api']['email_problems']['key'] = '';   // must be set to enable
-$opt['logic']['api']['user_inactivity']['key'] = '';  // must be set to enable
+$opt['logic']['api']['email_problems']['key'] = ''; // must be set to enable
+$opt['logic']['api']['user_inactivity']['key'] = ''; // must be set to enable
 
 /* cache report info settings
  */
 $opt['logic']['cache_reports']['delaydays'] = 2;
-$opt['logic']['cache_reports']['min_processperday'] = 5;   // set to 0 to disable
-$opt['logic']['cache_reports']['max_processperday'] = 20;  // set to 0 to disable
+$opt['logic']['cache_reports']['min_processperday'] = 5; // set to 0 to disable
+$opt['logic']['cache_reports']['max_processperday'] = 20; // set to 0 to disable
 
 /* cronjob
  */
-$opt['cron']['username'] = 'apache';   // system username for cronjobs
+$opt['cron']['username'] = 'apache'; // system username for cronjobs
 
 /* phpbb news integration (index.php, outdated)
  *

htdocs/lib2/imagebmp.inc.php

Doc Comments +5 added lines, -5 removed lines

@@ -491,7 +491,7 @@ 
 }
 
 /**
- * @param $byte
+ * @param integer $byte
  * @param $start
  * @param $len
  *
@@ -508,8 +508,8 @@ 
 
 $CurrentBit = 0;
 /**
- * @param $f
- * @param $count
+ * @param resource $f
+ * @param integer $count
  *
  * @return number
  */
@@ -564,7 +564,7 @@ 
 }
 
 /**
- * @param $n
+ * @param integer $n
  *
  * @return string
  */
@@ -585,7 +585,7 @@ 
 
 /**
  * @param $d
- * @param $n
+ * @param integer $n
  *
  * @return string
  */

htdocs/src/Oc/SmartyPlugins/prefilter.t.php

Doc Comments +4 added lines, -4 removed lines

@@ -91,10 +91,10 @@ 
  *
  */
 /**
- * @param $block
- * @param $message
+ * @param string $block
+ * @param string $message
  * @param $smarty
- * @param $line
+ * @param integer $line
  *
  * @return string
  */
@@ -268,7 +268,7 @@ 
 
 /**
  * @param $haystack
- * @param $needles
+ * @param string[] $needles
  *
  * @return bool|int
  */

htdocs/lib2/search/ftsearch.inc.php

Spacing +2 added lines, -2 removed lines

@@ -199,7 +199,7 @@ 
     $str = '';
 
     ftsearch_load_ignores();
-    for ($i = count($astr) - 1; $i >= 0; $i --) {
+    for ($i = count($astr) - 1; $i >= 0; $i--) {
         // ignore?
         if (array_search(mb_strtolower($astr[$i]), $ftsearch_ignores) !== false) {
             unset($astr[$i]);
@@ -254,7 +254,7 @@ 
 
     // doppelte chars ersetzen
     $ordZ = ord('z');
-    for ($c = ord('a'); $c <= $ordZ; $c ++) {
+    for ($c = ord('a'); $c <= $ordZ; $c++) {
         $old_str = '';
         while ($old_str !== $str) {
             $old_str = $str;

htdocs/lib2/menu.class.php

Doc Comments +2 added lines, -2 removed lines

@@ -280,7 +280,7 @@ 
     }
 
     /**
-     * @param $menuid
+     * @param integer|null $menuid
      * @param $ids
      * @param $items
      */
@@ -302,7 +302,7 @@ 
     }
 
     /**
-     * @return array
+     * @return integer[]
      */
     public function GetSelectedMenuIds()
     {

Spacing +3 added lines, -3 removed lines

@@ -80,7 +80,7 @@ 
                         'parent' => MNU_MAP
                     ];
                     $menuitem[MNU_MAP]['subitems'][] = $menu_map;
-                    ++ $menu_map;
+                    ++$menu_map;
                 }
             }
         }
@@ -107,7 +107,7 @@ 
         $rsSubmenu = sqlf("SELECT `id` FROM `sys_menu` WHERE `parent`=0 ORDER BY `parent` ASC, `position` ASC");
         while ($rSubmenu = sql_fetch_assoc($rsSubmenu)) {
             $aMenu[MNU_ROOT]['subitems'][$nPos] = $rSubmenu['id'];
-            $nPos ++;
+            $nPos++;
         }
         sql_free_result($rsSubmenu);
         fwrite($f, "\n");
@@ -144,7 +144,7 @@ 
             );
             while ($rSubmenu = sql_fetch_assoc($rsSubmenu)) {
                 $aMenu[$r['id']]['subitems'][$nPos] = $rSubmenu['id'];
-                $nPos ++;
+                $nPos++;
             }
             sql_free_result($rsSubmenu);
         }

htdocs/lib2/rowEditor.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -490,7 +490,7 @@
     }
 
     /**
-     * @return bool
+     * @return boolean|null
      */
     public function getAnyChanged()
     {

htdocs/lib2/translationHandler.class.php

Doc Comments +3 added lines, -3 removed lines

@@ -236,8 +236,8 @@ 
      * import variables for substition from config2/nodetext/
      *
      * @param $variables
-     * @param $file
-     * @param $language
+     * @param string $file
+     * @param string $language
      *
      * @return bool
      */
@@ -269,7 +269,7 @@ 
 
     /**
      * @param $variables
-     * @param $lang
+     * @param string $lang
      * @param $str
      *
      * @return string

htdocs/src/Oc/Session/SessionDataCookie.php

Doc Comments +2 added lines, -2 removed lines

@@ -63,7 +63,7 @@ 
     }
 
     /**
-     * @param $name
+     * @param string $name
      * @param null $default
      *
      * @return mixed|null
@@ -74,7 +74,7 @@ 
     }
 
     /**
-     * @param $name
+     * @param string $name
      *
      * @return bool
      */

htdocs/src/Oc/Session/SessionDataNative.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
                     // TODO fix the following if statement, seems corrupted
                     if (strtolower(
                             substr(
-                                'http' + strstr($_SERVER['REFERER'], '://'),
+                                'http' +strstr($_SERVER['REFERER'], '://'),
                                 0,
                                 strlen($opt['page']['absolute_http_url'])
                             )