picture - Code Metrics - Inspection of "Merge pull request #789 from following5/patch-3" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — next ( 5f2bc0...cef70f )

by Thomas

created 2020-09-08 06:40 UTC

picture F

↳ Parent: Project

Complexity

Total Complexity

121

Size/Duplication

Total Lines	936
Duplicated Lines	5.13 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	48
loc	936
rs	1.664
c	0
b	0
f	0
wmc	121
lcom	1
cbo	1

53 Methods

Rating	Name	Duplication	Size	Complexity
A	setPosition()	0	8	2
A	deletedFilename()	0	12	2
A	pictureIdFromUUID()	0	4	1
A	fromUUID()	0	9	2
A	__construct()	0	43	2
A	exist()	0	4	1
A	allowedExtension()	0	19	4
A	setFilenames()	0	20	3
A	getPictureId()	0	4	1
A	setArchiveFlag()	0	33	5
A	resetArchiveFlag()	0	7	1
A	getUrl()	0	4	1
A	setUrl()	0	4	1
A	getThumbUrl()	0	4	1
A	setThumbUrl()	0	4	1
A	getTitle()	0	4	1
A	setTitle()	0	8	2
A	getSpoiler()	0	4	1
A	setSpoiler()	0	4	2
A	getLocal()	0	4	1
A	setLocal()	0	4	2
A	getUnknownFormat()	0	4	1
A	setUnknownFormat()	0	4	2
A	getDisplay()	0	4	1
A	setDisplay()	0	4	2
A	getMapPreview()	0	4	1
A	setMapPreview()	0	4	2
A	getFilename()	3	14	2
A	getThumbFilename()	3	17	2
A	getLogId()	0	8	2
A	isVisibleOnCachePage()	0	26	4
A	getCacheId()	10	10	3
A	getObjectId()	0	4	1
A	setObjectId()	0	4	1
A	getObjectType()	0	4	1
A	setObjectType()	0	4	1
A	getUserId()	18	18	3
A	getNode()	0	4	1
A	setNode()	0	4	1
A	getUUID()	0	4	1
A	getLastModified()	0	4	1
A	getDateCreated()	0	4	1
A	getPosition()	0	4	1
A	getAnyChanged()	0	4	1
A	is_duplicate()	0	15	2
B	save()	0	57	8
A	delete()	0	32	5
A	allowEdit()	14	23	3
A	getPageLink()	0	16	4
D	rotate_and_shrink()	0	74	14
A	rotate()	0	25	5
A	imagick_rotate()	0	16	5
B	up()	0	63	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like picture often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use picture, and based on these observations, apply Extract Interface, too.

<?php
/***************************************************************************
 * for license information see LICENSE.md
 *
 *
 *   get/set has to be commited with save
 *   add/remove etc. is executed instantly
 ***************************************************************************/

require_once __DIR__ . '/const.inc.php';

class picture
{
    public $nPictureId = 0;
    public $rePicture;
    public $sFileExtension = '';
    public $bFilenamesSet = false;

    private $originalPosition;

    public static function pictureIdFromUUID($uuid)
    {
        return sql_value("SELECT `id` FROM `pictures` WHERE `uuid`='&1'", 0, $uuid);

    }

    public static function fromUUID($uuid)
    {
        $pictureId = self::pictureIdFromUUID($uuid);
        if ($pictureId == 0) {
            return null;
        }

        return new self($pictureId);
    }

    public function __construct($nNewPictureId = ID_NEW)
    {
        global $opt;

        $this->rePicture = new rowEditor('pictures');
        $this->rePicture->addPKInt('id', null, false, RE_INSERT_AUTOINCREMENT);
        $this->rePicture->addString('uuid', '', false, RE_INSERT_AUTOUUID);
        $this->rePicture->addInt('node', 0, false);
        $this->rePicture->addDate('date_created', time(), true, RE_INSERT_IGNORE);
        $this->rePicture->addDate('last_modified', time(), true, RE_INSERT_IGNORE);
        $this->rePicture->addString('url', '', false);
        $this->rePicture->addString('title', '', false);
        $this->rePicture->addDate('last_url_check', 0, true);
        $this->rePicture->addInt('object_id', null, false);
        $this->rePicture->addInt('object_type', null, false);
        $this->rePicture->addString('thumb_url', '', false);
        $this->rePicture->addDate('thumb_last_generated', 0, false);
        $this->rePicture->addInt('spoiler', 0, false);
        $this->rePicture->addInt('local', 0, false);
        $this->rePicture->addInt('unknown_format', 0, false);
        $this->rePicture->addInt('display', 1, false);
        $this->rePicture->addInt('mappreview', 0, false);
        $this->rePicture->addInt('seq', 0, false);

        $this->nPictureId = $nNewPictureId + 0;

        if ($nNewPictureId == ID_NEW) {
            $this->rePicture->addNew(null);

            $sUUID = mb_strtoupper(sql_value('SELECT UUID()', ''));

            $this->rePicture->setValue('uuid', $sUUID);
            $this->rePicture->setValue('node', $opt['logic']['node']['id']);
            $this->originalPosition = false;
        } else {
            $this->rePicture->load($this->nPictureId);
            $this->originalPosition = $this->getPosition();

            $sFilename = $this->getFilename();
            $fna = mb_split('\\.', $sFilename);
            $this->sFileExtension = mb_strtolower($fna[count($fna) - 1]);
            $this->bFilenamesSet = true;
        }
    }

    /**
     * @return bool
     */
    public function exist()
    {
        return $this->rePicture->exist();
    }

    /**
     * @param $sFilename
     * @return bool
     */
    public static function allowedExtension($sFilename)
    {
        global $opt;

        if (strpos($sFilename, ';') !== false) {
            return false;
        }
        if (strpos($sFilename, '.') === false) {
            return false;
        }

        $sExtension = mb_strtolower(substr($sFilename, strrpos($sFilename, '.') + 1));

        if (strpos(';' . $opt['logic']['pictures']['extensions'] . ';', ';' . $sExtension . ';') !== false) {
            return true;
        }

        return false;
    }

    /**
     * @param string $sFilename
     */
    public function setFilenames($sFilename): void
    {
        global $opt;

        if ($this->bFilenamesSet == true) {

            return;
        }
        if (strpos($sFilename, '.') === false) {
            return;
        }

        $sExtension = mb_strtolower(substr($sFilename, strrpos($sFilename, '.') + 1));
        $this->sFileExtension = $sExtension;

        $sUUID = $this->getUUID();

        $this->setUrl($opt['logic']['pictures']['url'] . $sUUID . '.' . $sExtension);

        $this->bFilenamesSet = true;
    }

    /**
     * @return int
     */
    public function getPictureId()
    {
        return $this->nPictureId;
    }

    /**
     * @param bool $bRestoring
     * @param int $original_id
     */
    private function setArchiveFlag($bRestoring, $original_id = 0): void
    {
        global $login;

        // This function determines if an insert, update oder deletion at pictures table
        // ist to be recorded for vandalism recovery, depending on WHO OR WHY the
        // operation is done. Other conditions, depending on the data, are handled
        // by triggers.
        //
        // Data is passed by ugly global DB variables, so try call this function as
        // close before the targetet DB operation as possible.

        if ($this->getObjectType() == 1) {
            $logger_id = sql_value(

                "SELECT
                    IFNULL((SELECT `user_id` FROM `cache_logs` WHERE `id`='&1'),
                           (SELECT `user_id` FROM `cache_logs_archived` WHERE `id`='&1'))",
                0,
                $this->getObjectId()
            );
            $archive = ($bRestoring || $login->userid != $logger_id);
        } else {
            $archive = true;
        }

        sql('SET @archive_picop=' . ($archive ? 'TRUE' : 'FALSE'));

        sql_slave('SET @archive_picop=' . ($archive ? 'TRUE' : 'FALSE'));


        sql("SET @original_picid='&1'", $original_id);

        sql_slave("SET @original_picid='&1'", $original_id);


        // @archive_picop and @original_picid are evaluated by trigger functions
    }

    private function resetArchiveFlag(): void
    {
        sql('SET @archive_picop=FALSE');

        sql('SET @original_picid=0');

        sql_slave('SET @archive_picop=FALSE');

        sql_slave('SET @original_picid=0');

    }

    /**
     * @return string
     */
    public function getUrl()
    {
        return $this->rePicture->getValue('url');
    }

    /**
     * @param string $value
     * @return bool
     */
    public function setUrl($value)
    {
        return $this->rePicture->setValue('url', $value);
    }

    /**
     * @return mixed
     */
    public function getThumbUrl()
    {
        return $this->rePicture->getValue('thumb_url');
    }

    /**
     * @param $value
     * @return bool
     */
    public function setThumbUrl($value)
    {
        return $this->rePicture->setValue('thumb_url', $value);
    }

    /**
     * @return mixed
     */
    public function getTitle()
    {
        return $this->rePicture->getValue('title');
    }

    /**
     * @param $value
     * @return bool
     */
    public function setTitle($value)
    {
        if ($value != '') {
            return $this->rePicture->setValue('title', $value);
        }

        return false;
    }

    /**
     * @return bool
     */
    public function getSpoiler()
    {
        return $this->rePicture->getValue('spoiler') != 0;
    }

    /**
     * @param $value
     * @return bool
     */
    public function setSpoiler($value)
    {
        return $this->rePicture->setValue('spoiler', $value ? 1 : 0);
    }

    /**
     * @return bool
     */
    public function getLocal()
    {
        return $this->rePicture->getValue('local') != 0;
    }

    /**
     * @param int $value
     * @return bool
     */
    public function setLocal($value)
    {
        return $this->rePicture->setValue('local', $value ? 1 : 0);
    }

    /**
     * @return bool
     */
    public function getUnknownFormat()
    {
        return $this->rePicture->getValue('unknown_format') != 0;
    }

    /**
     * @param $value
     * @return bool
     */
    public function setUnknownFormat($value)
    {
        return $this->rePicture->setValue('unknown_format', $value ? 1 : 0);
    }

    /**
     * @return bool
     */
    public function getDisplay()
    {
        return $this->rePicture->getValue('display') != 0;
    }

    /**
     * @param $value
     * @return bool
     */
    public function setDisplay($value)
    {
        return $this->rePicture->setValue('display', $value ? 1 : 0);
    }

    /**
     * @return bool
     */
    public function getMapPreview()
    {
        return $this->rePicture->getValue('mappreview') != 0;
    }

    /**
     * @param $value
     * @return bool
     */
    public function setMapPreview($value)
    {
        return $this->rePicture->setValue('mappreview', $value ? 1 : 0);
    }

    /**
     * @return string
     */
    public function getFilename()
    {
        // works intendently before bFilenameSet == true !
        global $opt;

        if (mb_substr($opt['logic']['pictures']['dir'], -1, 1) != '/') {
            $opt['logic']['pictures']['dir'] .= '/';
        }

        $url = $this->getUrl();
        $fna = mb_split('\\/', $url);

        return $opt['logic']['pictures']['dir'] . end($fna);
    }

    /**
     * @return string
     */
    public function getThumbFilename()
    {
        global $opt;

        if (mb_substr($opt['logic']['pictures']['thumb_dir'], -1, 1) != '/') {
            $opt['logic']['pictures']['thumb_dir'] .= '/';
        }

        $url = $this->getUrl();
        $fna = mb_split('\\/', $url);
        $filename = end($fna);

        $dir1 = mb_strtoupper(mb_substr($filename, 0, 1));
        $dir2 = mb_strtoupper(mb_substr($filename, 1, 1));

        return $opt['logic']['pictures']['thumb_dir'] . $dir1 . '/' . $dir2 . '/' . $filename;
    }

    /**
     * @return string
     */
    public function getLogId()
    {
        if ($this->getObjectType() == OBJECT_CACHELOG) {
            return $this->getObjectId();
        }

        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return bool|null
     */
    public function isVisibleOnCachePage()
    {
        if ($this->getObjectType() != OBJECT_CACHELOG) {
            return null;
        }
        $rs = sql(

                "SELECT `id`
                 FROM `cache_logs`
                 WHERE `cache_id`='&1'
                 ORDER BY `date`, `id` DESC
                 LIMIT &2",
                $this->getCacheId(),
                MAX_LOGENTRIES_ON_CACHEPAGE
            );
        
        $firstlogs = false;
        while ($r = sql_fetch_assoc($rs)) {

            if ($r['id'] == $this->getLogId()) {
                $firstlogs = true;
            }
        }

        sql_free_result($rs);


        return $firstlogs;
    }

    /**
     * @return string
     */
    public function getCacheId()

    {
        if ($this->getObjectType() == OBJECT_CACHELOG) {
            return sql_value("SELECT `cache_id` FROM `cache_logs` WHERE `id`='&1'", false, $this->getObjectId());

        } elseif ($this->getObjectType() == OBJECT_CACHE) {
            return $this->getObjectId();
        }

        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return mixed
     */
    public function getObjectId()
    {
        return $this->rePicture->getValue('object_id');
    }

    /**
     * @param $value
     * @return bool
     */
    public function setObjectId($value)
    {
        return $this->rePicture->setValue('object_id', $value + 0);
    }

    /**
     * @return mixed
     */
    public function getObjectType()
    {
        return $this->rePicture->getValue('object_type');
    }

    /**
     * @param $value
     * @return bool
     */
    public function setObjectType($value)
    {
        return $this->rePicture->setValue('object_type', $value + 0);
    }

    /**
     * @return bool|mixed
     */
    public function getUserId()

    {
        if ($this->getObjectType() == OBJECT_CACHE) {
            return sql_value(

                "SELECT `caches`.`user_id` FROM `caches` WHERE `caches`.`cache_id`='&1'",
                false,
                $this->getObjectId()
            );
        } elseif ($this->getObjectType() == OBJECT_CACHELOG) {
            return sql_value(

                "SELECT `cache_logs`.`user_id` FROM `cache_logs` WHERE `cache_logs`.`id`='&1'",
                false,
                $this->getObjectId()
            );
        }

        return false;
    }

    /**
     * @return mixed
     */
    public function getNode()
    {
        return $this->rePicture->getValue('node');
    }

    /**
     * @param $value
     * @return bool
     */
    public function setNode($value)
    {
        return $this->rePicture->setValue('node', $value);
    }

    /**
     * @return mixed
     */
    public function getUUID()
    {
        return $this->rePicture->getValue('uuid');
    }

    /**
     * @return mixed
     */
    public function getLastModified()
    {
        return $this->rePicture->getValue('last_modified');
    }

    /**
     * @return mixed
     */
    public function getDateCreated()
    {
        return $this->rePicture->getValue('date_created');
    }

    /**
     * @return mixed
     */
    public function getPosition()
    {
        return $this->rePicture->getValue('seq');
    }

    /**
     * @param int $position
     */
    public function setPosition($position): void
    {
        if ($this->originalPosition === false) {
            // position numbers are always >= 1
            $this->rePicture->setValue('seq', max(1, $position));
        }
        // repositioning existing pictures is not implemented yet
    }

    /**
     * @return bool|null
     */
    public function getAnyChanged()
    {
        return $this->rePicture->getAnyChanged();
    }

    // Test if the picture can be discarded as duplicate.
    // This is a quick test for Ocprop dups and may be extended for any
    // picture uploads by comparing the file sizes and contents.

    /**
     * @return bool
     */
    public function is_duplicate()
    {
        global $ocpropping;

        return $ocpropping &&
        sql_value(

            "
            SELECT COUNT(*) FROM `pictures`
            WHERE `object_type`='&1' AND `object_id`='&2' AND `title`='&3'",
            0,
            $this->getObjectType(),
            $this->getObjectId(),
            $this->getTitle()
        ) > 0;
    }

    /**
     * return true if successful (with insert)
     *
     * @param bool $restore
     * @param int $original_id
     * @param string $original_url
     * @return bool
     */
    public function save($restore = false, $original_id = 0, $original_url = '')
    {
        $undelete = ($original_id != 0);

        if ($undelete) {
            if ($this->bFilenamesSet == true) {

                return false;
            }
            // restore picture file
                $this->setUrl($original_url);     // set the url, so that we can
                $filename = $this->getFilename(); // .. retrieve the file path+name
                $this->setFilenames($filename);   // now set url(s) from the new uuid
                try {
                    rename($this->deletedFilename($filename), $this->getFilename());
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
                } catch (Exception $e) {
                    // @todo implement logging
                }
        }

        if ($this->bFilenamesSet == false) {

            return false;
        }

        // produce a position number gap for inserting
        sql(

            "UPDATE `pictures`
             SET `seq`=`seq`+1
             WHERE `object_type`='&1' AND `object_id`='&2' AND `seq` >= '&3'
             ORDER BY `seq` DESC",
            $this->getObjectType(),
            $this->getObjectId(),
            $this->getPosition()
        );

        // The seq numbers need not to be consecutive, so it dosen't matter
        // if something fails here and leaves the gap open.

        $this->setArchiveFlag($restore, $original_id);
        $bRetVal = $this->rePicture->save();
        $this->resetArchiveFlag();

        if ($bRetVal) {
            $this->nPictureId = $this->rePicture->getValue('id');
            if ($this->getObjectType() == OBJECT_CACHE && $this->getMapPreview()) {
                sql(

                    "UPDATE `pictures` SET `mappreview`= 0
                     WHERE `object_type`='&1' AND `object_id`='&2' AND `id`!='&3'",
                    OBJECT_CACHE,
                    $this->getObjectId(),
                    $this->getPictureId()
                );
            }
            sql_slave_exclude();

        }

        return $bRetVal;
    }

    /**
     * @param bool $restore
     * @return bool
     */
    public function delete($restore = false)
    {
        // see also removelog.php, 'remove log pictures'
        // delete record, image and thumb
        $this->setArchiveFlag($restore);
        sql("DELETE FROM `pictures` WHERE `id`='&1'", $this->nPictureId);

        $this->resetArchiveFlag();
        $filename = $this->getFilename();

        // archive picture if picture record has been archived
        if (sql_value("SELECT `id` FROM `pictures_modified` WHERE `id`='&1'", 0, $this->getPictureId()) != 0) {

            try {
                rename($filename, $this->deletedFilename($filename));
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            } catch (Exception $e) {
                // @todo implement logging
            }
        } else {
            try {
                unlink($filename);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
            } catch (Exception $e) {
                // @todo implement logging
            }
        }

        try {
            unlink($this->getThumbFilename());
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
        } catch (Exception $e) {
            // @todo implement logging
        }

        return true;
    }

    /**
     * @param string $filename
     *
     * @return string
     */
    private function deletedFilename($filename)
    {
        $fna = mb_split('\\/', $filename);
        $fna[] = end($fna);
        $fna[count($fna) - 2] = 'deleted';
        $dp = '';
        foreach ($fna as $fp) {
            $dp .= '/' . $fp;
        }

        return substr($dp, 1);
    }

    public function allowEdit()

    {
        global $login;

        $login->verify();

        if (sql_value(

            "SELECT COUNT(*)
            FROM `caches`
            INNER JOIN `cache_status` ON `caches`.`status`=`cache_status`.`id`
            WHERE (`cache_status`.`allow_user_view`=1 OR `caches`.`user_id`='&1')
            AND `caches`.`cache_id`='&2'",
            0,
            $login->userid,
            $this->getCacheId()
        ) == 0) {
            return false;
        } elseif ($this->getUserId() == $login->userid) {
            return true;
        }

        return false;
    }

    /**
     * @return bool|string
     */
    public function getPageLink()
    {
        if ($this->getObjectType() == OBJECT_CACHELOG) {
            $pl = 'viewcache.php?cacheid=' . urlencode($this->getCacheId());
            if (!$this->isVisibleOnCachePage()) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
                $pl .= '&log=A';
            }
            $pl .= '#log' . urlencode($this->getLogId());
        } elseif ($this->getObjectType() == OBJECT_CACHE) {
            $pl = 'editcache.php?cacheid=' . urlencode($this->getCacheId()) . '#pictures';
        } else {
            $pl = false;
        }

        return $pl;
    }

    /*
        Shrink picture to a specified maximum size. If present Imagemagick extension will be used, if not gd.
        Imagick is sharper, faster, need less memory and supports more types.
        For gd size is limited to 5000px (memory consumption).
        i prefer FILTER_CATROM because its faster but similiar to lanczos see http://de1.php.net/manual/de/imagick.resizeimage.php
        parameter:
        $tmpfile: full name of uploaded file
        $longSideSize:  if longer side of picture > $longSideSize, then it will be prop. shrinked to
        returns: true if no error occur, otherwise false

     * @param $tmpFile
     * @param $longSideSize
     * @return bool
     */
    public function rotate_and_shrink($tmpFile, $longSideSize)
    {
        global $opt;
        if (extension_loaded('imagick')) {
            try {
                $image = new Imagick();
                $image->readImage($tmpFile);
                $this->imagick_rotate($image);
                $w = $image->getImageWidth();
                $h = $image->getImageHeight();
                $image->setImageResolution(PICTURE_RESOLUTION, PICTURE_RESOLUTION);
                $image->setImageCompression(Imagick::COMPRESSION_JPEG);
                $image->setImageCompressionQuality(PICTURE_QUALITY);
                $image->stripImage(); //clears exif, private data
                //$newSize=$w<$h?array($w*$longSideSize/$h,$longSideSize):array($longSideSize,$h*$longSideSize/$w);
                if (max($w, $h) > $longSideSize) {
                    $image->resizeImage($longSideSize, $longSideSize, imagick::FILTER_CATROM, 1, true);
                }
                $result = $image->writeImage($this->getFilename());
                $image->clear();
            } catch (Exception $e) {
                if ($image) {
                    $image->clear();
                }
                if ($opt['debug'] & DEBUG_DEVELOPER) {
                    die($e);
                }
                $result = false;
            }

            return $result;
        } elseif (extension_loaded('gd')) {
            $imageNew = null;
            try {
                $image = imagecreatefromstring(file_get_contents($tmpFile));
                $w = imagesx($image);
                $h = imagesy($image);
                if (max($w, $h) > 5000) {
                    throw new Exception('Image too large >5000px');
                }
                if (max($w, $h) <= $longSideSize) {
                    $result = imagejpeg($image, $this->getFilename(), PICTURE_QUALITY);
                } else {
                    $newSize = $w < $h ? [
                        $w * $longSideSize / $h,
                        $longSideSize,
                    ] : [
                        $longSideSize,
                        $h * $longSideSize / $w,
                    ];
                    $imageNew = imagecreatetruecolor($newSize[0], $newSize[1]);
                    imagecopyresampled($imageNew, $image, 0, 0, 0, 0, $newSize[0], $newSize[1], $w, $h);
                    $result = imagejpeg($imageNew, $this->getFilename(), PICTURE_QUALITY);
                    imagedestroy($imageNew);
                }
                imagedestroy($image);
            } catch (Exception $e) {
                if ($image) {
                    imagedestroy($image);
                }
                if ($imageNew) {
                    imagedestroy($imageNew);
                }
                if ($opt['debug'] & DEBUG_DEVELOPER) {
                    die($e);
                }
                $result = false;
            }

            return $result;
        }

        return false;
    }

    /**
     * rotate image according to EXIF orientation
     *
     * @param $tmpFile
     * @return bool
     */
    public function rotate($tmpFile)
    {
        if (extension_loaded('imagick')) {
            try {
                $image = new Imagick();
                $image->readImage($tmpFile);
                if ($this->imagick_rotate($image)) {
                    $image->stripImage(); // clears exif, private data
                    $image->writeImage($this->getFilename());
                    $image->clear();

                    return true;
                }
                $image->clear();
            } catch (Exception $e) {
                if ($image) {
                    $image->clear();
                }

                return false;
            }
        }

        return move_uploaded_file($tmpFile, $this->getFilename());
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}
    }

    /**
     * @param Imagick $image
     *
     * @return bool
     */
    public function imagick_rotate(&$image)
    {
        $exif = $image->getImageProperties();
        if (isset($exif['exif:Orientation'])) {
            switch ($exif['exif:Orientation']) {
                case 3:
                    return $image->rotateImage(new ImagickPixel(), 180);
                case 6:
                    return $image->rotateImage(new ImagickPixel(), 90);
                case 8:
                    return $image->rotateImage(new ImagickPixel(), -90);
            }
        }

        return false;
    }

    /**
     * @return bool
     */
    public function up()
    {
        // TODO: protect the following operations by a transaction

        $prevPos = sql_value(

            "
            SELECT MAX(`seq`)
            FROM `pictures`
            WHERE `object_type`='&1' AND `object_id`='&2' AND `seq`<'&3'",
            0,
            $this->getObjectType(),
            $this->getObjectId(),
            $this->getPosition()
        );

        if ($prevPos) {
            $maxPos = sql_value(

                "
                SELECT MAX(`seq`)
                FROM `pictures`
                WHERE `object_type`='&1' AND `object_id`='&2'",
                0,
                $this->getObjectType(),
                $this->getObjectId()
            );

            // swap positions with the previous pic
            sql(

                "
                UPDATE `pictures`
                SET `seq`='&2'
                WHERE `id`='&1'",
                $this->getPictureId(),
                $maxPos + 1
            );
            // If something goes wrong from here (i.e. DB server failure) and
            // we are moving anything else but the last picture, it will
            // produce a wrong picture order. No big deal, the user can easily
            // correct that, but still a transaction would be nice.
            sql(

                "
                UPDATE `pictures` SET `seq`='&4'
                WHERE `object_type`='&1' AND `object_id`='&2' AND `seq`='&3'",
                $this->getObjectType(),
                $this->getObjectId(),
                $prevPos,
                $this->getPosition()
            );
            sql(

                "
                UPDATE `pictures`
                SET `seq`='&2'
                WHERE `id`='&1'",
                $this->getPictureId(),
                $prevPos
            );
            $this->rePicture->setValue('seq', $prevPos);

            return true;
        }

        return false;
    }
}


Push — next ( 5f2bc0...cef70f )

picture F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

53 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

1			<?php
2			/***************************************************************************
3			* for license information see LICENSE.md
4			*
5			*
6			* get/set has to be commited with save
7			* add/remove etc. is executed instantly
8			***************************************************************************/
9
10			require_once __DIR__ . '/const.inc.php';
11
12			class picture
13			{
14			public $nPictureId = 0;
15			public $rePicture;
16			public $sFileExtension = '';
17			public $bFilenamesSet = false;
18
19			private $originalPosition;
20
21			public static function pictureIdFromUUID($uuid)
22			{
23			return sql_value("SELECT `id` FROM `pictures` WHERE `uuid`='&1'", 0, $uuid);
			0 ignored issues – show Deprecated Code introduced 2017-10-17 14:32 UTC by Report Bug Copy Issue Report The function `sql_value()` has been deprecated with message: use DBAL Conenction instead. See adminreports.php for an example implementation This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
24			}
25
26			public static function fromUUID($uuid)
27			{
28			$pictureId = self::pictureIdFromUUID($uuid);
29			if ($pictureId == 0) {
30			return null;
31			}
32
33			return new self($pictureId);
34			}
35
36			public function __construct($nNewPictureId = ID_NEW)
37			{
38			global $opt;
39

OpencachingDeutschland / oc-server3

Push — next ( 5f2bc0...cef70f )

picture F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

53 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

15 paths for user data to reach this point

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like