OpencachingDeutschland / oc-server3

htdocs/lib2/logic/cracklib.inc.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
     // min. 4 different chars
     $chars = array();
-    for ($i = 0; $i < mb_strlen($pw); $i ++) {
+    for ($i = 0; $i < mb_strlen($pw); $i++) {
         $chars[mb_substr($pw, $i, 1)] = true;
     }
 

htdocs/lib2/search/search.inc.php

Spacing +1 added lines, -1 removed lines

@@ -156,7 +156,7 @@
     }
 
     // doppelte chars ersetzen
-    for ($c = ord('a'); $c <= ord('z'); $c ++) {
+    for ($c = ord('a'); $c <= ord('z'); $c++) {
         $str = mb_ereg_replace(chr($c) . chr($c), chr($c), $str);
     }
 

htdocs/lib2/error.inc.php

Indentation +27 added lines, -27 removed lines

@@ -7,34 +7,34 @@
  *  Common error messages
  ***************************************************************************/
 
- define('ERROR_UNKNOWN', 1000);
- define('ERROR_TEMPLATE_NOT_FOUND', 1001);
- define('ERROR_COMPILATION_FAILED', 1002);
- define('ERROR_NO_ACCESS', 1003);
- define('ERROR_INVALID_OPERATION', 1004);
- define('ERROR_LOGIN_REQUIRED', 1005);
- define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006);
- define('ERROR_NO_COOKIES', 1007);
- define('ERROR_ALREADY_LOGGEDIN', 1008);
- define('ERROR_USER_NOT_ACTIVE', 1009);
- define('ERROR_USER_NO_EMAIL', 1010);
- define('ERROR_CACHE_NOT_PUBLISHED', 1011);
- define('ERROR_CACHE_LOCKED', 1012);
+    define('ERROR_UNKNOWN', 1000);
+    define('ERROR_TEMPLATE_NOT_FOUND', 1001);
+    define('ERROR_COMPILATION_FAILED', 1002);
+    define('ERROR_NO_ACCESS', 1003);
+    define('ERROR_INVALID_OPERATION', 1004);
+    define('ERROR_LOGIN_REQUIRED', 1005);
+    define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006);
+    define('ERROR_NO_COOKIES', 1007);
+    define('ERROR_ALREADY_LOGGEDIN', 1008);
+    define('ERROR_USER_NOT_ACTIVE', 1009);
+    define('ERROR_USER_NO_EMAIL', 1010);
+    define('ERROR_CACHE_NOT_PUBLISHED', 1011);
+    define('ERROR_CACHE_LOCKED', 1012);
 
- define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013);
- define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014);
- define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015);
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013);
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014);
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015);
  
- define('ERROR_DB_COULD_NOT_RECONNECT', 1016);
- define('ERROR_DB_NO_ROOT', 1017);
+    define('ERROR_DB_COULD_NOT_RECONNECT', 1016);
+    define('ERROR_DB_NO_ROOT', 1017);
 
- define('ERROR_USER_NOT_EXISTS', 1018);
- define('ERROR_CACHE_NOT_EXISTS', 1019);
- define('ERROR_CACHELOG_NOT_EXISTS', 1020);
- define('ERROR_PICTURE_NOT_EXISTS', 1021);
+    define('ERROR_USER_NOT_EXISTS', 1018);
+    define('ERROR_CACHE_NOT_EXISTS', 1019);
+    define('ERROR_CACHELOG_NOT_EXISTS', 1020);
+    define('ERROR_PICTURE_NOT_EXISTS', 1021);
 
- define('ERROR_UPLOAD_ERR_NO_FILE', 1022);
- define('ERROR_UPLOAD_ERR_SIZE', 1023);
- define('ERROR_UPLOAD_ERR_TYPE', 1024);
- define('ERROR_UPLOAD_UNKNOWN', 1025);
- define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026);
+    define('ERROR_UPLOAD_ERR_NO_FILE', 1022);
+    define('ERROR_UPLOAD_ERR_SIZE', 1023);
+    define('ERROR_UPLOAD_ERR_TYPE', 1024);
+    define('ERROR_UPLOAD_UNKNOWN', 1025);
+    define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026);

htdocs/lib2/login.class.php

Spacing +6 added lines, -6 removed lines

@@ -20,13 +20,13 @@
  *
  ***************************************************************************/
 
-define('LOGIN_UNKNOWN_ERROR', - 1);     // unkown error occured
-define('LOGIN_OK', 0);                 // login succeeded
-define('LOGIN_BADUSERPW', 1);          // bad username or password
-define('LOGIN_TOOMUCHLOGINS', 2);      // too many logins in short time
-define('LOGIN_USERNOTACTIVE', 3);      // the useraccount locked
+define('LOGIN_UNKNOWN_ERROR', - 1); // unkown error occured
+define('LOGIN_OK', 0); // login succeeded
+define('LOGIN_BADUSERPW', 1); // bad username or password
+define('LOGIN_TOOMUCHLOGINS', 2); // too many logins in short time
+define('LOGIN_USERNOTACTIVE', 3); // the useraccount locked
 define('LOGIN_EMPTY_USERPASSWORD', 4); // given username/password was empty
-define('LOGIN_LOGOUT_OK', 5);          // logout was successfull
+define('LOGIN_LOGOUT_OK', 5); // logout was successfull
 
 // login times in seconds
 define('LOGIN_TIME', 60 * 60);

htdocs/lib2/html2text.class.php

Spacing +2 added lines, -2 removed lines

@@ -534,7 +534,7 @@ 
         if (substr($link, 0, 7) == 'http://' || substr($link, 0, 8) == 'https://' ||
             substr($link, 0, 7) == 'mailto:'
         ) {
-            $this->_link_count ++;
+            $this->_link_count++;
             $this->_link_list .= "[" . $this->_link_count . "] $link\n";
             $additional = ' [' . $this->_link_count . ']';
         } elseif (substr($link, 0, 11) == 'javascript:') {
@@ -542,7 +542,7 @@ 
             $additional = '';
             // what about href="#anchor" ?
         } else {
-            $this->_link_count ++;
+            $this->_link_count++;
             $this->_link_list .= "[" . $this->_link_count . "] " . $this->url;
             if (substr($link, 0, 1) != '/') {
                 $this->_link_list .= '/';

htdocs/okapi/services/replicate/changelog.php

Braces +9 added lines, -4 removed lines

@@ -29,13 +29,18 @@
         require_once('replicate_common.inc.php');
 
         $since = $request->get_parameter('since');
-        if ($since === null) throw new ParamMissing('since');
-        if ((int)$since != $since) throw new InvalidParam('since');
+        if ($since === null) {
+            throw new ParamMissing('since');
+        }
+        if ((int)$since != $since) {
+            throw new InvalidParam('since');
+        }
 
         # Let's check the $since parameter.
 
-        if (!ReplicateCommon::check_since_param($since))
-            throw new BadRequest("The 'since' parameter is too old. You must update your database more frequently.");
+        if (!ReplicateCommon::check_since_param($since)) {
+                    throw new BadRequest("The 'since' parameter is too old. You must update your database more frequently.");
+        }
 
         # Select a best chunk for the given $since, get the chunk from the database (or cache).
 

htdocs/okapi/services/replicate/fulldump.php

Spacing +4 added lines, -4 removed lines

@@ -28,7 +28,7 @@ 
                 select count(*)
                 from okapi_stats_temp
                 where
-                    consumer_key = '".Db::escape_string($consumer_key)."'
+                    consumer_key = '".Db::escape_string($consumer_key) . "'
                     and service_name='services/replicate/fulldump'
             ")
             +
@@ -36,7 +36,7 @@ 
                 select sum(total_calls)
                 from okapi_stats_hourly
                 where
-                    consumer_key = '".Db::escape_string($consumer_key)."'
+                    consumer_key = '".Db::escape_string($consumer_key) . "'
                     and service_name='services/replicate/fulldump'
                     and period_start > date_add(now(), interval -$days day)
                 limit 1
@@ -50,7 +50,7 @@ 
 
         $data = Cache::get("last_fulldump");
         if ($data == null)
-            throw new BadRequest("No fulldump found. Try again later. If this doesn't help ".
+            throw new BadRequest("No fulldump found. Try again later. If this doesn't help " .
                 "contact site administrator and/or OKAPI developers.");
 
         # Check consumer's quota
@@ -71,7 +71,7 @@ 
 
         $response = new OkapiHttpResponse();
         $response->content_type = $data['meta']['content_type'];
-        $response->content_disposition = 'attachment; filename="'.$data['meta']['public_filename'].'"';
+        $response->content_disposition = 'attachment; filename="' . $data['meta']['public_filename'] . '"';
         $response->stream_length = $data['meta']['compressed_size'];
         $response->body = fopen($data['meta']['filepath'], "rb");
         $response->allow_gzip = false;

Braces +10 added lines, -8 removed lines

@@ -49,9 +49,10 @@ 
         require_once('replicate_common.inc.php');
 
         $data = Cache::get("last_fulldump");
-        if ($data == null)
-            throw new BadRequest("No fulldump found. Try again later. If this doesn't help ".
+        if ($data == null) {
+                    throw new BadRequest("No fulldump found. Try again later. If this doesn't help ".
                 "contact site administrator and/or OKAPI developers.");
+        }
 
         # Check consumer's quota
 
@@ -59,14 +60,15 @@ 
         if ($please != 'true')
         {
             $not_good = 3 < self::count_calls($request->consumer->key, 30);
-            if ($not_good)
-                throw new BadRequest("Consumer's monthly quota exceeded. Try later or call with '&pleeaase=true'.");
-        }
-        else
+            if ($not_good) {
+                            throw new BadRequest("Consumer's monthly quota exceeded. Try later or call with '&pleeaase=true'.");
+            }
+        } else
         {
             $not_good = 5 < self::count_calls($request->consumer->key, 1);
-            if ($not_good)
-                throw new BadRequest("No more please. Seriously, dude...");
+            if ($not_good) {
+                            throw new BadRequest("No more please. Seriously, dude...");
+            }
         }
 
         $response = new OkapiHttpResponse();

htdocs/okapi/services/caches/formatters/gpx.php

Indentation +1 added lines, -1 removed lines

@@ -465,7 +465,7 @@
                 $ggz_entry['ratings'] = array();
                 $ratings_ref = &$ggz_entry['ratings'];
                 if (isset($cache_ref['rating'])){
-                   $ratings_ref['awesomeness'] = $cache_ref['rating'];
+                    $ratings_ref['awesomeness'] = $cache_ref['rating'];
                 }
                 $ratings_ref['difficulty'] = $cache_ref['difficulty'];
                 if (!isset($cache_ref['size'])) {

Spacing +13 added lines, -13 removed lines

@@ -96,7 +96,7 @@ 
 
         $langpref = $request->get_parameter('langpref');
         if (!$langpref) $langpref = "en";
-        $langpref .= "|".Settings::get('SITELANG');
+        $langpref .= "|" . Settings::get('SITELANG');
         foreach (array('ns_ground', 'ns_gsak', 'ns_ox', 'latest_logs', 'alt_wpts', 'mark_found') as $param)
         {
             $val = $request->get_parameter($param);
@@ -164,7 +164,7 @@ 
             else $protection_areas = 'none';
         }
         if (!in_array($protection_areas, array('none', 'desc:text')))
-            throw new InvalidParam('protection_areas',"'$protection_areas'");
+            throw new InvalidParam('protection_areas', "'$protection_areas'");
         $vars['protection_areas'] = $protection_areas;
 
         $tmp = $request->get_parameter('trackables');
@@ -194,7 +194,7 @@ 
         # Make sure location_source has prefix alt_wpt:
         if ($location_source != 'default-coords' && strncmp($location_source, 'alt_wpt:', 8) != 0)
         {
-            throw new InvalidParam('location_source', '\''.$location_source.'\'');
+            throw new InvalidParam('location_source', '\'' . $location_source . '\'');
         }
 
         # Make sure we have sufficient authorization
@@ -205,8 +205,8 @@ 
 
         # Which fields of the services/caches/geocaches method do we need?
 
-        $fields = 'code|name|location|date_created|url|type|status|size|size2|oxsize'.
-            '|difficulty|terrain|description|hint2|rating|owner|url|internal_id'.
+        $fields = 'code|name|location|date_created|url|type|status|size|size2|oxsize' .
+            '|difficulty|terrain|description|hint2|rating|owner|url|internal_id' .
             '|protection_areas|short_description';
         if ($vars['images'] != 'none')
             $fields .= "|images";
@@ -290,7 +290,7 @@ 
                     # database; OCPL stores attribute names in a different way and may use
                     # different names for equivalent attributes.
 
-                    $ocde_attrnames = Db::select_group_by('id',"
+                    $ocde_attrnames = Db::select_group_by('id', "
                         select id, name
                         from cache_attrib
                     ");
@@ -373,7 +373,7 @@ 
         $rs = Db::query("
             select uuid, user_id
             from user
-            where uuid in ('".implode("','", array_map('\okapi\Db::escape_string', array_keys($dict)))."')
+            where uuid in ('".implode("','", array_map('\okapi\Db::escape_string', array_keys($dict))) . "')
         ");
         while ($row = Db::fetch_assoc($rs))
             $dict[$row['uuid']] = $row['user_id'];
@@ -393,7 +393,7 @@ 
             {
                 foreach ($cache_ref['alt_wpts'] as $alt_wpt_key => $alt_wpt)
                 {
-                    if ('alt_wpt:'.$alt_wpt['type'] == $location_source)
+                    if ('alt_wpt:' . $alt_wpt['type'] == $location_source)
                     {
                         # Switch locations between primary wpt and alternate wpt.
                         # Also alter the cache name and make sure to append a proper
@@ -401,17 +401,17 @@ 
 
                         $original_location = $cache_ref['location'];
                         $cache_ref['location'] = $alt_wpt['location'];
-                        $cache_ref['name_2'] = $location_change_prefix.$cache_ref['name'];
+                        $cache_ref['name_2'] = $location_change_prefix . $cache_ref['name'];
                         if ($location_source == "alt_wpt:user-coords") {
                             # In case of "user-coords", replace the default warning with a custom-tailored one.
                             $cache_ref['warning_prefix'] = _(
-                                "<b>Geocache coordinates have been changed.</b> They have been replaced with ".
+                                "<b>Geocache coordinates have been changed.</b> They have been replaced with " .
                                 "your own custom coordinates which you have provided for this geocache."
                             );
                         } else {
                             # Default warning
                             $cache_ref['warning_prefix'] = _(
-                                "<b>Geocache coordinates have been changed.</b> Currently they ".
+                                "<b>Geocache coordinates have been changed.</b> Currently they " .
                                 "point to one of the alternate waypoints originally described as:"
                             ) . " " . $alt_wpt['description'];
                         }
@@ -421,7 +421,7 @@ 
                         if ($vars['alt_wpts'])
                         {
                             $cache_ref['alt_wpts'][] = array(
-                                'name' => $cache_ref['code'].'-DEFAULT-COORDS',
+                                'name' => $cache_ref['code'] . '-DEFAULT-COORDS',
                                 'location' => $original_location,
                                 'type' => 'default-coords',
                                 'type_name' => _("Original geocache location"),
@@ -464,7 +464,7 @@ 
 
                 $ggz_entry['ratings'] = array();
                 $ratings_ref = &$ggz_entry['ratings'];
-                if (isset($cache_ref['rating'])){
+                if (isset($cache_ref['rating'])) {
                    $ratings_ref['awesomeness'] = $cache_ref['rating'];
                 }
                 $ratings_ref['difficulty'] = $cache_ref['difficulty'];

Braces +87 added lines, -50 removed lines

@@ -89,24 +89,31 @@ 
         # $vars variable which we will use later in the GPS template.
 
         $cache_codes = $request->get_parameter('cache_codes');
-        if ($cache_codes === null) throw new ParamMissing('cache_codes');
+        if ($cache_codes === null) {
+            throw new ParamMissing('cache_codes');
+        }
 
         # Issue 106 requires us to allow empty list of cache codes to be passed into this method.
         # All of the queries below have to be ready for $cache_codes to be empty!
 
         $langpref = $request->get_parameter('langpref');
-        if (!$langpref) $langpref = "en";
+        if (!$langpref) {
+            $langpref = "en";
+        }
         $langpref .= "|".Settings::get('SITELANG');
         foreach (array('ns_ground', 'ns_gsak', 'ns_ox', 'latest_logs', 'alt_wpts', 'mark_found') as $param)
         {
             $val = $request->get_parameter($param);
-            if (!$val) $val = "false";
-            elseif (!in_array($val, array("true", "false")))
-                throw new InvalidParam($param);
+            if (!$val) {
+                $val = "false";
+            } elseif (!in_array($val, array("true", "false"))) {
+                            throw new InvalidParam($param);
+            }
             $vars[$param] = ($val == "true");
         }
-        if ($vars['latest_logs'] && (!$vars['ns_ground']))
-            throw new BadRequest("In order for 'latest_logs' to work you have to also include 'ns_ground' extensions.");
+        if ($vars['latest_logs'] && (!$vars['ns_ground'])) {
+                    throw new BadRequest("In order for 'latest_logs' to work you have to also include 'ns_ground' extensions.");
+        }
 
         $tmp = $request->get_parameter('my_notes');
         $vars['my_notes'] = array();
@@ -134,13 +141,18 @@ 
         }
 
         $images = $request->get_parameter('images');
-        if (!$images) $images = 'descrefs:nonspoilers';
-        if (!in_array($images, array('none', 'descrefs:thumblinks', 'descrefs:nonspoilers', 'descrefs:all', 'ox:all')))
-            throw new InvalidParam('images', "'$images'");
+        if (!$images) {
+            $images = 'descrefs:nonspoilers';
+        }
+        if (!in_array($images, array('none', 'descrefs:thumblinks', 'descrefs:nonspoilers', 'descrefs:all', 'ox:all'))) {
+                    throw new InvalidParam('images', "'$images'");
+        }
         $vars['images'] = $images;
 
         $tmp = $request->get_parameter('attrs');
-        if (!$tmp) $tmp = 'desc:text';
+        if (!$tmp) {
+            $tmp = 'desc:text';
+        }
         $tmp = explode("|", $tmp);
         $vars['attrs'] = array();
         foreach ($tmp as $elem)
@@ -148,10 +160,11 @@ 
             if ($elem == 'none') {
                 /* pass */
             } elseif (in_array($elem, array('desc:text', 'ox:tags', 'gc:attrs', 'gc_ocde:attrs'))) {
-                if ($elem == 'gc_ocde:attrs' && Settings::get('OC_BRANCH') != 'oc.de')
-                    $vars['attrs'][] = 'gc:attrs';
-                else
-                    $vars['attrs'][] = $elem;
+                if ($elem == 'gc_ocde:attrs' && Settings::get('OC_BRANCH') != 'oc.de') {
+                                    $vars['attrs'][] = 'gc:attrs';
+                } else {
+                                    $vars['attrs'][] = $elem;
+                }
             } else {
                 throw new InvalidParam('attrs', "Invalid list entry: '$elem'");
             }
@@ -160,27 +173,40 @@ 
         $protection_areas = $request->get_parameter('protection_areas');
         if (!$protection_areas || $protection_areas == 'desc:auto')
         {
-            if (Settings::get('OC_BRANCH') == 'oc.de') $protection_areas = 'desc:text';
-            else $protection_areas = 'none';
+            if (Settings::get('OC_BRANCH') == 'oc.de') {
+                $protection_areas = 'desc:text';
+            } else {
+                $protection_areas = 'none';
+            }
+        }
+        if (!in_array($protection_areas, array('none', 'desc:text'))) {
+                    throw new InvalidParam('protection_areas',"'$protection_areas'");
         }
-        if (!in_array($protection_areas, array('none', 'desc:text')))
-            throw new InvalidParam('protection_areas',"'$protection_areas'");
         $vars['protection_areas'] = $protection_areas;
 
         $tmp = $request->get_parameter('trackables');
-        if (!$tmp) $tmp = 'none';
-        if (!in_array($tmp, array('none', 'desc:list', 'desc:count')))
-            throw new InvalidParam('trackables', "'$tmp'");
+        if (!$tmp) {
+            $tmp = 'none';
+        }
+        if (!in_array($tmp, array('none', 'desc:list', 'desc:count'))) {
+                    throw new InvalidParam('trackables', "'$tmp'");
+        }
         $vars['trackables'] = $tmp;
 
         $tmp = $request->get_parameter('recommendations');
-        if (!$tmp) $tmp = 'none';
-        if (!in_array($tmp, array('none', 'desc:count')))
-            throw new InvalidParam('recommendations', "'$tmp'");
+        if (!$tmp) {
+            $tmp = 'none';
+        }
+        if (!in_array($tmp, array('none', 'desc:count'))) {
+                    throw new InvalidParam('recommendations', "'$tmp'");
+        }
         $vars['recommendations'] = $tmp;
 
         $lpc = $request->get_parameter('lpc');
-        if ($lpc === null) $lpc = 10; # will be checked in services/caches/geocaches call
+        if ($lpc === null) {
+            $lpc = 10;
+        }
+        # will be checked in services/caches/geocaches call
 
         $user_uuid = $request->get_parameter('user_uuid');
 
@@ -208,24 +234,32 @@ 
         $fields = 'code|name|location|date_created|url|type|status|size|size2|oxsize'.
             '|difficulty|terrain|description|hint2|rating|owner|url|internal_id'.
             '|protection_areas|short_description';
-        if ($vars['images'] != 'none')
-            $fields .= "|images";
-        if (count($vars['attrs']) > 0)
-            $fields .= "|attrnames|attr_acodes|needs_maintenance";
-        if ($vars['trackables'] == 'desc:list')
-            $fields .= "|trackables";
-        elseif ($vars['trackables'] == 'desc:count')
-            $fields .= "|trackables_count";
-        if ($vars['alt_wpts'] == 'true' || $location_source != 'default-coords')
-            $fields .= "|alt_wpts";
-        if ($vars['recommendations'] != 'none')
-            $fields .= "|recommendations|founds";
-        if (count($vars['my_notes']) > 0)
-            $fields .= "|my_notes";
-        if ($vars['latest_logs'])
-            $fields .= "|latest_logs";
-        if ($vars['mark_found'])
-            $fields .= "|is_found";
+        if ($vars['images'] != 'none') {
+                    $fields .= "|images";
+        }
+        if (count($vars['attrs']) > 0) {
+                    $fields .= "|attrnames|attr_acodes|needs_maintenance";
+        }
+        if ($vars['trackables'] == 'desc:list') {
+                    $fields .= "|trackables";
+        } elseif ($vars['trackables'] == 'desc:count') {
+                    $fields .= "|trackables_count";
+        }
+        if ($vars['alt_wpts'] == 'true' || $location_source != 'default-coords') {
+                    $fields .= "|alt_wpts";
+        }
+        if ($vars['recommendations'] != 'none') {
+                    $fields .= "|recommendations|founds";
+        }
+        if (count($vars['my_notes']) > 0) {
+                    $fields .= "|my_notes";
+        }
+        if ($vars['latest_logs']) {
+                    $fields .= "|latest_logs";
+        }
+        if ($vars['mark_found']) {
+                    $fields .= "|is_found";
+        }
 
         $vars['caches'] = OkapiServiceRunner::call(
             'services/caches/geocaches', new OkapiInternalRequest(
@@ -346,8 +380,9 @@ 
             {
                 foreach ($vars['caches'] as &$cache_ref)
                 {
-                    if ($cache_ref['needs_maintenance'])
-                        $cache_ref['attrnames'][] = 'Needs maintenance';
+                    if ($cache_ref['needs_maintenance']) {
+                                            $cache_ref['attrnames'][] = 'Needs maintenance';
+                    }
                 }
             }
         }
@@ -366,17 +401,19 @@ 
         foreach ($vars['caches'] as &$cache_ref)
         {
             $dict[$cache_ref['owner']['uuid']] = true;
-            if (isset($cache_ref['latest_logs']))
-                foreach ($cache_ref['latest_logs'] as &$log_ref)
+            if (isset($cache_ref['latest_logs'])) {
+                            foreach ($cache_ref['latest_logs'] as &$log_ref)
                     $dict[$log_ref['user']['uuid']] = true;
+            }
         }
         $rs = Db::query("
             select uuid, user_id
             from user
             where uuid in ('".implode("','", array_map('\okapi\Db::escape_string', array_keys($dict)))."')
         ");
-        while ($row = Db::fetch_assoc($rs))
-            $dict[$row['uuid']] = $row['user_id'];
+        while ($row = Db::fetch_assoc($rs)) {
+                    $dict[$row['uuid']] = $row['user_id'];
+        }
         $vars['user_uuid_to_internal_id'] = &$dict;
         unset($dict);
 

Unused Use Statements -2 removed lines

@@ -13,8 +13,6 @@
 use okapi\BadRequest;
 use okapi\OkapiInternalRequest;
 use okapi\OkapiServiceRunner;
-use okapi\OkapiAccessToken;
-use okapi\services\caches\search\SearchAssistant;
 use okapi\services\attrs\AttrHelper;
 
 class WebService

htdocs/okapi/services/caches/formatters/ggz.php

Spacing +3 added lines, -3 removed lines

@@ -19,7 +19,7 @@ 
 use \ZipArchive;
 use \Exception;
 
-require_once($GLOBALS['rootpath']."okapi/services/caches/formatters/gpx.php");
+require_once($GLOBALS['rootpath'] . "okapi/services/caches/formatters/gpx.php");
 
 class WebService
 {
@@ -43,7 +43,7 @@ 
         # Geocaching.com (groundspeak:) and Opencaching.com (ox:) extensions. It will
         # also include personal data (if the method was invoked using Level 3 Authentication).
 
-        $file_item_name = "data_".time()."_".rand(100000,999999).".gpx";
+        $file_item_name = "data_" . time() . "_" . rand(100000, 999999) . ".gpx";
         $ggz_file = array(
             'name' => $file_item_name,
             'crc32' => sprintf('%08X', crc32($gpx_result['gpx'])),
@@ -58,7 +58,7 @@ 
         $index_content = ob_get_clean();
 
         $response->zip->FileAdd("index/com/garmin/geocaches/v0/index.xml", $index_content);
-        $response->zip->FileAdd("data/".$file_item_name, $gpx_result['gpx']);
+        $response->zip->FileAdd("data/" . $file_item_name, $gpx_result['gpx']);
 
         unset($gpx_result);
         unset($index_content);