for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Oc\Import\Logs\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Response;
use Twig_Environment;
/**
* @Route(service="Oc\Import\Logs\Controller\ImportLogsController")
*/
class ImportLogsController extends Controller
{
* @var Twig_Environment
private $twig;
public function __construct(Twig_Environment $twig)
$this->twig = $twig;
}
* @Route(path="/import/logs")
public function indexAction()
error_reporting(E_ALL);
ini_set('display_errors', 'on');
$xmlContent = file_get_contents(__DIR__ . '/../../../../../../tests/fixtures/ImportLogs/geocaching.gpx');
$xmlContent = str_replace(
['<groundspeak:', '</groundspeak:'],
['<', '</'],
$xmlContent
);
$xml = new \SimpleXMLElement($xmlContent);
$xmlArray = json_decode(json_encode($xml), true);
$xmlArray
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$response = new Response();
$response->setContent(
$this->twig->render(
'importer/logs.html.twig',
['imports' => $xml]
)
return $response;
OpencachingDeutschland /
oc-server3
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.