Passed
Pull Request — development (#395)
by Thomas
08:57
created
htdocs/lib2/logic/attribute.class.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -23,6 +23,10 @@
 block discarded – undo
23 23
         return self::getAttrbutesListArrayInternal($cacheId, false, $firstLetterUppercase);
24 24
     }
25 25
 
26
+    /**
27
+     * @param boolean $bOnlySelectable
28
+     * @param boolean $firstLetterUppercase
29
+     */
26 30
     public static function getAttrbutesListArrayInternal($cacheId, $bOnlySelectable, $firstLetterUppercase)
27 31
     {
28 32
         global $opt;
Please login to merge, or discard this patch.
htdocs/lib2/logic/coordinate.class.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -303,6 +303,10 @@  discard block
 block discarded – undo
303 303
         return 'R ' . floor($result[0]) . ' H ' . floor($result[1]);
304 304
     }
305 305
 
306
+    /**
307
+     * @param integer $bw
308
+     * @param integer $lw
309
+     */
306 310
     public function wgs2pot($bw, $lw)
307 311
     {
308 312
         /* Copyright (c) 2006, HELMUT H. HEIMEIER
@@ -602,6 +606,9 @@  discard block
 block discarded – undo
602 606
         ];
603 607
     }
604 608
 
609
+    /**
610
+     * @param string $name
611
+     */
605 612
     public static function parseRequestLat($name)
606 613
     {
607 614
         if (!isset($_REQUEST[$name . 'NS']) || !isset($_REQUEST[$name . 'Lat']) || !isset($_REQUEST[$name . 'LatMin'])) {
@@ -620,6 +627,9 @@  discard block
 block discarded – undo
620 627
         return $lat;
621 628
     }
622 629
 
630
+    /**
631
+     * @param string $name
632
+     */
623 633
     public static function parseRequestLon($name)
624 634
     {
625 635
         if (!isset($_REQUEST[$name . 'EW']) || !isset($_REQUEST[$name . 'Lon']) || !isset($_REQUEST[$name . 'LonMin'])) {
Please login to merge, or discard this patch.
htdocs/lib2/logic/sitemapxml.class.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -46,6 +46,11 @@  discard block
 block discarded – undo
46 46
     /* sChaneFreq = {always, hourly, daily, weekly, monthly, yearly, never}
47 47
      * nPriority  = {0.0 to 1.0}
48 48
      */
49
+
50
+    /**
51
+     * @param string $sFile
52
+     * @param integer $dLastMod
53
+     */
49 54
     public function write($sFile, $dLastMod, $sChangeFreq = false, $nPriority = 0.5)
50 55
     {
51 56
         if ($sChangeFreq == false) {
@@ -62,6 +67,9 @@  discard block
 block discarded – undo
62 67
         $this->writeInternal($sXML);
63 68
     }
64 69
 
70
+    /**
71
+     * @param string $str
72
+     */
65 73
     public function writeInternal($str)
66 74
     {
67 75
         global $opt;
Please login to merge, or discard this patch.
htdocs/lib2/Net/IDNA2.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2760,7 +2760,7 @@  discard block
 block discarded – undo
2760 2760
      *
2761 2761
      * @param int $d One digit to encode
2762 2762
      *
2763
-     * @return char  Encoded digit
2763
+     * @return string  Encoded digit
2764 2764
      * @access private
2765 2765
      */
2766 2766
     private function _encodeDigit($d)
@@ -2771,7 +2771,7 @@  discard block
 block discarded – undo
2771 2771
     /**
2772 2772
      * Decode a certain digit.
2773 2773
      *
2774
-     * @param char $cp One digit (character) to decode
2774
+     * @param string $cp One digit (character) to decode
2775 2775
      *
2776 2776
      * @return int     Decoded digit
2777 2777
      * @access private
@@ -2785,7 +2785,7 @@  discard block
 block discarded – undo
2785 2785
     /**
2786 2786
      * Do Nameprep according to RFC3491 and RFC3454.
2787 2787
      *
2788
-     * @param array $input Unicode Characters
2788
+     * @param string $input Unicode Characters
2789 2789
      *
2790 2790
      * @return string      Unicode Characters, Nameprep'd
2791 2791
      * @throws Exception
@@ -2885,7 +2885,7 @@  discard block
 block discarded – undo
2885 2885
      *
2886 2886
      * @param integer $char 32bit UCS4 code point
2887 2887
      *
2888
-     * @return array        Either Hangul Syllable decomposed or original 32bit
2888
+     * @return integer[]        Either Hangul Syllable decomposed or original 32bit
2889 2889
      *                      value as one value array
2890 2890
      * @access private
2891 2891
      */
Please login to merge, or discard this patch.
htdocs/util/notification/run_notify.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -197,6 +197,9 @@
 block discarded – undo
197 197
     return 0;
198 198
 }
199 199
 
200
+/**
201
+ * @param string $domain
202
+ */
200 203
 function is_existent_maildomain($domain)
201 204
 {
202 205
     $smtp_serverlist = [];
Please login to merge, or discard this patch.
htdocs/restorecaches.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1011,7 +1011,7 @@
 block discarded – undo
1011 1011
                             }
1012 1012
                             $logs_restored = true;
1013 1013
                         }
1014
-                       // if it was not already restored by a later restore operation ...
1014
+                        // if it was not already restored by a later restore operation ...
1015 1015
                     } elseif (sql_value("SELECT `id` FROM `cache_logs` WHERE `id`='&1'", 0, $revert_logid) == 0) {
1016 1016
                         // id, uuid, date_created and last_modified are set automatically;
1017 1017
                         // picture will be updated automatically on picture-restore
Please login to merge, or discard this patch.
htdocs/lib2/logic/logpics.class.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         global $login;
31 31
 
32 32
         $fields =
33
-          "`pics`.`uuid` AS `pic_uuid`,
33
+            "`pics`.`uuid` AS `pic_uuid`,
34 34
            `pics`.`url` AS `pic_url`,
35 35
            `pics`.`title`,
36 36
            `pics`.`date_created`,
Please login to merge, or discard this patch.
htdocs/lib2/error.inc.php 1 patch
Indentation   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -7,34 +7,34 @@
 block discarded – undo
7 7
  *  Common error messages
8 8
  ***************************************************************************/
9 9
 
10
- define('ERROR_UNKNOWN', 1000);
11
- define('ERROR_TEMPLATE_NOT_FOUND', 1001);
12
- define('ERROR_COMPILATION_FAILED', 1002);
13
- define('ERROR_NO_ACCESS', 1003);
14
- define('ERROR_INVALID_OPERATION', 1004);
15
- define('ERROR_LOGIN_REQUIRED', 1005);
16
- define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006);
17
- define('ERROR_NO_COOKIES', 1007);
18
- define('ERROR_ALREADY_LOGGEDIN', 1008);
19
- define('ERROR_USER_NOT_ACTIVE', 1009);
20
- define('ERROR_USER_NO_EMAIL', 1010);
21
- define('ERROR_CACHE_NOT_PUBLISHED', 1011);
22
- define('ERROR_CACHE_LOCKED', 1012);
10
+    define('ERROR_UNKNOWN', 1000);
11
+    define('ERROR_TEMPLATE_NOT_FOUND', 1001);
12
+    define('ERROR_COMPILATION_FAILED', 1002);
13
+    define('ERROR_NO_ACCESS', 1003);
14
+    define('ERROR_INVALID_OPERATION', 1004);
15
+    define('ERROR_LOGIN_REQUIRED', 1005);
16
+    define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006);
17
+    define('ERROR_NO_COOKIES', 1007);
18
+    define('ERROR_ALREADY_LOGGEDIN', 1008);
19
+    define('ERROR_USER_NOT_ACTIVE', 1009);
20
+    define('ERROR_USER_NO_EMAIL', 1010);
21
+    define('ERROR_CACHE_NOT_PUBLISHED', 1011);
22
+    define('ERROR_CACHE_LOCKED', 1012);
23 23
 
24
- define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013);
25
- define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014);
26
- define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015);
24
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013);
25
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014);
26
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015);
27 27
  
28
- define('ERROR_DB_COULD_NOT_RECONNECT', 1016);
29
- define('ERROR_DB_NO_ROOT', 1017);
28
+    define('ERROR_DB_COULD_NOT_RECONNECT', 1016);
29
+    define('ERROR_DB_NO_ROOT', 1017);
30 30
 
31
- define('ERROR_USER_NOT_EXISTS', 1018);
32
- define('ERROR_CACHE_NOT_EXISTS', 1019);
33
- define('ERROR_CACHELOG_NOT_EXISTS', 1020);
34
- define('ERROR_PICTURE_NOT_EXISTS', 1021);
31
+    define('ERROR_USER_NOT_EXISTS', 1018);
32
+    define('ERROR_CACHE_NOT_EXISTS', 1019);
33
+    define('ERROR_CACHELOG_NOT_EXISTS', 1020);
34
+    define('ERROR_PICTURE_NOT_EXISTS', 1021);
35 35
 
36
- define('ERROR_UPLOAD_ERR_NO_FILE', 1022);
37
- define('ERROR_UPLOAD_ERR_SIZE', 1023);
38
- define('ERROR_UPLOAD_ERR_TYPE', 1024);
39
- define('ERROR_UPLOAD_UNKNOWN', 1025);
40
- define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026);
36
+    define('ERROR_UPLOAD_ERR_NO_FILE', 1022);
37
+    define('ERROR_UPLOAD_ERR_SIZE', 1023);
38
+    define('ERROR_UPLOAD_ERR_TYPE', 1024);
39
+    define('ERROR_UPLOAD_UNKNOWN', 1025);
40
+    define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026);
Please login to merge, or discard this patch.
htdocs/lang/de/ocstyle/newcache.inc.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -14,40 +14,40 @@
 block discarded – undo
14 14
  * set template specific language variables
15 15
  ****************************************************************************/
16 16
 
17
- $firstcache_note = t('If this is your first cache on %1, be sure to check out the <a href="articles.php?page=cacheinfo">description</a> of the individual fields.');
18
-
19
- $submit = t('Submit cache');
20
- $default_country = t('EN');
21
- $default_lang = t('EN');
22
- $show_all = t('Show all');
23
- $default_NS = 'N';
24
- $default_EW = 'E';
25
- $date_time_format_message = '&nbsp;' . t('Format:&nbsp;DD-MM-YYYY');
26
-
27
- $error_general = "<tr><td class='error' colspan='2'><b>" . t('Some errors occured, please check the marked fields.') . "</b></td></tr>";
28
- $error_long_not_ok = '<span class="errormsg">' . t('Your chosen coordinated are invalid') . '</span>';
29
- $error_lat_not_ok = $error_long_not_ok . "<br />";
30
- $error_duplicate_coords = '<span class="errormsg">' . t('Another cache (<a href="viewcache.php?wp=%1">%1</a>) exists at these coords. Maybe you pressed "submit cache" twice. To publish a cache with identical coords, enter other coords first, then edit the listing and change coords.') . '</span>';
31
- $time_not_ok_message = '<span class="errormsg">' . t('The entered time is invalid.') . '</span>';
32
- $way_length_not_ok_message = '<span class="errormsg">' . t('The entered distance is invalid, Format: aa.aaa') . '</span>';
33
- $date_not_ok_message = '<span class="errormsg">' . t('Invalid date, format:DD-MM-JJJJ') . '</span>';
34
- $name_not_ok_message = '&nbsp;<span class="errormsg">' . t('Cachename is invalid') . '</span>';
35
- $tos_not_ok_message = '<br/><span class="errormsg">' . t('The cache can only be adopted if you agree our terms of use.') . '</span>';
36
- $type_not_ok_message = '&nbsp;<span class="errormsg">' . t('No cache-type is chosen.') . '</span>';
37
- $size_not_ok_message = '&nbsp;<span class="errormsg">' . t('No cache-size is chosen.') . '</span>';
38
- $diff_not_ok_message = '&nbsp;<span class="errormsg">' . t('Choose both valuations!') . '</span>';
39
- $sizemismatch_message = '&nbsp;<span class="errormsg">' . t('For virtual and webcam caches, the cache size has to be -no container-!') . '</span>';
40
- $safari_not_allowed_message = '<span class="errormsg">' . t('Only virtual caches can be safari caches.') . '</span>';
41
- $bad_wpgc_message = '<span class="errormsg">' . t('GC waypoint is invalid, must be GCxxxxx') . '</span>';
42
-
43
- $cache_submitted = t('Your cache is successfully added to the database. You will be redirected to the cache page, now.');
44
-
45
- $sel_message = t('Select');
46
-
47
- $cache_attrib_js = "new Array({id}, {selected}, '{img_undef}', '{img_large}')";
48
- $cache_attrib_pic = '<img id="attr{attrib_id}" src="{attrib_pic}" border="0" onmousedown="toggleAttr({attrib_id})" onmouseover="Tip(\'{html_desc}\', TITLE, \'{name}\', TITLEBGCOLOR, \'{color}\', TITLEFONTCOLOR, \'#000000\', BGCOLOR, \'#FFFFFF\', BORDERCOLOR, \'{color}\', CLICKCLOSE, true, DELAY, 0, FADEIN, false, FADEOUT, false, FONTCOLOR, \'#000080\', WIDTH, 500)" onmouseout="UnTip()" />&nbsp;';
49
-
50
- $cache_attrib_group =
17
+    $firstcache_note = t('If this is your first cache on %1, be sure to check out the <a href="articles.php?page=cacheinfo">description</a> of the individual fields.');
18
+
19
+    $submit = t('Submit cache');
20
+    $default_country = t('EN');
21
+    $default_lang = t('EN');
22
+    $show_all = t('Show all');
23
+    $default_NS = 'N';
24
+    $default_EW = 'E';
25
+    $date_time_format_message = '&nbsp;' . t('Format:&nbsp;DD-MM-YYYY');
26
+
27
+    $error_general = "<tr><td class='error' colspan='2'><b>" . t('Some errors occured, please check the marked fields.') . "</b></td></tr>";
28
+    $error_long_not_ok = '<span class="errormsg">' . t('Your chosen coordinated are invalid') . '</span>';
29
+    $error_lat_not_ok = $error_long_not_ok . "<br />";
30
+    $error_duplicate_coords = '<span class="errormsg">' . t('Another cache (<a href="viewcache.php?wp=%1">%1</a>) exists at these coords. Maybe you pressed "submit cache" twice. To publish a cache with identical coords, enter other coords first, then edit the listing and change coords.') . '</span>';
31
+    $time_not_ok_message = '<span class="errormsg">' . t('The entered time is invalid.') . '</span>';
32
+    $way_length_not_ok_message = '<span class="errormsg">' . t('The entered distance is invalid, Format: aa.aaa') . '</span>';
33
+    $date_not_ok_message = '<span class="errormsg">' . t('Invalid date, format:DD-MM-JJJJ') . '</span>';
34
+    $name_not_ok_message = '&nbsp;<span class="errormsg">' . t('Cachename is invalid') . '</span>';
35
+    $tos_not_ok_message = '<br/><span class="errormsg">' . t('The cache can only be adopted if you agree our terms of use.') . '</span>';
36
+    $type_not_ok_message = '&nbsp;<span class="errormsg">' . t('No cache-type is chosen.') . '</span>';
37
+    $size_not_ok_message = '&nbsp;<span class="errormsg">' . t('No cache-size is chosen.') . '</span>';
38
+    $diff_not_ok_message = '&nbsp;<span class="errormsg">' . t('Choose both valuations!') . '</span>';
39
+    $sizemismatch_message = '&nbsp;<span class="errormsg">' . t('For virtual and webcam caches, the cache size has to be -no container-!') . '</span>';
40
+    $safari_not_allowed_message = '<span class="errormsg">' . t('Only virtual caches can be safari caches.') . '</span>';
41
+    $bad_wpgc_message = '<span class="errormsg">' . t('GC waypoint is invalid, must be GCxxxxx') . '</span>';
42
+
43
+    $cache_submitted = t('Your cache is successfully added to the database. You will be redirected to the cache page, now.');
44
+
45
+    $sel_message = t('Select');
46
+
47
+    $cache_attrib_js = "new Array({id}, {selected}, '{img_undef}', '{img_large}')";
48
+    $cache_attrib_pic = '<img id="attr{attrib_id}" src="{attrib_pic}" border="0" onmousedown="toggleAttr({attrib_id})" onmouseover="Tip(\'{html_desc}\', TITLE, \'{name}\', TITLEBGCOLOR, \'{color}\', TITLEFONTCOLOR, \'#000000\', BGCOLOR, \'#FFFFFF\', BORDERCOLOR, \'{color}\', CLICKCLOSE, true, DELAY, 0, FADEIN, false, FADEOUT, false, FONTCOLOR, \'#000080\', WIDTH, 500)" onmouseout="UnTip()" />&nbsp;';
49
+
50
+    $cache_attrib_group =
51 51
     '<div class="attribgroup"><table cellspacing="0" style="display:inline;border-spacing:0px;">
52 52
          <tr><td bgcolor="{color}" style="line-height:9px;padding-top:2px;margin:0 0 0 0;border-left:1px solid gray;border-right:1px solid gray;border-top:1px solid gray;"><font size="1">{name}</font></td></tr>
53 53
          <tr><td bgcolor="#F8F8F8" style="margin:0 0 0 0;border-left:1px solid gray;border-right:1px solid gray;border-bottom:1px solid gray;">{attribs}</td></tr>
Please login to merge, or discard this patch.