OpencachingDeutschland / oc-server3

htdocs/lib2/util.inc.php

Doc Comments +2 added lines, -2 removed lines

@@ -99,7 +99,7 @@ 
 /**
  * @param $filename
  * @param $maxLength
- * @return bool|string
+ * @return false|string
  */
 function read_file($filename, $maxLength = 4096)
 {
@@ -265,7 +265,7 @@ 
  * format number with 1000s dots
  *
  * @param $n
- * @return mixed|string
+ * @return string
  */
 function number1000($n)
 {

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  */
 function is_valid_email_address($eMail)
 {
-    return (int) ($eMail === filter_var($eMail, FILTER_VALIDATE_EMAIL));
+    return (int)($eMail === filter_var($eMail, FILTER_VALIDATE_EMAIL));
 }
 
 /**

htdocs/viewcache.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
 // get cacheid
 $cacheid = 0;
 if (isset($_REQUEST['cacheid'])) {
-    $cacheid = (int) $_REQUEST['cacheid'];
+    $cacheid = (int)$_REQUEST['cacheid'];
 } else {
     if (isset($_REQUEST['uuid'])) {
         $cacheid = cache::cacheIdFromUUID($_REQUEST['uuid']);

htdocs/lang/de/ocstyle/main.tpl.php

Spacing +3 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
 <?php
 foreach ($opt['template']['locales'] as $k => $lang) {
     if ($lang['status'] == OC_LOCALE_ACTIVE) {
-        echo '<a style="text-decoration: none;" href="'.$langUrl . $k . '"><img src="' . $lang['flag'] .
+        echo '<a style="text-decoration: none;" href="' . $langUrl . $k . '"><img src="' . $lang['flag'] .
             '" alt="' . $lang['name'] . '" title="' . $lang['name'] . '" width="24px" height="18px" /></a> ';
     }
 }
@@ -184,7 +184,7 @@ 
                                         }
                                         $nLastGroup = $tpl_usercountries[$i]['group'];
 
-                                        echo '<option value="' . htmlspecialchars($tpl_usercountries[$i]['country'], ENT_COMPAT, 'UTF-8') . '"' . (($sUserCountry==$tpl_usercountries[$i]['country']) ? ' selected="selected"' : '') . '>' . htmlspecialchars($tpl_usercountries[$i]['name'], ENT_COMPAT, 'UTF-8') . '</option>';
+                                        echo '<option value="' . htmlspecialchars($tpl_usercountries[$i]['country'], ENT_COMPAT, 'UTF-8') . '"' . (($sUserCountry == $tpl_usercountries[$i]['country']) ? ' selected="selected"' : '') . '>' . htmlspecialchars($tpl_usercountries[$i]['name'], ENT_COMPAT, 'UTF-8') . '</option>';
                                     }
 ?>
                                 </select>&nbsp;
@@ -345,7 +345,7 @@ 
             </div> <!-- page-container-1 -->
 
         </div> <!-- overall -->
-        <?php if($opt['tracking']['googleAnalytics']) { ?>
+        <?php if ($opt['tracking']['googleAnalytics']) { ?>
             <script type="text/javascript">
                 // Set to the same value as the web property used on the site
                 var gaProperty = '<?= $opt['tracking']['googleAnalytics']; ?>';

htdocs/lib2/error.inc.php

Indentation +28 added lines, -28 removed lines

@@ -6,36 +6,36 @@
  *  Common error messages
  ***************************************************************************/
 
- define('ERROR_UNKNOWN', 1000);
- define('ERROR_TEMPLATE_NOT_FOUND', 1001);
- define('ERROR_COMPILATION_FAILED', 1002);
- define('ERROR_NO_ACCESS', 1003);
- define('ERROR_INVALID_OPERATION', 1004);
- define('ERROR_LOGIN_REQUIRED', 1005);
- define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006);
- define('ERROR_NO_COOKIES', 1007);
- define('ERROR_ALREADY_LOGGEDIN', 1008);
- define('ERROR_USER_NOT_ACTIVE', 1009);
- define('ERROR_USER_NO_EMAIL', 1010);
- define('ERROR_CACHE_NOT_PUBLISHED', 1011);
- define('ERROR_CACHE_LOCKED', 1012);
+    define('ERROR_UNKNOWN', 1000);
+    define('ERROR_TEMPLATE_NOT_FOUND', 1001);
+    define('ERROR_COMPILATION_FAILED', 1002);
+    define('ERROR_NO_ACCESS', 1003);
+    define('ERROR_INVALID_OPERATION', 1004);
+    define('ERROR_LOGIN_REQUIRED', 1005);
+    define('ERROR_MAIL_TEMPLATE_NOT_FOUND', 1006);
+    define('ERROR_NO_COOKIES', 1007);
+    define('ERROR_ALREADY_LOGGEDIN', 1008);
+    define('ERROR_USER_NOT_ACTIVE', 1009);
+    define('ERROR_USER_NO_EMAIL', 1010);
+    define('ERROR_CACHE_NOT_PUBLISHED', 1011);
+    define('ERROR_CACHE_LOCKED', 1012);
 
- define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013);
- define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014);
- define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015);
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_FORMAT', 1013);
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_MANY', 1014);
+    define('ERROR_SEARCHPLUGIN_WAYPOINT_NOTFOUND', 1015);
  
- define('ERROR_DB_COULD_NOT_RECONNECT', 1016);
- define('ERROR_DB_NO_ROOT', 1017);
+    define('ERROR_DB_COULD_NOT_RECONNECT', 1016);
+    define('ERROR_DB_NO_ROOT', 1017);
 
- define('ERROR_USER_NOT_EXISTS', 1018);
- define('ERROR_CACHE_NOT_EXISTS', 1019);
- define('ERROR_CACHELOG_NOT_EXISTS', 1020);
- define('ERROR_PICTURE_NOT_EXISTS', 1021);
+    define('ERROR_USER_NOT_EXISTS', 1018);
+    define('ERROR_CACHE_NOT_EXISTS', 1019);
+    define('ERROR_CACHELOG_NOT_EXISTS', 1020);
+    define('ERROR_PICTURE_NOT_EXISTS', 1021);
 
- define('ERROR_UPLOAD_ERR_NO_FILE', 1022);
- define('ERROR_UPLOAD_ERR_SIZE', 1023);
- define('ERROR_UPLOAD_ERR_TYPE', 1024);
- define('ERROR_UPLOAD_UNKNOWN', 1025);
- define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026);
+    define('ERROR_UPLOAD_ERR_NO_FILE', 1022);
+    define('ERROR_UPLOAD_ERR_SIZE', 1023);
+    define('ERROR_UPLOAD_ERR_TYPE', 1024);
+    define('ERROR_UPLOAD_UNKNOWN', 1025);
+    define('ERROR_UPLOAD_ERR_BAD_FORMAT', 1026);
 
- define('ERROR_WRONG_NODE', 1027);
+    define('ERROR_WRONG_NODE', 1027);

htdocs/picture.php

Spacing +2 added lines, -2 removed lines

@@ -86,7 +86,7 @@ 
     } else {
         $position = PHP_INT_MAX;
     }
-    $position = min($position, $allpics ? $allpics[count($allpics)-1]['seq'] + 1 : 1);
+    $position = min($position, $allpics ? $allpics[count($allpics) - 1]['seq'] + 1 : 1);
 
     // uploaded file ok?
     if (isset($_REQUEST['ok'])) { // Ocprop
@@ -233,7 +233,7 @@ 
     }
     $tpl->assign('allpics', $allpics);
     $tpl->assign('position', $position);
-    $tpl->assign('appendseq', $allpics ? $allpics[count($allpics)-1]['seq']+1 : 1);
+    $tpl->assign('appendseq', $allpics ? $allpics[count($allpics) - 1]['seq'] + 1 : 1);
 }
 
 $rsCache = sql("SELECT `wp_oc`, `name` FROM `caches` WHERE `cache_id`='&1'", $picture->getCacheId());

htdocs/lib2/edithelper.inc.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
             // mode switch from plain text to HTML editor => convert HTML special chars
             $text = nl2br(htmlspecialchars($text));
             // .. and smilies
-            $text = ' ' . $text . ' ';   // see Redmine #1103
+            $text = ' ' . $text . ' '; // see Redmine #1103
             $text = str_replace($smiley['text'], $smiley['spaced_image'], $text);
             if (substr($text, 0, 1) == ' ') {
                 $text = substr($text, 1);
@@ -59,7 +59,7 @@ 
             // convert to HTML for storing to database
             // also implemented in okapi/services/logs/submit.php
             $text = nl2br(htmlspecialchars($text, ENT_COMPAT, 'UTF-8'));
-            $text = str_replace('  ', '  ', $text);   // can produce new '  ' ('  ' + ' ')
+            $text = str_replace('  ', '  ', $text); // can produce new '  ' ('  ' + ' ')
             $text = str_replace('  ', '  ', $text);
         } else {
             // mode switch from HTML editor to plain text, or decode HTML-encoded plain text

htdocs/myhome.php

Spacing +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
     $allpics = 'ownlogs';
 }
 if ($allpics == 'ownlogs' || $allpics == 'owncaches') {
-    $gallery =  ($allpics == 'ownlogs' ? LogPics::FOR_OWNLOGS_GALLERY : LogPics::FOR_OWNCACHES_GALLERY);
+    $gallery = ($allpics == 'ownlogs' ? LogPics::FOR_OWNLOGS_GALLERY : LogPics::FOR_OWNCACHES_GALLERY);
     $all_pictures = LogPics::get($gallery);
     LogPics::setPaging($gallery, 0, 0, "myhome.php?allpics=" . $allpics);
 } else {

htdocs/src/Oc/Translation/CrowdinImport.php

Doc Comments +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     }
 
     /**
-     * @param $path
+     * @param string $path
      * @return TranslationStruct[]
      */
     private function readCrowdinCsv($path)

htdocs/src/Oc/Postfix/JournalLogs.php

Spacing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
                     $cursor[$key] = $value;
                 }
 
-                $logEntry->id = (int) hexdec($cursor['i']);
+                $logEntry->id = (int)hexdec($cursor['i']);
 
                 $timeStamp = $entry['__REALTIME_TIMESTAMP'];
                 $logEntry->created = \DateTimeImmutable::createFromFormat(