CacheListBookmarksRepository - Code Metrics - Inspection of "remove google maps type" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — next ( 01f675...c3ca23 )

by Thomas

created 2018-09-03 20:20 UTC

CacheListBookmarksRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	188
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
dl	188
loc	188
rs	10
c	0
b	0
f	0
wmc	21
lcom	1
cbo	7

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	fetchAll()	21	21	3
A	fetchOneBy()	23	23	4
A	fetchBy()	28	28	5
A	create()	17	17	2
A	update()	16	16	2
A	remove()	15	15	2
A	getDatabaseArrayFromEntity()	8	8	1
A	getEntityFromDatabaseArray()	9	9	1

How to fix Duplicated Code

<?php

use Doctrine\DBAL\Connection;
use Oc\Repository\Exception\RecordAlreadyExistsException;
use Oc\Repository\Exception\RecordNotFoundException;
use Oc\Repository\Exception\RecordNotPersistedException;
use Oc\Repository\Exception\RecordsNotFoundException;

class CacheListBookmarksRepository

{
    const TABLE = 'cache_list_bookmarks';

    /** @var Connection */
    private $connection;

    public function __construct(Connection $connection)
    {
        $this->connection = $connection;
    }

    /**
     * @return GeoCacheListBookmarksEntity[]
     */
    public function fetchAll()
    {
        $statement = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE)
            ->execute();

        $result = $statement->fetchAll();

        if ($statement->rowCount() === 0) {
            throw new RecordsNotFoundException('No records found');
        }

        $records = [];

        foreach ($result as $item) {
            $records[] = $this->getEntityFromDatabaseArray($item);
        }

        return $records;
    }

    /**
     * @param array $where
     * @return GeoCacheListBookmarksEntity
     */
    public function fetchOneBy(array $where = [])
    {
        $queryBuilder = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE)
            ->setMaxResults(1);

        if (count($where) > 0) {
            foreach ($where as $column => $value) {
                $queryBuilder->andWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
            }
        }

        $statement = $queryBuilder->execute();

        $result = $statement->fetch();

        if ($statement->rowCount() === 0) {
            throw new RecordNotFoundException('Record with given where clause not found');
        }

        return $this->getEntityFromDatabaseArray($result);
    }

    /**
     * @param array $where
     * @return GeoCacheListBookmarksEntity[]
     */
    public function fetchBy(array $where = [])
    {
        $queryBuilder = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE);

        if (count($where) > 0) {
            foreach ($where as $column => $value) {
                $queryBuilder->andWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
            }
        }

        $statement = $queryBuilder->execute();

        $result = $statement->fetchAll();

        if ($statement->rowCount() === 0) {
            throw new RecordsNotFoundException('No records with given where clause found');
        }

        $entities = [];

        foreach ($result as $item) {
            $entities[] = $this->getEntityFromDatabaseArray($item);
        }

        return $entities;
    }

    /**
     * @param GeoCacheListBookmarksEntity $entity
     * @return GeoCacheListBookmarksEntity
     */
    public function create(GeoCacheListBookmarksEntity $entity)
    {
        if (!$entity->isNew()) {
            throw new RecordAlreadyExistsException('The entity does already exist.');
        }

        $databaseArray = $this->getDatabaseArrayFromEntity($entity);

        $this->connection->insert(
            self::TABLE,
            $databaseArray
        );

        $entity->cacheListId = (int) $this->connection->lastInsertId();

        return $entity;
    }

    /**
     * @param GeoCacheListBookmarksEntity $entity
     * @return GeoCacheListBookmarksEntity
     */
    public function update(GeoCacheListBookmarksEntity $entity)
    {
        if ($entity->isNew()) {
            throw new RecordNotPersistedException('The entity does not exist.');
        }

        $databaseArray = $this->getDatabaseArrayFromEntity($entity);

        $this->connection->update(
            self::TABLE,
            $databaseArray,
            ['cache_list_id' => $entity->cacheListId]
        );

        return $entity;
    }

    /**
     * @param GeoCacheListBookmarksEntity $entity
     * @return GeoCacheListBookmarksEntity
     */
    public function remove(GeoCacheListBookmarksEntity $entity)
    {
        if ($entity->isNew()) {
            throw new RecordNotPersistedException('The entity does not exist.');
        }

        $this->connection->delete(
            self::TABLE,
            ['cache_list_id' => $entity->cacheListId]
        );

        $entity->cacheId = null;


        return $entity;
    }

    /**
     * @param GeoCacheListBookmarksEntity $entity
     * @return []

     */
    public function getDatabaseArrayFromEntity(GeoCacheListBookmarksEntity $entity)
    {
        return [
            'cache_list_id' => $entity->cacheListId,
            'user_id' => $entity->userId,
            'password' => $entity->password,
        ];
    }

    /**
     * @param array $data
     * @return GeoCacheListBookmarksEntity
     */
    public function getEntityFromDatabaseArray(array $data)
    {
        $entity = new GeoCacheListBookmarksEntity();
        $entity->cacheListId = (int) $data['cache_list_id'];
        $entity->userId = (int) $data['user_id'];
        $entity->password = (string) $data['password'];

        return $entity;
    }
}


1		<?php
2
3		use Doctrine\DBAL\Connection;
4		use Oc\Repository\Exception\RecordAlreadyExistsException;
5		use Oc\Repository\Exception\RecordNotFoundException;
6		use Oc\Repository\Exception\RecordNotPersistedException;
7		use Oc\Repository\Exception\RecordsNotFoundException;
8
9	View Code Duplication	class CacheListBookmarksRepository
		0 ignored issues – show Duplication introduced 2018-08-10 14:46 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		const TABLE = 'cache_list_bookmarks';
12
13		/** @var Connection */
14		private $connection;
15
16		public function __construct(Connection $connection)
17		{
18		$this->connection = $connection;
19		}
20
21		/**
22		* @return GeoCacheListBookmarksEntity[]
23		*/
24		public function fetchAll()
25		{
26		$statement = $this->connection->createQueryBuilder()
27		->select('*')
28		->from(self::TABLE)
29		->execute();
30
31		$result = $statement->fetchAll();
32
33		if ($statement->rowCount() === 0) {
34		throw new RecordsNotFoundException('No records found');
35		}
36
37		$records = [];
38
39		foreach ($result as $item) {
40		$records[] = $this->getEntityFromDatabaseArray($item);
41		}
42
43		return $records;
44		}
45
46		/**
47		* @param array $where
48		* @return GeoCacheListBookmarksEntity
49		*/
50		public function fetchOneBy(array $where = [])
51		{
52		$queryBuilder = $this->connection->createQueryBuilder()
53		->select('*')
54		->from(self::TABLE)
55		->setMaxResults(1);
56
57		if (count($where) > 0) {
58		foreach ($where as $column => $value) {
59		$queryBuilder->andWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
60		}
61		}
62
63		$statement = $queryBuilder->execute();
64
65		$result = $statement->fetch();
66
67		if ($statement->rowCount() === 0) {
68		throw new RecordNotFoundException('Record with given where clause not found');
69		}
70
71		return $this->getEntityFromDatabaseArray($result);
72		}
73
74		/**
75		* @param array $where
76		* @return GeoCacheListBookmarksEntity[]
77		*/
78		public function fetchBy(array $where = [])
79		{
80		$queryBuilder = $this->connection->createQueryBuilder()
81		->select('*')
82		->from(self::TABLE);
83
84		if (count($where) > 0) {
85		foreach ($where as $column => $value) {
86		$queryBuilder->andWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
87		}
88		}
89
90		$statement = $queryBuilder->execute();
91
92		$result = $statement->fetchAll();
93
94		if ($statement->rowCount() === 0) {
95		throw new RecordsNotFoundException('No records with given where clause found');
96		}
97
98		$entities = [];
99
100		foreach ($result as $item) {
101		$entities[] = $this->getEntityFromDatabaseArray($item);
102		}
103
104		return $entities;
105		}
106
107		/**
108		* @param GeoCacheListBookmarksEntity $entity
109		* @return GeoCacheListBookmarksEntity
110		*/
111		public function create(GeoCacheListBookmarksEntity $entity)
112		{
113		if (!$entity->isNew()) {
114		throw new RecordAlreadyExistsException('The entity does already exist.');
115		}
116
117		$databaseArray = $this->getDatabaseArrayFromEntity($entity);
118
119		$this->connection->insert(
120		self::TABLE,
121		$databaseArray
122		);
123
124		$entity->cacheListId = (int) $this->connection->lastInsertId();
125
126		return $entity;
127		}
128
129		/**
130		* @param GeoCacheListBookmarksEntity $entity
131		* @return GeoCacheListBookmarksEntity
132		*/
133		public function update(GeoCacheListBookmarksEntity $entity)
134		{
135		if ($entity->isNew()) {
136		throw new RecordNotPersistedException('The entity does not exist.');
137		}
138
139		$databaseArray = $this->getDatabaseArrayFromEntity($entity);
140
141		$this->connection->update(
142		self::TABLE,
143		$databaseArray,
144		['cache_list_id' => $entity->cacheListId]
145		);
146
147		return $entity;
148		}
149
150		/**
151		* @param GeoCacheListBookmarksEntity $entity
152		* @return GeoCacheListBookmarksEntity
153		*/
154		public function remove(GeoCacheListBookmarksEntity $entity)
155		{
156		if ($entity->isNew()) {
157		throw new RecordNotPersistedException('The entity does not exist.');
158		}
159
160		$this->connection->delete(
161		self::TABLE,
162		['cache_list_id' => $entity->cacheListId]
163		);
164
165		$entity->cacheId = null;
		0 ignored issues – show Bug introduced 2018-08-10 14:46 UTC by Report Bug Copy Issue Report The property `cacheId` does not seem to exist in `GeoCacheListBookmarksEntity`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
166
167		return $entity;
168		}
169
170		/**
171		* @param GeoCacheListBookmarksEntity $entity
172		* @return []
		0 ignored issues – show Documentation introduced 2018-08-10 14:46 UTC by Report Bug Copy Issue Report The doc-type `[]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
173		*/
174		public function getDatabaseArrayFromEntity(GeoCacheListBookmarksEntity $entity)
175		{
176		return [
177		'cache_list_id' => $entity->cacheListId,
178		'user_id' => $entity->userId,
179		'password' => $entity->password,
180		];
181		}
182
183		/**
184		* @param array $data
185		* @return GeoCacheListBookmarksEntity
186		*/
187		public function getEntityFromDatabaseArray(array $data)
188		{
189		$entity = new GeoCacheListBookmarksEntity();
190		$entity->cacheListId = (int) $data['cache_list_id'];
191		$entity->userId = (int) $data['user_id'];
192		$entity->password = (string) $data['password'];
193
194		return $entity;
195		}
196		}
197

OpencachingDeutschland / oc-server3

Push — next ( 01f675...c3ca23 )

CacheListBookmarksRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like