LegacyTemplateTrait - Code Metrics - Inspection of "Feature/symfony integration" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#346)

by Mirko

created 2016-06-07 21:40 UTC

LegacyTemplateTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	32
rs	10
wmc	3
lcom	0
cbo	0

3 Methods

Rating	Name	Size	Complexity
A	setMenu()	4	1
A	setTitle()	4	1
A	setTarget()	4	1

<?php

namespace AppBundle\Legacy\Traits;

trait LegacyTemplateTrait
{
    /**
     * @param int $menu
     *
     * @return void
     */
    protected function setMenu($menu)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $GLOBALS['tpl']->menuitem = $menu;
    }

    /**
     * @param string $title
     *
     * @return void
     */
    protected function setTitle($title)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $GLOBALS['tpl']->title = $title;
    }

    /**
     * @param string $url
     *
     * @return void
     */
    protected function setTarget($url)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $GLOBALS['tpl']->target = $url;
    }
}


1			<?php
2
3			namespace AppBundle\Legacy\Traits;
4
5			trait LegacyTemplateTrait
6			{
7			/**
8			* @param int $menu
9			*
10			* @return void
11			*/
12			protected function setMenu($menu)
			0 ignored issues – show Coding Style introduced 2016-06-07 21:48 UTC by Report Bug Copy Issue Report `setMenu` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
13			{
14			$GLOBALS['tpl']->menuitem = $menu;
15			}
16
17			/**
18			* @param string $title
19			*
20			* @return void
21			*/
22			protected function setTitle($title)
			0 ignored issues – show Coding Style introduced 2016-06-07 21:48 UTC by Report Bug Copy Issue Report `setTitle` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
23			{
24			$GLOBALS['tpl']->title = $title;
25			}
26
27			/**
28			* @param string $url
29			*
30			* @return void
31			*/
32			protected function setTarget($url)
			0 ignored issues – show Coding Style introduced 2016-06-07 21:48 UTC by Report Bug Copy Issue Report `setTarget` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
33			{
34			$GLOBALS['tpl']->target = $url;
35			}
36			}
37

OpencachingDeutschland / oc-server3

Pull Request — master (#346)

LegacyTemplateTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like