Passed
Pull Request — master (#329)
by Mirko
07:45
created
htdocs/lib2/logic/coordinate.class.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -303,6 +303,10 @@  discard block
 block discarded – undo
303 303
         return 'R ' . floor($result[0]) . ' H ' . floor($result[1]);
304 304
     }
305 305
 
306
+    /**
307
+     * @param integer $bw
308
+     * @param integer $lw
309
+     */
306 310
     public function wgs2pot($bw, $lw)
307 311
     {
308 312
         /* Copyright (c) 2006, HELMUT H. HEIMEIER
@@ -602,6 +606,9 @@  discard block
 block discarded – undo
602 606
         ];
603 607
     }
604 608
 
609
+    /**
610
+     * @param string $name
611
+     */
605 612
     public static function parseRequestLat($name)
606 613
     {
607 614
         if (!isset($_REQUEST[$name . 'NS']) || !isset($_REQUEST[$name . 'Lat']) || !isset($_REQUEST[$name . 'LatMin'])) {
@@ -620,6 +627,9 @@  discard block
 block discarded – undo
620 627
         return $lat;
621 628
     }
622 629
 
630
+    /**
631
+     * @param string $name
632
+     */
623 633
     public static function parseRequestLon($name)
624 634
     {
625 635
         if (!isset($_REQUEST[$name . 'EW']) || !isset($_REQUEST[$name . 'Lon']) || !isset($_REQUEST[$name . 'LonMin'])) {
Please login to merge, or discard this patch.
htdocs/lib2/logic/geomath.class.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -50,6 +50,11 @@
 block discarded – undo
50 50
         }
51 51
     }
52 52
 
53
+    /**
54
+     * @param integer $parShortText
55
+     *
56
+     * @return string
57
+     */
53 58
     public static function Bearing2Text($parBearing, $parShortText, $language)
54 59
     {
55 60
         global $opt, $translate;
Please login to merge, or discard this patch.
htdocs/lib2/logic/mailcheck.class.php 2 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -135,6 +135,11 @@  discard block
 block discarded – undo
135 135
         fclose($fp);
136 136
     }
137 137
 
138
+    /**
139
+     * @param string $sResp
140
+     *
141
+     * @return string
142
+     */
138 143
     public function extract_return_code($sResp)
139 144
     {
140 145
         $nPos1 = strpos($sResp, ' ');
@@ -157,6 +162,9 @@  discard block
 block discarded – undo
157 162
         return substr($sResp, 0, $nPos);
158 163
     }
159 164
 
165
+    /**
166
+     * @param string $out
167
+     */
160 168
     public function send_command($fp, $out)
161 169
     {
162 170
         fwrite($fp, $out . "\r\n");
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 
26 26
     public $nConnectTimeout = 15; // (sec)
27 27
 
28
-    public $nReadTimeout = 25;   // (sec)
28
+    public $nReadTimeout = 25; // (sec)
29 29
 
30 30
     /* check if the mailserver of $sAddress
31 31
      * explicit says that the user does not exist
Please login to merge, or discard this patch.
htdocs/lib2/logic/picture.class.php 3 patches
Doc Comments   +27 added lines patch added patch discarded remove patch
@@ -102,6 +102,9 @@  discard block
 block discarded – undo
102 102
         }
103 103
     }
104 104
 
105
+    /**
106
+     * @param string $sFilename
107
+     */
105 108
     public function setFilenames($sFilename)
106 109
     {
107 110
         global $opt;
@@ -129,6 +132,9 @@  discard block
 block discarded – undo
129 132
         return $this->nPictureId;
130 133
     }
131 134
 
135
+    /**
136
+     * @param boolean $bRestoring
137
+     */
132 138
     private function setArchiveFlag($bRestoring, $original_id = 0)
133 139
     {
134 140
         global $login;
@@ -175,11 +181,17 @@  discard block
 block discarded – undo
175 181
         sql_slave("SET @original_picid=0");
176 182
     }
177 183
 
184
+    /**
185
+     * @return string
186
+     */
178 187
     public function getUrl()
179 188
     {
180 189
         return $this->rePicture->getValue('url');
181 190
     }
182 191
 
192
+    /**
193
+     * @param string $value
194
+     */
183 195
     public function setUrl($value)
184 196
     {
185 197
         return $this->rePicture->setValue('url', $value);
@@ -224,6 +236,9 @@  discard block
 block discarded – undo
224 236
         return $this->rePicture->getValue('local') != 0;
225 237
     }
226 238
 
239
+    /**
240
+     * @param integer $value
241
+     */
227 242
     public function setLocal($value)
228 243
     {
229 244
         return $this->rePicture->setValue('local', $value ? 1 : 0);
@@ -292,6 +307,9 @@  discard block
 block discarded – undo
292 307
         return $opt['logic']['pictures']['thumb_dir'] . $dir1 . '/' . $dir2 . '/' . $filename;
293 308
     }
294 309
 
310
+    /**
311
+     * @return string
312
+     */
295 313
     public function getLogId()
296 314
     {
297 315
         if ($this->getObjectType() == OBJECT_CACHELOG) {
@@ -328,6 +346,9 @@  discard block
 block discarded – undo
328 346
         return $firstlogs;
329 347
     }
330 348
 
349
+    /**
350
+     * @return string
351
+     */
331 352
     public function getCacheId()
332 353
     {
333 354
         if ($this->getObjectType() == OBJECT_CACHELOG) {
@@ -491,6 +512,9 @@  discard block
 block discarded – undo
491 512
         return true;
492 513
     }
493 514
 
515
+    /**
516
+     * @param string $filename
517
+     */
494 518
     private function deleted_filename($filename)
495 519
     {
496 520
         $fna = mb_split('\\/', $filename);
@@ -648,6 +672,9 @@  discard block
 block discarded – undo
648 672
         return move_uploaded_file($tmpFile, $this->getFilename());
649 673
     }
650 674
 
675
+    /**
676
+     * @param Imagick $image
677
+     */
651 678
     public function imagick_rotate(&$image)
652 679
     {
653 680
         $exif = $image->getImageProperties();
Please login to merge, or discard this patch.
Indentation   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -313,25 +313,25 @@
 block discarded – undo
313 313
             return null;
314 314
         }
315 315
 
316
-		$rs = sql(
317
-			"SELECT `id`
316
+        $rs = sql(
317
+            "SELECT `id`
318 318
 			 FROM `cache_logs`
319 319
 			 WHERE `cache_id`='&1'
320 320
 			 ORDER BY `date`, `id` DESC
321 321
 			 LIMIT &2",
322
-			$this->getCacheId(),
323
-			MAX_LOGENTRIES_ON_CACHEPAGE
324
-		);
325
-		$firstlogs = false;
326
-		while ($r = sql_fetch_assoc($rs)) {
327
-			if ($r['id'] == $this->getLogId()) {
328
-				$firstlogs = true;
329
-			}
330
-		}
331
-
332
-		sql_free_result($rs);
333
-
334
-		return $firstlogs;
322
+            $this->getCacheId(),
323
+            MAX_LOGENTRIES_ON_CACHEPAGE
324
+        );
325
+        $firstlogs = false;
326
+        while ($r = sql_fetch_assoc($rs)) {
327
+            if ($r['id'] == $this->getLogId()) {
328
+                $firstlogs = true;
329
+            }
330
+        }
331
+
332
+        sql_free_result($rs);
333
+
334
+        return $firstlogs;
335 335
     }
336 336
 
337 337
     public function getCacheId()
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -444,9 +444,9 @@
 block discarded – undo
444 444
             }
445 445
 
446 446
             // restore picture file
447
-            $this->setUrl($original_url);        // set the url, so that we can
448
-            $filename = $this->getFilename();    // .. retreive the file path+name
449
-            $this->setFilenames($filename);      // now set url(s) from the new uuid
447
+            $this->setUrl($original_url); // set the url, so that we can
448
+            $filename = $this->getFilename(); // .. retreive the file path+name
449
+            $this->setFilenames($filename); // now set url(s) from the new uuid
450 450
             try {
451 451
                 rename($this->deleted_filename($filename), $this->getFilename());
452 452
             } catch (Exception $e) {
Please login to merge, or discard this patch.
htdocs/lib2/logic/sitemapxml.class.php 2 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -46,6 +46,11 @@  discard block
 block discarded – undo
46 46
     /* sChaneFreq = {always, hourly, daily, weekly, monthly, yearly, never}
47 47
      * nPriority  = {0.0 to 1.0}
48 48
      */
49
+
50
+    /**
51
+     * @param string $sFile
52
+     * @param integer $dLastMod
53
+     */
49 54
     public function write($sFile, $dLastMod, $sChangeFreq = false, $nPriority = 0.5)
50 55
     {
51 56
         if ($sChangeFreq == false) {
@@ -62,6 +67,9 @@  discard block
 block discarded – undo
62 67
         $this->writeInternal($sXML);
63 68
     }
64 69
 
70
+    /**
71
+     * @param string $str
72
+     */
65 73
     public function writeInternal($str)
66 74
     {
67 75
         global $opt;
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
 {
13 13
     public $sDefaultChangeFreq = 'monthly';
14 14
     public $nMaxFileSize = 9961472; // max file size, 10MB by specification
15
-    public $nMaxUrlCount = 50000;   // max number of URLs per file, 50000 by specification
15
+    public $nMaxUrlCount = 50000; // max number of URLs per file, 50000 by specification
16 16
 
17 17
     public $sPath = '';
18 18
     public $sDomain = '';
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 
76 76
         // open new XML file?
77 77
         if ($this->oSitemapFile === false) {
78
-            $this->nSitemapIndex ++;
78
+            $this->nSitemapIndex++;
79 79
             $sFilename = 'sitemap-' . $this->nSitemapIndex . '.xml.gz';
80 80
             $this->oSitemapFile = gzopen($this->sPath . $sFilename, 'wb');
81 81
 
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
         // write string to XML
92 92
         gzwrite($this->oSitemapFile, $str);
93 93
         $this->nWrittenSize += strlen($str);
94
-        $this->nWrittenCount ++;
94
+        $this->nWrittenCount++;
95 95
     }
96 96
 
97 97
     public function close()
Please login to merge, or discard this patch.
htdocs/lib2/logic/user.class.php 1 patch
Doc Comments   +36 added lines patch added patch discarded remove patch
@@ -143,6 +143,9 @@  discard block
 block discarded – undo
143 143
         return $this->reUser->getValue('username');
144 144
     }
145 145
 
146
+    /**
147
+     * @param string $value
148
+     */
146 149
     public function setUsername($value)
147 150
     {
148 151
         if (!mb_ereg_match(REGEX_USERNAME, $value)) {
@@ -210,6 +213,9 @@  discard block
 block discarded – undo
210 213
         return $this->reUser->getValue('first_name');
211 214
     }
212 215
 
216
+    /**
217
+     * @param string $value
218
+     */
213 219
     public function setFirstName($value)
214 220
     {
215 221
         if ($value != '') {
@@ -226,6 +232,9 @@  discard block
 block discarded – undo
226 232
         return $this->reUser->getValue('last_name');
227 233
     }
228 234
 
235
+    /**
236
+     * @param string $value
237
+     */
229 238
     public function setLastName($value)
230 239
     {
231 240
         if ($value != '') {
@@ -275,6 +284,9 @@  discard block
 block discarded – undo
275 284
         return $this->reUser->getValue('latitude');
276 285
     }
277 286
 
287
+    /**
288
+     * @param double $value
289
+     */
278 290
     public function setLatitude($value)
279 291
     {
280 292
         if (($value + 0) > 90 || ($value + 0) < - 90) {
@@ -289,6 +301,9 @@  discard block
 block discarded – undo
289 301
         return $this->reUser->getValue('longitude');
290 302
     }
291 303
 
304
+    /**
305
+     * @param double $value
306
+     */
292 307
     public function setLongitude($value)
293 308
     {
294 309
         if (($value + 0) > 180 || ($value + 0) < - 180) {
@@ -303,6 +318,9 @@  discard block
 block discarded – undo
303 318
         return $this->reUser->getValue('notify_radius');
304 319
     }
305 320
 
321
+    /**
322
+     * @param integer $value
323
+     */
306 324
     public function setNotifyRadius($value)
307 325
     {
308 326
         if (($value + 0) < 0 || ($value + 0) > 150) {
@@ -317,6 +335,9 @@  discard block
 block discarded – undo
317 335
         return $this->reUser->getValue('notify_oconly') != 0;
318 336
     }
319 337
 
338
+    /**
339
+     * @param boolean $value
340
+     */
320 341
     public function setNotifyOconly($value)
321 342
     {
322 343
         return $this->reUser->setValue('notify_oconly', $value ? 1 : 0);
@@ -397,6 +418,9 @@  discard block
 block discarded – undo
397 418
         return $this->reUser->getValue('new_pw_code');
398 419
     }
399 420
 
421
+    /**
422
+     * @param string|null $value
423
+     */
400 424
     public function setNewPWCode($value)
401 425
     {
402 426
         return $this->reUser->setValue('new_pw_code', $value);
@@ -407,6 +431,9 @@  discard block
 block discarded – undo
407 431
         return $this->reUser->getValue('new_pw_date');
408 432
     }
409 433
 
434
+    /**
435
+     * @param integer|null $value
436
+     */
410 437
     public function setNewPWDate($value)
411 438
     {
412 439
         return $this->reUser->setValue('new_pw_date', $value);
@@ -417,6 +444,9 @@  discard block
 block discarded – undo
417 444
         return $this->reUser->getValue('new_email_code');
418 445
     }
419 446
 
447
+    /**
448
+     * @param string|null $value
449
+     */
420 450
     public function setNewEMailCode($value)
421 451
     {
422 452
         return $this->reUser->setValue('new_email_code', $value);
@@ -427,6 +457,9 @@  discard block
 block discarded – undo
427 457
         return $this->reUser->getValue('new_email_date');
428 458
     }
429 459
 
460
+    /**
461
+     * @param integer|null $value
462
+     */
430 463
     public function setNewEMailDate($value)
431 464
     {
432 465
         return $this->reUser->setValue('new_email_date', $value);
@@ -493,6 +526,9 @@  discard block
 block discarded – undo
493 526
         return $this->reUser->getValue('watchmail_nextmail');
494 527
     }
495 528
 
529
+    /**
530
+     * @param string $value
531
+     */
496 532
     public function setWatchmailNext($value)
497 533
     {
498 534
         return $this->reUser->setValue('watchmail_nextmail', $value);
Please login to merge, or discard this patch.
htdocs/lib2/mail.class.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -130,6 +130,9 @@  discard block
 block discarded – undo
130 130
         return mb_send_mail($this->to, $opt['mail']['subject'] . $this->subject, $body, $mailheaders);
131 131
     }
132 132
 
133
+    /**
134
+     * @param string $domain
135
+     */
133 136
     public static function is_existent_maildomain($domain)
134 137
     {
135 138
         if ($domain == "localhost") {
@@ -154,6 +157,9 @@  discard block
 block discarded – undo
154 157
         return false;
155 158
     }
156 159
 
160
+    /**
161
+     * @param string $mail
162
+     */
157 163
     public static function getToMailDomain($mail)
158 164
     {
159 165
         if ($mail == '') {
Please login to merge, or discard this patch.
htdocs/lib2/menu.class.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -245,6 +245,9 @@
 block discarded – undo
245 245
         return $retval;
246 246
     }
247 247
 
248
+    /**
249
+     * @param integer|null $menuid
250
+     */
248 251
     public function pAppendSubMenu($menuid, $ids, &$items)
249 252
     {
250 253
         global $menuitem, $login;
Please login to merge, or discard this patch.
htdocs/lib2/Net/IDNA2.php 4 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2760,7 +2760,7 @@  discard block
 block discarded – undo
2760 2760
      *
2761 2761
      * @param int $d One digit to encode
2762 2762
      *
2763
-     * @return char  Encoded digit
2763
+     * @return string  Encoded digit
2764 2764
      * @access private
2765 2765
      */
2766 2766
     private function _encodeDigit($d)
@@ -2771,7 +2771,7 @@  discard block
 block discarded – undo
2771 2771
     /**
2772 2772
      * Decode a certain digit.
2773 2773
      *
2774
-     * @param char $cp One digit (character) to decode
2774
+     * @param string $cp One digit (character) to decode
2775 2775
      *
2776 2776
      * @return int     Decoded digit
2777 2777
      * @access private
@@ -2785,7 +2785,7 @@  discard block
 block discarded – undo
2785 2785
     /**
2786 2786
      * Do Nameprep according to RFC3491 and RFC3454.
2787 2787
      *
2788
-     * @param array $input Unicode Characters
2788
+     * @param string $input Unicode Characters
2789 2789
      *
2790 2790
      * @return string      Unicode Characters, Nameprep'd
2791 2791
      * @throws Exception
@@ -2885,7 +2885,7 @@  discard block
 block discarded – undo
2885 2885
      *
2886 2886
      * @param integer $char 32bit UCS4 code point
2887 2887
      *
2888
-     * @return array        Either Hangul Syllable decomposed or original 32bit
2888
+     * @return integer[]        Either Hangul Syllable decomposed or original 32bit
2889 2889
      *                      value as one value array
2890 2890
      * @access private
2891 2891
      */
Please login to merge, or discard this patch.
Switch Indentation   +79 added lines, -79 removed lines patch added patch discarded remove patch
@@ -2273,38 +2273,38 @@  discard block
 block discarded – undo
2273 2273
 
2274 2274
         foreach ($option as $k => $v) {
2275 2275
             switch ($k) {
2276
-            case 'encoding':
2277
-                switch ($v) {
2278
-                case 'utf8':
2279
-                case 'ucs4_string':
2280
-                case 'ucs4_array':
2281
-                    $this->_api_encoding = $v;
2282
-                    break;
2276
+                case 'encoding':
2277
+                    switch ($v) {
2278
+                        case 'utf8':
2279
+                        case 'ucs4_string':
2280
+                        case 'ucs4_array':
2281
+                            $this->_api_encoding = $v;
2282
+                            break;
2283 2283
 
2284
-                default:
2285
-                    throw new InvalidArgumentException('Set Parameter: Unknown parameter '.$v.' for option '.$k);
2286
-                }
2284
+                        default:
2285
+                            throw new InvalidArgumentException('Set Parameter: Unknown parameter '.$v.' for option '.$k);
2286
+                    }
2287 2287
 
2288 2288
                 break;
2289 2289
 
2290
-            case 'overlong':
2291
-                $this->_allow_overlong = ($v) ? true : false;
2292
-                break;
2290
+                case 'overlong':
2291
+                    $this->_allow_overlong = ($v) ? true : false;
2292
+                    break;
2293 2293
 
2294
-            case 'strict':
2295
-                $this->_strict_mode = ($v) ? true : false;
2296
-                break;
2294
+                case 'strict':
2295
+                    $this->_strict_mode = ($v) ? true : false;
2296
+                    break;
2297 2297
 
2298
-            case 'version':
2299
-                if (in_array($v, array('2003', '2008'))) {
2300
-                    $this->_version = $v;
2301
-                } else {
2302
-                    throw new InvalidArgumentException('Set Parameter: Invalid parameter '.$v.' for option '.$k);
2303
-                }
2304
-                break;
2298
+                case 'version':
2299
+                    if (in_array($v, array('2003', '2008'))) {
2300
+                        $this->_version = $v;
2301
+                    } else {
2302
+                        throw new InvalidArgumentException('Set Parameter: Invalid parameter '.$v.' for option '.$k);
2303
+                    }
2304
+                    break;
2305 2305
 
2306
-            default:
2307
-                return false;
2306
+                default:
2307
+                    return false;
2308 2308
             }
2309 2309
         }
2310 2310
 
@@ -2328,15 +2328,15 @@  discard block
 block discarded – undo
2328 2328
         // Forcing conversion of input to UCS4 array
2329 2329
         // If one time encoding is given, use this, else the objects property
2330 2330
         switch (($one_time_encoding) ? $one_time_encoding : $this->_api_encoding) {
2331
-        case 'utf8':
2332
-            $decoded = $this->_utf8_to_ucs4($decoded);
2333
-            break;
2334
-        case 'ucs4_string':
2335
-            $decoded = $this->_ucs4_string_to_ucs4($decoded);
2336
-        case 'ucs4_array': // No break; before this line. Catch case, but do nothing
2337
-            break;
2338
-        default:
2339
-            throw new InvalidArgumentException('Unsupported input format');
2331
+            case 'utf8':
2332
+                $decoded = $this->_utf8_to_ucs4($decoded);
2333
+                break;
2334
+            case 'ucs4_string':
2335
+                $decoded = $this->_ucs4_string_to_ucs4($decoded);
2336
+            case 'ucs4_array': // No break; before this line. Catch case, but do nothing
2337
+                break;
2338
+            default:
2339
+                throw new InvalidArgumentException('Unsupported input format');
2340 2340
         }
2341 2341
 
2342 2342
         // No input, no output, what else did you expect?
@@ -2350,35 +2350,35 @@  discard block
 block discarded – undo
2350 2350
         foreach ($decoded as $k => $v) {
2351 2351
             // Make sure to use just the plain dot
2352 2352
             switch($v) {
2353
-            case 0x3002:
2354
-            case 0xFF0E:
2355
-            case 0xFF61:
2356
-                $decoded[$k] = 0x2E;
2357
-                // It's right, no break here
2358
-                // The codepoints above have to be converted to dots anyway
2359
-
2360
-            // Stumbling across an anchoring character
2361
-            case 0x2E:
2362
-            case 0x2F:
2363
-            case 0x3A:
2364
-            case 0x3F:
2365
-            case 0x40:
2366
-                // Neither email addresses nor URLs allowed in strict mode
2367
-                if ($this->_strict_mode) {
2368
-                    throw new InvalidArgumentException('Neither email addresses nor URLs are allowed in strict mode.');
2369
-                }
2370
-                // Skip first char
2371
-                if ($k) {
2372
-                    $encoded = '';
2373
-                    $encoded = $this->_encode(array_slice($decoded, $last_begin, (($k)-$last_begin)));
2374
-                    if ($encoded) {
2375
-                        $output .= $encoded;
2376
-                    } else {
2377
-                        $output .= $this->_ucs4_to_utf8(array_slice($decoded, $last_begin, (($k)-$last_begin)));
2353
+                case 0x3002:
2354
+                case 0xFF0E:
2355
+                case 0xFF61:
2356
+                    $decoded[$k] = 0x2E;
2357
+                    // It's right, no break here
2358
+                    // The codepoints above have to be converted to dots anyway
2359
+
2360
+                // Stumbling across an anchoring character
2361
+                case 0x2E:
2362
+                case 0x2F:
2363
+                case 0x3A:
2364
+                case 0x3F:
2365
+                case 0x40:
2366
+                    // Neither email addresses nor URLs allowed in strict mode
2367
+                    if ($this->_strict_mode) {
2368
+                        throw new InvalidArgumentException('Neither email addresses nor URLs are allowed in strict mode.');
2378 2369
                     }
2379
-                    $output .= chr($decoded[$k]);
2380
-                }
2381
-                $last_begin = $k + 1;
2370
+                    // Skip first char
2371
+                    if ($k) {
2372
+                        $encoded = '';
2373
+                        $encoded = $this->_encode(array_slice($decoded, $last_begin, (($k)-$last_begin)));
2374
+                        if ($encoded) {
2375
+                            $output .= $encoded;
2376
+                        } else {
2377
+                            $output .= $this->_ucs4_to_utf8(array_slice($decoded, $last_begin, (($k)-$last_begin)));
2378
+                        }
2379
+                        $output .= chr($decoded[$k]);
2380
+                    }
2381
+                    $last_begin = $k + 1;
2382 2382
             }
2383 2383
         }
2384 2384
         // Catch the rest of the string
@@ -2416,12 +2416,12 @@  discard block
 block discarded – undo
2416 2416
         // Optionally set
2417 2417
         if ($one_time_encoding) {
2418 2418
             switch ($one_time_encoding) {
2419
-            case 'utf8':
2420
-            case 'ucs4_string':
2421
-            case 'ucs4_array':
2422
-                break;
2423
-            default:
2424
-                throw new InvalidArgumentException('Unknown encoding '.$one_time_encoding);
2419
+                case 'utf8':
2420
+                case 'ucs4_string':
2421
+                case 'ucs4_array':
2422
+                    break;
2423
+                default:
2424
+                    throw new InvalidArgumentException('Unknown encoding '.$one_time_encoding);
2425 2425
             }
2426 2426
         }
2427 2427
         // Make sure to drop any newline characters around
@@ -2473,17 +2473,17 @@  discard block
 block discarded – undo
2473 2473
         // The output is UTF-8 by default, other output formats need conversion here
2474 2474
         // If one time encoding is given, use this, else the objects property
2475 2475
         switch (($one_time_encoding) ? $one_time_encoding : $this->_api_encoding) {
2476
-        case 'utf8':
2477
-            return $return;
2478
-            break;
2479
-        case 'ucs4_string':
2480
-            return $this->_ucs4_to_ucs4_string($this->_utf8_to_ucs4($return));
2481
-            break;
2482
-        case 'ucs4_array':
2483
-            return $this->_utf8_to_ucs4($return);
2484
-            break;
2485
-        default:
2486
-            throw new InvalidArgumentException('Unsupported output format');
2476
+            case 'utf8':
2477
+                return $return;
2478
+                break;
2479
+            case 'ucs4_string':
2480
+                return $this->_ucs4_to_ucs4_string($this->_utf8_to_ucs4($return));
2481
+                break;
2482
+            case 'ucs4_array':
2483
+                return $this->_utf8_to_ucs4($return);
2484
+                break;
2485
+            default:
2486
+                throw new InvalidArgumentException('Unsupported output format');
2487 2487
         }
2488 2488
     }
2489 2489
 
Please login to merge, or discard this patch.
Spacing   +43 added lines, -47 removed lines patch added patch discarded remove patch
@@ -272,16 +272,16 @@  discard block
 block discarded – undo
272 272
      * @access private
273 273
      */
274 274
     private static $_np_prohibit_ranges = array(
275
-        array(0x80,     0x9F    ),
276
-        array(0x2060,   0x206F  ),
277
-        array(0x1D173,  0x1D17A ),
278
-        array(0xE000,   0xF8FF  ),
279
-        array(0xF0000,  0xFFFFD ),
275
+        array(0x80, 0x9F),
276
+        array(0x2060, 0x206F),
277
+        array(0x1D173, 0x1D17A),
278
+        array(0xE000, 0xF8FF),
279
+        array(0xF0000, 0xFFFFD),
280 280
         array(0x100000, 0x10FFFD),
281
-        array(0xFDD0,   0xFDEF  ),
282
-        array(0xD800,   0xDFFF  ),
283
-        array(0x2FF0,   0x2FFB  ),
284
-        array(0xE0020,  0xE007F )
281
+        array(0xFDD0, 0xFDEF),
282
+        array(0xD800, 0xDFFF),
283
+        array(0x2FF0, 0x2FFB),
284
+        array(0xE0020, 0xE007F)
285 285
     );
286 286
 
287 287
     /**
@@ -2282,7 +2282,7 @@  discard block
 block discarded – undo
2282 2282
                     break;
2283 2283
 
2284 2284
                 default:
2285
-                    throw new InvalidArgumentException('Set Parameter: Unknown parameter '.$v.' for option '.$k);
2285
+                    throw new InvalidArgumentException('Set Parameter: Unknown parameter ' . $v . ' for option ' . $k);
2286 2286
                 }
2287 2287
 
2288 2288
                 break;
@@ -2299,7 +2299,7 @@  discard block
 block discarded – undo
2299 2299
                 if (in_array($v, array('2003', '2008'))) {
2300 2300
                     $this->_version = $v;
2301 2301
                 } else {
2302
-                    throw new InvalidArgumentException('Set Parameter: Invalid parameter '.$v.' for option '.$k);
2302
+                    throw new InvalidArgumentException('Set Parameter: Invalid parameter ' . $v . ' for option ' . $k);
2303 2303
                 }
2304 2304
                 break;
2305 2305
 
@@ -2328,8 +2328,7 @@  discard block
 block discarded – undo
2328 2328
         // Forcing conversion of input to UCS4 array
2329 2329
         // If one time encoding is given, use this, else the objects property
2330 2330
         switch (($one_time_encoding) ? $one_time_encoding : $this->_api_encoding) {
2331
-        case 'utf8':
2332
-            $decoded = $this->_utf8_to_ucs4($decoded);
2331
+        case 'utf8' : $decoded = $this->_utf8_to_ucs4($decoded);
2333 2332
             break;
2334 2333
         case 'ucs4_string':
2335 2334
             $decoded = $this->_ucs4_string_to_ucs4($decoded);
@@ -2349,7 +2348,7 @@  discard block
 block discarded – undo
2349 2348
 
2350 2349
         foreach ($decoded as $k => $v) {
2351 2350
             // Make sure to use just the plain dot
2352
-            switch($v) {
2351
+            switch ($v) {
2353 2352
             case 0x3002:
2354 2353
             case 0xFF0E:
2355 2354
             case 0xFF61:
@@ -2370,11 +2369,11 @@  discard block
 block discarded – undo
2370 2369
                 // Skip first char
2371 2370
                 if ($k) {
2372 2371
                     $encoded = '';
2373
-                    $encoded = $this->_encode(array_slice($decoded, $last_begin, (($k)-$last_begin)));
2372
+                    $encoded = $this->_encode(array_slice($decoded, $last_begin, (($k) - $last_begin)));
2374 2373
                     if ($encoded) {
2375 2374
                         $output .= $encoded;
2376 2375
                     } else {
2377
-                        $output .= $this->_ucs4_to_utf8(array_slice($decoded, $last_begin, (($k)-$last_begin)));
2376
+                        $output .= $this->_ucs4_to_utf8(array_slice($decoded, $last_begin, (($k) - $last_begin)));
2378 2377
                     }
2379 2378
                     $output .= chr($decoded[$k]);
2380 2379
                 }
@@ -2385,11 +2384,11 @@  discard block
 block discarded – undo
2385 2384
         if ($last_begin) {
2386 2385
             $inp_len = sizeof($decoded);
2387 2386
             $encoded = '';
2388
-            $encoded = $this->_encode(array_slice($decoded, $last_begin, (($inp_len)-$last_begin)));
2387
+            $encoded = $this->_encode(array_slice($decoded, $last_begin, (($inp_len) - $last_begin)));
2389 2388
             if ($encoded) {
2390 2389
                 $output .= $encoded;
2391 2390
             } else {
2392
-                $output .= $this->_ucs4_to_utf8(array_slice($decoded, $last_begin, (($inp_len)-$last_begin)));
2391
+                $output .= $this->_ucs4_to_utf8(array_slice($decoded, $last_begin, (($inp_len) - $last_begin)));
2393 2392
             }
2394 2393
             return $output;
2395 2394
         }
@@ -2421,7 +2420,7 @@  discard block
 block discarded – undo
2421 2420
             case 'ucs4_array':
2422 2421
                 break;
2423 2422
             default:
2424
-                throw new InvalidArgumentException('Unknown encoding '.$one_time_encoding);
2423
+                throw new InvalidArgumentException('Unknown encoding ' . $one_time_encoding);
2425 2424
             }
2426 2425
         }
2427 2426
         // Make sure to drop any newline characters around
@@ -2473,8 +2472,7 @@  discard block
 block discarded – undo
2473 2472
         // The output is UTF-8 by default, other output formats need conversion here
2474 2473
         // If one time encoding is given, use this, else the objects property
2475 2474
         switch (($one_time_encoding) ? $one_time_encoding : $this->_api_encoding) {
2476
-        case 'utf8':
2477
-            return $return;
2475
+        case 'utf8' : return $return;
2478 2476
             break;
2479 2477
         case 'ucs4_string':
2480 2478
             return $this->_ucs4_to_ucs4_string($this->_utf8_to_ucs4($return));
@@ -2629,9 +2627,8 @@  discard block
 block discarded – undo
2629 2627
                     $delta++;
2630 2628
                 } else if ($decoded[$i] == $cur_code) {
2631 2629
                     for ($q = $delta, $k = $this->_base; 1; $k += $this->_base) {
2632
-                        $t = ($k <= $bias)?
2633
-                            $this->_tmin :
2634
-                            (($k >= $bias + $this->_tmax)? $this->_tmax : $k - $bias);
2630
+                        $t = ($k <= $bias) ?
2631
+                            $this->_tmin : (($k >= $bias + $this->_tmax) ? $this->_tmax : $k - $bias);
2635 2632
 
2636 2633
                         if ($q < $t) {
2637 2634
                             break;
@@ -2699,14 +2696,13 @@  discard block
 block discarded – undo
2699 2696
         $idx      = 0;
2700 2697
         $char     = $this->_initial_n;
2701 2698
 
2702
-        for ($enco_idx = ($delim_pos)? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len) {
2703
-            for ($old_idx = $idx, $w = 1, $k = $this->_base; 1 ; $k += $this->_base) {
2699
+        for ($enco_idx = ($delim_pos) ? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len) {
2700
+            for ($old_idx = $idx, $w = 1, $k = $this->_base; 1; $k += $this->_base) {
2704 2701
                 $digit = $this->_decodeDigit($encoded{$enco_idx++});
2705 2702
                 $idx += $digit * $w;
2706 2703
 
2707 2704
                 $t = ($k <= $bias) ?
2708
-                    $this->_tmin :
2709
-                    (($k >= $bias + $this->_tmax)? $this->_tmax : ($k - $bias));
2705
+                    $this->_tmin : (($k >= $bias + $this->_tmax) ? $this->_tmax : ($k - $bias));
2710 2706
 
2711 2707
                 if ($digit < $t) {
2712 2708
                     break;
@@ -2717,7 +2713,7 @@  discard block
 block discarded – undo
2717 2713
 
2718 2714
             $bias      = $this->_adapt($idx - $old_idx, $deco_len + 1, $is_first);
2719 2715
             $is_first  = false;
2720
-            $char     += (int) ($idx / ($deco_len + 1));
2716
+            $char     += (int)($idx / ($deco_len + 1));
2721 2717
             $idx      %= ($deco_len + 1);
2722 2718
 
2723 2719
             if ($deco_len > 0) {
@@ -2745,14 +2741,14 @@  discard block
 block discarded – undo
2745 2741
      */
2746 2742
     private function _adapt($delta, $npoints, $is_first)
2747 2743
     {
2748
-        $delta = (int) ($is_first ? ($delta / $this->_damp) : ($delta / 2));
2749
-        $delta += (int) ($delta / $npoints);
2744
+        $delta = (int)($is_first ? ($delta / $this->_damp) : ($delta / 2));
2745
+        $delta += (int)($delta / $npoints);
2750 2746
 
2751 2747
         for ($k = 0; $delta > (($this->_base - $this->_tmin) * $this->_tmax) / 2; $k += $this->_base) {
2752
-            $delta = (int) ($delta / ($this->_base - $this->_tmin));
2748
+            $delta = (int)($delta / ($this->_base - $this->_tmin));
2753 2749
         }
2754 2750
 
2755
-        return (int) ($k + ($this->_base - $this->_tmin + 1) * $delta / ($delta + $this->_skew));
2751
+        return (int)($k + ($this->_base - $this->_tmin + 1) * $delta / ($delta + $this->_skew));
2756 2752
     }
2757 2753
 
2758 2754
     /**
@@ -2779,7 +2775,7 @@  discard block
 block discarded – undo
2779 2775
     private function _decodeDigit($cp)
2780 2776
     {
2781 2777
         $cp = ord($cp);
2782
-        return ($cp - 48 < 10)? $cp - 22 : (($cp - 65 < 26)? $cp - 65 : (($cp - 97 < 26)? $cp - 97 : $this->_base));
2778
+        return ($cp - 48 < 10) ? $cp - 22 : (($cp - 65 < 26) ? $cp - 65 : (($cp - 97 < 26) ? $cp - 97 : $this->_base));
2783 2779
     }
2784 2780
 
2785 2781
     /**
@@ -2862,7 +2858,7 @@  discard block
 block discarded – undo
2862 2858
                     // Rewind the for loop by one, since there can be more possible compositions
2863 2859
                     $i--;
2864 2860
                     $out_len--;
2865
-                    $last_class = ($i == $last_starter)? 0 : $this->_getCombiningClass($output[$i - 1]);
2861
+                    $last_class = ($i == $last_starter) ? 0 : $this->_getCombiningClass($output[$i - 1]);
2866 2862
 
2867 2863
                     continue;
2868 2864
                 }
@@ -2899,7 +2895,7 @@  discard block
 block discarded – undo
2899 2895
 
2900 2896
         $result   = array();
2901 2897
         $T        = $this->_tbase + $sindex % $this->_tcount;
2902
-        $result[] = (int)($this->_lbase +  $sindex / $this->_ncount);
2898
+        $result[] = (int)($this->_lbase + $sindex / $this->_ncount);
2903 2899
         $result[] = (int)($this->_vbase + ($sindex % $this->_ncount) / $this->_tcount);
2904 2900
 
2905 2901
         if ($T != $this->_tbase) {
@@ -2985,7 +2981,7 @@  discard block
 block discarded – undo
2985 2981
      */
2986 2982
     private function _getCombiningClass($char)
2987 2983
     {
2988
-        return isset(self::$_np_norm_combcls[$char])? self::$_np_norm_combcls[$char] : 0;
2984
+        return isset(self::$_np_norm_combcls[$char]) ? self::$_np_norm_combcls[$char] : 0;
2989 2985
     }
2990 2986
 
2991 2987
     /**
@@ -3119,7 +3115,7 @@  discard block
 block discarded – undo
3119 3115
                 $output[$out_len] = $v;
3120 3116
                 ++$out_len;
3121 3117
                 if ('add' == $mode) {
3122
-                    throw new UnexpectedValueException('Conversion from UTF-8 to UCS-4 failed: malformed input at byte '.$k);
3118
+                    throw new UnexpectedValueException('Conversion from UTF-8 to UCS-4 failed: malformed input at byte ' . $k);
3123 3119
                 }
3124 3120
                 continue;
3125 3121
             }
@@ -3143,10 +3139,10 @@  discard block
 block discarded – undo
3143 3139
                     $next_byte = 4;
3144 3140
                     $v = ($v - 252) << 30;
3145 3141
                 } else {
3146
-                    throw new UnexpectedValueException('This might be UTF-8, but I don\'t understand it at byte '.$k);
3142
+                    throw new UnexpectedValueException('This might be UTF-8, but I don\'t understand it at byte ' . $k);
3147 3143
                 }
3148 3144
                 if ('add' == $mode) {
3149
-                    $output[$out_len] = (int) $v;
3145
+                    $output[$out_len] = (int)$v;
3150 3146
                     ++$out_len;
3151 3147
                     continue;
3152 3148
                 }
@@ -3155,7 +3151,7 @@  discard block
 block discarded – undo
3155 3151
                 if (!$this->_allow_overlong && $test == 'range') {
3156 3152
                     $test = 'none';
3157 3153
                     if (($v < 0xA0 && $start_byte == 0xE0) || ($v < 0x90 && $start_byte == 0xF0) || ($v > 0x8F && $start_byte == 0xF4)) {
3158
-                        throw new OutOfRangeException('Bogus UTF-8 character detected (out of legal range) at byte '.$k);
3154
+                        throw new OutOfRangeException('Bogus UTF-8 character detected (out of legal range) at byte ' . $k);
3159 3155
                     }
3160 3156
                 }
3161 3157
                 if ($v >> 6 == 2) { // Bit mask must be 10xxxxxx
@@ -3163,7 +3159,7 @@  discard block
 block discarded – undo
3163 3159
                     $output[($out_len - 1)] += $v;
3164 3160
                     --$next_byte;
3165 3161
                 } else {
3166
-                    throw new UnexpectedValueException('Conversion from UTF-8 to UCS-4 failed: malformed input at byte '.$k);
3162
+                    throw new UnexpectedValueException('Conversion from UTF-8 to UCS-4 failed: malformed input at byte ' . $k);
3167 3163
                 }
3168 3164
                 if ($next_byte < 0) {
3169 3165
                     $mode = 'next';
@@ -3205,14 +3201,14 @@  discard block
 block discarded – undo
3205 3201
                 // 4 bytes
3206 3202
                 $output .= chr(240 + ($v >> 18))
3207 3203
                     . chr(128 + (($v >> 12) & 63))
3208
-                    . chr(128 + (($v >>  6) & 63))
3204
+                    . chr(128 + (($v >> 6) & 63))
3209 3205
                     . chr(128 + ($v & 63));
3210 3206
             } else if ($v < 1 << 26) {
3211 3207
                 // 5 bytes
3212 3208
                 $output .= chr(248 + ($v >> 24))
3213 3209
                     . chr(128 + (($v >> 18) & 63))
3214 3210
                     . chr(128 + (($v >> 12) & 63))
3215
-                    . chr(128 + (($v >>  6) & 63))
3211
+                    . chr(128 + (($v >> 6) & 63))
3216 3212
                     . chr(128 + ($v & 63));
3217 3213
             } else if ($v < 1 << 31) {
3218 3214
                 // 6 bytes
@@ -3220,7 +3216,7 @@  discard block
 block discarded – undo
3220 3216
                     . chr(128 + (($v >> 24) & 63))
3221 3217
                     . chr(128 + (($v >> 18) & 63))
3222 3218
                     . chr(128 + (($v >> 12) & 63))
3223
-                    . chr(128 + (($v >>  6) & 63))
3219
+                    . chr(128 + (($v >> 6) & 63))
3224 3220
                     . chr(128 + ($v & 63));
3225 3221
             } else {
3226 3222
                 throw new UnexpectedValueException('Conversion from UCS-4 to UTF-8 failed: malformed input');
@@ -3280,7 +3276,7 @@  discard block
 block discarded – undo
3280 3276
                 $out_len++;
3281 3277
                 $output[$out_len] = 0;
3282 3278
             }
3283
-            $output[$out_len] += ord($input{$i}) << (8 * (3 - ($i % 4) ) );
3279
+            $output[$out_len] += ord($input{$i}) << (8 * (3 - ($i % 4)));
3284 3280
         }
3285 3281
         return $output;
3286 3282
     }
@@ -3331,7 +3327,7 @@  discard block
 block discarded – undo
3331 3327
         $return = '';
3332 3328
 
3333 3329
         for ($i = $w; $i > -1; $i--) {
3334
-            $return .= ($octet & (1 << $i))? '1' : '0';
3330
+            $return .= ($octet & (1 << $i)) ? '1' : '0';
3335 3331
         }
3336 3332
 
3337 3333
         return $return;
Please login to merge, or discard this patch.
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -2340,7 +2340,9 @@  discard block
 block discarded – undo
2340 2340
         }
2341 2341
 
2342 2342
         // No input, no output, what else did you expect?
2343
-        if (empty($decoded)) return '';
2343
+        if (empty($decoded)) {
2344
+            return '';
2345
+        }
2344 2346
 
2345 2347
         // Anchors for iteration
2346 2348
         $last_begin = 0;
@@ -2438,7 +2440,9 @@  discard block
 block discarded – undo
2438 2440
             $arr = explode('.', $input);
2439 2441
             foreach ($arr as $k => $v) {
2440 2442
                 $conv = $this->_decode($v);
2441
-                if ($conv) $arr[$k] = $conv;
2443
+                if ($conv) {
2444
+                    $arr[$k] = $conv;
2445
+                }
2442 2446
             }
2443 2447
             $return = $email_pref . '@' . join('.', $arr);
2444 2448
         } elseif (preg_match('![:\./]!', $input)) { // Or a complete domain name (with or without paths / parameters)
@@ -2452,7 +2456,9 @@  discard block
 block discarded – undo
2452 2456
                 $arr = explode('.', $parsed['host']);
2453 2457
                 foreach ($arr as $k => $v) {
2454 2458
                     $conv = $this->_decode($v);
2455
-                    if ($conv) $arr[$k] = $conv;
2459
+                    if ($conv) {
2460
+                        $arr[$k] = $conv;
2461
+                    }
2456 2462
                 }
2457 2463
                 $parsed['host'] = join('.', $arr);
2458 2464
                 if (isset($parsed['scheme'])) {
@@ -2463,7 +2469,9 @@  discard block
 block discarded – undo
2463 2469
                 $arr = explode('.', $input);
2464 2470
                 foreach ($arr as $k => $v) {
2465 2471
                     $conv = $this->_decode($v);
2466
-                    if ($conv) $arr[$k] = $conv;
2472
+                    if ($conv) {
2473
+                        $arr[$k] = $conv;
2474
+                    }
2467 2475
                 }
2468 2476
                 $return = join('.', $arr);
2469 2477
             }
Please login to merge, or discard this patch.