CachesRepository::__construct() - Code Metrics - Inspection of "Rework for occ 78 occ 79 occ 80" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#812)

unknown

created 2021-01-11 16:42 UTC

CachesRepository::__construct() A

↳ Parent: CachesRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Oc\Repository;

use Doctrine\DBAL\Connection;
use Oc\Entity\CachesEntity;
use Oc\Repository\Exception\RecordAlreadyExistsException;
use Oc\Repository\Exception\RecordNotFoundException;
use Oc\Repository\Exception\RecordNotPersistedException;
use Oc\Repository\Exception\RecordsNotFoundException;

class CachesRepository
{
    const TABLE = 'caches';

    /** @var Connection */
    private $connection;

    public function __construct(Connection $connection)
    {
        $this->connection = $connection;
    }

    /**
     * @return CachesEntity[]
     */
    public function fetchAll()
    {
        $statement = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE)
            ->execute();

        $result = $statement->fetchAll();

        if ($statement->rowCount() === 0) {
            throw new RecordsNotFoundException('No records found');
        }

        $records = [];

        foreach ($result as $item) {
            $records[] = $this->getEntityFromDatabaseArray($item);
        }

        return $records;
    }

    /**
     * @return CachesEntity
     */
    public function fetchOneBy(array $where = [])
    {
        $queryBuilder = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE)
            ->setMaxResults(1);

        if (count($where) > 0) {
            foreach ($where as $column => $value) {
                $queryBuilder->andWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
            }
        }

        $statement = $queryBuilder->execute();

        $result = $statement->fetch();

        if ($statement->rowCount() === 0) {
            //            throw new RecordNotFoundException('Record with given where clause not found');
        } else {
            return $this->getEntityFromDatabaseArray($result);
        }
    }

    /**
     * @return CachesEntity[]
     */
    public function fetchBy(array $where = [])
    {
        $queryBuilder = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE);

        if (count($where) > 0) {
            foreach ($where as $column => $value) {
                $queryBuilder->orWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
            }
        }

        $statement = $queryBuilder->execute();
        $result = $statement->fetchAll();

        if ($statement->rowCount() === 0) {
            //            throw new RecordsNotFoundException('No records with given where clause found');
        } else {
            $entities = [];

            foreach ($result as $item) {
                $entities[] = $this->getEntityFromDatabaseArray($item);
            }
        }

        return $entities;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * @return CachesEntity
     */
    public function getIdByWP(string $wp = '')
    {
        $queryBuilder = $this->connection->createQueryBuilder()
            ->select('*')
            ->from(self::TABLE)
            ->setMaxResults(1);

        if ($wp != '') {
            $queryBuilder->where('wp_oc = ' . $queryBuilder->createNamedParameter($wp));
            $queryBuilder->orWhere('wp_gc = ' . $queryBuilder->createNamedParameter($wp));
        }

        $statement = $queryBuilder->execute();

        $result = $statement->fetch();

        if ($statement->rowCount() === 0) {
            //            throw new RecordNotFoundException('Record with given where clause not found');
        } else {
            return $result['cache_id'];
        }
    }

    public function getEntityFromDatabaseArray(array $data)
    {
        $entity = new CachesEntity();

        $entity->setCacheId((int) $data['cache_id']);
        $entity->setOCid((string) $data['wp_oc']);
        $entity->setGCid((string) $data['wp_gc']);
        $entity->setName((string) $data['name']);
        $entity->setUserId((int) $data['user_id']);
        // ..

        return $entity;
    }
}


1			<?php
2
3			namespace Oc\Repository;
4
5			use Doctrine\DBAL\Connection;
6			use Oc\Entity\CachesEntity;
7			use Oc\Repository\Exception\RecordAlreadyExistsException;
8			use Oc\Repository\Exception\RecordNotFoundException;
9			use Oc\Repository\Exception\RecordNotPersistedException;
10			use Oc\Repository\Exception\RecordsNotFoundException;
11
12			class CachesRepository
13			{
14			const TABLE = 'caches';
15
16			/** @var Connection */
17			private $connection;
18
19			public function __construct(Connection $connection)
20			{
21			$this->connection = $connection;
22			}
23
24			/**
25			* @return CachesEntity[]
26			*/
27			public function fetchAll()
28			{
29			$statement = $this->connection->createQueryBuilder()
30			->select('*')
31			->from(self::TABLE)
32			->execute();
33
34			$result = $statement->fetchAll();
35
36			if ($statement->rowCount() === 0) {
37			throw new RecordsNotFoundException('No records found');
38			}
39
40			$records = [];
41
42			foreach ($result as $item) {
43			$records[] = $this->getEntityFromDatabaseArray($item);
44			}
45
46			return $records;
47			}
48
49			/**
50			* @return CachesEntity
51			*/
52			public function fetchOneBy(array $where = [])
53			{
54			$queryBuilder = $this->connection->createQueryBuilder()
55			->select('*')
56			->from(self::TABLE)
57			->setMaxResults(1);
58
59			if (count($where) > 0) {
60			foreach ($where as $column => $value) {
61			$queryBuilder->andWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
62			}
63			}
64
65			$statement = $queryBuilder->execute();
66
67			$result = $statement->fetch();
68
69			if ($statement->rowCount() === 0) {
70			// throw new RecordNotFoundException('Record with given where clause not found');
71			} else {
72			return $this->getEntityFromDatabaseArray($result);
73			}
74			}
75
76			/**
77			* @return CachesEntity[]
78			*/
79			public function fetchBy(array $where = [])
80			{
81			$queryBuilder = $this->connection->createQueryBuilder()
82			->select('*')
83			->from(self::TABLE);
84
85			if (count($where) > 0) {
86			foreach ($where as $column => $value) {
87			$queryBuilder->orWhere($column . ' = ' . $queryBuilder->createNamedParameter($value));
88			}
89			}
90
91			$statement = $queryBuilder->execute();
92			$result = $statement->fetchAll();
93
94			if ($statement->rowCount() === 0) {
95			// throw new RecordsNotFoundException('No records with given where clause found');
96			} else {
97			$entities = [];
98
99			foreach ($result as $item) {
100			$entities[] = $this->getEntityFromDatabaseArray($item);
101			}
102			}
103
104			return $entities;
			0 ignored issues – show Bug introduced 2021-01-11 16:54 UTC by Report Bug Copy Issue Report The variable `$entities` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
105			}
106
107			/**
108			* @return CachesEntity
109			*/
110			public function getIdByWP(string $wp = '')
111			{
112			$queryBuilder = $this->connection->createQueryBuilder()
113			->select('*')
114			->from(self::TABLE)
115			->setMaxResults(1);
116
117			if ($wp != '') {
118			$queryBuilder->where('wp_oc = ' . $queryBuilder->createNamedParameter($wp));
119			$queryBuilder->orWhere('wp_gc = ' . $queryBuilder->createNamedParameter($wp));
120			}
121
122			$statement = $queryBuilder->execute();
123
124			$result = $statement->fetch();
125
126			if ($statement->rowCount() === 0) {
127			// throw new RecordNotFoundException('Record with given where clause not found');
128			} else {
129			return $result['cache_id'];
130			}
131			}
132
133			public function getEntityFromDatabaseArray(array $data)
134			{
135			$entity = new CachesEntity();
136
137			$entity->setCacheId((int) $data['cache_id']);
138			$entity->setOCid((string) $data['wp_oc']);
139			$entity->setGCid((string) $data['wp_gc']);
140			$entity->setName((string) $data['name']);
141			$entity->setUserId((int) $data['user_id']);
142			// ..
143
144			return $entity;
145			}
146			}
147

OpencachingDeutschland / oc-server3

Pull Request — development (#812)

CachesRepository::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like