Inspection of "Fix/open bug bounty issues" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#894)

unknown

created 2022-09-04 19:32 UTC

Status

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -22,29 +22,29 @@
 block discarded – undo
         $builder
             ->add(
                 'email', EmailType::Class, [
-                           'attr' => [
-                               'autofocus' => 'autofocus',
-                               'size' => '10%',
-                               'style' => 'width: 250px;'
-                           ],
-                           'required' => true,
-                           'disabled' => false,
-                           'label' => false,
-                           'trim' => true
-                       ]
+                            'attr' => [
+                                'autofocus' => 'autofocus',
+                                'size' => '10%',
+                                'style' => 'width: 250px;'
+                            ],
+                            'required' => true,
+                            'disabled' => false,
+                            'label' => false,
+                            'trim' => true
+                        ]
             )
             ->add(
                 'activationCode', null, [
-                              'attr' => [
-                                  'size' => '10%',
-                                  'pattern' => '[A-F0-9]{13}',
-                                  'style' => 'width: 250px;'
-                              ],
-                              'required' => true,
-                              'disabled' => false,
-                              'label' => false,
-                              'trim' => true
-                          ]
+                                'attr' => [
+                                    'size' => '10%',
+                                    'pattern' => '[A-F0-9]{13}',
+                                    'style' => 'width: 250px;'
+                                ],
+                                'required' => true,
+                                'disabled' => false,
+                                'label' => false,
+                                'trim' => true
+                            ]
             )
             ->add(
                 'submit', SubmitType::class, [

Please login to merge, or discard this patch.

htdocs_symfony/src/Form/UserRegistrationForm.php 1 patch

Indentation +81 added lines, -81 removed lines patch added patch discarded remove patch

@@ -27,102 +27,102 @@  discard block
 block discarded – undo
         $builder
             ->add(
                 'username', null, [
-                              'attr' => [
-                                  'autofocus' => 'autofocus',
-                                  'size' => '10%',
-                                  'pattern' => '[a-zA-Z0-9_-]{3,60}',
-                                  'style' => 'width: 250px;'
-                              ],
-                              'required' => true,
-                              'disabled' => false,
-                              'label' => false,
-                              'trim' => true
-                          ]
+                                'attr' => [
+                                    'autofocus' => 'autofocus',
+                                    'size' => '10%',
+                                    'pattern' => '[a-zA-Z0-9_-]{3,60}',
+                                    'style' => 'width: 250px;'
+                                ],
+                                'required' => true,
+                                'disabled' => false,
+                                'label' => false,
+                                'trim' => true
+                            ]
             )
             ->add(
                 'firstname', null, [
-                               'attr' => [
-                                   'size' => '10%',
-                                   'minlength' => '3',
-                                   'maxlength' => '100',
-                                   'style' => 'width: 250px;'
-                               ],
-                               'required' => false,
-                               'disabled' => false,
-                               'label' => false,
-                               'trim' => true
-                           ]
+                                'attr' => [
+                                    'size' => '10%',
+                                    'minlength' => '3',
+                                    'maxlength' => '100',
+                                    'style' => 'width: 250px;'
+                                ],
+                                'required' => false,
+                                'disabled' => false,
+                                'label' => false,
+                                'trim' => true
+                            ]
             )
             ->add(
                 'lastname', null, [
-                              'attr' => [
-                                  'size' => '10%',
-                                  'minlength' => '3',
-                                  'maxlength' => '100',
-                                  'style' => 'width: 250px;'
-                              ],
-                              'required' => false,
-                              'disabled' => false,
-                              'label' => false,
-                              'trim' => true
-                          ]
+                                'attr' => [
+                                    'size' => '10%',
+                                    'minlength' => '3',
+                                    'maxlength' => '100',
+                                    'style' => 'width: 250px;'
+                                ],
+                                'required' => false,
+                                'disabled' => false,
+                                'label' => false,
+                                'trim' => true
+                            ]
             )
             ->add(
                 'country', ChoiceType::Class, [
-                             'attr' => [
-                                 'expanded' => false,
-                                 'multiple' => false,
-                                 'style' => 'width: 250px;'
-                             ],
-                             'choices' => $options['countryList'],
-                             'required' => false,
-                             'disabled' => false,
-                             'label' => false,
-                         ]
+                                'attr' => [
+                                    'expanded' => false,
+                                    'multiple' => false,
+                                    'style' => 'width: 250px;'
+                                ],
+                                'choices' => $options['countryList'],
+                                'required' => false,
+                                'disabled' => false,
+                                'label' => false,
+                            ]
             )
             ->add(
                 'email', EmailType::Class, [
-                           'attr' => [
-                               'size' => '10%',
-                               'minlength' => '3',
-                               'maxlength' => '100',
-                               'style' => 'width: 250px;'
-                           ],
-                           'required' => true,
-                           'disabled' => false,
-                           'label' => false,
-                           'trim' => true
-                       ]
+                            'attr' => [
+                                'size' => '10%',
+                                'minlength' => '3',
+                                'maxlength' => '100',
+                                'style' => 'width: 250px;'
+                            ],
+                            'required' => true,
+                            'disabled' => false,
+                            'label' => false,
+                            'trim' => true
+                        ]
             )
             ->add(
                 'plainPassword', RepeatedType::Class, [
-                                   'options' => [
-                                       'attr' => [
-                                           'size' => '10%',
-                                           'minlength' => '8',
-                                           'maxlength' => '60',
-                                           // TODO: pattern anpassen. Aktuell: Minimum eight characters, at least one letter, one number and one special character.
-                                           'pattern' => '^(?=.*[A-Za-z])(?=.*\d)(?=.*[@$!%*#?&])[A-Za-z\d@$!%*#?&]{8,}$',
-                                           'style' => 'width: 250px;'
-                                       ]
-                                   ],
-                                   'first_options' => ['label' => false, 'error_bubbling' => true],
-                                   'second_options' => ['label' => false],
-                                   'required' => true,
-                                   'disabled' => false,
-                                   'trim' => true,
-                                   'type' => PasswordType::class,
-                                   'invalid_message' => 'Your passwords do not match.',
-                                   'mapped' => false,
-                               ]
+                                    'options' => [
+                                        'attr' => [
+                                            'size' => '10%',
+                                            'minlength' => '8',
+                                            'maxlength' => '60',
+                                            // TODO: pattern anpassen. Aktuell: Minimum eight characters, at least one letter, one number and one special character.
+                                            'pattern' => '^(?=.*[A-Za-z])(?=.*\d)(?=.*[@$!%*#?&])[A-Za-z\d@$!%*#?&]{8,}$',
+                                            'style' => 'width: 250px;'
+                                        ]
+                                    ],
+                                    'first_options' => ['label' => false, 'error_bubbling' => true],
+                                    'second_options' => ['label' => false],
+                                    'required' => true,
+                                    'disabled' => false,
+                                    'trim' => true,
+                                    'type' => PasswordType::class,
+                                    'invalid_message' => 'Your passwords do not match.',
+                                    'mapped' => false,
+                                ]
             )
             ->add(
                 'tos', CheckboxType::class, [
-                         'attr' => [],
-                         'label' => false,
-                         'mapped' => false,
-                         'required' => true,
-                     ]
+                            'attr' => [],
+                            'label' => false,
+                            'mapped' => false,
+                            'required' => true,
+                        ]
             )
             ->add(
                 'submit', SubmitType::class, [
@@ -140,8 +140,8 @@  discard block
 block discarded – undo
     public function configureOptions(OptionsResolver $resolver)
     : void {
         $resolver->setDefaults([
-                                   'countryList' => [],
-                                   'data_class' => UserEntity::class,
-                               ]);
+                                    'countryList' => [],
+                                    'data_class' => UserEntity::class,
+                                ]);
     }
 }

Please login to merge, or discard this patch.

htdocs_symfony/public/index.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -20,8 +20,8 @@
 block discarded – undo
 if ($trustedProxies = $_SERVER['TRUSTED_PROXIES'] ?? false) {
     Request::setTrustedProxies(
         explode(',', $trustedProxies), Request::HEADER_X_FORWARDED_FOR
-                                       ^ Request::HEADER_X_FORWARDED_PROTO
-                                       ^ Request::HEADER_X_FORWARDED_PORT
+                                        ^ Request::HEADER_X_FORWARDED_PROTO
+                                        ^ Request::HEADER_X_FORWARDED_PORT
     );
 }
 

Please login to merge, or discard this patch.

htdocs_symfony/src/Controller/Backend/SupportController.php 1 patch

Indentation +65 added lines, -65 removed lines patch added patch discarded remove patch

@@ -187,9 +187,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/searchedCaches.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'foundCaches' => $fetchedCaches
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'foundCaches' => $fetchedCaches
+                                                        ]
         );
     }
 
@@ -211,9 +211,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/reportedCaches.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'reportedCaches_by_id' => $fetchedReports
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'reportedCaches_by_id' => $fetchedReports
+                                                        ]
         );
     }
 
@@ -234,10 +234,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCaches.html.twig', [
-                                                       'supportCachesForm' => $formSearch->createView(),
-                                                       'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
-                                                       'bonusCaches_by_id' => $fetchedBonuscaches
-                                                   ]
+                                                        'supportCachesForm' => $formSearch->createView(),
+                                                        'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
+                                                        'bonusCaches_by_id' => $fetchedBonuscaches
+                                                    ]
         );
     }
 
@@ -260,10 +260,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCachesAssignment.html.twig', [
-                                                                 'supportCachesForm' => $formSearch->createView(),
-                                                                 'bonus_Cache' => $wpID,
-                                                                 'caches_by_owner' => $fetchedOwnerCaches
-                                                             ]
+                                                                    'supportCachesForm' => $formSearch->createView(),
+                                                                    'bonus_Cache' => $wpID,
+                                                                    'caches_by_owner' => $fetchedOwnerCaches
+                                                                ]
         );
     }
 
@@ -290,10 +290,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCachesAssignment.html.twig', [
-                                                                 'supportCachesForm' => $formSearch->createView(),
-                                                                 'bonus_Cache' => $toBonusCache,
-                                                                 'caches_by_owner' => $fetchedOwnerCaches
-                                                             ]
+                                                                    'supportCachesForm' => $formSearch->createView(),
+                                                                    'bonus_Cache' => $toBonusCache,
+                                                                    'caches_by_owner' => $fetchedOwnerCaches
+                                                                ]
         );
     }
 
@@ -402,10 +402,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'SQLFlexForm' => $formSQLFlex->createView(),
-                                                           'suppSQLqueryFlex' => $fetchedInformation
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'SQLFlexForm' => $formSQLFlex->createView(),
+                                                            'suppSQLqueryFlex' => $fetchedInformation
+                                                        ]
         );
     }
 
@@ -541,16 +541,16 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/occ.html.twig', [
-                                               'supportCachesForm' => $formSearch->createView(),
-                                               'supportCommentFormUser' => $formCommentUser->createView(),
-                                               'supportCommentFormCache' => $formCommentCache->createView(),
-                                               'occ_cache_data' => $fetchedCacheData,
-                                               'occ_cache_comments' => $fetchedCacheComments,
-                                               'occ_cache_infos' => $fetchedCacheInfos,
-                                               'occ_user_data' => $fetchedUserData,
-                                               'occ_user_comments' => $fetchedUserComments,
-                                               'occ_user_relations' => $fetchedUserRelations
-                                           ]
+                                                'supportCachesForm' => $formSearch->createView(),
+                                                'supportCommentFormUser' => $formCommentUser->createView(),
+                                                'supportCommentFormCache' => $formCommentCache->createView(),
+                                                'occ_cache_data' => $fetchedCacheData,
+                                                'occ_cache_comments' => $fetchedCacheComments,
+                                                'occ_cache_infos' => $fetchedCacheInfos,
+                                                'occ_user_data' => $fetchedUserData,
+                                                'occ_user_comments' => $fetchedUserComments,
+                                                'occ_user_relations' => $fetchedUserRelations
+                                            ]
         );
     }
 
@@ -684,10 +684,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/userDetails.html.twig', [
-                                                       'supportCachesForm' => $formSearch->createView(),
-                                                       'supportUserAccountActions' => $formActions->createView(),
-                                                       'user_account_details' => $fetchedUserDetails
-                                                   ]
+                                                        'supportCachesForm' => $formSearch->createView(),
+                                                        'supportUserAccountActions' => $formActions->createView(),
+                                                        'user_account_details' => $fetchedUserDetails
+                                                    ]
         );
     }
 
@@ -786,9 +786,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
+                                                        ]
         );
     }
 
@@ -815,9 +815,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
+                                                        ]
         );
     }
 
@@ -851,9 +851,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
+                                                        ]
         );
     }
 
@@ -872,9 +872,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
+                                                        ]
         );
     }
 
@@ -919,9 +919,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery6' => $qb_caches_list
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery6' => $qb_caches_list
+                                                        ]
         );
     }
 
@@ -1037,15 +1037,15 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/occ_gpx_import.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'supportUploadGPXForm' => $formUpload->createView(),
-                                                          'amountProcessedCaches' => $amountProcessedCaches,
-                                                          'amountAssignedCaches' => $amountAssignedCaches,
-                                                          'amountUpdatedCaches' => $amountUpdatedCaches,
-                                                          'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
-                                                          'fetchedListingInfos' => $fetchedListingInfos,
-                                                          'differencesDetected' => $differencesDetected
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'supportUploadGPXForm' => $formUpload->createView(),
+                                                            'amountProcessedCaches' => $amountProcessedCaches,
+                                                            'amountAssignedCaches' => $amountAssignedCaches,
+                                                            'amountUpdatedCaches' => $amountUpdatedCaches,
+                                                            'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
+                                                            'fetchedListingInfos' => $fetchedListingInfos,
+                                                            'differencesDetected' => $differencesDetected
+                                                        ]
         );
     }
 
@@ -1209,11 +1209,11 @@  discard block
 block discarded – undo
                     ] as $checkItem) {
                         if ($wpt[$checkItem] != $fetchedExistingSupportListingInfoArray[$checkItem]) {
                             $newComment .= $checkItem
-                                           . ' changed from '
-                                           . $fetchedExistingSupportListingInfoArray[$checkItem]
-                                           . ' to '
-                                           . $wpt[$checkItem]
-                                           . PHP_EOL;
+                                            . ' changed from '
+                                            . $fetchedExistingSupportListingInfoArray[$checkItem]
+                                            . ' to '
+                                            . $wpt[$checkItem]
+                                            . PHP_EOL;
                         }
                     }
 

Please login to merge, or discard this patch.

htdocs_symfony/src/Form/SupportImportGPX.php 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -27,14 +27,14 @@  discard block
 block discarded – undo
                                 ],
                                 'constraints' => [
                                     new File([
-                                                 'maxSize' => '20480000',
-                                                 'mimeTypes' => [
-                                                     'application/gpx+xml',
-                                                     'application/xml',
-                                                     'text/xml',
-                                                 ],
-                                                 'mimeTypesMessage' => 'Please upload a valid GPX/XML document',
-                                             ])
+                                                    'maxSize' => '20480000',
+                                                    'mimeTypes' => [
+                                                        'application/gpx+xml',
+                                                        'application/xml',
+                                                        'text/xml',
+                                                    ],
+                                                    'mimeTypesMessage' => 'Please upload a valid GPX/XML document',
+                                                ])
                                 ],
                                 'multiple' => false,
                                 'required' => true,
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
             )
             ->add(
                 'start_upload', SubmitType::class, [
-                                  'attr' => ['class' => 'btn btn-primary', 'style' => 'width: 100px;'],
-                                  'label' => '

Please login to merge, or discard this patch.

htdocs_symfony/src/Form/SupportCommentField.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -24,22 +24,22 @@
 block discarded – undo
         $builder
             ->add(
                 'content_comment_field', TextareaType::class, [
-                                           'attr' => [
-                                               'maxlength' => '100000',
-                                               'overflow' => 'auto',
-                                               'rows' => '10',
-                                           ],
-                                           'required' => false,
-                                           'disabled' => false,
-                                           'label' => false,
-                                           'trim' => true
-                                       ]
+                                            'attr' => [
+                                                'maxlength' => '100000',
+                                                'overflow' => 'auto',
+                                                'rows' => '10',
+                                            ],
+                                            'required' => false,
+                                            'disabled' => false,
+                                            'label' => false,
+                                            'trim' => true
+                                        ]
             )
             ->add(
                 'save_comment_button', SubmitType::class, [
-                                         'attr' => ['class' => 'btn btn-primary', 'style' => 'width: 180px;'],
-                                         'label' => '

Please login to merge, or discard this patch.

		@@ -22,29 +22,29 @@
		block discarded – undo
22	22	$builder
23	23	->add(
24	24	'email', EmailType::Class, [
25		- 'attr' => [
26		- 'autofocus' => 'autofocus',
27		- 'size' => '10%',
28		- 'style' => 'width: 250px;'
29		- ],
30		- 'required' => true,
31		- 'disabled' => false,
32		- 'label' => false,
33		- 'trim' => true
34		- ]
	25	+ 'attr' => [
	26	+ 'autofocus' => 'autofocus',
	27	+ 'size' => '10%',
	28	+ 'style' => 'width: 250px;'
	29	+ ],
	30	+ 'required' => true,
	31	+ 'disabled' => false,
	32	+ 'label' => false,
	33	+ 'trim' => true
	34	+ ]
35	35	)
36	36	->add(
37	37	'activationCode', null, [
38		- 'attr' => [
39		- 'size' => '10%',
40		- 'pattern' => '[A-F0-9]{13}',
41		- 'style' => 'width: 250px;'
42		- ],
43		- 'required' => true,
44		- 'disabled' => false,
45		- 'label' => false,
46		- 'trim' => true
47		- ]
	38	+ 'attr' => [
	39	+ 'size' => '10%',
	40	+ 'pattern' => '[A-F0-9]{13}',
	41	+ 'style' => 'width: 250px;'
	42	+ ],
	43	+ 'required' => true,
	44	+ 'disabled' => false,
	45	+ 'label' => false,
	46	+ 'trim' => true
	47	+ ]
48	48	)
49	49	->add(
50	50	'submit', SubmitType::class, [

		@@ -27,102 +27,102 @@ discard block
		block discarded – undo
27	27	$builder
28	28	->add(
29	29	'username', null, [
30		- 'attr' => [
31		- 'autofocus' => 'autofocus',
32		- 'size' => '10%',
33		- 'pattern' => '[a-zA-Z0-9_-]{3,60}',
34		- 'style' => 'width: 250px;'
35		- ],
36		- 'required' => true,
37		- 'disabled' => false,
38		- 'label' => false,
39		- 'trim' => true
40		- ]
	30	+ 'attr' => [
	31	+ 'autofocus' => 'autofocus',
	32	+ 'size' => '10%',
	33	+ 'pattern' => '[a-zA-Z0-9_-]{3,60}',
	34	+ 'style' => 'width: 250px;'
	35	+ ],
	36	+ 'required' => true,
	37	+ 'disabled' => false,
	38	+ 'label' => false,
	39	+ 'trim' => true
	40	+ ]
41	41	)
42	42	->add(
43	43	'firstname', null, [
44		- 'attr' => [
45		- 'size' => '10%',
46		- 'minlength' => '3',
47		- 'maxlength' => '100',
48		- 'style' => 'width: 250px;'
49		- ],
50		- 'required' => false,
51		- 'disabled' => false,
52		- 'label' => false,
53		- 'trim' => true
54		- ]
	44	+ 'attr' => [
	45	+ 'size' => '10%',
	46	+ 'minlength' => '3',
	47	+ 'maxlength' => '100',
	48	+ 'style' => 'width: 250px;'
	49	+ ],
	50	+ 'required' => false,
	51	+ 'disabled' => false,
	52	+ 'label' => false,
	53	+ 'trim' => true
	54	+ ]
55	55	)
56	56	->add(
57	57	'lastname', null, [
58		- 'attr' => [
59		- 'size' => '10%',
60		- 'minlength' => '3',
61		- 'maxlength' => '100',
62		- 'style' => 'width: 250px;'
63		- ],
64		- 'required' => false,
65		- 'disabled' => false,
66		- 'label' => false,
67		- 'trim' => true
68		- ]
	58	+ 'attr' => [
	59	+ 'size' => '10%',
	60	+ 'minlength' => '3',
	61	+ 'maxlength' => '100',
	62	+ 'style' => 'width: 250px;'
	63	+ ],
	64	+ 'required' => false,
	65	+ 'disabled' => false,
	66	+ 'label' => false,
	67	+ 'trim' => true
	68	+ ]
69	69	)
70	70	->add(
71	71	'country', ChoiceType::Class, [
72		- 'attr' => [
73		- 'expanded' => false,
74		- 'multiple' => false,
75		- 'style' => 'width: 250px;'
76		- ],
77		- 'choices' => $options['countryList'],
78		- 'required' => false,
79		- 'disabled' => false,
80		- 'label' => false,
81		- ]
	72	+ 'attr' => [
	73	+ 'expanded' => false,
	74	+ 'multiple' => false,
	75	+ 'style' => 'width: 250px;'
	76	+ ],
	77	+ 'choices' => $options['countryList'],
	78	+ 'required' => false,
	79	+ 'disabled' => false,
	80	+ 'label' => false,
	81	+ ]
82	82	)
83	83	->add(
84	84	'email', EmailType::Class, [
85		- 'attr' => [
86		- 'size' => '10%',
87		- 'minlength' => '3',
88		- 'maxlength' => '100',
89		- 'style' => 'width: 250px;'
90		- ],
91		- 'required' => true,
92		- 'disabled' => false,
93		- 'label' => false,
94		- 'trim' => true
95		- ]
	85	+ 'attr' => [
	86	+ 'size' => '10%',
	87	+ 'minlength' => '3',
	88	+ 'maxlength' => '100',
	89	+ 'style' => 'width: 250px;'
	90	+ ],
	91	+ 'required' => true,
	92	+ 'disabled' => false,
	93	+ 'label' => false,
	94	+ 'trim' => true
	95	+ ]
96	96	)
97	97	->add(
98	98	'plainPassword', RepeatedType::Class, [
99		- 'options' => [
100		- 'attr' => [
101		- 'size' => '10%',
102		- 'minlength' => '8',
103		- 'maxlength' => '60',
104		- // TODO: pattern anpassen. Aktuell: Minimum eight characters, at least one letter, one number and one special character.
105		- 'pattern' => '^(?=.[A-Za-z])(?=.\d)(?=.[@$!%#?&])[A-Za-z\d@$!%*#?&]{8,}$',
106		- 'style' => 'width: 250px;'
107		- ]
108		- ],
109		- 'first_options' => ['label' => false, 'error_bubbling' => true],
110		- 'second_options' => ['label' => false],
111		- 'required' => true,
112		- 'disabled' => false,
113		- 'trim' => true,
114		- 'type' => PasswordType::class,
115		- 'invalid_message' => 'Your passwords do not match.',
116		- 'mapped' => false,
117		- ]
	99	+ 'options' => [
	100	+ 'attr' => [
	101	+ 'size' => '10%',
	102	+ 'minlength' => '8',
	103	+ 'maxlength' => '60',
	104	+ // TODO: pattern anpassen. Aktuell: Minimum eight characters, at least one letter, one number and one special character.
	105	+ 'pattern' => '^(?=.[A-Za-z])(?=.\d)(?=.[@$!%#?&])[A-Za-z\d@$!%*#?&]{8,}$',
	106	+ 'style' => 'width: 250px;'
	107	+ ]
	108	+ ],
	109	+ 'first_options' => ['label' => false, 'error_bubbling' => true],
	110	+ 'second_options' => ['label' => false],
	111	+ 'required' => true,
	112	+ 'disabled' => false,
	113	+ 'trim' => true,
	114	+ 'type' => PasswordType::class,
	115	+ 'invalid_message' => 'Your passwords do not match.',
	116	+ 'mapped' => false,
	117	+ ]
118	118	)
119	119	->add(
120	120	'tos', CheckboxType::class, [
121		- 'attr' => [],
122		- 'label' => false,
123		- 'mapped' => false,
124		- 'required' => true,
125		- ]
	121	+ 'attr' => [],
	122	+ 'label' => false,
	123	+ 'mapped' => false,
	124	+ 'required' => true,
	125	+ ]
126	126	)
127	127	->add(
128	128	'submit', SubmitType::class, [
		@@ -140,8 +140,8 @@ discard block
		block discarded – undo
140	140	public function configureOptions(OptionsResolver $resolver)
141	141	: void {
142	142	$resolver->setDefaults([
143		- 'countryList' => [],
144		- 'data_class' => UserEntity::class,
145		- ]);
	143	+ 'countryList' => [],
	144	+ 'data_class' => UserEntity::class,
	145	+ ]);
146	146	}
147	147	}

		@@ -20,8 +20,8 @@
		block discarded – undo
20	20	if ($trustedProxies = $_SERVER['TRUSTED_PROXIES'] ?? false) {
21	21	Request::setTrustedProxies(
22	22	explode(',', $trustedProxies), Request::HEADER_X_FORWARDED_FOR
23		- ^ Request::HEADER_X_FORWARDED_PROTO
24		- ^ Request::HEADER_X_FORWARDED_PORT
	23	+ ^ Request::HEADER_X_FORWARDED_PROTO
	24	+ ^ Request::HEADER_X_FORWARDED_PORT
25	25	);
26	26	}
27	27

		@@ -187,9 +187,9 @@ discard block
		block discarded – undo
187	187
188	188	return $this->render(
189	189	'backend/support/searchedCaches.html.twig', [
190		- 'supportCachesForm' => $formSearch->createView(),
191		- 'foundCaches' => $fetchedCaches
192		- ]
	190	+ 'supportCachesForm' => $formSearch->createView(),
	191	+ 'foundCaches' => $fetchedCaches
	192	+ ]
193	193	);
194	194	}
195	195
		@@ -211,9 +211,9 @@ discard block
		block discarded – undo
211	211
212	212	return $this->render(
213	213	'backend/support/reportedCaches.html.twig', [
214		- 'supportCachesForm' => $formSearch->createView(),
215		- 'reportedCaches_by_id' => $fetchedReports
216		- ]
	214	+ 'supportCachesForm' => $formSearch->createView(),
	215	+ 'reportedCaches_by_id' => $fetchedReports
	216	+ ]
217	217	);
218	218	}
219	219
		@@ -234,10 +234,10 @@ discard block
		block discarded – undo
234	234
235	235	return $this->render(
236	236	'backend/support/bonusCaches.html.twig', [
237		- 'supportCachesForm' => $formSearch->createView(),
238		- 'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
239		- 'bonusCaches_by_id' => $fetchedBonuscaches
240		- ]
	237	+ 'supportCachesForm' => $formSearch->createView(),
	238	+ 'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
	239	+ 'bonusCaches_by_id' => $fetchedBonuscaches
	240	+ ]
241	241	);
242	242	}
243	243
		@@ -260,10 +260,10 @@ discard block
		block discarded – undo
260	260
261	261	return $this->render(
262	262	'backend/support/bonusCachesAssignment.html.twig', [
263		- 'supportCachesForm' => $formSearch->createView(),
264		- 'bonus_Cache' => $wpID,
265		- 'caches_by_owner' => $fetchedOwnerCaches
266		- ]
	263	+ 'supportCachesForm' => $formSearch->createView(),
	264	+ 'bonus_Cache' => $wpID,
	265	+ 'caches_by_owner' => $fetchedOwnerCaches
	266	+ ]
267	267	);
268	268	}
269	269
		@@ -290,10 +290,10 @@ discard block
		block discarded – undo
290	290
291	291	return $this->render(
292	292	'backend/support/bonusCachesAssignment.html.twig', [
293		- 'supportCachesForm' => $formSearch->createView(),
294		- 'bonus_Cache' => $toBonusCache,
295		- 'caches_by_owner' => $fetchedOwnerCaches
296		- ]
	293	+ 'supportCachesForm' => $formSearch->createView(),
	294	+ 'bonus_Cache' => $toBonusCache,
	295	+ 'caches_by_owner' => $fetchedOwnerCaches
	296	+ ]
297	297	);
298	298	}
299	299
		@@ -402,10 +402,10 @@ discard block
		block discarded – undo
402	402
403	403	return $this->render(
404	404	'backend/support/databaseQueries.html.twig', [
405		- 'supportCachesForm' => $formSearch->createView(),
406		- 'SQLFlexForm' => $formSQLFlex->createView(),
407		- 'suppSQLqueryFlex' => $fetchedInformation
408		- ]
	405	+ 'supportCachesForm' => $formSearch->createView(),
	406	+ 'SQLFlexForm' => $formSQLFlex->createView(),
	407	+ 'suppSQLqueryFlex' => $fetchedInformation
	408	+ ]
409	409	);
410	410	}
411	411
		@@ -541,16 +541,16 @@ discard block
		block discarded – undo
541	541
542	542	return $this->render(
543	543	'backend/support/occ.html.twig', [
544		- 'supportCachesForm' => $formSearch->createView(),
545		- 'supportCommentFormUser' => $formCommentUser->createView(),
546		- 'supportCommentFormCache' => $formCommentCache->createView(),
547		- 'occ_cache_data' => $fetchedCacheData,
548		- 'occ_cache_comments' => $fetchedCacheComments,
549		- 'occ_cache_infos' => $fetchedCacheInfos,
550		- 'occ_user_data' => $fetchedUserData,
551		- 'occ_user_comments' => $fetchedUserComments,
552		- 'occ_user_relations' => $fetchedUserRelations
553		- ]
	544	+ 'supportCachesForm' => $formSearch->createView(),
	545	+ 'supportCommentFormUser' => $formCommentUser->createView(),
	546	+ 'supportCommentFormCache' => $formCommentCache->createView(),
	547	+ 'occ_cache_data' => $fetchedCacheData,
	548	+ 'occ_cache_comments' => $fetchedCacheComments,
	549	+ 'occ_cache_infos' => $fetchedCacheInfos,
	550	+ 'occ_user_data' => $fetchedUserData,
	551	+ 'occ_user_comments' => $fetchedUserComments,
	552	+ 'occ_user_relations' => $fetchedUserRelations
	553	+ ]
554	554	);
555	555	}
556	556
		@@ -684,10 +684,10 @@ discard block
		block discarded – undo
684	684
685	685	return $this->render(
686	686	'backend/support/userDetails.html.twig', [
687		- 'supportCachesForm' => $formSearch->createView(),
688		- 'supportUserAccountActions' => $formActions->createView(),
689		- 'user_account_details' => $fetchedUserDetails
690		- ]
	687	+ 'supportCachesForm' => $formSearch->createView(),
	688	+ 'supportUserAccountActions' => $formActions->createView(),
	689	+ 'user_account_details' => $fetchedUserDetails
	690	+ ]
691	691	);
692	692	}
693	693
		@@ -786,9 +786,9 @@ discard block
		block discarded – undo
786	786
787	787	return $this->render(
788	788	'backend/support/databaseQueries.html.twig', [
789		- 'supportCachesForm' => $formSearch->createView(),
790		- 'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
791		- ]
	789	+ 'supportCachesForm' => $formSearch->createView(),
	790	+ 'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
	791	+ ]
792	792	);
793	793	}
794	794
		@@ -815,9 +815,9 @@ discard block
		block discarded – undo
815	815
816	816	return $this->render(
817	817	'backend/support/databaseQueries.html.twig', [
818		- 'supportCachesForm' => $formSearch->createView(),
819		- 'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
820		- ]
	818	+ 'supportCachesForm' => $formSearch->createView(),
	819	+ 'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
	820	+ ]
821	821	);
822	822	}
823	823
		@@ -851,9 +851,9 @@ discard block
		block discarded – undo
851	851
852	852	return $this->render(
853	853	'backend/support/databaseQueries.html.twig', [
854		- 'supportCachesForm' => $formSearch->createView(),
855		- 'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
856		- ]
	854	+ 'supportCachesForm' => $formSearch->createView(),
	855	+ 'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
	856	+ ]
857	857	);
858	858	}
859	859
		@@ -872,9 +872,9 @@ discard block
		block discarded – undo
872	872
873	873	return $this->render(
874	874	'backend/support/databaseQueries.html.twig', [
875		- 'supportCachesForm' => $formSearch->createView(),
876		- 'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
877		- ]
	875	+ 'supportCachesForm' => $formSearch->createView(),
	876	+ 'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
	877	+ ]
878	878	);
879	879	}
880	880
		@@ -919,9 +919,9 @@ discard block
		block discarded – undo
919	919
920	920	return $this->render(
921	921	'backend/support/databaseQueries.html.twig', [
922		- 'supportCachesForm' => $formSearch->createView(),
923		- 'suppSQLquery6' => $qb_caches_list
924		- ]
	922	+ 'supportCachesForm' => $formSearch->createView(),
	923	+ 'suppSQLquery6' => $qb_caches_list
	924	+ ]
925	925	);
926	926	}
927	927
		@@ -1037,15 +1037,15 @@ discard block
		block discarded – undo
1037	1037
1038	1038	return $this->render(
1039	1039	'backend/support/occ_gpx_import.html.twig', [
1040		- 'supportCachesForm' => $formSearch->createView(),
1041		- 'supportUploadGPXForm' => $formUpload->createView(),
1042		- 'amountProcessedCaches' => $amountProcessedCaches,
1043		- 'amountAssignedCaches' => $amountAssignedCaches,
1044		- 'amountUpdatedCaches' => $amountUpdatedCaches,
1045		- 'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
1046		- 'fetchedListingInfos' => $fetchedListingInfos,
1047		- 'differencesDetected' => $differencesDetected
1048		- ]
	1040	+ 'supportCachesForm' => $formSearch->createView(),
	1041	+ 'supportUploadGPXForm' => $formUpload->createView(),
	1042	+ 'amountProcessedCaches' => $amountProcessedCaches,
	1043	+ 'amountAssignedCaches' => $amountAssignedCaches,
	1044	+ 'amountUpdatedCaches' => $amountUpdatedCaches,
	1045	+ 'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
	1046	+ 'fetchedListingInfos' => $fetchedListingInfos,
	1047	+ 'differencesDetected' => $differencesDetected
	1048	+ ]
1049	1049	);
1050	1050	}
1051	1051
		@@ -1209,11 +1209,11 @@ discard block
		block discarded – undo
1209	1209	] as $checkItem) {
1210	1210	if ($wpt[$checkItem] != $fetchedExistingSupportListingInfoArray[$checkItem]) {
1211	1211	$newComment .= $checkItem
1212		- . ' changed from '
1213		- . $fetchedExistingSupportListingInfoArray[$checkItem]
1214		- . ' to '
1215		- . $wpt[$checkItem]
1216		- . PHP_EOL;
	1212	+ . ' changed from '
	1213	+ . $fetchedExistingSupportListingInfoArray[$checkItem]
	1214	+ . ' to '
	1215	+ . $wpt[$checkItem]
	1216	+ . PHP_EOL;
1217	1217	}
1218	1218	}
1219	1219

		@@ -27,14 +27,14 @@ discard block
		block discarded – undo
27	27	],
28	28	'constraints' => [
29	29	new File([
30		- 'maxSize' => '20480000',
31		- 'mimeTypes' => [
32		- 'application/gpx+xml',
33		- 'application/xml',
34		- 'text/xml',
35		- ],
36		- 'mimeTypesMessage' => 'Please upload a valid GPX/XML document',
37		- ])
	30	+ 'maxSize' => '20480000',
	31	+ 'mimeTypes' => [
	32	+ 'application/gpx+xml',
	33	+ 'application/xml',
	34	+ 'text/xml',
	35	+ ],
	36	+ 'mimeTypesMessage' => 'Please upload a valid GPX/XML document',
	37	+ ])
38	38	],
39	39	'multiple' => false,
40	40	'required' => true,
		@@ -45,9 +45,9 @@ discard block
		block discarded – undo
45	45	)
46	46	->add(
47	47	'start_upload', SubmitType::class, [
48		- 'attr' => ['class' => 'btn btn-primary', 'style' => 'width: 100px;'],
49		- 'label' => '

		@@ -24,22 +24,22 @@
		block discarded – undo
24	24	$builder
25	25	->add(
26	26	'content_comment_field', TextareaType::class, [
27		- 'attr' => [
28		- 'maxlength' => '100000',
29		- 'overflow' => 'auto',
30		- 'rows' => '10',
31		- ],
32		- 'required' => false,
33		- 'disabled' => false,
34		- 'label' => false,
35		- 'trim' => true
36		- ]
	27	+ 'attr' => [
	28	+ 'maxlength' => '100000',
	29	+ 'overflow' => 'auto',
	30	+ 'rows' => '10',
	31	+ ],
	32	+ 'required' => false,
	33	+ 'disabled' => false,
	34	+ 'label' => false,
	35	+ 'trim' => true
	36	+ ]
37	37	)
38	38	->add(
39	39	'save_comment_button', SubmitType::class, [
40		- 'attr' => ['class' => 'btn btn-primary', 'style' => 'width: 180px;'],
41		- 'label' => '

OpencachingDeutschland / oc-server3

Pull Request — development (#894)

Status

Category

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

Indentation +81 added lines, -81 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +65 added lines, -65 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch