Passed
Pull Request — master (#322)
by Mirko
08:41
created
htdocs/newcaches.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -12,8 +12,7 @@
 block discarded – undo
12 12
 $tpl->change_country_inpage = true;
13 13
 
14 14
 $startat = isset($_REQUEST['startat']) ? floor($_REQUEST['startat'] + 0) : 0;
15
-$country = isset($_REQUEST['usercountry']) ? $_REQUEST['usercountry'] :
16
-    (isset($_REQUEST['country']) ? $_REQUEST['country'] : '');
15
+$country = isset($_REQUEST['usercountry']) ? $_REQUEST['usercountry'] : (isset($_REQUEST['country']) ? $_REQUEST['country'] : '');
17 16
 $cachetype = isset($_REQUEST['cachetype']) ? $_REQUEST['cachetype'] + 0 : 0;
18 17
 $bEvents = ($cachetype == 6);
19 18
 
Please login to merge, or discard this patch.
htdocs/newlogs.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     $tpl->cache_lifetime = 900;
70 70
     $tpl->cache_id = $exclude_country;
71 71
     $logcount = 250;
72
-    $paging = false;  // paging would have poor performance for all logs
72
+    $paging = false; // paging would have poor performance for all logs
73 73
     $orderByDate = $logselection == 3 ? "{fromtable}.`order_date` DESC, " : "";
74 74
 } else {
75 75
     // latest logs for all countries or for one country
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     $tpl->cache_lifetime = 300;
89 89
     $tpl->cache_id = $country;
90 90
     $logcount = 250;
91
-    $paging = false;  // paging would have poor performance for all logs
91
+    $paging = false; // paging would have poor performance for all logs
92 92
     $orderByDate = $logselection == 3 ? "{fromtable}.`order_date` DESC, " : "";
93 93
     $optimize_for_latest_logs = ($country == '' || $country == $opt['page']['main_country']);
94 94
 }
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             }
248 248
             sql_free_result($rsPic);
249 249
         }
250
-        $pics --;
250
+        $pics--;
251 251
 
252 252
         $rLog['first'] = false;
253 253
         if (isset($caches_logged)) {
Please login to merge, or discard this patch.
htdocs/xml/ocxml11.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 require_once __DIR__ . '/../lib2/const.inc.php';
22 22
 require_once __DIR__ . '/../lib2/logic/data-license.inc.php';
23 23
 require_once __DIR__ . '/../lib2/logic/npas.inc.php';
24
-require_once __DIR__ .' /../lib2/logic/geomath.class.php';
24
+require_once __DIR__ . ' /../lib2/logic/geomath.class.php';
25 25
 
26 26
 if ($error == true) {
27 27
     echo 'Unable to connect to database';
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 
388 388
     $logtypes = [];
389 389
     $rs = sql('SELECT `id`, `de` FROM log_types');
390
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
390
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
391 391
         $r = sql_fetch_array($rs);
392 392
         $logtypes[$r['id']] = $r['de'];
393 393
     }
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
 
396 396
     $cachetypes = [];
397 397
     $rs = sql('SELECT `id`, `short`, `de` FROM cache_type');
398
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
398
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
399 399
         $r = sql_fetch_array($rs);
400 400
         $cachetypes[$r['id']]['de'] = $r['de'];
401 401
         $cachetypes[$r['id']]['short'] = $r['short'];
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
 
405 405
     $cachestatus = [];
406 406
     $rs = sql('SELECT `id`, `de` FROM cache_status');
407
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
407
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
408 408
         $r = sql_fetch_array($rs);
409 409
         $cachestatus[$r['id']]['de'] = $r['de'];
410 410
     }
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
 
413 413
     $counties = [];
414 414
     $rs = sql('SELECT `short`, `de` FROM countries');
415
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
415
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
416 416
         $r = sql_fetch_array($rs);
417 417
         $counties[$r['short']]['de'] = $r['de'];
418 418
     }
@@ -420,7 +420,7 @@  discard block
 block discarded – undo
420 420
 
421 421
     $cachesizes = [];
422 422
     $rs = sql('SELECT `id`, `de` FROM cache_size');
423
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
423
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
424 424
         $r = sql_fetch_array($rs);
425 425
         $cachesizes[$r['id']]['de'] = $r['de'];
426 426
     }
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
 
429 429
     $languages = [];
430 430
     $rs = sql('SELECT `short`, `de` FROM languages');
431
-    for ($i = 0; $i < mysql_num_rows($rs); $i ++) {
431
+    for ($i = 0; $i < mysql_num_rows($rs); $i++) {
432 432
         $r = sql_fetch_array($rs);
433 433
         $languages[$r['short']]['de'] = $r['de'];
434 434
     }
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     $objecttypes['3'] = 'cachedesc';
440 440
     $objecttypes['1'] = 'cachelog';
441 441
     $objecttypes['6'] = 'picture';
442
-    $objecttypes['8'] = 'cachelist';    // not implemented yet
442
+    $objecttypes['8'] = 'cachelist'; // not implemented yet
443 443
 
444 444
     /* end now a few dynamically loaded constants */
445 445
 
@@ -452,7 +452,7 @@  discard block
 block discarded – undo
452 452
     while (file_exists(
453 453
         $zip_basedir . 'ocxml11/' . $sessionid . '/' . $sessionid . '-' . $filenr . '-' . $fileid . '.xml'
454 454
     )) {
455
-        $fileid ++;
455
+        $fileid++;
456 456
     }
457 457
 
458 458
     $xmlfilename = $zip_basedir . 'ocxml11/' . $sessionid . '/' . $sessionid . '-' . $filenr . '-' . $fileid . '.xml';
@@ -1300,7 +1300,7 @@  discard block
 block discarded – undo
1300 1300
 //    echo $startat . ' ' . $endat . '<br><br>';
1301 1301
 //    echo '<table>';
1302 1302
 //    echo '<tr><td>sql-start</td><td>sql-count</td><td>count</td><td>begin</td><td>end</td></tr>';
1303
-    for ($i = 0; $i < 6; $i ++) {
1303
+    for ($i = 0; $i < 6; $i++) {
1304 1304
         if (($startat >= $recordnr[$i]) && ($startat + 500 < $recordnr[$i + 1])) {
1305 1305
             if ($recordnr[$i + 1] - $startat > 500) {
1306 1306
                 $limits[$i] = ['start' => $startat - $recordnr[$i], 'count' => 500];
@@ -1422,7 +1422,7 @@  discard block
 block discarded – undo
1422 1422
     $from[4] = '\'';
1423 1423
     $to[4] = '&apos;';
1424 1424
 
1425
-    for ($i = 0; $i <= 4; $i ++) {
1425
+    for ($i = 0; $i <= 4; $i++) {
1426 1426
         $str = mb_ereg_replace($from[$i], $to[$i], $str);
1427 1427
     }
1428 1428
 
@@ -1501,13 +1501,13 @@  discard block
 block discarded – undo
1501 1501
 
1502 1502
     $hDir = opendir($path);
1503 1503
     if ($hDir === false) {
1504
-        ++ $notunlinked;
1504
+        ++$notunlinked;
1505 1505
     } else {
1506 1506
         while (false !== ($file = readdir($hDir))) {
1507 1507
             if (($file != '.') && ($file != '..')) {
1508 1508
                 if (is_dir($path . $file)) {
1509 1509
                     if (unlinkrecursiv($path . $file . '/') == false) {
1510
-                        $notunlinked ++;
1510
+                        $notunlinked++;
1511 1511
                     }
1512 1512
                 } else {
1513 1513
                     if ((mb_substr($file, - 4) == '.zip') ||
@@ -1517,7 +1517,7 @@  discard block
 block discarded – undo
1517 1517
                     ) {
1518 1518
                         @unlink($path . $file);
1519 1519
                     } else {
1520
-                        $notunlinked ++;
1520
+                        $notunlinked++;
1521 1521
                     }
1522 1522
                 }
1523 1523
             }
Please login to merge, or discard this patch.
htdocs/xml/csv/cache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,6 +43,6 @@
 block discarded – undo
43 43
         echo ';';
44 44
         echo '"' . mb_ereg_replace('"', '\"', $cache->getWPGC()) . '"';
45 45
         echo ';';
46
-        echo '""';  // obsolete Navicache WP
46
+        echo '""'; // obsolete Navicache WP
47 47
     }
48 48
 }
Please login to merge, or discard this patch.
htdocs/util/watchlist/runwatch.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     WHERE cache_logs.cache_id=caches.cache_id
52 52
     AND cache_logs.owner_notified=0"
53 53
 );
54
-for ($i = 0; $i < mysql_num_rows($rsNewLogs); $i ++) {
54
+for ($i = 0; $i < mysql_num_rows($rsNewLogs); $i++) {
55 55
     $rNewLog = sql_fetch_array($rsNewLogs);
56 56
 
57 57
     $rsNotified = sql(
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
     WHERE `user`.`watchmail_nextmail`<NOW()",
135 135
     $opt['template']['default']['locale']
136 136
 );
137
-for ($i = 0; $i < mysql_num_rows($rsUsers); $i ++) {
137
+for ($i = 0; $i < mysql_num_rows($rsUsers); $i++) {
138 138
     $rUser = sql_fetch_array($rsUsers);
139 139
 
140 140
     if ($rUser['watchmail_nextmail'] != '0000-00-00 00:00:00') {
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
                 );
159 159
                 if (mysql_num_rows($rsWatchesOwner) > 0) {
160 160
                     $logtexts = '';
161
-                    for ($j = 0; $j < mysql_num_rows($rsWatchesOwner); $j ++) {
161
+                    for ($j = 0; $j < mysql_num_rows($rsWatchesOwner); $j++) {
162 162
                         $rWatch = sql_fetch_array($rsWatchesOwner);
163 163
                         $logtexts .= $rWatch['watchtext'];
164 164
                     }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
                 );
184 184
                 if (mysql_num_rows($rsWatchesLog) > 0) {
185 185
                     $logtexts = '';
186
-                    for ($j = 0; $j < mysql_num_rows($rsWatchesLog); $j ++) {
186
+                    for ($j = 0; $j < mysql_num_rows($rsWatchesLog); $j++) {
187 187
                         $rWatch = sql_fetch_array($rsWatchesLog);
188 188
                         $logtexts .= $rWatch['watchtext'];
189 189
                     }
@@ -583,7 +583,7 @@  discard block
 block discarded – undo
583 583
         $pid_daemon = fgets($pidfile, 20);
584 584
         fclose($pidfile);
585 585
 
586
-        $pid_daemon = (int) $pid_daemon;
586
+        $pid_daemon = (int)$pid_daemon;
587 587
 
588 588
         // process running?
589 589
         if (posix_kill($pid_daemon, 0)) {
Please login to merge, or discard this patch.
htdocs/translate.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -690,7 +690,7 @@  discard block
 block discarded – undo
690 690
         $writer->writeAttribute('id', $r['id']);
691 691
 
692 692
         $writer->writeElement('code', $r['text']);
693
-        for ($n = 0; $n < count($lang); $n ++) {
693
+        for ($n = 0; $n < count($lang); $n++) {
694 694
             $writer->writeElement(
695 695
                 $lang[$n],
696 696
                 sql_value(
@@ -818,7 +818,7 @@  discard block
 block discarded – undo
818 818
 
819 819
     $nCount = isset($_REQUEST['count']) ? $_REQUEST['count'] + 0 : 0;
820 820
 
821
-    for ($nIndex = 1; $nIndex <= $nCount; $nIndex ++) {
821
+    for ($nIndex = 1; $nIndex <= $nCount; $nIndex++) {
822 822
         if (isset($_REQUEST['useitem' . $nIndex]) && ($_REQUEST['useitem' . $nIndex] == '1')) {
823 823
             $sCode = base64_decode($_REQUEST['code' . $nIndex]);
824 824
             $transId = sql_value("SELECT `id` FROM `sys_trans` WHERE `text`='&1'", 0, $sCode);
Please login to merge, or discard this patch.
htdocs/lib2/charset.inc.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
     $result = "";
29 29
 
30 30
     while ($pos < strlen($s)) {
31
-        $c1 = ord($s[$pos ++]);
31
+        $c1 = ord($s[$pos++]);
32 32
         if ($c1 < 0xC0) {
33 33
             $result .= chr($c1);
34 34
         } elseif ($pos < strlen($s)) {
35
-            $c2 = ord($s[$pos ++]);
35
+            $c2 = ord($s[$pos++]);
36 36
             if ($c1 < 0xE0) {
37 37
                 $code = 0x40 * ($c1 & 0x1F) + ($c2 & 0x3F);
38 38
                 if ($code < 0x100) {
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
                     $result .= "?";
47 47
                 }
48 48
             } elseif ($pos < strlen($s)) {
49
-                $c3 = ord($s[$pos ++]);
49
+                $c3 = ord($s[$pos++]);
50 50
                 $code = 0x1000 * ($c1 & 0x0F) + 0x40 * ($c2 & 0x3F) + ($c3 & 0x3F);
51 51
                 switch ($code) {
52 52
                     case 0x2026:
Please login to merge, or discard this patch.
htdocs/lib2/OcHTMLPurifier.class.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,8 +50,8 @@  discard block
 block discarded – undo
50 50
         $config->set('Attr.IDPrefix', 'custom_');
51 51
 
52 52
         // enable 'display' and 'visibility' styles for mystery descriptions
53
-        $config->set('CSS.AllowTricky', true);                // + display, visibility, overflow
54
-        $config->set('CSS.ForbiddenProperties', 'overflow');  // - overflow
53
+        $config->set('CSS.AllowTricky', true); // + display, visibility, overflow
54
+        $config->set('CSS.ForbiddenProperties', 'overflow'); // - overflow
55 55
 
56 56
         // prepare additional definitions
57 57
         $def = $config->getHTMLDefinition(true);
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         ); //  HTML5 attribs currently not supported by TinyMCE
66 66
         $def->addElement('legend', 'Inline', 'Flow', 'Common');
67 67
         $def->addElement('q', 'Inline', 'Inline', 'Common', ['cite' => 'URI']);
68
-        $def->addElement('strike', 'Inline', 'Inline', 'Common');   // -> wird in CSS umgewandelt
68
+        $def->addElement('strike', 'Inline', 'Inline', 'Common'); // -> wird in CSS umgewandelt
69 69
         $def->addElement(
70 70
             'area',
71 71
             'Inline',
Please login to merge, or discard this patch.
htdocs/lib2/cookie.class.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 
52 52
             if ($opt['session']['check_referer']) {
53 53
                 if (isset($_SERVER['REFERER'])) {
54
-                    if (strtolower(substr('http' + strstr($_SERVER['REFERER'], '://'), 0, strlen($opt['page']['absolute_http_url']))) != strtolower($opt['page']['absolute_http_url'])) {
54
+                    if (strtolower(substr('http' +strstr($_SERVER['REFERER'], '://'), 0, strlen($opt['page']['absolute_http_url']))) != strtolower($opt['page']['absolute_http_url'])) {
55 55
                         $this->createNewSession();
56 56
                     }
57 57
                 }
Please login to merge, or discard this patch.