Inspection of "Merge pull request #890 from fraggle-DE/OCC-152_wo..." - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — development ( 50db33...4beac3 )

by Thomas

created 2022-08-30 07:59 UTC

Status

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -20,8 +20,8 @@
 block discarded – undo
 if ($trustedProxies = $_SERVER['TRUSTED_PROXIES'] ?? false) {
     Request::setTrustedProxies(
         explode(',', $trustedProxies), Request::HEADER_X_FORWARDED_FOR
-                                       ^ Request::HEADER_X_FORWARDED_PROTO
-                                       ^ Request::HEADER_X_FORWARDED_PORT
+                                        ^ Request::HEADER_X_FORWARDED_PROTO
+                                        ^ Request::HEADER_X_FORWARDED_PORT
     );
 }
 

Please login to merge, or discard this patch.

htdocs_symfony/src/Controller/Backend/SupportController.php 1 patch

Indentation +65 added lines, -65 removed lines patch added patch discarded remove patch

@@ -187,9 +187,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/searchedCaches.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'foundCaches' => $fetchedCaches
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'foundCaches' => $fetchedCaches
+                                                        ]
         );
     }
 
@@ -211,9 +211,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/reportedCaches.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'reportedCaches_by_id' => $fetchedReports
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'reportedCaches_by_id' => $fetchedReports
+                                                        ]
         );
     }
 
@@ -234,10 +234,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCaches.html.twig', [
-                                                       'supportCachesForm' => $formSearch->createView(),
-                                                       'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
-                                                       'bonusCaches_by_id' => $fetchedBonuscaches
-                                                   ]
+                                                        'supportCachesForm' => $formSearch->createView(),
+                                                        'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
+                                                        'bonusCaches_by_id' => $fetchedBonuscaches
+                                                    ]
         );
     }
 
@@ -260,10 +260,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCachesAssignment.html.twig', [
-                                                                 'supportCachesForm' => $formSearch->createView(),
-                                                                 'bonus_Cache' => $wpID,
-                                                                 'caches_by_owner' => $fetchedOwnerCaches
-                                                             ]
+                                                                    'supportCachesForm' => $formSearch->createView(),
+                                                                    'bonus_Cache' => $wpID,
+                                                                    'caches_by_owner' => $fetchedOwnerCaches
+                                                                ]
         );
     }
 
@@ -290,10 +290,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/bonusCachesAssignment.html.twig', [
-                                                                 'supportCachesForm' => $formSearch->createView(),
-                                                                 'bonus_Cache' => $toBonusCache,
-                                                                 'caches_by_owner' => $fetchedOwnerCaches
-                                                             ]
+                                                                    'supportCachesForm' => $formSearch->createView(),
+                                                                    'bonus_Cache' => $toBonusCache,
+                                                                    'caches_by_owner' => $fetchedOwnerCaches
+                                                                ]
         );
     }
 
@@ -402,10 +402,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'SQLFlexForm' => $formSQLFlex->createView(),
-                                                           'suppSQLqueryFlex' => $fetchedInformation
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'SQLFlexForm' => $formSQLFlex->createView(),
+                                                            'suppSQLqueryFlex' => $fetchedInformation
+                                                        ]
         );
     }
 
@@ -541,16 +541,16 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/occ.html.twig', [
-                                               'supportCachesForm' => $formSearch->createView(),
-                                               'supportCommentFormUser' => $formCommentUser->createView(),
-                                               'supportCommentFormCache' => $formCommentCache->createView(),
-                                               'occ_cache_data' => $fetchedCacheData,
-                                               'occ_cache_comments' => $fetchedCacheComments,
-                                               'occ_cache_infos' => $fetchedCacheInfos,
-                                               'occ_user_data' => $fetchedUserData,
-                                               'occ_user_comments' => $fetchedUserComments,
-                                               'occ_user_relations' => $fetchedUserRelations
-                                           ]
+                                                'supportCachesForm' => $formSearch->createView(),
+                                                'supportCommentFormUser' => $formCommentUser->createView(),
+                                                'supportCommentFormCache' => $formCommentCache->createView(),
+                                                'occ_cache_data' => $fetchedCacheData,
+                                                'occ_cache_comments' => $fetchedCacheComments,
+                                                'occ_cache_infos' => $fetchedCacheInfos,
+                                                'occ_user_data' => $fetchedUserData,
+                                                'occ_user_comments' => $fetchedUserComments,
+                                                'occ_user_relations' => $fetchedUserRelations
+                                            ]
         );
     }
 
@@ -684,10 +684,10 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/userDetails.html.twig', [
-                                                       'supportCachesForm' => $formSearch->createView(),
-                                                       'supportUserAccountActions' => $formActions->createView(),
-                                                       'user_account_details' => $fetchedUserDetails
-                                                   ]
+                                                        'supportCachesForm' => $formSearch->createView(),
+                                                        'supportUserAccountActions' => $formActions->createView(),
+                                                        'user_account_details' => $fetchedUserDetails
+                                                    ]
         );
     }
 
@@ -786,9 +786,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
+                                                        ]
         );
     }
 
@@ -815,9 +815,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
+                                                        ]
         );
     }
 
@@ -851,9 +851,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
+                                                        ]
         );
     }
 
@@ -872,9 +872,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
+                                                        ]
         );
     }
 
@@ -919,9 +919,9 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/databaseQueries.html.twig', [
-                                                           'supportCachesForm' => $formSearch->createView(),
-                                                           'suppSQLquery6' => $qb_caches_list
-                                                       ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'suppSQLquery6' => $qb_caches_list
+                                                        ]
         );
     }
 
@@ -1037,15 +1037,15 @@  discard block
 block discarded – undo
 
         return $this->render(
             'backend/support/occ_gpx_import.html.twig', [
-                                                          'supportCachesForm' => $formSearch->createView(),
-                                                          'supportUploadGPXForm' => $formUpload->createView(),
-                                                          'amountProcessedCaches' => $amountProcessedCaches,
-                                                          'amountAssignedCaches' => $amountAssignedCaches,
-                                                          'amountUpdatedCaches' => $amountUpdatedCaches,
-                                                          'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
-                                                          'fetchedListingInfos' => $fetchedListingInfos,
-                                                          'differencesDetected' => $differencesDetected
-                                                      ]
+                                                            'supportCachesForm' => $formSearch->createView(),
+                                                            'supportUploadGPXForm' => $formUpload->createView(),
+                                                            'amountProcessedCaches' => $amountProcessedCaches,
+                                                            'amountAssignedCaches' => $amountAssignedCaches,
+                                                            'amountUpdatedCaches' => $amountUpdatedCaches,
+                                                            'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
+                                                            'fetchedListingInfos' => $fetchedListingInfos,
+                                                            'differencesDetected' => $differencesDetected
+                                                        ]
         );
     }
 
@@ -1209,11 +1209,11 @@  discard block
 block discarded – undo
                     ] as $checkItem) {
                         if ($wpt[$checkItem] != $fetchedExistingSupportListingInfoArray[$checkItem]) {
                             $newComment .= $checkItem
-                                           . ' changed from '
-                                           . $fetchedExistingSupportListingInfoArray[$checkItem]
-                                           . ' to '
-                                           . $wpt[$checkItem]
-                                           . PHP_EOL;
+                                            . ' changed from '
+                                            . $fetchedExistingSupportListingInfoArray[$checkItem]
+                                            . ' to '
+                                            . $wpt[$checkItem]
+                                            . PHP_EOL;
                         }
                     }
 

Please login to merge, or discard this patch.

		@@ -20,8 +20,8 @@
		block discarded – undo
20	20	if ($trustedProxies = $_SERVER['TRUSTED_PROXIES'] ?? false) {
21	21	Request::setTrustedProxies(
22	22	explode(',', $trustedProxies), Request::HEADER_X_FORWARDED_FOR
23		- ^ Request::HEADER_X_FORWARDED_PROTO
24		- ^ Request::HEADER_X_FORWARDED_PORT
	23	+ ^ Request::HEADER_X_FORWARDED_PROTO
	24	+ ^ Request::HEADER_X_FORWARDED_PORT
25	25	);
26	26	}
27	27

		@@ -187,9 +187,9 @@ discard block
		block discarded – undo
187	187
188	188	return $this->render(
189	189	'backend/support/searchedCaches.html.twig', [
190		- 'supportCachesForm' => $formSearch->createView(),
191		- 'foundCaches' => $fetchedCaches
192		- ]
	190	+ 'supportCachesForm' => $formSearch->createView(),
	191	+ 'foundCaches' => $fetchedCaches
	192	+ ]
193	193	);
194	194	}
195	195
		@@ -211,9 +211,9 @@ discard block
		block discarded – undo
211	211
212	212	return $this->render(
213	213	'backend/support/reportedCaches.html.twig', [
214		- 'supportCachesForm' => $formSearch->createView(),
215		- 'reportedCaches_by_id' => $fetchedReports
216		- ]
	214	+ 'supportCachesForm' => $formSearch->createView(),
	215	+ 'reportedCaches_by_id' => $fetchedReports
	216	+ ]
217	217	);
218	218	}
219	219
		@@ -234,10 +234,10 @@ discard block
		block discarded – undo
234	234
235	235	return $this->render(
236	236	'backend/support/bonusCaches.html.twig', [
237		- 'supportCachesForm' => $formSearch->createView(),
238		- 'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
239		- 'bonusCaches_by_id' => $fetchedBonuscaches
240		- ]
	237	+ 'supportCachesForm' => $formSearch->createView(),
	238	+ 'supportAssignBonusCacheForm' => $formAssignBonusCache->createView(),
	239	+ 'bonusCaches_by_id' => $fetchedBonuscaches
	240	+ ]
241	241	);
242	242	}
243	243
		@@ -260,10 +260,10 @@ discard block
		block discarded – undo
260	260
261	261	return $this->render(
262	262	'backend/support/bonusCachesAssignment.html.twig', [
263		- 'supportCachesForm' => $formSearch->createView(),
264		- 'bonus_Cache' => $wpID,
265		- 'caches_by_owner' => $fetchedOwnerCaches
266		- ]
	263	+ 'supportCachesForm' => $formSearch->createView(),
	264	+ 'bonus_Cache' => $wpID,
	265	+ 'caches_by_owner' => $fetchedOwnerCaches
	266	+ ]
267	267	);
268	268	}
269	269
		@@ -290,10 +290,10 @@ discard block
		block discarded – undo
290	290
291	291	return $this->render(
292	292	'backend/support/bonusCachesAssignment.html.twig', [
293		- 'supportCachesForm' => $formSearch->createView(),
294		- 'bonus_Cache' => $toBonusCache,
295		- 'caches_by_owner' => $fetchedOwnerCaches
296		- ]
	293	+ 'supportCachesForm' => $formSearch->createView(),
	294	+ 'bonus_Cache' => $toBonusCache,
	295	+ 'caches_by_owner' => $fetchedOwnerCaches
	296	+ ]
297	297	);
298	298	}
299	299
		@@ -402,10 +402,10 @@ discard block
		block discarded – undo
402	402
403	403	return $this->render(
404	404	'backend/support/databaseQueries.html.twig', [
405		- 'supportCachesForm' => $formSearch->createView(),
406		- 'SQLFlexForm' => $formSQLFlex->createView(),
407		- 'suppSQLqueryFlex' => $fetchedInformation
408		- ]
	405	+ 'supportCachesForm' => $formSearch->createView(),
	406	+ 'SQLFlexForm' => $formSQLFlex->createView(),
	407	+ 'suppSQLqueryFlex' => $fetchedInformation
	408	+ ]
409	409	);
410	410	}
411	411
		@@ -541,16 +541,16 @@ discard block
		block discarded – undo
541	541
542	542	return $this->render(
543	543	'backend/support/occ.html.twig', [
544		- 'supportCachesForm' => $formSearch->createView(),
545		- 'supportCommentFormUser' => $formCommentUser->createView(),
546		- 'supportCommentFormCache' => $formCommentCache->createView(),
547		- 'occ_cache_data' => $fetchedCacheData,
548		- 'occ_cache_comments' => $fetchedCacheComments,
549		- 'occ_cache_infos' => $fetchedCacheInfos,
550		- 'occ_user_data' => $fetchedUserData,
551		- 'occ_user_comments' => $fetchedUserComments,
552		- 'occ_user_relations' => $fetchedUserRelations
553		- ]
	544	+ 'supportCachesForm' => $formSearch->createView(),
	545	+ 'supportCommentFormUser' => $formCommentUser->createView(),
	546	+ 'supportCommentFormCache' => $formCommentCache->createView(),
	547	+ 'occ_cache_data' => $fetchedCacheData,
	548	+ 'occ_cache_comments' => $fetchedCacheComments,
	549	+ 'occ_cache_infos' => $fetchedCacheInfos,
	550	+ 'occ_user_data' => $fetchedUserData,
	551	+ 'occ_user_comments' => $fetchedUserComments,
	552	+ 'occ_user_relations' => $fetchedUserRelations
	553	+ ]
554	554	);
555	555	}
556	556
		@@ -684,10 +684,10 @@ discard block
		block discarded – undo
684	684
685	685	return $this->render(
686	686	'backend/support/userDetails.html.twig', [
687		- 'supportCachesForm' => $formSearch->createView(),
688		- 'supportUserAccountActions' => $formActions->createView(),
689		- 'user_account_details' => $fetchedUserDetails
690		- ]
	687	+ 'supportCachesForm' => $formSearch->createView(),
	688	+ 'supportUserAccountActions' => $formActions->createView(),
	689	+ 'user_account_details' => $fetchedUserDetails
	690	+ ]
691	691	);
692	692	}
693	693
		@@ -786,9 +786,9 @@ discard block
		block discarded – undo
786	786
787	787	return $this->render(
788	788	'backend/support/databaseQueries.html.twig', [
789		- 'supportCachesForm' => $formSearch->createView(),
790		- 'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
791		- ]
	789	+ 'supportCachesForm' => $formSearch->createView(),
	790	+ 'suppSQLquery1' => $qb->execute()->fetchAllAssociative()
	791	+ ]
792	792	);
793	793	}
794	794
		@@ -815,9 +815,9 @@ discard block
		block discarded – undo
815	815
816	816	return $this->render(
817	817	'backend/support/databaseQueries.html.twig', [
818		- 'supportCachesForm' => $formSearch->createView(),
819		- 'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
820		- ]
	818	+ 'supportCachesForm' => $formSearch->createView(),
	819	+ 'suppSQLquery2' => $qb->execute()->fetchAllAssociative()
	820	+ ]
821	821	);
822	822	}
823	823
		@@ -851,9 +851,9 @@ discard block
		block discarded – undo
851	851
852	852	return $this->render(
853	853	'backend/support/databaseQueries.html.twig', [
854		- 'supportCachesForm' => $formSearch->createView(),
855		- 'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
856		- ]
	854	+ 'supportCachesForm' => $formSearch->createView(),
	855	+ 'suppSQLquery4' => $qb->execute()->fetchAllAssociative()
	856	+ ]
857	857	);
858	858	}
859	859
		@@ -872,9 +872,9 @@ discard block
		block discarded – undo
872	872
873	873	return $this->render(
874	874	'backend/support/databaseQueries.html.twig', [
875		- 'supportCachesForm' => $formSearch->createView(),
876		- 'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
877		- ]
	875	+ 'supportCachesForm' => $formSearch->createView(),
	876	+ 'suppSQLquery5' => $this->supportUserCommentsRepository->fetchAll()
	877	+ ]
878	878	);
879	879	}
880	880
		@@ -919,9 +919,9 @@ discard block
		block discarded – undo
919	919
920	920	return $this->render(
921	921	'backend/support/databaseQueries.html.twig', [
922		- 'supportCachesForm' => $formSearch->createView(),
923		- 'suppSQLquery6' => $qb_caches_list
924		- ]
	922	+ 'supportCachesForm' => $formSearch->createView(),
	923	+ 'suppSQLquery6' => $qb_caches_list
	924	+ ]
925	925	);
926	926	}
927	927
		@@ -1037,15 +1037,15 @@ discard block
		block discarded – undo
1037	1037
1038	1038	return $this->render(
1039	1039	'backend/support/occ_gpx_import.html.twig', [
1040		- 'supportCachesForm' => $formSearch->createView(),
1041		- 'supportUploadGPXForm' => $formUpload->createView(),
1042		- 'amountProcessedCaches' => $amountProcessedCaches,
1043		- 'amountAssignedCaches' => $amountAssignedCaches,
1044		- 'amountUpdatedCaches' => $amountUpdatedCaches,
1045		- 'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
1046		- 'fetchedListingInfos' => $fetchedListingInfos,
1047		- 'differencesDetected' => $differencesDetected
1048		- ]
	1040	+ 'supportCachesForm' => $formSearch->createView(),
	1041	+ 'supportUploadGPXForm' => $formUpload->createView(),
	1042	+ 'amountProcessedCaches' => $amountProcessedCaches,
	1043	+ 'amountAssignedCaches' => $amountAssignedCaches,
	1044	+ 'amountUpdatedCaches' => $amountUpdatedCaches,
	1045	+ 'listOfAmbiguousCaches' => $listOfAmbiguousCaches,
	1046	+ 'fetchedListingInfos' => $fetchedListingInfos,
	1047	+ 'differencesDetected' => $differencesDetected
	1048	+ ]
1049	1049	);
1050	1050	}
1051	1051
		@@ -1209,11 +1209,11 @@ discard block
		block discarded – undo
1209	1209	] as $checkItem) {
1210	1210	if ($wpt[$checkItem] != $fetchedExistingSupportListingInfoArray[$checkItem]) {
1211	1211	$newComment .= $checkItem
1212		- . ' changed from '
1213		- . $fetchedExistingSupportListingInfoArray[$checkItem]
1214		- . ' to '
1215		- . $wpt[$checkItem]
1216		- . PHP_EOL;
	1212	+ . ' changed from '
	1213	+ . $fetchedExistingSupportListingInfoArray[$checkItem]
	1214	+ . ' to '
	1215	+ . $wpt[$checkItem]
	1216	+ . PHP_EOL;
1217	1217	}
1218	1218	}
1219	1219

OpencachingDeutschland / oc-server3

Push — development ( 50db33...4beac3 )

Status

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +65 added lines, -65 removed lines patch added patch discarded remove patch