Passed
Push — development ( f44b13...fa29db )
by Mirco
01:47
created
htdocs/lib/common.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -680,7 +680,7 @@
 block discarded – undo
680 680
 
681 681
     $str = $translate->t($str, '', basename(__FILE__), __LINE__);
682 682
     $args = func_get_args();
683
-    for ($nIndex = count($args) - 1; $nIndex > 0; $nIndex --) {
683
+    for ($nIndex = count($args) - 1; $nIndex > 0; $nIndex--) {
684 684
         $str = str_replace('%' . $nIndex, $args[$nIndex], $str);
685 685
     }
686 686
 
Please login to merge, or discard this patch.
htdocs/lib/consts-common.inc.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,10 +7,10 @@
 block discarded – undo
7 7
  *  common constant definitions of lib1 and lib2
8 8
  ***************************************************************************/
9 9
 
10
-define('GUI_HTML', 0);   // also defined in lib/consts.inc.php
10
+define('GUI_HTML', 0); // also defined in lib/consts.inc.php
11 11
 define('GUI_TEXT', 1);
12 12
 
13
-define('HTTPS_DISABLED', 0);   // also defined in lib/consts.inc.php
13
+define('HTTPS_DISABLED', 0); // also defined in lib/consts.inc.php
14 14
 define('HTTPS_ENABLED', 1);
15 15
 define('HTTPS_ENFORCED', 2);
16 16
 
Please login to merge, or discard this patch.
htdocs/lib/settings-sample-dev.inc.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 
19 19
 // database names
20 20
 $dbname = 'opencaching';
21
-$tmpdbname = 'octmp';   // empty db with CREATE and DROP privileges
21
+$tmpdbname = 'octmp'; // empty db with CREATE and DROP privileges
22 22
 
23 23
 // common developer system settings
24 24
 require 'settings-dev.inc.php';
Please login to merge, or discard this patch.
htdocs/lib/sqldebugger.inc.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     global $sqldbg_cmdNo;
156 156
     global $sqldbg_sumTimes;
157 157
 
158
-    $sqldbg_cmdNo ++;
158
+    $sqldbg_cmdNo++;
159 159
 
160 160
     echo '<p class="sqlno"><span class="white">/*</span> SQL command ' . $sqldbg_cmdNo . ' ';
161 161
     if ($bSlave) {
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 
231 231
         while ($r = sql_fetch_assoc($rs)) {
232 232
             $usebr = true;
233
-            $nLine ++;
233
+            $nLine++;
234 234
             if ($bFirstLine == true) {
235 235
                 echo '<tr>' . "\n";
236 236
                 foreach ($r as $field => $value) {
Please login to merge, or discard this patch.
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -329,6 +329,9 @@  discard block
 block discarded – undo
329 329
     exit;
330 330
 }
331 331
 
332
+/**
333
+ * @param string $sql
334
+ */
332 335
 function sqldbg_strip_temptable($sql)
333 336
 {
334 337
     $start = mb_strpos(mb_strtoupper($sql), 'SELECT ');
@@ -340,6 +343,9 @@  discard block
 block discarded – undo
340 343
     return mb_substr($sql, $start);
341 344
 }
342 345
 
346
+/**
347
+ * @param string $sql
348
+ */
343 349
 function sqldbg_strip_from($sql)
344 350
 {
345 351
     $start = mb_strpos(mb_strtoupper($sql), 'FROM ');
@@ -351,6 +357,9 @@  discard block
 block discarded – undo
351 357
     return 'SELECT * ' . mb_substr($sql, $start);
352 358
 }
353 359
 
360
+/**
361
+ * @param string $sql
362
+ */
354 363
 function sqldbg_insert_nocache($sql)
355 364
 {
356 365
     if (mb_strtoupper(mb_substr($sql, 0, 7)) == 'SELECT ') {
Please login to merge, or discard this patch.
htdocs/lib/login.class.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,13 +18,13 @@
 block discarded – undo
18 18
  *
19 19
  ***************************************************************************/
20 20
 
21
-define('LOGIN_UNKNOWN_ERROR', - 1);     // unkown error occured
22
-define('LOGIN_OK', 0);            // login succeeded
23
-define('LOGIN_BADUSERPW', 1);     // bad username or password
21
+define('LOGIN_UNKNOWN_ERROR', - 1); // unkown error occured
22
+define('LOGIN_OK', 0); // login succeeded
23
+define('LOGIN_BADUSERPW', 1); // bad username or password
24 24
 define('LOGIN_TOOMUCHLOGINS', 2); // too many logins in short time
25 25
 define('LOGIN_USERNOTACTIVE', 3); // the useraccount locked
26 26
 define('LOGIN_EMPTY_USERPASSWORD', 4); // given username/password was empty
27
-define('LOGIN_LOGOUT_OK', 5);          // logout was successfull
27
+define('LOGIN_LOGOUT_OK', 5); // logout was successfull
28 28
 
29 29
 // login times in seconds
30 30
 define('LOGIN_TIME', 60 * 60);
Please login to merge, or discard this patch.
htdocs/newcachesrest.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,8 +14,7 @@
 block discarded – undo
14 14
 $tpl->caching = true;
15 15
 $tpl->cache_lifetime = 3600;
16 16
 
17
-$country = isset($_REQUEST['usercountry']) ? $_REQUEST['usercountry'] :
18
-    (isset($_REQUEST['country']) ? $_REQUEST['country'] : $opt['page']['main_country']);
17
+$country = isset($_REQUEST['usercountry']) ? $_REQUEST['usercountry'] : (isset($_REQUEST['country']) ? $_REQUEST['country'] : $opt['page']['main_country']);
19 18
 
20 19
 if (!$tpl->is_cached()) {
21 20
     $newCaches = array();
Please login to merge, or discard this patch.
htdocs/picture.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,11 +75,11 @@
 block discarded – undo
75 75
     if (isset($_REQUEST['ok'])) { // Ocprop
76 76
         $bError = false;
77 77
 
78
-        $picture->setSpoiler(isset($_REQUEST['spoiler']) && $_REQUEST['spoiler'] == '1');  // Ocprop
79
-        $picture->setDisplay((isset($_REQUEST['notdisplay']) && $_REQUEST['notdisplay'] == '1') == false);  // Ocprop
78
+        $picture->setSpoiler(isset($_REQUEST['spoiler']) && $_REQUEST['spoiler'] == '1'); // Ocprop
79
+        $picture->setDisplay((isset($_REQUEST['notdisplay']) && $_REQUEST['notdisplay'] == '1') == false); // Ocprop
80 80
         $picture->setMapPreview(isset($_REQUEST['mappreview']) && $_REQUEST['mappreview'] == '1');
81 81
 
82
-        $title = isset($_REQUEST['title']) ? $_REQUEST['title'] : '';  // Ocprop
82
+        $title = isset($_REQUEST['title']) ? $_REQUEST['title'] : ''; // Ocprop
83 83
         if ($title == '' || ($picture->getObjectType() == OBJECT_CACHELOG && trim($title) == '')) {
84 84
             $tpl->assign('errortitle', true);
85 85
             $bError = true;
Please login to merge, or discard this patch.
htdocs/query.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
     if ($submit == true) {
73 73
         $options = sql_value("SELECT `options` FROM `queries` WHERE `id`='&1'", false, $queryid);
74 74
         if (!$options) {
75
-            $tpl->error(ERROR_UNKNOWN);   // query does not exist
75
+            $tpl->error(ERROR_UNKNOWN); // query does not exist
76 76
         } elseif ($sortby || $sortorder || $creationdate) {
77 77
             $oa = unserialize($options);
78 78
             if ($sortby) {
Please login to merge, or discard this patch.
local/mailing/mailing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
 
42 42
 foreach ($sendto as $receiver) {
43 43
     $receiver = trim($receiver);
44
-    echo ++ $n . "/$total: $receiver";
44
+    echo ++$n . "/$total: $receiver";
45 45
     mail(
46 46
         $receiver,
47 47
         $subject,
Please login to merge, or discard this patch.