PersistedWaypointValidator::validate() - Code Metrics - Inspection of "Refactor field notes" - OpencachingDeutschland/oc-server3 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — development (#682)

by Nick

created 2017-10-25 19:45 UTC

PersistedWaypointValidator::validate() A

↳ Parent: PersistedWaypointValidator

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	3
nop	2
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0

<?php

namespace Oc\Validator\Constraints;

use Oc\GeoCache\Persistence\GeoCache\GeoCacheService;
use Symfony\Component\Validator\Constraint;

/**
 * Class PersistedWaypointValidator
 *
 * @package Oc\Validator\Constraints

 */
class PersistedWaypointValidator extends WaypointValidator
{
    /**
     * @var GeoCacheService

     */
    private $geoCacheService;

    /**
     * PersistedWaypointValidator constructor.
     *
     * @param GeoCacheService $geoCacheService

     */
    public function __construct(GeoCacheService $geoCacheService)
    {
        $this->geoCacheService = $geoCacheService;
    }

    /**
     * Checks if the passed value is valid.
     *
     * @param mixed $waypoint The value that should be validated

     * @param Constraint $constraint The constraint for the validation

     *
     * @return bool
     */
    public function validate($waypoint, Constraint $constraint)
    {
        $valid = parent::validate($waypoint, $constraint);

        if (!$valid) {
            return false;
        }

        $geoCache = $this->geoCacheService->fetchByWaypoint($waypoint);

        if ($geoCache === null) {
            $this->context->buildViolation($constraint->messageNotFound)
                ->setParameter('%waypoint%', $waypoint)
                ->addViolation();
        }

        return true;
    }
}


1			<?php
2
3			namespace Oc\Validator\Constraints;
4
5			use Oc\GeoCache\Persistence\GeoCache\GeoCacheService;
6			use Symfony\Component\Validator\Constraint;
7
8			/**
9			* Class PersistedWaypointValidator
10			*
11			* @package Oc\Validator\Constraints
			0 ignored issues – show introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Unexpected tag type `@package` in doc block Loading history...
12			*/
13			class PersistedWaypointValidator extends WaypointValidator
14			{
15			/**
16			* @var GeoCacheService
			0 ignored issues – show introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report GeoCacheService => \Oc\GeoCache\Persistence\GeoCache\GeoCacheService Loading history...
17			*/
18			private $geoCacheService;
19
20			/**
21			* PersistedWaypointValidator constructor.
22			*
23			* @param GeoCacheService $geoCacheService
			0 ignored issues – show introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report GeoCacheService => \Oc\GeoCache\Persistence\GeoCache\GeoCacheService Loading history...
24			*/
25			public function __construct(GeoCacheService $geoCacheService)
26			{
27			$this->geoCacheService = $geoCacheService;
28			}
29
30			/**
31			* Checks if the passed value is valid.
32			*
33			* @param mixed $waypoint The value that should be validated
			0 ignored issues – show Coding Style introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Expected 3 spaces after parameter name; 1 found Loading history... Coding Style Documentation introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Parameter comment must end with a full stop Loading history...
34			* @param Constraint $constraint The constraint for the validation
			0 ignored issues – show Coding Style Documentation introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Parameter comment must end with a full stop Loading history... introduced 2017-10-20 20:02 UTC by Report Bug Copy Issue Report Constraint => \Symfony\Component\Validator\Constraint Loading history...
35			*
36			* @return bool
37			*/
38			public function validate($waypoint, Constraint $constraint)
39			{
40			$valid = parent::validate($waypoint, $constraint);
41
42			if (!$valid) {
43			return false;
44			}
45
46			$geoCache = $this->geoCacheService->fetchByWaypoint($waypoint);
47
48			if ($geoCache === null) {
49			$this->context->buildViolation($constraint->messageNotFound)
50			->setParameter('%waypoint%', $waypoint)
51			->addViolation();
52			}
53
54			return true;
55			}
56			}
57

OpencachingDeutschland / oc-server3

Pull Request — development (#682)

PersistedWaypointValidator::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like