OpencachingDeutschland / oc-server3

htdocs/src/Oc/SmartyPlugins/prefilter.t.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
 
                 // rebuild block with replaced plural
                 $block = '';
-                foreach ($attrs AS $k => $v) {
+                foreach ($attrs as $k => $v) {
                     if ($block != '') {
                         $block .= ' ';
                     }

htdocs/lang/de/ocstyle/main.tpl.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
                         <td><strong>{t}Language:{/t}&nbsp;</strong></td>
                         <td>
 <?php
-                            foreach ($opt['template']['locales'] AS $k => $lang)
+                            foreach ($opt['template']['locales'] as $k => $lang)
                                 if ($lang['show'] == true)
                                     echo '<a style="text-decoration: none;" href="index.php?locale=' . $k . '"><img src="' . $lang['flag'] . '" alt="' . $lang['name'] . '" title="' . $lang['name'] . '" width="24px" height="18px" /></a> ';
 ?>

htdocs/okapi/oauth.php

Upper-Lower-Casing +12 added lines, -12 removed lines

@@ -172,7 +172,7 @@ 
   public $key;
   public $secret;
 
-  function __construct($key, $secret, $callback_url=NULL) {
+  function __construct($key, $secret, $callback_url=null) {
     $this->key = $key;
     $this->secret = $secret;
     $this->callback_url = $callback_url;
@@ -403,7 +403,7 @@ 
   public static $version = '1.0';
   public static $POST_INPUT = 'php://input';
 
-  function __construct($http_method, $http_url, $parameters=NULL) {
+  function __construct($http_method, $http_url, $parameters=null) {
     $parameters = ($parameters) ? $parameters : array();
     $parameters = array_merge( OAuthUtil::parse_parameters(parse_url($http_url, PHP_URL_QUERY)), $parameters);
     $this->parameters = $parameters;
@@ -415,7 +415,7 @@ 
   /**
    * attempt to build up a request from what was passed to the server
    */
-  public static function from_request($http_method=NULL, $http_url=NULL, $parameters=NULL) {
+  public static function from_request($http_method=null, $http_url=null, $parameters=null) {
     $scheme = (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != "on")
               ? 'http'
               : 'https';
@@ -467,7 +467,7 @@ 
   /**
    * pretty much a helper function to set up the request
    */
-  public static function from_consumer_and_token($consumer, $token, $http_method, $http_url, $parameters=NULL) {
+  public static function from_consumer_and_token($consumer, $token, $http_method, $http_url, $parameters=null) {
     $parameters = ($parameters) ?  $parameters : array();
     $defaults = array("oauth_version" => OAuthRequest::$version,
                       "oauth_nonce" => OAuthRequest::generate_nonce(),
@@ -682,7 +682,7 @@ 
     $consumer = $this->get_consumer($request);
 
     // no token required for the initial token request
-    $token = NULL;
+    $token = null;
 
     $this->check_signature($request, $consumer, $token);
 
@@ -748,7 +748,7 @@ 
   private function get_signature_method($request) {
     $signature_method = $request instanceof OAuthRequest
         ? $request->get_parameter("oauth_signature_method")
-        : NULL;
+        : null;
 
     if (!$signature_method) {
       // According to chapter 7 ("Accessing Protected Ressources") the signature-method
@@ -773,7 +773,7 @@ 
   protected function get_consumer($request) {
     $consumer_key = $request instanceof OAuthRequest
         ? $request->get_parameter("oauth_consumer_key")
-        : NULL;
+        : null;
 
     if (!$consumer_key) {
       throw new OAuthMissingParameterException('oauth_consumer_key');
@@ -793,7 +793,7 @@ 
   protected function get_token($request, $consumer, $token_type="access") {
     $token_field = $request instanceof OAuthRequest
          ? $request->get_parameter('oauth_token')
-         : NULL;
+         : null;
     if (!$token_field) {
       throw new OAuthMissingParameterException('oauth_token');
     }
@@ -801,7 +801,7 @@ 
       $consumer, $token_type, $token_field
     );
     if (!$token) {
-      throw new OAuthInvalidTokenException("Invalid $token_type token: $token_field.");
+      throw new OAuthInvalidTokenException("invalid $token_type token: $token_field.");
     }
     return $token;
   }
@@ -814,10 +814,10 @@ 
     // this should probably be in a different method
     $timestamp = $request instanceof OAuthRequest
         ? $request->get_parameter('oauth_timestamp')
-        : NULL;
+        : null;
     $nonce = $request instanceof OAuthRequest
         ? $request->get_parameter('oauth_nonce')
-        : NULL;
+        : null;
 
     $this->check_timestamp($timestamp);
     $this->check_nonce($consumer, $token, $nonce, $timestamp);
@@ -955,7 +955,7 @@ 
       // returns the headers in the same case as they are in the
       // request
       $out = array();
-      foreach ($headers AS $key => $value) {
+      foreach ($headers as $key => $value) {
         $key = str_replace(
             " ",
             "-",

htdocs/okapi/services/caches/search/searching.inc.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -26,10 +26,10 @@ 
     public  function __construct(OkapiRequest $request)
     {
         $this->request = $request;
-        $this->longitude_expr = NULL;
-        $this->latitude_expr = NULL;
-        $this->location_extra_sql = NULL;
-        $this->search_params = NULL;
+        $this->longitude_expr = null;
+        $this->latitude_expr = null;
+        $this->location_extra_sql = null;
+        $this->search_params = null;
     }
 
     /**
@@ -697,7 +697,7 @@ 
             'extra_joins' => $extra_joins,
         );
 
-        if ($this->search_params === NULL)
+        if ($this->search_params === null)
         {
             $this->search_params = $ret_array;
         } else {
@@ -818,7 +818,7 @@ 
             $location_extra_sql = array(
                 'extra_joins' => $extra_joins
             );
-            if ($this->search_params === NULL)
+            if ($this->search_params === null)
             {
                 $this->search_params = $location_extra_sql;
             } else {

htdocs/okapi/services/apiref/method.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
             throw new InvalidParam('name', "Method does not exist: '$methodname'.");
         $options = OkapiServiceRunner::options($methodname);
         if (!isset($options['min_auth_level']))
-            throw new Exception("Method $methodname is missing a required 'min_auth_level' option!");
+            throw new Exception("method $methodname is missing a required 'min_auth_level' option!");
         $docs = simplexml_load_string(OkapiServiceRunner::docs($methodname));
         $exploded = explode("/", $methodname);
         $result = array(

htdocs/okapi/views/devel/dbstruct.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
         $struct = shell_exec($shell_arguments);
         if (strlen($struct) > 1000000)
             throw new Exception("something went terribly wrong while dumping table structures");
-        if (stripos($struct,"dumping data") !== FALSE)
+        if (stripos($struct,"dumping data") !== false)
             throw new Exception("something went terribly wrong while dumping table structures");
 
         # Remove the "AUTO_INCREMENT=..." values. They break the diffs.

htdocs/okapi/cronjobs.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
                 return;
             }
         }
-        throw new Exception("CronJob $job_name not found.");
+        throw new Exception("cronjob $job_name not found.");
     }
 
     /**

htdocs/editcache.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -844,7 +844,7 @@
                 $desclangs = mb_split(',', $cache_record['desc_languages']);
                 $cache_descs = '';
                 $gc_com_refs = false;
-                foreach ($desclangs AS $desclang) {
+                foreach ($desclangs as $desclang) {
                     if (count($desclangs) > 1) {
                         $remove_url = 'removedesc.php?cacheid=' . urlencode($cache_id) . '&desclang=' . urlencode(
                                 $desclang

htdocs/translate.php

Upper-Lower-Casing +10 added lines, -10 removed lines

@@ -231,7 +231,7 @@ 
 }
 
 $languages = [];
-foreach ($opt['locale'] AS $k => $v) {
+foreach ($opt['locale'] as $k => $v) {
     if ($access->mayTranslate($k)) {
         $languages[] = $k;
     }
@@ -514,7 +514,7 @@ 
     global $opt, $tpl, $translang;
 
     $structure = enumSqlFiles($opt['rootpath'] . '../sql/tables');
-    foreach ($structure AS $sTable) {
+    foreach ($structure as $sTable) {
         sql_export_structure_to_file($opt['rootpath'] . '../sql/tables/' . $sTable . '.sql', $sTable);
     }
 
@@ -590,7 +590,7 @@ 
     global $tpl, $msDirlist;
 
     $files = [];
-    foreach ($msDirlist AS $dir) {
+    foreach ($msDirlist as $dir) {
         $hDir = opendir($dir);
         if ($hDir !== false) {
             while (($file = readdir($hDir)) !== false) {
@@ -625,7 +625,7 @@ 
     /* check if supplied filename is within allowed path!
      */
     $bFound = false;
-    foreach ($msDirlist AS $dir) {
+    foreach ($msDirlist as $dir) {
         if (substr($dir, - 1) != '/') {
             $dir .= '/';
         }
@@ -651,7 +651,7 @@ 
     $transFileScan = new translate_filescan($filename);
     $transFileScan->parse();
 
-    foreach ($transFileScan->textlist AS $item) {
+    foreach ($transFileScan->textlist as $item) {
         $translationHandler->addText($item['text'], $filename, $item['line']);
     }
 
@@ -666,7 +666,7 @@ 
     header('Content-Disposition:attachment;filename="translation.xml"');
 
     $lang = [];
-    foreach ($opt['template']['locales'] AS $k => $v) {
+    foreach ($opt['template']['locales'] as $k => $v) {
         $lang[] = $k;
     }
 
@@ -737,7 +737,7 @@ 
     }
 
     $scanlang = [];
-    foreach ($opt['locale'] AS $k => $v) {
+    foreach ($opt['locale'] as $k => $v) {
         if (isset($_REQUEST['lang' . $k]) && ($_REQUEST['lang' . $k] == '1')) {
             $scanlang[] = $k;
         }
@@ -758,10 +758,10 @@ 
      */
     $saTexts = [];
 
-    foreach ($doc->documentElement->childNodes AS $textnode) {
+    foreach ($doc->documentElement->childNodes as $textnode) {
         if ($textnode->nodeType == XML_ELEMENT_NODE) {
             $codeElements = $textnode->getElementsByTagName('code');
-            foreach ($scanlang AS $lang) {
+            foreach ($scanlang as $lang) {
                 $langElements = $textnode->getElementsByTagName($lang);
 
                 $sCodeText = $codeElements->item(0)->nodeValue;
@@ -824,7 +824,7 @@ 
             $transId = sql_value("SELECT `id` FROM `sys_trans` WHERE `text`='&1'", 0, $sCode);
 
             if ($transId != 0) {
-                foreach ($opt['locale'] AS $k => $v) {
+                foreach ($opt['locale'] as $k => $v) {
                     if (isset($_REQUEST[$k . $nIndex . 'new'])) {
                         $sText = base64_decode($_REQUEST[$k . $nIndex . 'new']);